Commit Graph

5513 Commits

Author SHA1 Message Date
Dão Gottwald
f453703731 Bug 1774377 - Add Firefox View menu item to the Tools menu. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149367
2022-06-17 07:56:26 +00:00
Butkovits Atila
246c21a815 Backed out changeset df17ec7a8095 (bug 1774377) for causing assertion failures at ErrorResult.h. CLOSED TREE 2022-06-16 01:20:24 +03:00
Dão Gottwald
ff2e859367 Bug 1774377 - Add Firefox View menu item to the Tools menu. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149367
2022-06-15 21:34:44 +00:00
Tom Schuster
214369e07f Bug 1738694 - Pass around hasValidUserGestureActivation and fromExternal when opening links from the UI or command-line. r=Gijs,edgar
Differential Revision: https://phabricator.services.mozilla.com/D147515
2022-06-15 19:01:02 +00:00
Tom Schuster
0fc6e71eb9 Bug 1738694 - Use openLinkIn instead of loadURI. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D147514
2022-06-15 19:01:01 +00:00
Michael Kohler
7b63f7517f Bug 1696233 - Remove expired Telemetry probe a11y.indicator_acted_on r=Jamie DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D148379
2022-06-07 11:14:32 +00:00
Calixte
9eafb7c7a0 Bug 1766030 - Add an optional source URL when saving an URL. r=Gijs
In pdf.js, files are saved thanks to a blob but the original URL is lost.
Consequently, the download panel doesn't contain any information about the
origins of a saved pdf.
The saveURL, internalSave and nsITransfer.init functions has now a parameter for this originalURL.

Differential Revision: https://phabricator.services.mozilla.com/D147651
2022-05-31 17:25:29 +00:00
Tooru Fujisawa
d1bd5e4401 Bug 1771463 - Do not export lazy getter "fxAccounts" from services/fxaccounts/FxAccounts.jsm. r=markh,preferences-reviewers,Mardak
Instead of exporting lazy getter, export a function that returns the FxAccount
singleton, lazily creating on the first call, and define the lazy getter on the
consumer side that calls the function.

Differential Revision: https://phabricator.services.mozilla.com/D147634
2022-05-31 14:09:10 +00:00
Cosmin Sabou
dd73bafd11 Backed out changeset 697ab99d1c61 (bug 1771463) for causing node newtab failures. CLOSED TREE 2022-05-31 07:16:41 +03:00
Tooru Fujisawa
7f15e8996c Bug 1771463 - Do not export lazy getter "fxAccounts" from services/fxaccounts/FxAccounts.jsm. r=markh,preferences-reviewers
Instead of exporting lazy getter, export a function that returns the FxAccount
singleton, lazily creating on the first call, and define the lazy getter on the
consumer side that calls the function.

Differential Revision: https://phabricator.services.mozilla.com/D147634
2022-05-31 03:12:22 +00:00
Dão Gottwald
365511d874 Bug 1766896 - Redirect attempts to load something else in the Firefox View tab to new tabs. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D145613
2022-05-10 22:16:45 +00:00
Henrik Skupin
55c503496c Bug 1726465 - Don't update remote control cue for startup performance tests. r=florian
Startup performance tests are browser-chrome tests which use Marionette
to install required extensions. Because Marionette will be initialized
earlier during the startup of Firefox this can cause a partially updated
remote control cue for the first opened browser window.

As such stop updating the remote control cue by guarding this behavior
behind two flags - when the browser is in automation and a special
preference set.

Depends on D145933

Differential Revision: https://phabricator.services.mozilla.com/D145934
2022-05-10 15:08:18 +00:00
criss
ba242a0c40 Backed out 8 changesets (bug 1726465) for causing failures on browser_preferences_usage.js. CLOSED TREE
Backed out changeset 4b57310622a0 (bug 1726465)
Backed out changeset 0c6c4a15621a (bug 1726465)
Backed out changeset 081a0f91e0a7 (bug 1726465)
Backed out changeset 60bceb18ff57 (bug 1726465)
Backed out changeset f241655ea876 (bug 1726465)
Backed out changeset 7bc0a3aeb254 (bug 1726465)
Backed out changeset b2f7c710daef (bug 1726465)
Backed out changeset e9b90fd1b4ec (bug 1726465)
2022-05-10 13:59:54 +03:00
Henrik Skupin
e0b4a7ad89 Bug 1726465 - Don't update remote control cue for startup performance tests. r=florian
Startup performance tests are browser-chrome tests which use Marionette
to install required extensions. Because Marionette will be initialized
earlier during the startup of Firefox this can cause a partially updated
remote control cue for the first opened browser window.

As such stop updating the remote control cue by guarding this behavior
behind two flags - when the browser is in automation and a special
preference set.

Differential Revision: https://phabricator.services.mozilla.com/D145934
2022-05-10 09:04:03 +00:00
Mike Kaply
f26b216117 Bug 1754773 - Use new domain policy message for policy blocking. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D144834
2022-05-09 16:04:54 +00:00
Dão Gottwald
4b1a26f239 Bug 1768216 - Remove about:firefoxview from gPageIcons. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D145793
2022-05-06 15:51:22 +00:00
Jonathan Watt
bd8604a213 Bug 1712104 p1 - Refactor PrintUtils.startPrintWindow for easier reasoning. r=emilio,webdriver-reviewers
Having the called-back-for-new-static-doc logic mixed in with the
start-new-print logic was confusing. The new structure, function names
and comments should hopefully make it easier for people unfamiliar with the
various printing code flows to understand and reason about this code. It also
allows the addition of new print-via-system-dialog logic without things getting
completely out of hand.

Differential Revision: https://phabricator.services.mozilla.com/D135451
2022-05-06 14:30:24 +00:00
Sam Foster
d7e35a511b Bug 1764139 - Rename about:myfirefox to about:firefoxview and all the other files and references. r=dao,fluent-reviewers,flod
Depends on D145697

Differential Revision: https://phabricator.services.mozilla.com/D145699
2022-05-06 10:31:47 +00:00
Shane Hughes
2746e4eb90 Bug 1749998 - Expose alwaysOpenPanel in context menu. r=mak,Gijs,fluent-reviewers,flod
This patch adds a new menuitem to the toolbar context menu that
functions analogously to the downloads button auto-hide menuitem.
It's visible when the context menu is opened on the downloads button,
and hidden otherwise. It toggles browser.download.alwaysOpenPanel.
Also add some tests to make sure it's showing in the correct conditions
and having the correct effect in practice. While we're at it, make some
slight simplifications of related tests.

Differential Revision: https://phabricator.services.mozilla.com/D145284
2022-05-06 08:21:41 +00:00
Molnar Sandor
78e21319ab Backed out changeset cf50b25d52a0 (bug 1749998) for causing browser-chrome failures in browser_downloads_panel_opens. CLOSED TREE 2022-05-06 03:11:13 +03:00
Shane Hughes
5b7a1ba473 Bug 1749998 - Expose alwaysOpenPanel in context menu. r=mak,Gijs,fluent-reviewers,flod
This patch adds a new menuitem to the toolbar context menu that
functions analogously to the downloads button auto-hide menuitem.
It's visible when the context menu is opened on the downloads button,
and hidden otherwise. It toggles browser.download.alwaysOpenPanel.
Also add some tests to make sure it's showing in the correct conditions
and having the correct effect in practice. While we're at it, make some
slight simplifications of related tests.

Differential Revision: https://phabricator.services.mozilla.com/D145284
2022-05-05 21:25:40 +00:00
Emilio Cobos Álvarez
cb73028091 Bug 1768004 - Remove proton places tooltip code. r=dao
There's nobody working on it, and tooltips should hopefully be nice
enough after recent changes (bug 1765423).

Having it enabled causes artifacts like bug 1767815 comment 3. We can
always rescue this from hg history if needed.

Differential Revision: https://phabricator.services.mozilla.com/D145621
2022-05-05 16:18:17 +00:00
Henrik Skupin
9760ffb2c8 Bug 1719505 - [remote] Unify Remote Agent's running state with Marionette. r=webdriver-reviewers,mossop,smaug,keeler,jdescottes
Both components are related to WebDriver and should expose the
same flag for their running state.

Differential Revision: https://phabricator.services.mozilla.com/D144982
2022-04-29 17:38:14 +00:00
Butkovits Atila
23bdcdba52 Backed out 6 changesets (bug 1719505) for causing failures at browser_Troubleshoot.js. CLOSED TREE
Backed out changeset 915b5331f6b2 (bug 1719505)
Backed out changeset 8df69b3445e5 (bug 1719505)
Backed out changeset 674fe8523cf6 (bug 1719505)
Backed out changeset f40c2fe6872d (bug 1719505)
Backed out changeset 3e3df2a6b1e3 (bug 1719505)
Backed out changeset 621024810236 (bug 1719505)
2022-04-29 17:32:32 +03:00
Henrik Skupin
1b2dd60e07 Bug 1719505 - [remote] Unify Remote Agent's running state with Marionette. r=webdriver-reviewers,mossop,smaug,keeler,jdescottes
Both components are related to WebDriver and should expose the
same flag for their running state.

Differential Revision: https://phabricator.services.mozilla.com/D144982
2022-04-29 11:55:43 +00:00
Nika Layzell
6ee69ff4d9 Bug 1756980 - Part 1: Redirect internally-handled attachment loads into new tabs, r=Gijs,smaug,necko-reviewers,dragana
This patch changes how we handle document loads which are being handled
internally but have Content-Disposition: attachment specified at the
DocumentLoadListener layer. This was done as process switching is
currently the only place during a load where we can change the target
BrowsingContext which the load will complete in.

The only situation where we should currently continue to deliver a
successful request to the default content-viewer despite
Content-Disposition: attachment being specified is when we choose to
handle a downloaded PDF internally, so this shouldn't impact other
cases.

The change is handled by forcing a process switch under the hood, and
opening a new browser window asynchronously to handle the process
switch, similar to how object and embed load upgrades are handled. This
is done using nsIBrowserDOMWindow to attempt to respect the user's
window opening preferences.

A small change to browser.js was also made to try to encourage the new
tab to be opened next to the previous tab, as well as to avoid starting
unnecessary new processes when creating the new browser window.

Differential Revision: https://phabricator.services.mozilla.com/D143675
2022-04-27 15:22:00 +00:00
Paul Zuehlcke
4faa9743bc Bug 1746383 - Set URLBar pageProxyState to invalid for onLocationChange triggered by SessionStore. r=nika,dao
Differential Revision: https://phabricator.services.mozilla.com/D138823
2022-04-12 14:41:06 +00:00
Oriol Brufau
73d2312b3b Bug 1761635 - Make switchToTabHavingURI handle adoptTab failures. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D142758
2022-04-11 08:43:49 +00:00
Gijs Kruitbosch
435f05b398 Bug 1761618 - don't include about:myfirefox in gInitialPages if not present, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D142291
2022-03-29 16:28:23 +00:00
Gijs Kruitbosch
10f20e4e9c Bug 1760991 - add 'my firefox' shell page, r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D142050
2022-03-25 12:46:45 +00:00
Mark Banner
f31a292cd3 Bug 1759992 - Change string id for the search engine removal infobar. r=mcheang,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D141335
2022-03-21 08:47:51 +00:00
Sarah Clements
ea3ed0617e Bug 1752833 - remove menubar_can_autohide from browser.css r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D140374
2022-03-15 09:57:45 +00:00
Noemi Erli
c611337801 Backed out changeset ee9b7007dd66 (bug 1752833) for causing bc failures CLOSED TREE 2022-03-14 14:47:54 +02:00
Sarah Clements
2ac3e85486 Bug 1752833 - remove menubar_can_autohide from browser.css r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D140374
2022-03-14 11:09:36 +00:00
Mark Banner
7ea3c792f2 Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-11 16:41:29 +00:00
smolnar
19781d16c7 Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
de1754318e Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-10 09:25:28 +00:00
mcheang
07b5d1e0f8 Bug 1754454 - update urlbar placeholder when search engine is removed on restart and idle. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D139553
2022-02-24 10:53:53 +00:00
Emilio Cobos Álvarez
1c45bb4c02 Bug 1756323 - Fix tooltip coordinates in presence of full zoom. r=jfkthame
And cleanup similar code in nsXULTooltipListener. That code shouldn't
need to deal with zoom since the target and the tooltip are in the same
document.

Differential Revision: https://phabricator.services.mozilla.com/D139235
2022-02-21 17:30:08 +00:00
Neil Deakin
83d3315263 Bug 1681712, wait for the MozAfterPaint event before swapping remote browsers, so that tab switching doesn't get confused when the browser gets swapped out, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D138386
2022-02-11 16:24:47 +00:00
Andrew McCreight
fc031e3b1e Bug 1754652 - Remove WINDOW_REMOTE_SUBFRAMES_ENABLED_STATUS telemetry. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D138472
2022-02-11 02:11:08 +00:00
Emilio Cobos Álvarez
8de26dc4c1 Bug 1754547 - Generalize moz-os-version into moz-platform. r=dao,preferences-reviewers,Gijs
Allow differentiating non-windows platforms on it.

Differential Revision: https://phabricator.services.mozilla.com/D138431
2022-02-10 15:50:31 +00:00
Mike Kaply
c9e3b5bc27 Bug 1735806 - Don't allow installs from AMO if not in policy install_sources r=willdurand,extension-reviewers,rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D129415
2022-02-09 20:21:17 +00:00
Evgenia Kotovich
7c7818f34e Bug 1753816 - Change browser/base/content/browser.js to apply only InstantEditBookmark. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D137934
2022-02-07 08:02:19 +00:00
mcheang
a30935cd88 Bug 1748923 - Show Search Engine Removal Infobar on restart or 5 seconds idle. r=Standard8,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D136818
2022-02-03 08:02:49 +00:00
Iulian Moraru
6d6ce3b1d1 Backed out changeset 8e0d1f35d3cc (bug 1748923) for causing mochitest failures on browser_ProcessHangNotifications.js. CLOSED TREE 2022-02-03 07:33:00 +02:00
mcheang
83b59b248c Bug 1748923 - Show Search Engine Removal Infobar on restart or 5 seconds idle. r=Standard8,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D136818
2022-02-03 03:56:20 +00:00
Julien Wajsberg
a0311c9aa8 Bug 1745208 - [utilityOverlay] Make getTopWin take an option parameter r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D133376
2022-01-26 17:26:19 +00:00
aminomancer
7aebd7f3db Bug 1591040 - show both fullscreen and normal toolbar/tabstrip context menus in full screen, r=jaws,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131493
2022-01-21 22:52:24 +00:00
Norisz Fay
d35104b746 Backed out changeset e23259733a51 (bug 1591040) for causing bc failures on browser_fullscreen_context_menu.js CLOSED TREE 2022-01-19 13:32:54 +02:00