corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
787,407 Commits 1 Branch 0 Tags
9ee28b3a4e5581142417787aefe8f9c85f71bf7b
Commit Graph

289 Commits

Author SHA1 Message Date
Eemeli Aro
9ee28b3a4e Bug 1448444 - Drop signInToSync.description string as unused. r=markh,sync-reviewers 
This was only used to format the tooltip of the "Sync now" button in the Firefox Accounts app menu pane when the UI's state was such that the whole pane would not be displayed.

Differential Revision: https://phabricator.services.mozilla.com/D178804
 2023-05-29 15:24:38 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-05-18 17:19:45 +00:00
Sammy Khamis
435afb34a5 Bug 1824216: Always show sync settings if sync is enabled r=markh,sync-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176960
 2023-05-18 02:26:23 +00:00
Eemeli Aro
4562dff30c Bug 1831851 - Migrate accounts.properties strings used by browser-sync.js to Fluent. r=sync-reviewers,fluent-reviewers,flod,markh 
Differential Revision: https://phabricator.services.mozilla.com/D177601
 2023-05-11 06:27:41 +00:00
Eemeli Aro
0233358cf6 Bug 1832179 - Convert sendTabsToDevice.label string to Fluent. r=sync-reviewers,fluent-reviewers,flod,markh 
The l10n migration shows a diff, as the singular form of the en-US source string is more appropriately categorized as `1` rather than `one` due to its lack of a `{ $tabCount }` reference.

Differential Revision: https://phabricator.services.mozilla.com/D177612
 2023-05-10 18:35:53 +00:00
Francesco Lodolo (:flod)
1dfecb77f0 Bug 1826755 - Move Firefox account Fluent term to toolkit, r=fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,mconley,sclements,sgalich,eemeli 
Differential Revision: https://phabricator.services.mozilla.com/D175097
 2023-04-12 15:51:42 +00:00
Barret Rennie
f7a4fadf48 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D172850
 2023-03-30 20:51:58 +00:00
Mike Conley
e4a149ad16 Bug 1818570 - Fix entrypoint for FxA toolbarbutton and include experiment / variation slugs when opening FxA page. r=Mardak,markh 
Differential Revision: https://phabricator.services.mozilla.com/D170790
 2023-02-24 22:04:03 +00:00
Mark Hammond
9a080f909e Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis 
Differential Revision: https://phabricator.services.mozilla.com/D170186
 2023-02-22 03:58:11 +00:00
Norisz Fay
d30055eea6 Backed out changeset d82c03e04249 (bug 1359861) for causing xpcshell failure on test_BrowserUtils.js CLOSED TREE 2023-02-22 00:05:07 +02:00
Mark Hammond
9ef3fc0513 Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis 
Differential Revision: https://phabricator.services.mozilla.com/D170186
 2023-02-21 21:04:10 +00:00
Mark Banner
81e5d26ac3 Bug 1817183 - Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D170062
 2023-02-17 16:34:43 +00:00
Cristian Tuns
b9ee007450 Backed out 6 changesets (bug 1816934, bug 1817182, bug 1817179, bug 1817183) for causing dt failures in browser_jsterm_autocomplete_null.js CLOSED TREE 
Backed out changeset 17d4c013ed92 (bug 1817183)
Backed out changeset cfed8d9c23f3 (bug 1817183)
Backed out changeset 62fe2f589efe (bug 1817182)
Backed out changeset 557bd773fb85 (bug 1817179)
Backed out changeset 7f8a7865868b (bug 1816934)
Backed out changeset d6c1d4c0d2a0 (bug 1816934)
 2023-02-17 10:51:33 -05:00
Mark Banner
c8baa7a866 Bug 1817183 - Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D170062
 2023-02-17 09:01:45 +00:00
Marian-Vasile Laza
d6301f89ed Backed out changeset 9ea51bb77cfc (bug 1816969) for causing multiple services-sync bc failures. CLOSED TREE 2023-02-16 16:18:49 +02:00
Pier Angelo Vendrame
0ce8df939b Bug 1816969 - Fix runtime errors with MOZ_SERVICES_SYNC=False. r=mossop 
Some checks on MOZ_SERVICES_SYNC have been removed in Bug 1227361, but
it is still used in a few places in the codebase.
Trying to set it to False results in some runtime errors, that this
commit fixes.

Differential Revision: https://phabricator.services.mozilla.com/D170047
 2023-02-16 13:27:22 +00:00
Gijs Kruitbosch
e341f68082 Bug 1811198 - show synced tabs panel correctly when the button is in a hidden area, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D169742
 2023-02-15 09:19:49 +00:00
Mark Banner
18898557b3 Bug 1814931 - Convert services/sync imports to direct ES imports. r=markh,settings-reviewers,credential-management-reviewers,mconley,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D168837
 2023-02-13 11:44:29 +00:00
Mark Banner
774d70b85f Bug 1808400 - Handle cases of .then(foo, Cu.reportError) in ESLint rule no-cu-reportError. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D167520
 2023-01-23 18:09:04 +00:00
Mark Banner
34d6fb8d94 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D165068
 2022-12-27 10:08:58 +00:00
Shane Hughes
0c880c51f9 Bug 1805360 - Fix FxA panel separators. r=mconley 
Replace menuseparator -> toolbarseparator in the FxA panel.

Differential Revision: https://phabricator.services.mozilla.com/D164537
 2022-12-13 18:49:56 +00:00
Francesco Lodolo (:flod)
083fc7f23f Bug 1801915 - Migrate confirmation hints to Fluent, r=eemeli,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D162746
 2022-11-22 20:12:55 +00:00
Emilio Cobos Álvarez
8eb4bd796d Bug 1795944 - Remove descriptionheightworkaround. r=Gijs 
Stuff wraps properly now with flexbox emulation.

Differential Revision: https://phabricator.services.mozilla.com/D159621
 2022-10-19 11:55:29 +00:00
Mark Hammond
21bd24ad69 Bug 1792550 - ensure the primary password is unlocked before signing in to sync. r=Mardak,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158719
 2022-10-12 22:31:37 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
63996e4f6c Bug 1790920 - Don't check defaultPrevented for click events closing panels. r=Gijs 
(To be landed right after the soft freeze is over)

One interesting consequence of my previous patch in this bug, is that
the time at which the XUL element processes the click event is different
(earlier, at bubbling phase rather than after everything).

This caused some test failures caused by the panel autohide, since now
it goes after than the native handling and the native handling
default-prevents to dispatch the XUL command.

Given we don't check key events for defaultPrevented either, it makes
sense to be consistent.

This uncovered an interesting failure, where the "show more tabs" button
in the sync menu starts closing the panel unexpectedly on click. The
right fix is to use closemenu="none" in that button, since otherwise
that button is not keyboard accessible (this is an issue on current
nightly that this patch fixes).

Differential Revision: https://phabricator.services.mozilla.com/D157584
 2022-09-19 17:02:37 +00:00
Sammy Khamis
be54278282 Bug 1756252: Collect telemetry on synced tabs usage r=markh 
Differential Revision: https://phabricator.services.mozilla.com/D139221
 2022-02-23 02:39:26 +00:00
Sergey Galich
277f54a286 Bug 1653486 - Replace all non-user-facing references to "master" password. r=dimi,tgiles,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D138113
 2022-02-17 17:29:57 +00:00
Sammy Khamis
4dc06d1612 Bug 1643752 - Sort send tab targets by last used r=markh,vbudhram 
Differential Revision: https://phabricator.services.mozilla.com/D134722
 2022-01-27 19:14:35 +00:00
Katherine Patenio
6d1eaab783 Bug 1728460 - Migrate appmenu-viewcache.inc.xhtml to Fluent. r=mtigley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D124404
 2021-09-07 17:46:19 +00:00
Katherine Patenio
bd7e890d96 Bug 1727197 - Remove fluent strings for synced tabs "show all" button. r=emalysz 
Differential Revision: https://phabricator.services.mozilla.com/D124143
 2021-09-01 17:57:30 +00:00
Molly Howell
e9ba2664a2 Bug 1727484 - Convert the "Send Tab to Device" string in the tab context menu to title case. r=Gijs,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D124131
 2021-09-01 00:18:57 +00:00
Katherine Patenio
b2b6c01fc5 Bug 1625478 - Convert appMenu* strings from browser.dtd to appmenu.ftl. r=mtigley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D123167
 2021-08-30 02:36:44 +00:00
Molly Howell
bf500595af Bug 1684950 - Change the remaining Firefox Account panel strings to sentence case. r=Gijs,flod,fluent-reviewers 
Only two strings that appear in the accounts panel are still in title case,
but those two need to be forked, because they are also used in other menus
where they need to remain in title case.

This patch adds the two "new" strings and the necessary switch to select
between them and the existing strings, since all of these menus are dynamically
constructed by the same code.

Differential Revision: https://phabricator.services.mozilla.com/D122764
 2021-08-17 19:17:24 +00:00
Gijs Kruitbosch
5d35161584 Bug 1724718 - do not set an image attribute for synced tabs items in the synced tabs menupanel unless there is an icon to show, r=markh 
Depends on D122162

Differential Revision: https://phabricator.services.mozilla.com/D122163
 2021-08-10 06:52:51 +00:00
Sam Foster
10c8de097c Bug 1719463 - Part 2: Remove the Fxa items from the pre-proton appMenu view. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D121802
 2021-08-10 05:29:30 +00:00
Neil Deakin
a551374625 Bug 1714079, send confirmation does not appear when sending a tab when the account button is in the overflow menu, r=mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D120845
 2021-07-28 09:13:38 +00:00
Tarik Eshaq
e436613e2b Bug 1587228 - Removes support for old send-tab clients. r=markh 
* Removes the fallback to the old sent-tab
* Deletes the api to send URIs using commands
* Modifies tests that depended on that api to now use
   other commands, namely the wipeEngine command

Differential Revision: https://phabricator.services.mozilla.com/D118086
 2021-07-14 16:50:26 +00:00
Gijs Kruitbosch
4508e659f8 Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D117058
 2021-07-07 22:15:50 +00:00
Mike Conley
591e5facd9 Bug 1700198 - Remove most subviewbutton-iconic class usage from FxA panel. r=markh 
This also removes code that handled the case where a Send Tab or Send Link to Device
menu needed to be populated when in the STATUS_NOT_CONFIGURED state. Since those menus
should be unavailable when in the STATUS_NOT_CONFIGURED state, we throw instead.

Depends on D118622

Differential Revision: https://phabricator.services.mozilla.com/D118623
 2021-06-24 20:27:47 +00:00
Brindusan Cristian
b098967db9 Backed out changeset 0a18936814a7 (bug 1587228) for causing bc failures in browser_contextmenu_sendpage.js. 
CLOSED TREE
 2021-06-23 00:09:46 +03:00
Tarik Eshaq
0bf2762b2d Bug 1587228 - Removes support for old send-tab clients. r=markh 
* Removes the fallback to the old sent-tab
* Deletes the api to send URIs using commands
* Modifies tests that depended on that api to now use
   other commands, namely the wipeEngine command

Differential Revision: https://phabricator.services.mozilla.com/D118086
 2021-06-22 20:21:40 +00:00
Gijs Kruitbosch
7ad523084b Bug 1711523 - remove private proton tracking flags in frontend modules, r=mak,emalysz,desktop-theme-reviewers,harry 
Differential Revision: https://phabricator.services.mozilla.com/D116009
 2021-05-28 19:33:38 +00:00
Bernard Igiri
e96485c24a Bug 1705500 - Added word wrap to send tab to another device menu r=mconley 
Modified toolbaritem for the send tab to another device menu item to wrap text and align icon at the top of the button.

Differential Revision: https://phabricator.services.mozilla.com/D115657
 2021-05-21 16:30:21 +00:00
Mike Conley
67629f2ea8 Bug 1703494 - Use CSS box for FxA CTA item to avoid need for descriptionHeightWorkaround. r=emalysz 
Differential Revision: https://phabricator.services.mozilla.com/D114770
 2021-05-10 23:49:55 +00:00
Gijs Kruitbosch
2799396ec0 Bug 1704483 - improve a11y labeling of disconnected/errored account item in the hamburger menu, r=morgan 
The full text is split into 2 labels, one describing state and one containing the e-mail address.
To sighted users, both are visible. When this happens, let's use aria-labelledby to ensure both
labels are associated with the button control, so that both are read by screenreaders.

In the signed in and signed out state, the label is already correct (and either doesn't include
an email address, or doesn't include anything *but* the email address).

Note that in non-proton, the only label (both visible and otherwise) is the
state (the e-mail is not shown/used).

Differential Revision: https://phabricator.services.mozilla.com/D113657
 2021-04-28 18:27:47 +00:00
Mark Striemer
2ea6a4f349 Bug 1701544 - Show Sent! confirmation when sending a tab to a device r=harry,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D113047
 2021-04-22 17:59:10 +00:00
Emma Malysz
ed642d15fc Bug 1706460: update fxa disconnected string r=mhowell,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D112838
 2021-04-21 16:40:13 +00:00