Commit Graph

24 Commits

Author SHA1 Message Date
Brian Grinstead
893ef542cf Bug 1366851 - Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;r=Gijs
MozReview-Commit-ID: Kaobl1Ox2QZ
2017-06-28 10:15:48 -07:00
Brian Grinstead
a55b1911a1 Bug 1372954 - Do not persist sidebar checked state to document;r=Gijs
The the state will be properly set in the show() call anyway, and the xulstore
doesn't track attribute removals which led to improper checked state

MozReview-Commit-ID: rGb6Td55eW
2017-06-19 13:45:03 -07:00
Gijs Kruitbosch
a1e48e4623 Bug 1368317 - fix sidebar overlap styling for when the sidebar is on the end-side of the window (rhs in ltr), r=bgrins
MozReview-Commit-ID: 3BZily6xSD2
2017-06-15 14:31:54 +01:00
Brian Grinstead
a8bd252623 Bug 1360282 - Remove the popup that opens from the sidebar toolbar button;r=Gijs
MozReview-Commit-ID: 4N841nISf3F
2017-06-13 08:14:58 -07:00
Brian Grinstead
77feb23ee2 Bug 1360282 - Use the existing title setter for SidebarUI instead of changing the value directly;r=Gijs
MozReview-Commit-ID: FCke6FxUrJj
2017-06-13 08:14:58 -07:00
Brian Grinstead
c736caa070 Bug 1360282 - Remove _setVisibility helper now that the sidebar is always shown through show();r=Gijs
MozReview-Commit-ID: FWJshLtYZ3h
2017-06-13 08:14:57 -07:00
Brian Grinstead
c4465b0338 Bug 1360282 - Use querySelectorAll instead of getElementsByAttribute and a condition;r=Gijs
MozReview-Commit-ID: Fq6pXxiSZ7b
2017-06-13 08:14:57 -07:00
Brian Grinstead
73631ec8e2 Bug 1360282 - Always call show to open the sidebar, even when it's called from startDelayedLoad;r=Gijs
By running through the same path anytime the sidebar is shown it will be easier to
implement the sidebar-button as a toggle, since we can rely on consistent state
to determine which sidebar was opened last.

MozReview-Commit-ID: 14HXtr8uNmb
2017-06-13 08:14:10 -07:00
Florian Quèze
924bae5dfa Bug 1369751 - avoid constructing the sidebar browser before first paint, r=mikedeboer. 2017-06-09 15:11:07 +02:00
Brian Grinstead
74242a4433 Bug 1355331 - Create an option to move sidebar between the left and right sides of the window;r=mikedeboer
MozReview-Commit-ID: 79ts9djMC3e
2017-05-24 09:54:34 -07:00
Brian Grinstead
e7a8943bf1 Bug 1355324 - Create a popup to switch between sidebars from the sidebar header;r=Gijs
MozReview-Commit-ID: HBwIfmtKybi
2017-05-16 10:31:00 -07:00
Shane Caraveo
faa7c87b80 Bug 1350597 fix reload/upgrade of sidebar addon, r=kmag
MozReview-Commit-ID: FcC7zJn1ka5
2017-04-14 17:01:23 -07:00
Shane Caraveo
1f656159fc Bug 1208596 implement sidebar api for webextensions, f?kmag, gijs r=Gijs,kmag
MozReview-Commit-ID: 6GMdU5kcrFR
2017-02-09 15:32:50 -08:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Jared Wein
ebf1ccbe46 Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh
2016-08-03 18:54:59 -04:00
Mark Hammond
a26eeefd75 Bug 1241571 - Collect synced tabs and sidebar ui telemetry. r=Gijs
Adds UI telemetry for sidebar opening and closing and actions taken in the
SyncedTabs menu and side. Also adds a "sync-state" object so that analysis
of the Synced Tabs data can determine if the user has Sync configured at the
time.

MozReview-Commit-ID: JDxFmlNMi7n
2016-05-18 10:39:14 +10:00
Zachary Carter
de74e8bcb6 Bug 1210586 - Create a Synced tabs sidebar r=markh 2016-01-27 14:40:30 -08:00
Felipe Gomes
e5ea10c3ed Bug 1228627 - Remove #includes from browser.js. r=Gijs 2015-11-30 12:13:57 -02:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Mark Capella
9ec105736f Bug 1133489 - Hook up "Open ReadingList" button in desktop ReaderMode, r=unfocused 2015-02-27 14:31:31 -05:00
Mark Hammond
423bc396e1 Bug 1136291 - better handle an unexpected (eg, the hidden DOM window) being the window opener when initializing the sidebar. r=Unfocused 2015-02-25 20:51:21 +11:00
Blair McBride
21d225439d Bug 1123517 - Refactor sidebar code. r=florian 2015-02-20 21:21:33 +13:00