Mark Banner
6699dcb7f8
Bug 1799465 - Enable require-jsdoc rules by default, disabling on code where there are existing failures. r=frontend-codestyle-reviewers,migration-reviewers,backup-reviewers,mossop,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D206878
2024-04-08 13:34:13 +00:00
negin
45aff83a3d
Bug 1889703 - Re-introduce embedded migration wizard default title r=migration-reviewers,aminomancer,mconley,omc-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D206683
2024-04-04 19:25:53 +00:00
Jason Prickett
a6095771b4
Bug 1876176 - Update migration wizard to support future experiments r=omc-reviewers,desktop-theme-reviewers,mconley,migration-reviewers,aminomancer,Itiel
...
Differential Revision: https://phabricator.services.mozilla.com/D201142
2024-03-22 02:29:57 +00:00
Sandor Molnar
e608e4df81
Backed out 2 changesets (bug 1876176) for causing node newtab failures @ browser/components/aboutwelcome CLOSED TREE
...
Backed out changeset 4899c27af9c2 (bug 1876176)
Backed out changeset 9ae306e9577a (bug 1876176)
2024-03-21 20:57:54 +02:00
Sandor Molnar
47d8e8cc72
Bug 1876176 - Fix file-whitespace failure. a=lint-fix CLOSED TREE
2024-03-21 20:32:24 +02:00
Jason Prickett
569f5bb7a6
Bug 1876176 - Update migration wizard to support future experiments r=omc-reviewers,desktop-theme-reviewers,mconley,migration-reviewers,aminomancer,Itiel
...
Differential Revision: https://phabricator.services.mozilla.com/D201142
2024-03-21 17:21:05 +00:00
Dave Townsend
a0c83bc943
Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Tim Giles
e78971728a
Bug 1885421 - Fix migration wizard links not opening in new tabs. r=mconley,migration-reviewers
...
The support-text links should open a new tab instead of interrupting
the migration process.
Differential Revision: https://phabricator.services.mozilla.com/D204693
2024-03-15 16:11:33 +00:00
Mark Banner
afdbce2ec3
Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer
...
Differential Revision: https://phabricator.services.mozilla.com/D204182
2024-03-11 15:26:28 +00:00
Bojidar Marinov
b0118a001e
Bug 1839845 - Try switching to about:settings tab when opening about:preferences. r=Gijs,extension-reviewers,migration-reviewers,mconley,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D202735
2024-02-29 10:09:59 +00:00
Gregory Pappas
9bd4fc9c87
Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
...
Depends on D200551
Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 21:29:39 +00:00
Gregory Pappas
c1ec40f95a
Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
...
Depends on D200546
Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 21:29:37 +00:00
Sandor Molnar
c853f2f3e9
Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
...
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Gregory Pappas
55e30a8b92
Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
...
Depends on D200551
Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 15:07:46 +00:00
Gregory Pappas
0428704119
Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
...
Depends on D200546
Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 15:07:44 +00:00
Mark Banner
02d621a87e
Bug 1878110 - Change marionette based tests to import ES modules directly. r=arai,webdriver-reviewers,jgraham,application-update-reviewers,bytesized,migration-reviewers,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D200373
2024-02-23 18:39:31 +00:00
Mark Banner
6493c0a4a5
Bug 1879811 - Avoid re-enabling ESLint rules when they are already enabled by ESLint's recommended configuration, or mozilla-central's one. r=Gijs,webcompat-reviewers,extension-reviewers,devtools-reviewers,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D201361
2024-02-12 18:46:28 +00:00
Joel Maher
3662d84cd4
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96
Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures.
2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439
Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Erik Nordin
5bb63471e3
Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster
...
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198826
2024-01-19 02:15:33 +00:00
Erik Nordin
857bffe429
Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell
...
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198825
2024-01-19 02:15:33 +00:00
Gregory Pappas
8e0ae3e9ae
Bug 1872922 - Replace last few uses of XPCOMUtils.defineLazyGetter with ChromeUtils.defineLazyGetter and add linter error for XPCOMUtils.defineLazyGetter r=extension-reviewers,credential-management-reviewers,devtools-reviewers,Standard8,arai,robwu,Gijs,sgalich
...
Differential Revision: https://phabricator.services.mozilla.com/D198677
2024-01-17 15:54:00 +00:00
Henrik Skupin
144fe1476d
Bug 1836727 - [marionette] Fix MARIONETTE_MANIFESTS usage in moz.build files. r=webdriver-reviewers,necko-reviewers,application-update-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,Standard8,jesup,jdescottes,nalexander,sclements,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D197515
2024-01-11 10:34:29 +00:00
Mark Banner
e2e80f646d
Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in system modules. r=Gijs,perftest-reviewers,necko-reviewers,extension-reviewers,application-update-reviewers,fxview-reviewers,sync-reviewers,sessionstore-reviewers,reusable-components-reviewers,rpl,jesup,hjones,kshampur,skhamis,nalexander,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D197489
2024-01-05 09:22:34 +00:00
Nikki Sharpley
12407fd178
Bug 1864534 - remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
...
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
2024-01-04 15:40:22 +00:00
Cosmin Sabou
7cd8c743d7
Backed out changeset 0a133d5fd155 (bug 1864534) for causing screenshot related failures. CLOSED TREE
2024-01-04 18:38:25 +02:00
Nikki Sharpley
c4649017a7
Bug 1864534 - remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
...
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
2024-01-04 15:40:22 +00:00
Noemi Erli
7d4856299a
Backed out changeset 6aab4af4cab8 (bug 1864534) for causing failures in browser_syncedtabs_firefoxview_next.js CLOSED TREE
2024-01-03 19:30:19 +02:00
Nikki Sharpley
c3ee3b9dcd
Bug 1864534 - remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
...
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
2024-01-03 16:17:03 +00:00
Tom Marble
4b00b49e47
Bug 1859908 - convert .ini manifests to .toml: batch 20 marionette.ini r=jmaher,webdriver-reviewers,necko-reviewers,application-update-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,bytesized,kershaw,whimboo,dao,jesup,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D197206
2024-01-02 15:31:51 +00:00
Mike Conley
e42785a693
Bug 1866772 - Be more resilient against malformed URLs when importing from Safari. r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D196100
2023-12-12 19:13:26 +00:00
Sidharth Sachdev
43b6f2450c
Bug 1867031 - Update miscellaneous Strings, e.g. Migration Wizard. r=issammani,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D195376
2023-12-04 14:21:19 +00:00
Sylvestre Ledru
5bd4bc54a3
Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot
...
clang-format version 17.0.6 (taskcluster-QueHFUviQeyM8Y7r_d7MQQ)
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D195397
2023-12-04 10:09:36 +00:00
Joel Maher
33fa84a382
Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Mike Conley
1201221bf2
Bug 1860606 - Get rid of migration.ftl in favour of migrationWizard.ftl. r=kpatenio,fluent-reviewers,bolsson
...
migration.ftl was used by the old, legacy XUL migration dialog that was removed
in bug 1824851.
There were still a few strings being used by migration.ftl, but I've moved those
over to migrationWizard.ftl, and gone ahead and just removed the old file.
Differential Revision: https://phabricator.services.mozilla.com/D192509
2023-11-02 22:03:26 +00:00
Mike Conley
882584cc9e
Bug 1824851 - Remove the legacy XUL-based migration dialog. r=kpatenio
...
This also gets rid of some Histograms and Scalars that only the legacy wizard was
using, and also gets rid of the "legacy_wizard" object for migration wizard events.
Differential Revision: https://phabricator.services.mozilla.com/D191227
2023-10-23 16:08:06 +00:00
Cosmin Sabou
b76dbd47b9
Bug 1858783 - Fix browser_permissions.js filtering failures. a=test-only CLOSED TREE
2023-10-19 00:23:36 +03:00
Mike Conley
ee031a3626
Bug 1858783 - Add a telemetry event for when migration permissions are requested for Snap packages. data-review=jhirsch,r=kpatenio
...
Differential Revision: https://phabricator.services.mozilla.com/D190934
2023-10-18 19:16:38 +00:00
Dave Townsend
f2f7777e96
Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
...
The result of running the automated script available at https://github.com/Mossop/depi
Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-18 07:04:41 +00:00
Anna Yeddi
e2a8d8ebc6
Bug 1858041 - Temporarily skip of fail-if some Tier 2 a11y_checks failing or crashing on Autoland. r=Jamie,fxview-reviewers,ochameau,devtools-reviewers,places-reviewers,mixedpuppy
...
There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.
Related bugs:
- Fail-if tests: meta bug 1848402
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D190890
2023-10-17 18:00:05 +00:00
Mike Conley
3c473874e4
Bug 1855280 - Remove the ability to switch to the old migration wizard. r=kpatenio,omc-reviewers,settings-reviewers,credential-management-reviewers,negin,aminomancer,mtigley
...
This removes the pref to re-enable the legacy wizard, and all of the things that used
to read from it.
It also disables the ability to use the legacy wizard from about:welcome with the
aboutWelcomeBehavior feature.
It also removes the closeMigrationWizard utility from BrowserTestUtils, since that
effectively became a thin-wrapper around BrowserTestUtils.removeTab.
Finally, this patch also removes some documentation about the legacy migration wizard,
and tests that specifically check the legacy dialog behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D190716
2023-10-16 18:24:42 +00:00
Sandor Molnar
099f0fd4c3
Backed out 4 changesets (bug 1857999) for causing dt failures on browser_theme_switching.js & Mn failures at test_element_state_chrome.py CLOSED TREE
...
Backed out changeset 75f5e6e3d917 (bug 1857999)
Backed out changeset 0d0c1d1e80e7 (bug 1857999)
Backed out changeset b8a03d31ecea (bug 1857999)
Backed out changeset dd5a10f9cfff (bug 1857999)
2023-10-16 14:12:22 +03:00
Dave Townsend
92c3ea0f78
Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
...
The result of running the automated script available at https://github.com/Mossop/depi
Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-16 09:43:26 +00:00
Mike Conley
1ba58e779d
Bug 1818237 - Add automated tests for requesting migrator permissions. r=mstriemer
...
Depends on D188874
Differential Revision: https://phabricator.services.mozilla.com/D189842
2023-10-11 20:09:22 +00:00
Mike Conley
5085c317ab
Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
...
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.
We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).
Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.
Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 20:09:21 +00:00
Sandor Molnar
d8a0e28ce0
Backed out 2 changesets (bug 1818237) for causing xpc failures on browser/components/migration/tests/unit/test_Chrome_permissions.js CLOSED TREE
...
Backed out changeset e5d78a9ddcb4 (bug 1818237)
Backed out changeset 87f67f05c8a8 (bug 1818237)
2023-10-11 19:53:35 +03:00
Anna Yeddi
d3ec1141aa
Bug 1858037 - Temporarily skip some tests to investigate intermittent a11y_checks results. r=Jamie,devtools-reviewers,mixedpuppy
...
These tests were failing on Try but are passing on Autoland or vice versa. We need to skip them while we investigate it
Differential Revision: https://phabricator.services.mozilla.com/D190523
2023-10-11 15:26:25 +00:00
Mike Conley
3c1fdf043c
Bug 1818237 - Add automated tests for requesting migrator permissions. r=mstriemer
...
Depends on D188874
Differential Revision: https://phabricator.services.mozilla.com/D189842
2023-10-11 14:53:56 +00:00