Iulian Moraru
9a36d620f9
Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE
2023-05-18 22:09:25 +03:00
Itiel
801dad3de3
Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane
...
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-05-18 17:19:45 +00:00
Mark Banner
2bd093b567
Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Mike Conley
c759904dae
Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
...
Long ago, the menu panel in was a customizable area that users could drag things into.
That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.
It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.
I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.
Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00
Mark Banner
a49b8ef78f
Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
abab9b2db7
Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
...
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.
Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.
This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.
Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311
Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE
2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa
Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
...
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.
Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.
This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.
Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Shane Caraveo
c114951f8b
Bug 1783972 make browser actions pop out of overflow r=zombie,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D154179
2022-08-22 18:55:59 +00:00
Iulian Moraru
df431be6b8
Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
...
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
9e59e52e55
Bug 1780074 - Migrate newtab consumers to use ESM imports directly. r=daleharvey,application-update-reviewers,nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D152114
2022-07-20 10:36:52 +00:00
Neil Deakin
c9ddb2f4b9
Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs
...
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm
This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.
Differential Revision: https://phabricator.services.mozilla.com/D149285
2022-07-03 09:44:39 +00:00
Norisz Fay
f4827a4636
Backed out 2 changesets (bug 1682621) for causing bc failures on browser_menu_touch.js CLOSED TREE
...
Backed out changeset 88be5107a4a1 (bug 1682621)
Backed out changeset e32910a4948b (bug 1682621)
2022-06-29 19:36:51 +03:00
Neil Deakin
4674aa45e8
Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs
...
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm
This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.
Differential Revision: https://phabricator.services.mozilla.com/D149285
2022-06-29 12:38:30 +00:00
Marian-Vasile Laza
3dee1242d8
Backed out 2 changesets (bug 1682621) for causing bc failures on browser_ext_browserAction_click_types.js.
...
Backed out changeset 31a6b027b4e7 (bug 1682621)
Backed out changeset 782fd4871c5f (bug 1682621)
2022-06-28 20:27:15 +03:00
Neil Deakin
27e54692b9
Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs
...
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm
This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.
Differential Revision: https://phabricator.services.mozilla.com/D149285
2022-06-28 16:02:37 +00:00
Gijs Kruitbosch
a408c9940d
Bug 1749537 - remove obsolete _formatPrintButtonShortcuts(), r=jwatt
...
Differential Revision: https://phabricator.services.mozilla.com/D135949
2022-02-28 14:33:29 +00:00
Jonathan Watt
8bf216317f
Bug 1745332 - Remove print.tab_modal.enabled checks from CustomizableUI code. r=mconley
...
The old UI is going away.
Differential Revision: https://phabricator.services.mozilla.com/D133451
2022-01-06 18:55:37 +00:00
Rob Wu
b6b78cf0cc
Bug 1714846 - Really hide panels on hide, r=robwu,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-07 11:50:19 +00:00
Butkovits Atila
f90ffaea22
Backed out changeset 6e298bdd0dd8 (bug 1714846) for causing assertion failures at CompositorBridgeParent.cpp. CLOSED TREE
2021-12-03 23:30:10 +02:00
Rob Wu
68e93f997c
Bug 1714846 - Really hide panels on hide, r=robwu,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-03 19:16:51 +00:00
Scott
9c09e77b2e
Bug 1737868 - Pocket panel overflow menu not properly getting the remote attribute. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D130770
2021-11-16 00:35:34 +00:00
Tooru Fujisawa
9281ca231f
Bug 1706650 - Split localization item for update banner label for each notification. r=zbraniecki,fluent-reviewers,Gijs
...
Instead of copying from label-* attributes, set data-l10n-id for each
notification
Also, stop using attributes for checking if the notification is supported.
Differential Revision: https://phabricator.services.mozilla.com/D129270
2021-10-26 18:32:36 +00:00
Neil Deakin
0d6adaeabb
Bug 1733786, replace uitour implementation of show how button with one that focuses the item on the app menu and submenu instead, r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D128428
2021-10-19 14:54:45 +00:00
Scott
d596fb0a27
Bug 1693582 - Moving Pocket button panels to remote content process r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D122128
2021-09-08 16:11:34 +00:00
Scott
016ff65279
Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D122278
2021-08-25 00:46:01 +00:00
Marian-Vasile Laza
3cf60904a9
Backed out changeset 6ba2b54d02f6 (bug 1724668) for causing bc failures on browser_panel_locationSpecific.js. CLOSED TREE
2021-08-20 20:52:53 +03:00
Scott
6b8ab0fe63
Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D122278
2021-08-20 16:54:00 +00:00
Sam Foster
22012dcb8a
Bug 1719463 - Part 7: Remove the Logins, Addons, Preferences and Print buttons from the pre-proton appMenu view. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D121807
2021-08-10 05:29:32 +00:00
Mike Conley
45d08882f4
Bug 1720534 - Clean up styles in Bookmarks Menu Button menupopups on Windows 7 and 10. r=desktop-theme-reviewers,dao
...
This also gets rid of a dead CSS class (panel-subview-footer).
Differential Revision: https://phabricator.services.mozilla.com/D119906
2021-07-18 00:06:41 +00:00
Gijs Kruitbosch
4508e659f8
Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D117058
2021-07-07 22:15:50 +00:00
Mike Conley
ec03c5ad34
Bug 1700198 - Remove subviewbutton-iconic class from Library panel markup. r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D118621
2021-06-24 20:27:46 +00:00
prathikshaprasadsuman
367366ff97
Bug 1701057 - Addon icon should be visible in the addon install confirmation dialog. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D112742
2021-04-21 08:22:22 +00:00
Emma Malysz
eead5ed482
Bug 1701287, use brand short name for app menu button label r=fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D110113
2021-03-29 15:52:08 +00:00
Doug Thayer
d6c9d471c7
Bug 1694811 - Extend existing popup hiding logic to PanelUI r=Gijs
...
This effectively mirrors the panel hiding logic we use to hide
PopupNotifications panels so that we also hide notifications attached to the
hamburger menu. This will cover alerts and other similar modals originating
from content.
Differential Revision: https://phabricator.services.mozilla.com/D109526
2021-03-25 17:54:10 +00:00
Emma Malysz
c0ba2b2262
Bug 1700503, insert enterprise policy support menu item to app menu r=mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D109569
2021-03-24 20:48:28 +00:00
Molly Howell
6c5cf6c1d4
Bug 1696260 - Keep app menu button badges showing while the menu is open. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D107950
2021-03-15 15:51:19 +00:00
Gijs Kruitbosch
2c74e1ff84
Bug 1697420 - add fluent support to CustomizableUI API widgets, r=emalysz
...
Differential Revision: https://phabricator.services.mozilla.com/D107797
2021-03-10 17:29:51 +00:00
Gijs Kruitbosch
eebfa86591
Bug 1695904 - update menu button tooltip when the panel hides/shows regardless of cause, r=emalysz
...
Differential Revision: https://phabricator.services.mozilla.com/D106912
2021-03-02 17:08:49 +00:00
Emma Malysz
ce870c395d
Bug 1695698: update hamburger menu tooltip text r=fluent-reviewers,mconley,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D106808
2021-03-01 18:51:00 +00:00
Mike Conley
632adba6fc
Bug 1695348 - Mass rename browser.proton.appmenu.enabled to browser.proton.enabled. r=emalysz,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D106800
2021-03-01 17:27:52 +00:00
Mike Conley
7e1ba6d3c8
Bug 1691152 - Apply latest Proton stylings to AppMenu. r=ewright
...
Depends on D104749
Differential Revision: https://phabricator.services.mozilla.com/D105027
2021-02-12 17:59:50 +00:00
Mike Conley
a318c5ef0b
Bug 1690662 - Port the add-on and browser update banners to the Proton AppMenu. r=ewright
...
Differential Revision: https://phabricator.services.mozilla.com/D104749
2021-02-12 17:59:49 +00:00
Micah Tigley
e2ada69a69
Bug 1690351 - Create a Proton-specific More Tools panel. r=jdescottes,mconley,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D104249
2021-02-10 15:21:58 +00:00
Emma Malysz
5a03aeace8
Bug 1689405: remove components of library panel r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D103532
2021-01-30 17:12:51 +00:00
Molly Howell
44628f3c69
Bug 1688257 - Switch to dedicated Proton appmenu pref. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D102790
2021-01-22 20:05:55 +00:00
Erica Wright
ad5e1db657
Bug 1686331 - Library menu should not have a scroll bar. r=prathiksha,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D102471
2021-01-21 06:20:55 +00:00
Mike Conley
9a71ff4019
Bug 1683419 - Fork Help menu strings for use in the AppMenu. r=Gijs,flod,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D100957
2021-01-20 18:12:33 +00:00
Molly Howell
d771456edc
Bug 1686324 - Introduce a temporary Proton AppMenu skeleton. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D102031
2021-01-19 16:48:29 +00:00
Erica Wright
4b15bc0bb2
Bug 1685133 - String changes due to newtab updates r=preferences-reviewers,prathiksha,fluent-reviewers,flod,ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D100819
2021-01-08 18:55:24 +00:00