Commit Graph

6101 Commits

Author SHA1 Message Date
Gijs Kruitbosch
998f345683 Bug 1946400 - move nsBrowserAccess (nsIBrowserDOMWindow impl) out of browser.js into its own module, r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D238533
2025-02-18 16:17:28 +00:00
Kai Engert
cc7d553c17 Bug 1944707 - Move pippki.js to .sys.mjs. r=keeler,fluent-reviewers,bolsson,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D131184
2025-02-12 10:54:02 +00:00
Meg Viar
7ecf60304b Bug 1946517 - Prevent URL bar from showing through preonboarding modal UI r=nalexander,emilio,urlbar-reviewers,adw
Addresses issue where the URL bar appeared through the UI of the preonboarding modal (see screenshot in bug).
- Show the preonboarding after the "MozAfterPaint" event fires for the browser chrome.
- If for some reason the "MozAfterPaint" event never fires of the event listener was added after it fired, show the modal after 1 second as a fallback.

Differential Revision: https://phabricator.services.mozilla.com/D237100
2025-02-10 22:46:06 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
Stanca Serban
d2bc5aedda Backed out changeset aee2b68df733 (bug 1944707) for causing mochitests failures. CLOSED TREE 2025-02-07 05:25:15 +02:00
Kai Engert
5c959ca366 Bug 1944707 - Move pippki.js to .sys.mjs. r=keeler,fluent-reviewers,bolsson,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D131184
2025-02-06 23:00:46 +00:00
Emilio Cobos Álvarez
ab23c6cf79 Bug 1945451 - Avoid breaking out the urlbar while in customize mode. r=dao,urlbar-reviewers
Density changes called directly into the urlbar input to update the
breakout. But when customizing the urlbar shouldn't break out.

That means that this code is mostly for when density is changed via
another window, or direct pref changes I guess.

Differential Revision: https://phabricator.services.mozilla.com/D236539
2025-02-04 19:42:04 +00:00
Emma Zuehlcke
c4bd8080a9 Bug 1866661, r=hjones,reusable-components-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D235457
2025-02-04 14:26:29 +00:00
Moritz Beier
16914fd2b6 Bug 1880913 - Part 6: Remove BrowserSearch and BrowserSearchTelemetry from browser.js. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D236218
2025-02-04 11:07:13 +00:00
Moritz Beier
4afb8b6192 Bug 1880913 - Part 5: Display search engine removal notification via category manager. r=Standard8,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236217
2025-02-04 11:07:13 +00:00
Moritz Beier
4ff8ed5deb Bug 1880913 - Part 4: Remove BrowserSearch.searchBar getter. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D235598
2025-02-04 11:07:12 +00:00
Moritz Beier
152f732f88 Bug 1880913 - Part 3: Move open search handling from BrowserSearch to dedicated module. r=Standard8,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235597
2025-02-04 11:07:12 +00:00
Moritz Beier
3ef77c7282 Bug 1880913 - Part 2: Move search request handling from browser.js to SearchUIUtils. r=search-reviewers,firefox-desktop-core-reviewers ,mossop,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D235596
2025-02-04 11:07:11 +00:00
Moritz Beier
6c0a5096a8 Bug 1880913 - Part 1: Move urlbar placeholder handling from BrowserSearch to UrlbarInput. r=urlbar-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D235595
2025-02-04 11:07:11 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Jeremy Swinarton
4c0ff4a071 Bug 1940752: 'Reopen Closed Tab' tab context menu, and other paths calling undoCloseTab, support tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234680
2025-01-21 23:07:02 +00:00
Sandor Molnar
f776616d69 Backed out 2 changesets (bug 1297008) for causing M-vt failures @ browser_link_in_tab_title_and_url_prefilled_blank_page.js CLOSED TREE
Backed out changeset ce85088a9340 (bug 1297008)
Backed out changeset cd90c0935331 (bug 1297008)
2025-01-10 01:14:53 +02:00
Emma Zuehlcke
5ca6a4bb43 Bug 1297008, r=mak,Gijs,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226694
2025-01-09 17:49:09 +00:00
Jeremy Swinarton
cf0ea617df Bug 1939599: Tab groups can be restored by Ctrl+Shift+T r=dao,sthompson,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233102
2025-01-08 22:33:13 +00:00
Emilio Cobos Álvarez
b24d6ef3e4 Bug 1935035 - Use a <toolbar> for notifications. r=desktop-theme-reviewers,dao
I'm not sure off-hand how to test the tab-specific notifications, but
that uses no particular styling so seems it should just work?

Differential Revision: https://phabricator.services.mozilla.com/D233427
2025-01-08 15:02:34 +00:00
Tom Schuster
a7bbaa266b Bug 1936519 - Remove inline event handler from panic-button success panel. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D231786
2024-12-11 18:40:00 +00:00
Daisuke Akatsuka
8c442be904 Bug 1928132: Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228954
2024-12-05 07:13:31 +00:00
Adam Vandolder
2ba689d99e Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-05 01:20:07 +00:00
Goloman Adrian
05b7d33317 Backed out changeset 4d19e4620e63 (bug 1924861) for causing bc failures @browser_stop_pending.js. CLOSED TREE 2024-12-04 09:11:45 +02:00
Adam Vandolder
87c9038ba7 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-04 04:17:36 +00:00
Cosmin Sabou
82fbc8fbe4 Backed out changeset a8d030efc4ea (bug 1924861) for causing bc failures on browser_stop_pending. 2024-12-02 01:21:14 +02:00
Adam Vandolder
f6e7455adc Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-01 04:13:01 +00:00
Sandor Molnar
7e190c9386 Backed out changeset b94afd94ed9c (bug 1924861) for causing multiple bc failures. CLOSED TREE 2024-11-30 20:40:15 +02:00
Norisz Fay
5caeaca8fe Backed out 2 changesets (bug 1928132) for causing failures on browser_mouseout_notification_panel.js and Bug 1934387, Bug 1934388, Bug 1934389 CLOSED TREE
Backed out changeset 2ea4986f9eb8 (bug 1928132)
Backed out changeset 4a72ad308d0c (bug 1928132)
2024-11-30 15:43:28 +02:00
Adam Vandolder
5f7b028386 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-11-29 23:38:09 +00:00
Daisuke Akatsuka
38412e4cd1 Bug 1928132: Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228954
2024-11-29 21:24:53 +00:00
Goloman Adrian
2cd2737f6f Backed out 2 changesets (bug 1928132) for causing bc failures browser_popupNotification_2.js. CLOSED TREE
Backed out changeset 5882194e7456 (bug 1928132)
Backed out changeset 0d13b91f55e0 (bug 1928132)
2024-11-29 15:18:36 +02:00
Daisuke Akatsuka
c738c0eb32 Bug 1928132: Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228954
2024-11-29 11:18:02 +00:00
Emilio Cobos Álvarez
768894a512 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 12:12:51 +00:00
Cristina Horotan
bb08cc9f1d Backed out 5 changesets (bug 1930292, bug 1932600) for causing chrome failures at test_maximized_persist.xhtml on a CLOSED TREE
Backed out changeset 2418bfee53f1 (bug 1932600)
Backed out changeset 3297e990715a (bug 1932600)
Backed out changeset 24a670dea977 (bug 1930292)
Backed out changeset 7dd9f48216dd (bug 1930292)
Backed out changeset 15a85ec739dd (bug 1930292)
2024-11-28 06:57:35 +02:00
Emilio Cobos Álvarez
26de824592 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 03:26:50 +00:00
Dão Gottwald
3245dd9a52 Bug 1928189 - Let Firefox View show tabs from collapsed groups. r=sthompson,fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D229896
2024-11-26 16:45:56 +00:00
Butkovits Atila
6a4f64d393 Backed out changeset 8c5bff1fa41a (bug 1924861) for causing failures at forward.py. 2024-11-26 12:51:09 +02:00
Adam Vandolder
fad0c07fe5 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-11-26 04:48:49 +00:00
Sandor Molnar
7058c42e18 Backed out changeset c64aebba09d9 (bug 1924861) for causing mochitest failures. CLOSED TREE 2024-11-26 03:17:30 +02:00
Adam Vandolder
2d308415a4 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-11-25 23:18:32 +00:00
Martin Sirringhaus
9fd347e052 Bug 1928686: Handle devices that do not send retriesLeft-counter (r=jschanck)
Differential Revision: https://phabricator.services.mozilla.com/D228332
2024-11-20 22:33:59 +00:00
Ray Kraesig
19038c4983 Bug 1929474 - [1/2] Fix Win10 tablet-mode hiding of close-button r=desktop-theme-reviewers,dao
The simplification of browser.css in bug 1844242 caused the close-button
to be hidden in tablet mode alongside the window-resizing buttons.
Revert that change's effect, and add documentation.

Differential Revision: https://phabricator.services.mozilla.com/D228205
2024-11-14 18:01:42 +00:00
Ray Kraesig
60ee4131e1 Bug 1819421 - [2/2] consider Win11 tablet mode for UI density r=win-reviewers,handyman,Gijs
Check for Windows 11 tablet mode when setting the UI density. (In
particular, have the UI-density object listen for the signal change,
rather than filtering it through `TabletModeUpdater`.)

This includes a change to the semantics of "tablet-mode-change": it now
signals Win11 tablet mode as distinct from Win10 tablet mode.

Differential Revision: https://phabricator.services.mozilla.com/D224245
2024-11-04 13:56:20 +00:00
Ray Kraesig
28f8d3d9cf Bug 1819421 - [1/2] create parallel check for Win11 tablet mode r=win-reviewers,Gijs,gsvelto,gstoll
Win11's tablet mode is different from Win10's tablet mode in ways both
subtle and gross. Avoid unifying them implicitly, and make it clear that
they should not be unified _explicitly_ without testing.

Unfortunately, Windows 11's API for checking whether the device is in
tablet mode is broken -- it requires one to know whether the device is a
tablet to interpret the return value, but there is no documented API
providing that information. We use a heuristic partly borrowed from
Chromium and partly based on independent investigation.

As all of the code using WindowsUIUtils effectively only checked for
Win10's tablet mode, this commit technically has no functional
changes.

Differential Revision: https://phabricator.services.mozilla.com/D224244
2024-11-04 13:56:20 +00:00
Butkovits Atila
24b71f7279 Backed out 2 changesets (bug 1819421) for causing linting failures at browser.js. CLOSED TREE
Backed out changeset b4f770bfe94c (bug 1819421)
Backed out changeset b11774655311 (bug 1819421)
2024-11-01 19:43:00 +02:00
Ray Kraesig
048455f466 Bug 1819421 - [2/2] consider Win11 tablet mode for UI density r=win-reviewers,handyman,Gijs
Check for Windows 11 tablet mode when setting the UI density. (In
particular, have the UI-density object listen for the signal change,
rather than filtering it through `TabletModeUpdater`.)

This includes a change to the semantics of "tablet-mode-change": it now
signals Win11 tablet mode as distinct from Win10 tablet mode.

Differential Revision: https://phabricator.services.mozilla.com/D224245
2024-11-01 16:32:09 +00:00
Ray Kraesig
16f10abebe Bug 1819421 - [1/2] create parallel check for Win11 tablet mode r=win-reviewers,Gijs,gsvelto,gstoll
Win11's tablet mode is different from Win10's tablet mode in ways both
subtle and gross. Avoid unifying them implicitly, and make it clear that
they should not be unified _explicitly_ without testing.

Unfortunately, Windows 11's API for checking whether the device is in
tablet mode is broken -- it requires one to know whether the device is a
tablet to interpret the return value, but there is no documented API
providing that information. We use a heuristic partly borrowed from
Chromium and partly based on independent investigation.

As all of the code using WindowsUIUtils effectively only checked for
Win10's tablet mode, this commit technically has no functional
changes.

Differential Revision: https://phabricator.services.mozilla.com/D224244
2024-11-01 16:32:08 +00:00
Norisz Fay
7c7d41d846 Backed out changeset 5b4cea7ea948 (bug 1924861) for causing mochitest failures on test_ext_tabs_goBack_goForward.html, test_bug1300461.html CLOSED TREE 2024-10-29 04:57:43 +02:00