Commit Graph

378 Commits

Author SHA1 Message Date
milindl
96eb3d4985 Bug 1247201 - Run cleaners async to clear as much as possible r=mak
Amended to fix review changes
(stylistic + other)
Turns all cleaners into promises so they run asyc

MozReview-Commit-ID: DV5ug6vNXkS
2017-03-27 19:27:35 +05:30
Marco Bonardo
fdcc7c5e61 Bug 1306276 - Deprecate History RemovePage and RemovePages. r=standard8
MozReview-Commit-ID: 3NSaXKy1hP3
2017-03-22 12:44:54 +01:00
David Rajchenbach-Teller
eba4a143fb Bug 1087255 - Convert browser/components/places JS clients of RemovePage(s) to History.remove; Patch by Yoric, updated by Standard8. r=mak
MozReview-Commit-ID: GcVajWOyvkT
2014-10-31 12:39:02 +01:00
Tooru Fujisawa
da7d4444d8 Bug 1302661 - Add multiple bookmark items when multiple URLs are dropped as single item. r=mak 2014-02-06 01:38:31 +09:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Pavan
458aed5d63 Bug 1196395 - No plurals form for context menus when multiple pages are selected in Library. r=mak 2016-12-21 10:06:00 +01:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Mark Banner
0dc78b7964 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop
MozReview-Commit-ID: LdoXLniNeT7
2016-11-03 11:51:48 +00:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Pushpankar
77a14e357c Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 2016-07-16 10:20:04 +02:00
Mike de Boer
60f6e6c5d2 Bug 1248616 - move simulated places nodes after a successful drag 'n drop operation, which applies to Recently Bookmarked items. r=mak 2016-05-31 11:06:37 +02:00
Sebastian Hengst
07e4f53195 Backed out changeset 4dbe106594fa (bug 1248616) for failing browser_423515.js. r=backout 2016-05-30 20:28:52 +02:00
Mike de Boer
16cf8a43d8 Bug 1248616 - move simulated places nodes after a successful drag 'n drop operation, which applies to Recently Bookmarked items. r=mak 2016-05-30 16:47:09 +02:00
Mike de Boer
bb1fb58dcc Bug 1248267 - allow Recently Bookmarked items to be special root nodes to allow primitive contextual actions. r=mak,dao 2016-05-19 12:37:33 +02:00
Dão Gottwald
7412b86381 Bug 1248268 - Add option for disabling the "Recently Bookmarked" UI. r=mak 2016-04-29 13:43:59 +02:00
Marco Bonardo
c805b3d790 Bug 1251446 - Can't delete more than 300 items from history treeviews. r=trivial-typo-fix
MozReview-Commit-ID: CoMlnL0Wwht
2016-02-26 16:16:48 +01:00
Dave Townsend
a2ba043d69 Bug 1245649: Turn on no-trailing-spaces. r=Gijs 2016-02-03 14:22:33 -08:00
Marco Bonardo
2456bebdca Bug 1230471 - Basic eslint fixes in places. r=mconley 2015-12-10 06:46:49 -05:00
simplyblue
eebafcf9e3 Bug 1228976 - Remove array comprehensions from Places .r=mak 2015-12-03 16:26:58 +05:30
Hassen ben tanfous
aa7b48bf89 Bug 1074804 - Replace arrays .indexOf with .includes in Places. r=mak 2015-10-11 20:24:32 +02:00
Kapeel Sable
d5d674fd3c Bug 1212171 - Change for referencing a different object Component.utils. instead of Cu. r=mak 2015-10-08 06:53:00 +02:00
Tooru Fujisawa
735dfed4e6 Bug 1207491 - Part 10: Remove use of expression closure from browser/components/places/content/. r=Gijs 2015-09-23 18:36:21 +09:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Marco Bonardo
19425c3f03 Bug 1095411 - PlacesUtils.wrapNode is using synchronous getKeywordForBookmark. r=ttaubert 2015-05-22 19:02:41 +02:00
Asaf Romano
d911d456eb Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak 2015-04-23 16:34:55 +03:00
Carsten "Tomcat" Book
a4d1b4af8a Backed out changeset 7f9114a84892 (bug 951651) for bc2 test bustage on a CLOSED TREE 2015-04-23 08:52:56 +02:00
Asaf Romano
823f1fa468 Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak. 2015-04-23 08:15:21 +03:00
Marco Bonardo
0c56948218 Bug 1144571 - Pasting multiple bookmarks should retain their order. r=ttaubert 2015-03-28 14:00:11 +01:00
Tom Schuster
24216f65f0 Bug 821724 - Implement a menuitem for places/bookmarks to open them in a private window. r=mak 2015-01-13 21:18:33 +01:00
Marco Bonardo
77be050825 Bug 1095069 - Cannot copy or delete bookmarks from search results in library. r=mano 2014-11-13 10:19:19 +01:00
Asaf Romano
1fb486c62a Bug 982115 - PlacesTransactions: (1) Decouple |transact| and |batch|, and make batch work like Task.spawn, rather than the custom solution we had so far (yielding transactions rather than calling |transact| for the batched transactions). so that |transact| may be called during a batch from any function, not limiting the batch 'context' to the function passed to |batch|; (2) Rename the uri input property to URL, and allow passing DOM URL objects for it (in addition to plain specs and nsIURI objects) - this matches recent Bookmark.jsm and History.jsm work; (3) Improve the module documentation. r=mak. 2014-11-10 10:36:56 +02:00
Gijs Kruitbosch
476bf86d60 Bug 1090609 - don't disable open in tabs when there's only one item there, r=mak 2014-11-03 10:44:47 +00:00
Asaf Romano
fbed712ada Bug 1068671 - folderReadOnly doesn't pertain to bookmarks or results. r=mak 2014-10-14 17:03:28 +03:00
Carsten "Tomcat" Book
720b2367b9 Backed out changeset b30d47d94a85 (bug 1068671) for bc1 test failures 2014-10-01 13:14:06 +02:00
Asaf Romano
ce0d37a700 Bug 1068671 - Remove 'read-only' folders support from places. r=mak 2014-10-01 12:19:06 +03:00
Asaf Romano
99e55486ac Bug 1070503 - Async Places Transactions: Delete command implementation. r=mak. 2014-09-23 09:11:26 +03:00
Asaf Romano
88912b1ad3 Bug 1069235 - make guid and parentGuid naming consistent. r=mak 2014-09-20 10:57:34 +03:00
Asaf Romano
cb0b83af93 Fix the 'bustage' of browser_parsable_script.js coming from bug 1067954 by whitelisting controller.js. It broke due to bug 1015578 (see mak's comment 2 there). CLOSED TREE 2014-09-19 18:23:20 +03:00
Asaf Romano
a9fb56da73 Bug 1067956 - Async Places Transactions: Drop functionality. r=mak. 2014-09-19 17:04:51 +03:00
Asaf Romano
acc27114a6 Bug 1067954 - Async Places Transactions: Paste functionality. r=mak 2014-09-19 16:53:27 +03:00
Gijs Kruitbosch
9ace2cd351 Bug 1006989 - hide and disable cut/copy/delete/properties when opening bookmarks context menu with no selection, r=mano 2014-06-05 15:28:07 +01:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Asaf Romano
199cfe7699 Bug 993391 - Places async transactions: Implement "move bookmarks" command. r=mak. 2014-04-22 08:42:23 +03:00
Tetsuharu OHZEKI
a2ad59c326 Bug 994188 - Fix "ReferenceError: Cu is not defined" in browser/components/places/content/controller.js. r=mak 2014-04-12 01:11:10 +09:00
Asaf Romano
3f90880910 Bug 993274 - Remove cmd_new:livemark. r=mak 2014-04-08 12:05:26 +03:00