Commit Graph

56 Commits

Author SHA1 Message Date
Bevis Tseng
96aaed1a3c Bug 1394349 - Label dom::SimpleTextTrackEvent with its associated inner window. r=billm 2017-08-28 17:22:20 +08:00
bechen@mozilla.com
5c83066d94 Bug 1385092 - Null check for the sParserWrapper. r=alwu
From the crash report and code logic, it is possible that the KillClearOnShutdown comes and the NS_XPCOM_SHUTDOWN_OBSERVER_ID never comes when getting obsercerService fail.
So add null check for the sParserWrapper and combine mShutdown to a new function.

MozReview-Commit-ID: Cj5ph2JrO7v
2017-08-09 17:30:52 +08:00
Carsten "Tomcat" Book
3fe83e45ea merge mozilla-inbound to mozilla-central a=merge 2017-07-27 10:57:25 +02:00
Bevis Tseng
2ecbda13e2 Bug 1378930 - Part 2: Remove the aName parameter from SchedulerGroup/DocGroup/DispatcherTrait. r=billm 2017-07-26 16:13:35 +08:00
Kartikaya Gupta
14424677af Bug 1384233 - Remove SizePrintfMacros.h. r=froydnj
We have a minimum requirement of VS 2015 for Windows builds, which supports
the z length modifier for format specifiers. So we don't need SizePrintfMacros.h
any more, and can just use %zu and friends directly everywhere.

MozReview-Commit-ID: 6s78RvPFMzv
2017-07-26 16:03:57 -04:00
Bill McCloskey
ce42826bdf Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
238bf154d5 Backed out changeset 4f6302a98ae4 (bug 1372405) 2017-06-21 13:59:26 +02:00
Bill McCloskey
67e8af4720 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
bbe9441993 Backed out changeset 9846de3bd954 (bug 1372405) 2017-06-20 08:27:02 +02:00
Bill McCloskey
f69608368b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
bechen
4db4e2b3e3 Bug 1368489 - Fixing TimeMarchesOn step 13, sort the tasks by "text track cue order". r=rillian.
1. Sort by TextTrack. 2. Sort by time. 3. Sort by the order of added to TextTrack.

MozReview-Commit-ID: 4nwx6U5dMpy
2017-06-13 09:52:27 +08:00
bechen
30c6754f04 Bug 1325001 - TextTrackList::GetShowingCues should return cues whose kind is Subtitles or Captions. r=rillian
We should only render the Subtitles/Captions cue on the screen. In addition, rename the activeCues to showingCues.
Because the meaning of "active" and "showing" are different. Showing means we can see the cue on the screen, active means the current playback time touches the cue.

MozReview-Commit-ID: 1BfHhxFXBDP
2017-05-22 11:30:22 +08:00
bechen
7a5d6fe640 Bug 1364185 - Call DispatchUpdateCueDisplay() in TextTrackManager::NotifyCueUpdated. r=alwu
If the video is paused, then set the "TextTrack.mode=hidden/showing", in this case, TimeMarchesOn will return at step 7,
not update the screen. So call DispatchUpdateCueDisplay explicitly to update the screen.

MozReview-Commit-ID: IuazaeSXX31
2017-05-17 14:57:51 +08:00
bechen
b96882816b Bug 1343797 - Label runnables in TextTrackManager.cpp. r=jwwang
MozReview-Commit-ID: 2rP55aUyNi
2017-03-27 16:51:17 +08:00
bechen
e7707bafc3 Bug 1334112 - part1: Add IsLoaded functions for TextTrack, TextTrackList, TextTrackManager. r=rillian
MozReview-Commit-ID: GBEKZvLUiPn
2017-02-20 15:27:06 +08:00
Tom Tromey
a4b717ab39 Bug 1060419 - make log_print use Printf.h, r=froydnj
MozReview-Commit-ID: BIZ1GQEZ1vs
2016-12-15 20:16:31 -07:00
Ralph Giles
f4801cef5f Bug 1333931 - Handle nullptr TextTrack objects in sorting. r=kinetik
Check for nullptr arguments passed to CompareTextTracks. Based
on Ben Kelly's analysis this can happen if the cycle collector
has cleared a TextTrack pointer while comparision is still
happening, perhaps in a queued event task.

This change makes nullptr sort to the end, and adds a
MOZ_DIAGNOSTIC_ASSERT for trying to get the position
of a nullptr track should someone add another call at
a later date.
2017-01-31 17:24:17 -08:00
bechen
6b22fabee8 Bug 1329117 - Run HonorUserPreferencesForTrackSelection at stable state. r=jwwang
MozReview-Commit-ID: FwZyHHFa8KD
2017-01-23 11:12:22 +08:00
bechen
4ad2bfb27c Bug 1310162 - mTrack in SimpleTextTrackEvent might be null. r=jwwang
MozReview-Commit-ID: ESqYqBem7kQ
2016-12-28 15:51:37 +08:00
bechen
f68820a82c Bug 1304948 - Part 2: Don't run TimeMarchesOn when shutdown. r=rillian
MozReview-Commit-ID: AE6FE74ESHN
2016-09-29 17:47:33 +08:00
Paul Bignier
be164c144a Bug 1305674 - initialize mUpdateCueDisplayDispatched. r=mrbkap
* There is no visible initializer function to that class so the variable could be accessed to, uninitialized
2016-09-27 12:19:17 +02:00
bechen
dae08cf497 Bug 1275492 - Add logs for TextTrackManager. r=jwwang
MozReview-Commit-ID: LyNTDhjj0fR
2016-08-25 10:58:49 +08:00
bechen
bf02f3914b Bug 1294142 - TextTrackManager::mTextTracks is null after CC. r=jwwang
MozReview-Commit-ID: 7EU54n1erpZ
2016-08-11 18:09:06 +08:00
bechen
eac7c9268a Bug 1285897 - Async dispatch cuechange event on TextTrack object. r=rillian
MozReview-Commit-ID: DKWCAEaT58J
2016-07-12 17:41:41 +08:00
Carsten "Tomcat" Book
4241e83a8a Backed out changeset 5c7dda18ec02 (bug 1285897) 2016-07-21 08:03:10 +02:00
bechen
726efd3dd1 Bug 1285897 - Async dispatch cuechange event on TextTrack object. r=rillian
MozReview-Commit-ID: DKWCAEaT58J
2016-07-12 17:41:41 +08:00
bechen
6a5de816db Bug 1281999 - Update the display when we remove an active cue by changing the texttrackmode to disabled. r=rillian
MozReview-Commit-ID: GeF5Icd9jLu
2016-07-18 15:39:14 +08:00
Alastor Wu
d767ac8e41 Bug 1280644 - part2 : modify naming and add scope indentifier. r=rillian
MozReview-Commit-ID: 9ysNb5SiQOP
2016-07-11 10:51:13 +08:00
Alastor Wu
b698b3ba71 Bug 1280644 - part1 : add Telemetry for webvtt. r=bsmedberg,rillian
MozReview-Commit-ID: 4a6JmfolqkW
2016-07-11 10:51:08 +08:00
bechen
a475af3cfd Bug 1279865 - Don't run TimeMarchesOn if the MediaElement is not played. r=rillian
1. If mHasUserInteraction MediaElement is false, don't run the TimeMarchesOn because the element is not played. 2. Update the activeCueList only in TimeMarchesOn(). 3. Run TimeMarchesOn() at the beginning of play. r=rillian

MozReview-Commit-ID: BhwsIfRm3B2
2016-06-30 13:31:56 +08:00
Ray Lin
8f4815c8d7 Bug 985915 - Vertically move up closed caption to not overlap control bar. r=rillian
MozReview-Commit-ID: HzJ3ppbmQnk
2016-06-27 11:22:15 +08:00
bechen
e48b33a3a0 Bug 1278151 - Fix web-platform/meta/html/semantics/embedded-content/media-elements/interfaces/TextTrack/cues.html. r=rillian
MozReview-Commit-ID: 7VuUfyegq2d
2016-06-22 16:03:46 +08:00
bechen
835da4b871 Bug 1280814 - Prevent the media::Interval crash due to the unexpected playback position. r=rillian
MozReview-Commit-ID: AZ9Gb2Y0wDF
2016-06-20 15:58:58 +08:00
bechen
3cdd14dfed Bug 1276530 - part2: The id of cue might be empty, so don't use it for checking. r=rillian
MozReview-Commit-ID: CyjEkOmDNG0
2016-06-17 17:20:24 +08:00
bechen
d2e8373ca8 Bug 882717 - Invoke TimeMarchesOn when the startTime/endTime/pauseOnExit be changed of TextTrackCue. r=rillian
MozReview-Commit-ID: 7Xol9x83lLx
2016-06-08 16:53:30 +08:00
bechen
dea4a1a40f Bug 1274884 - Add/Remove cue into MediaElement when TextTrack::mMode changed. r=rillian
MozReview-Commit-ID: 9PGEV5g8iv3
2016-06-02 16:08:32 +08:00
bechen
e0bae2d76b Bug 1275808 - Move the UpdateCueDisplay() into TimeMarchesOn() as step 18. r=rillian
MozReview-Commit-ID: GrcZCjstBy9
2016-06-01 17:37:26 +08:00
bechen
7a60c08ea5 Bug 882718 - Do not dispatch task to main thread when shutdown. r=rillian
MozReview-Commit-ID: 5Y79Fbhyoc3
2016-06-01 15:13:45 +08:00
bechen
b3a670e7fd Bug 882718 - 1. Fix testcase crash/failed . 2. The cuechange event should be fired in TimeMarchesOn. r=rillian
MozReview-Commit-ID: EYi9iZ1mfjg
2016-06-01 15:13:43 +08:00
bechen
8351247123 Bug 882718 - triggerTimeMarchesOn. r=rillian
MozReview-Commit-ID: 2OOqr1Z6X9
2016-06-01 13:35:58 +08:00
Andrew Quartey
cf228a188b Bug 882718 - Implement "TimeMarchesOn". r=rillian
MozReview-Commit-ID: 1RqUmgz056N
* * *
[mq]: hotfix

MozReview-Commit-ID: CPByIPsUag4
2016-06-01 13:35:56 +08:00
Sebastian Hengst
ed6d27c5af Backed out changeset f6363fdbbf29 (bug 882718) 2016-05-31 18:54:41 +02:00
Sebastian Hengst
5f6a0468d7 Backed out changeset 7f61a6bd8a3d (bug 882718) 2016-05-31 18:54:41 +02:00
Sebastian Hengst
780319fe94 Backed out changeset 883bfabfde46 (bug 882718) 2016-05-31 18:54:41 +02:00
Sebastian Hengst
661632111a Backed out changeset 830cccc16bd9 (bug 882718) 2016-05-31 18:54:41 +02:00
bechen
b5b9e680da Bug 882718 - Do not dispatch task to main thread when shutdown. r=rillian
MozReview-Commit-ID: 5Y79Fbhyoc3
2016-05-30 12:03:15 +08:00
bechen
6274ffece2 Bug 882718 - 1. Fix testcase crash/failed . 2. The cuechange event should be fired in TimeMarchesOn. r=rillian
MozReview-Commit-ID: EYi9iZ1mfjg
2016-05-26 11:45:43 +08:00
bechen
da72c8bd4c Bug 882718 - triggerTimeMarchesOn. r=rillian
MozReview-Commit-ID: 2OOqr1Z6X9
2016-05-25 16:11:28 +08:00
Andrew Quartey
6391e8e2b5 Bug 882718 - Implement "TimeMarchesOn". r=rillian
MozReview-Commit-ID: 1RqUmgz056N
* * *
[mq]: hotfix

MozReview-Commit-ID: CPByIPsUag4
2016-05-25 16:11:27 +08:00
Kyle Huey
e95edb30a9 Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug 2016-01-30 09:05:36 -08:00