corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
566,841 Commits 1 Branch 0 Tags
967d76d33b38bac498672273fd67173f6c156ca7
Commit Graph

553 Commits

Author SHA1 Message Date
ScottDowne
0b01ad7419 Fixes bug 1488813 - Migrating Pocket off any bootstrap code r=ursula,k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D6849
 2018-10-12 19:38:10 +00:00
Marco Bonardo
5cc5f2c138 Bug 1477671 - Stop allowing creation of new live bookmarks from the backend. r=standard8 
Differential Revision: https://phabricator.services.mozilla.com/D7083
 2018-10-06 10:32:13 +01:00
Doug Thayer
6c2f2815de Bug 1426245 - Test changes r=mak 
MozReview-Commit-ID: 4fhhzspxLJZ

Depends on D4606

Differential Revision: https://phabricator.services.mozilla.com/D5162
 2018-10-09 14:47:31 +00:00
Doug Thayer
98d7bd0923 Bug 1426245 - Replace OnItemAdded with bookmark-item-added r=mak 
See https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit#
for further info. This essentially follows the same philosophy as
the onVisits migration.

MozReview-Commit-ID: I4bOvFH0ZQR

Depends on D4605

Differential Revision: https://phabricator.services.mozilla.com/D4606
 2018-10-09 14:47:27 +00:00
Jared Wein
2d6a3e988f Bug 1480529 - Changed 'Bookmark All Tabs' to 'Bookmark Tab' for single tab selections. r=Felipe 
I changed the toolbar context menuitem from 'Bookmark All Tabs' to 'Bookmark Selected Tabs' because it is separated from a specific tab and thus it is not clear which tab would get bookmarked if only one is selected. This seemed much clearer to me in my testing. The wording of 'Bookmark Selected Tabs' is already used elsewhere where we have 'Reload Selected Tabs', 'Close Selected Tabs', etc.

Differential Revision: https://phabricator.services.mozilla.com/D7217
 2018-10-02 16:24:43 +00:00
Bogdan Tara
ad579c1651 Backed out changeset 1f4d7ab6cd6d (bug 1480529) for perma failing on browser_multiselect_tabs_bookmark.js 2018-10-02 18:33:49 +03:00
Jared Wein
f42d5228b2 Bug 1480529 - Changed 'Bookmark All Tabs' to 'Bookmark Tab' for single tab selections. r=Felipe 
I changed the toolbar context menuitem from 'Bookmark All Tabs' to 'Bookmark Selected Tabs' because it is separated from a specific tab and thus it is not clear which tab would get bookmarked if only one is selected. This seemed much clearer to me in my testing. The wording of 'Bookmark Selected Tabs' is already used elsewhere where we have 'Reload Selected Tabs', 'Close Selected Tabs', etc.

Differential Revision: https://phabricator.services.mozilla.com/D7217
 2018-10-02 03:19:01 +00:00
Dão Gottwald
162931004c Bug 1495291 - Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r=paolo 
Differential Revision: https://phabricator.services.mozilla.com/D7397
 2018-10-02 10:02:08 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop 
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
 2018-08-31 05:59:17 +00:00
Mark Banner
c017ef2f34 Bug 1484482 - Fix the bookmarks menu when it is displayed via the hidden window. r=paolo 
MozReview-Commit-ID: 7VYNxFmedZl

Differential Revision: https://phabricator.services.mozilla.com/D3923
 2018-08-22 10:17:28 +00:00
ExE Boss
923f59f240 Bug 1482498 - Remove mozMatchesSelector(…) usage from browser‑places.js r=miketaylr 
Differential Revision: https://phabricator.services.mozilla.com/D3766
 2018-08-20 18:36:58 +00:00
Paolo Amadini
1b4a4d3c71 Bug 1481813 - Part 3 - Remove bookmarkThisPageBroadcaster. r=Standard8,bgrins 
The PageActions API is now used to assign a title to the bookmark action.

This also prevents some tooltips from being set unnecessarily on menu items.

Differential Revision: https://phabricator.services.mozilla.com/D3010
 2018-08-13 17:25:28 +01:00
Paolo Amadini
853c33315b Bug 1481813 - Part 2 - Move reference strings out of the bookmark broadcaster. r=Standard8 
This prevents the reference string attributes from being replicated unneededly.

Differential Revision: https://phabricator.services.mozilla.com/D3008
 2018-08-13 17:02:44 +01:00
Paolo Amadini
4ea606710c Bug 1481813 - Part 1 - Remove unneeded broadcaster observers for bookmarks. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D3007
 2018-08-09 13:13:27 +01:00
Mark Banner
76c26311e8 Bug 1479722 - Rework PlacesUtils.setCharsetForURI to PlacesUIUtils.setCharsetForPage and avoid main thread sync io. r=mak 
MozReview-Commit-ID: HeO3Mm5Dibo

Differential Revision: https://phabricator.services.mozilla.com/D2582
 2018-08-01 10:13:59 +00:00
Mark Striemer
95b3e1beda Bug 1478042 - Check if gBrowser exists in History menu for hidden tabs r=mak 
MozReview-Commit-ID: F8zhbb4l7J8
 2018-07-27 17:13:55 -05:00
Boris Zbarsky
e98236cf07 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Brian Grinstead
3097f96e03 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs 
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t
 2018-07-24 08:12:50 -07:00
Dão Gottwald
a682f07772 Bug 1476901 - Stop ever hiding editBookmarkPanelContent and editBookmarkPanelBottomButtons in the bookmark panel. r=mak 
MozReview-Commit-ID: CwfHapJicIG
 2018-07-19 13:43:30 +02:00
Abdoulaye O. Ly
6290b52439 Bug 1458067 - Implement ability to bookmark a selection of tabs. r=Gijs 
MozReview-Commit-ID: 4KE3qSf3j0y
 2018-07-12 00:25:35 +00:00
Marco Bonardo
899632d5f6 Bug 1475276 - Remove some no more necessary usage of promiseItemGuid. r=lina 
Some code is unnecessarily using promiseItemGuid

Differential Revision: https://phabricator.services.mozilla.com/D2100
 2018-07-12 21:38:21 +00:00
Dão Gottwald
e5e6bb2a49 Bug 1473862 - Remove URL and title arguments from PlacesCommandHook.bookmarkPage. r=standard8 
MozReview-Commit-ID: MYERqUTpD6
 2018-07-06 14:08:03 +02:00
Dão Gottwald
a39a79d47f Bug 1473073 - Remove PlacesCommandHook.bookmarkPage's browser argument. r=mak 
MozReview-Commit-ID: BH5r7Tn8KV1
 2018-07-03 22:46:46 +02:00
Dão Gottwald
541fa834f8 Bug 1472275 - Remove PlacesCommandHook.bookmarkPage's aShowEditUI argument. r=standard8 
MozReview-Commit-ID: CGYSF1OvoVg
 2018-06-29 19:45:35 +02:00
Dão Gottwald
7cfce3c337 Bug 1468077 - Stop disabling cmd_close and cmd_closeWindow in the bookmark panel since it seems to be half-broken and is inconsistent with other panels. r=mak 
MozReview-Commit-ID: AkKaq5Kon77
 2018-06-29 13:33:05 +02:00
Dão Gottwald
0a450e0d60 Bug 1459878 - Add "Show editor when saving" checkbox to the Bookmark panel. r=mak 
MozReview-Commit-ID: IUji9cQmVz9
 2018-06-29 12:39:30 +02:00
Dão Gottwald
21d58cc4ae Bug 1471585 - Stop assuming that BookmarkingUI.anchor can be null. r=standard8 
MozReview-Commit-ID: JpObSnChEU0
 2018-06-27 15:14:27 +02:00
Dão Gottwald
40e9ec9d52 Bug 1471580 - Remove unused _bookmarkPopupInitialized flag. r=standard8 
MozReview-Commit-ID: LI7oXGLDyso
 2018-06-27 14:57:16 +02:00
Mark Banner
b24bddc9dc Bug 1452645 - Remove load in sidebar functionality. r=lina,mak 
Based on patch by mixedpuppy.

MozReview-Commit-ID: BZwOtr4VbCH
 2018-06-06 21:00:45 +01:00
Dão Gottwald
3e1a255f0a Bug 1459907 - Implement new bookmark confirmation. r=mak 
MozReview-Commit-ID: DsTXTKgX72y
 2018-06-23 15:28:47 +02:00
Mark Striemer
d115d51aec Bug 1446101 - Part 3: Make History > Hidden Tabs deep link to Hidden Tabs menu r=mak 
MozReview-Commit-ID: KgfpYbfVjUm
 2018-06-04 17:11:23 -05:00
Dão Gottwald
6d855a868e Bug 1460248 - Display screenshot and favicon in the New Bookmark dialog. r=mak 
MozReview-Commit-ID: C5zMr2HlBC9
 2018-06-19 20:36:20 +02:00
Sam Foster
4e88ea0295 Bug 1385262 - Restore the star icon when the bookmark animation ends. r=jaws 
* Also remove unused frame at the end of the bookmark-animation

MozReview-Commit-ID: 5zOO1gXEfcz
 2018-06-04 12:21:26 -07:00
Mark Banner
04568e0b5a Bug 1460579 - Replace the 'bookmarkPropertiesDialog/folderLastUsed' annotation with a key/value pair in moz_meta. r=mak 
MozReview-Commit-ID: GpEPxOMDret
 2018-05-11 07:35:59 +01:00
Dão Gottwald
306f193ab6 Bug 1464489 - When creating a new bookmark, the bookmark panel should be titled "New Bookmark" instead of "Page Bookmarked". r=standard8 
MozReview-Commit-ID: 1OeIdsf3bx
 2018-05-25 20:22:35 +02:00
Mark Banner
8853e86675 Bug 1463738 - Remove the Bookmark description UI. r=dao 
This removes the bookmark description UI, but leaves the backend in-place for a release or two, so that users have time to save anything they want (e.g. via backup).
The backend will be removed in bug 1402890.

MozReview-Commit-ID: La4AYFar7eK
 2018-05-23 17:15:09 +01:00
Tawny Hoover
ec89441940 Bug 1400323 - Refactor code for openInTabClosesMenu pref to avoid needing setTimeout on Mac. (cleanup on popuphidden) r=mak 
MozReview-Commit-ID: FR6vZksnFEz
 2018-05-17 22:32:47 -04:00
Mark Striemer
c598ee9ff8 Bug 1455300 - Part 2: Include hidden tabs in the History menu r=mak 
MozReview-Commit-ID: 8sKrAJVIAD5
 2018-05-10 16:01:36 -05:00
Dão Gottwald
cda5638fb0 Bug 1464384 - Stop returning true/false from focusAndSelectUrlBar. r=mak 
MozReview-Commit-ID: BKmsjCRZiLs
 2018-05-25 15:38:09 +02:00
Dão Gottwald
f564e75ad7 Bug 1459887 - Relabel the "Remove Bookmark" button to "Cancel" in the New Bookmark dialog. r=standard8 
MozReview-Commit-ID: EcCW2eBzfBT
 2018-05-25 10:53:53 +02:00
Mark Banner
bcb5601b9f Bug 824502 - Change folder=<id> to parent=<guid> in Places' bookmark queries. r=mak 
This allows queries to be stable across devices, and requires less work to obtain the ids.

MozReview-Commit-ID: 5KAKKags7o9
 2018-04-26 09:05:00 +01:00
Dão Gottwald
8a4e4ea835 Bug 1459885 - Implement new header style and lay out labels above input fields in the new bookmarks dialog. r=mak 
MozReview-Commit-ID: 9FmGhfP9aDo
 2018-05-22 12:21:52 +02:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8 
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
 2018-04-22 20:55:06 -07:00
Neil Deakin
ddc248eb52 Bug 1446961, remove obsolete calls to showPopup and replace usages of the popup box object with the same methods defined on popups, r=paolo 2018-04-27 11:04:36 -04:00
Paolo Amadini
7f627ce196 Bug 1391948 - Don't use checkboxes for the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu. r=mak 
MozReview-Commit-ID: 2P3yV6xHLxi
 2018-04-11 12:42:18 +01:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs 
MozReview-Commit-ID: 1NQrlWzIBja
 2018-02-21 14:28:48 +00:00
Manish Kumar
012e316f55 Bug 1450588 - Remove old bookmark animation code and images. r=ntim,dao 2018-04-04 10:47:50 +02:00
Paolo Amadini
5621a22a69 Bug 1434860 - Part 2 - Remove support for menu-button toolbar buttons. r=enn 
MozReview-Commit-ID: MTLaIPzg7a
 2018-04-03 16:26:03 +01:00
Masayuki Nakano
3ed74d7cc4 Bug 1449018 - The bookmark panel should listen to keypress event at the system event group r=mak 
The bookmark panel should handle keypress events at the system event group
because it needs to handle keypress events after autocomplete module which
handles keypress events at the system event group.

MozReview-Commit-ID: 9KjBlQ59gHw
 2018-03-27 16:50:18 +09:00
Marco Bonardo
59a5035ca3 Bug 1448362 - Remove some unused code from Places. r=standard8 
MozReview-Commit-ID: DQCoYyZIvGD
 2018-03-23 16:26:56 +01:00