Robert O'Callahan
02e693326e
Bug 735898. Part 7: Remove expensive nsIFrame::HasBorder checks, just check style instead. r=dbaron,a=blocking-fennec
2012-04-18 17:14:31 +12:00
L. David Baron
464614b05f
Add a font inflation data structure per block formatting context. (Bug 706193, patch 2) r=roc
...
This structure is per block formatting context because we have to make a
single inflation decision for things like consecutive runs of paragraphs
of text. Inflating some paragraphs and not others (within the same
sequence of adjacent paragraphs) based on the amount of text in each one
would be disastrous. Otherwise it's ideal for the units to be as small
as possible as long as they merge such sequences; therefore this uses a
definition corresponding to CSS's idea of elements that establish new
block formatting contexts.
2012-04-16 15:32:12 -07:00
Robert O'Callahan
8867dda1b1
Bug 735898. Part 3: In DisplayBorderBackgroundOutline, when we have created an nsDisplayBackground item and it's themed, don't bother checking to create an nsDisplayBorder item. r=mattwoodrow
...
It turns out that calling HasBorder() is especially expensive for themed frames since we call into the theme engine to compute the border, so avoiding it is a nice win.
2012-04-13 23:44:06 +12:00
Robert O'Callahan
c99e983698
Backing out changesets ef599d7f3f11, 70ef464f50e3 and 1a204c38918e (bug 735898) due to test failures.
2012-04-12 00:34:23 +12:00
Robert O'Callahan
28b6cf56db
Bug 735898. Part 3: In DisplayBorderBackgroundOutline, when we have created an nsDisplayBackground item and it's themed, don't bother checking to create an nsDisplayBorder item. r=mattwoodrow
...
It turns out that calling HasBorder() is especially expensive for themed frames since we call into the theme engine to compute the border, so avoiding it is a nice win.
2012-04-11 16:49:34 +12:00
Robert O'Callahan
fb6a78d67b
Bug 733607. Restructure logic to compute snapped bounds of display items in layer coordinates. Moves responsibility for computing snapped bounds from within the display items to callers of GetBounds/GetOpaqueRegion. r=tnikkel
...
Previously we snapped the results of nsDisplayItem::GetBounds and
nsDisplayItem::GetOpaqueRegion internally. By tracking which display items were
inside transforms, we disabled snapping quite conservatively whenever an ancestor
had a transform, which is undesirable.
With this patch, we don't snap inside GetBounds or GetOpaqueRegion, but just return
a boolean flag indicating whether the item will draw with snapping or not. This flag
is conservative so that "true" means we will snap (if the graphics context has a transform
that allows snapping), but "false" means we might or might not snap (so it's always safe
to return false).
FrameLayerBuilder takes over responsibility for snapping item bounds. When it converts
display item bounds to layer pixel coordinates, it checks the snap flag returned from
the display item and checks whether the transform when we draw into the layer will be
a known scale (the ContainerParameters scale factors) plus integer translation. If both
are true, we snap the item bounds when converting to layer pixel coordinates. With
this approach, we can snap item bounds even when the items have ancestors with active
transforms.
2012-04-10 23:24:18 +12:00
Mats Palmgren
a3cd816ea1
Bug 736915 - Print Selection prints a blank page when the selection is inside a table. r=bz
...
When rendering just the current Selection (Print - Selection) then don't create display items
for table-related frames unless the frame itself is part of the selection, and always ask
descendant frames to build display lists [in case they are selected].
2012-04-03 02:30:45 +02:00
Boris Zbarsky
0c6d4d066f
Bug 735579. Correctly handle changes to column widths in fixed-layout tables. r=ehsan
2012-03-16 15:56:41 -04:00
Daniel Holbert
3dbcc8aba7
Bug 732610 - Make nsIFrame::ComputeSize take a bitfield 'aFlags' instead of a bool 'aShrinkWrap'. r=dbaron
2012-03-16 11:01:05 -07:00
Mats Palmgren
1ceaa4894a
Bug 728906 - Make nsIFrame::GetChildList return const nsFrameList&. r=bz
2012-03-08 02:57:37 +01:00
Nathan Froyd
20f5ce545a
Bug 731615 - Eliminate duplicate headers in layout. rs=smontagu
2012-02-29 10:57:47 -05:00
Matt Woodrow
439a12dca2
Bug 721082 - Constify nsIFrame::GetParentStyleContextFrame. r=roc
2012-02-15 22:28:21 +13:00
Aryeh Gregor
46356c7953
Bug 722777 - Tables with 'transform' property set don't act as abs-pos/fixed-pos containers; r=roc
2012-02-10 21:05:00 +00:00
Panagiotis Koutsourakis
835036b234
Bug 702388 - Convert Makefiles to use |TEST_DIRS += foo| r=khuey
...
Files named Makefile.in containing the expression
DIRS += <foo>
or
DIRS = <foo>
inside the conditional expression
ifdef ENABLE_TESTS
...
endif
are changed to
TEST_DIRS += tests
outside any conditional expression.
The files
./layout/Makefile.in
./layout/Makefile.in
./layout/style/Makefile.in
./rdf/Makefile.in
./security/manager/Makefile.in
./content/Makefile.in
./content/smil/Makefile.in
./content/xul/templates/Makefile.in
./content/xul/content/Makefile.in
./content/base/Makefile.in
./content/media/Makefile.in
./parser/htmlparser/Makefile.in
./dom/sms/Makefile.in
./js/jsd/Makefile.in
./js/xpconnect/Makefile.in
./widget/Makefile.in
./widget/windows/Makefile.in
./Makefile.in
./startupcache/Makefile.in
./storage/Makefile.in
./gfx/Makefile.in
./intl/strres/Makefile.in
./intl/uconv/Makefile.in
./intl/unicharutil/Makefile.in
./intl/lwbrk/Makefile.in
./embedding/Makefile.in
./modules/libjar/Makefile.in
./modules/libpref/Makefile.in
./build/Makefile.in
./build/win32/Makefile.in
./xpcom/Makefile.in
./extensions/spellcheck/hunspell/Makefile.in
./extensions/cookie/Makefile.in
./netwerk/Makefile.in
./netwerk/streamconv/Makefile.in
./editor/txmgr/Makefile.in
./toolkit/mozapps/shared/Makefile.in
./toolkit/mozapps/update/Makefile.in
./toolkit/library/Makefile.in
./toolkit/library/Makefile.in
./toolkit/crashreporter/Makefile.in
./toolkit/components/perf/Makefile.in
./toolkit/components/perf/Makefile.in
./toolkit/components/feeds/Makefile.in
./toolkit/components/url-classifier/Makefile.in
contain the string
ifdef ENABLE_TESTS
but have some other statement inside (e.g. TOOL_DIRS += <foo> etc) and
they remain unchanged by this patch.
2012-02-04 17:32:24 +00:00
Phil Ringnalda
811ea3f8e2
Bug 694248 - skip layout/tables/crashtests/691824-1.xhtml on Android, r=ehsan
2012-01-23 15:40:43 -08:00
L. David Baron
eadb1db264
Set inflation container to null during ComputeSize calls for inflation containers, when we should not have inflation applied. (Bug 706609, patch 4.5) r=roc
2012-01-24 17:21:29 -08:00
L. David Baron
1d98076bbe
Set inflation container to null during parts of intrinsic sizing that should not have inflation applied. (Bug 706609, patch 4) r=roc
...
This is the first of two patches to honor inflation during intrinsic
width calculation (which we need to do to make some form controls
inflate correctly).
2012-01-24 17:21:29 -08:00
Mats Palmgren
8c2341696d
Bug 720142 - Avoid calling GetFirstInFlow() on the row group twice. r=bernd
2012-01-22 23:48:34 +01:00
Mats Palmgren
ef530e8633
Bug 720142 - Only calculate the border half we actally use. r=bernd
2012-01-22 23:48:34 +01:00
Mats Palmgren
aedc830d14
Bug 720142 - Use nsIntRect for table damage. r=bernd
2012-01-22 23:48:34 +01:00
Daniel Holbert
deefba1b91
Bug 716738: Label layout/tables as gcc-warning-free with FAIL_ON_WARNINGS. r=dbaron
2012-01-19 21:33:20 -08:00
Mats Palmgren
a58fa4d0e1
Bug 524925 - Consolidate overflow clipping checks to nsFrame::ApplyOverflowClipping(); and fix some code style nits. part=5/6 r=roc
2012-01-18 21:04:51 +01:00
Benjamin Stover
a38eb5067f
Bug 524925 - Recompute overflow without reflowing for transforms. part=1/6 r=dbaron
...
Add an extra change hint, UpdateOverflow, that can be used to specify that
a frame's overflow areas may have changed and that they need to be recalculated.
When a transform on a frame changes, instead of marking it for reflow, set this
hint instead.
There is an added virtual function on nsIFrame, UpdateOverflow, which is called
recursively on a frame when the corresponding hint is set, to allow it to
update its overflow areas.
2011-06-15 14:03:49 -07:00
Mats Palmgren
dc6e69db71
Bug 716408 - Fix nsTableFrame::DidSetStyleContext indentation. r=bernd
2012-01-17 00:38:10 +01:00
Mats Palmgren
19f0d33495
Bug 716408 - Assert that a prev-in-flow is null or of the same frame type. No need to null out mCellMap, the ctor does that and re-Init of frames isn't allowed. r=bernd
2012-01-17 00:38:10 +01:00
Mats Palmgren
da4686bef0
Bug 716408 - No need to null-check for delete, no need to null out members in dtor. r=bernd
2012-01-17 00:38:10 +01:00
Mats Palmgren
ec399fc7e2
Bug 716408 - Initialize all bits of mBits to zero. r=bernd
2012-01-17 00:38:10 +01:00
Mats Palmgren
e0018d2b82
Bug 716408 - Make nsTableFrame::GetTableFrame abort if the given frame isn't a table frame descendant, thus guaranteeing a non-null result. r=bernd
2012-01-17 00:38:10 +01:00
Mats Palmgren
702081ffc5
Bug 716408 - Remove unnecessary nsTableFrame::GetFirstInFlow() calls to get IsBorderCollapse() bit. r=bernd
2012-01-17 00:38:10 +01:00
Mats Palmgren
5b5536da83
Bug 716408 - Remove null-checks of GetFirstInFlow() result. r=bernd
2012-01-17 00:38:10 +01:00
Bernd
e43b60de59
bug 711864 - dEndY is already in the rowgroup r=mats
2012-01-09 07:37:16 +01:00
Bernd
60b2dc44e9
bug 710098 - use effective rowspan r=mats
2011-12-29 09:17:55 +01:00
Mats Palmgren
8fe75b1c1b
Bug 515530 - Remove nsHTMLContainerFrame. r=roc
2011-12-27 21:18:48 +01:00
Andrew Quartey
b83d437bf9
Bug 507419-Consistent ordering of AppendFrames and InsertFrames
2011-12-27 09:31:22 +01:00
Bernd
e30f773e18
bug 531200 - always set the desiredHeight, also if SplitSpanningCells does not split any cell r=dholbert
2011-12-27 09:31:10 +01:00
Bernd
dd28d4b094
bug 711359 - mark all subsequent rows as damaged r=mats
2011-12-27 09:31:09 +01:00
Nicholas Nethercote
c8d93dc02b
Bug 711908 - Fix a bunch of GCC warnings in layout. r=dbaron.
2011-12-19 19:46:39 -08:00
Mats Palmgren
8f89cccd9c
Bug 619273 - Move the selection state bit from frames to content nodes. r=smaug
2011-12-20 10:15:41 +01:00
Bernd
41e488d602
bug 707622 - rows without originating cells are suppressed at the table bottom r=mats
2011-12-07 20:38:25 +01:00
Bernd
8de3361c2a
followup on bug 460637
2011-12-04 07:20:09 +01:00
Bernd
7ec70833de
bug 705996 - the damageArea should only be set once the columns are in shape r=mats
2011-12-03 07:21:16 +01:00
Bernd
cca73631fc
bug 451355 - testcase is now wfm
2011-12-03 07:21:16 +01:00
Bernd
83e927550f
bug 467444 - firstTruncatedRow can not be the last row on page if it should be pushed r=dholbert
2011-12-01 07:34:30 +01:00
Bernd
05da1a27c4
bug 460637 - the group cellmaps need to set the damageArea relative to the entire table, patch by Mats Palmgren, Randell Jesup and Bernd, r=mats, bernd
2011-10-27 09:58:44 -04:00
L. David Baron
ca13d55580
Don't construct cell reflow states with a row group reflow state as their parent; instead, always link in a table row reflow state as appropriate. (Bug 627842, patch 3.875) r=roc
...
Fixes assertion on layout/reftests/bugs/409084-1a.html once the rest
of the inflation patches land.
2011-11-23 18:48:23 -08:00
Ed Morley
6e731c995a
Backout 4997c6f8b24d (bug 616542) for causing locally run mochitest-browser-chrome test runs to fail
2011-11-05 18:35:59 +00:00
Rail Aliiev
b2aeac5a65
Bug 616542 - Shorten file path length of mochitest; r=ted
2011-11-04 21:13:42 +00:00
Jonathan Watt
276bdfa251
Bug 695303 - Add a mozilla::clamped function to replace NS_CLAMP (so side affects of args are evaluated no more than once) and NS_MIN(max, NS_MAX(val, min)) (to make code clearer). r=bsmedberg.
2011-10-28 19:33:28 +01:00
Bernd
c08e133266
bug 695430 - stop trying to insert previously emptied framelists r=bzbarsky
2011-10-24 21:22:33 +02:00
Ehsan Akhgari
478ad1a412
Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
...
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
