Commit Graph

5629 Commits

Author SHA1 Message Date
Meg Viar
95c9d5c236 Bug 1793453 - Prevent automatic suppression of popups on 'blank' pages when URL bar is focused r=dao,adw
Differential Revision: https://phabricator.services.mozilla.com/D158850
2022-11-29 01:13:08 +00:00
Niklas Baumgardner
0913d5fbd9 Bug 1801360 - Use selectedBrowser URI for gScreenshots. r=cmkm
Differential Revision: https://phabricator.services.mozilla.com/D162747
2022-11-25 15:08:32 +00:00
Emilio Cobos Álvarez
c0c34eb571 Bug 1801840 - Go back to using .browserStack rather than .browserContainer for tab dialog box. r=Gijs,nchevobbe
This makes alert take the same area as the status panel, partially
backing out the regressing bug.

.browserStack is also relatively-positioned, so this works too. I think
I didn't realize this while writing bug 1791972 because the rule was in
a UA sheet (all <stack>s are relatively positioned, apparently).

This restores the behavior when devtools is toggled vertically. On
responsive mode this still covers the top toolbar, but that was the
pre-existing behavior. Could be fixed in a follow-up with some z-index
tweaking...

Differential Revision: https://phabricator.services.mozilla.com/D162739
2022-11-24 16:42:52 +00:00
Francesco Lodolo (:flod)
083fc7f23f Bug 1801915 - Migrate confirmation hints to Fluent, r=eemeli,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D162746
2022-11-22 20:12:55 +00:00
Eemeli Aro
4b82968ec9 Bug 1760029 - Remove tabbrowser.properties as empty. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D159021
2022-11-22 17:12:23 +00:00
Kagami Sascha Rosylight
dad1c63030 Bug 1801346 - Esmify browser/modules/Sanitizer.jsm r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D162425
2022-11-19 01:45:42 +00:00
Itiel
3d0bd22bd1 Bug 1796940 - Unify bookmark-related popups r=emilio,mak,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D158460
2022-11-17 22:58:04 +00:00
Cosmin Sabou
bb17ead141 Backed out changeset 99db9921183c (bug 1796940) for bc failures on browser_parsable_css.js. CLOSED TREE 2022-11-18 00:08:28 +02:00
Itiel
b1e0feab9a Bug 1796940 - Unify bookmark-related popups r=emilio,mak,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D158460
2022-11-17 20:34:58 +00:00
Mike Conley
d4d3af9877 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161200
2022-11-15 16:37:23 +00:00
Stanca Serban
7abed322ee Backed out 3 changesets (bug 1782203) for causing lint failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
Backed out changeset 50e57afebed3 (bug 1782203)
Backed out changeset d17ea376ed45 (bug 1782203)
Backed out changeset e91d51f1ce90 (bug 1782203)
2022-11-15 17:42:22 +02:00
Mike Conley
55af77e9ed Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161200
2022-11-15 15:02:08 +00:00
Csoregi Natalia
1ce4bb73a7 Backed out 4 changesets (bug 1782203, bug 1777484) for failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
Backed out changeset ae47d92443a7 (bug 1782203)
Backed out changeset 0c90b1d40e9f (bug 1782203)
Backed out changeset 4b4cae098ea0 (bug 1782203)
Backed out changeset 75eba3b7a626 (bug 1777484)
2022-11-15 03:06:21 +02:00
Mike Conley
70738f0144 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161200
2022-11-14 22:41:09 +00:00
Iulian Moraru
ffca1b9713 Backed out changeset 392451891968 (bug 1793453) for causing bc failures on browser_permissions_dismiss.js. CLOSED TREE 2022-11-10 01:57:57 +02:00
Meg Viar
d0d139c724 Bug 1793453 - Prevent automatic suppression of popups on 'blank' pages when URL bar is focused r=dao,adw
Differential Revision: https://phabricator.services.mozilla.com/D158850
2022-11-09 18:55:11 +00:00
James Teow
d6dddd38a9 Bug 1798793 - Add search tip message for showSearchTerms feature - r=adw,fluent-reviewers,flod
The showSearchTerms feature has a search tip that should appear
on the users default search engine results page.

The design and copy for the feature are in this Figma file:
https://www.figma.com/file/Ock0cYjzi7I1GmcctqOr9K/Search-settings-updates?node-id=352%3A9183

Differential Revision: https://phabricator.services.mozilla.com/D161186
2022-11-09 18:36:08 +00:00
Mike Conley
c759904dae Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00
Mike Conley
1b4db4803a Bug 1797836 - Part 1: browser.js should only call registerToolbarNode on CUI areas of TYPE_TOOLBAR. r=cmkm
It looks like we had some kind of hard-coded assumption here that every area
in CustomizableUI was of TYPE_TOOLBAR except for AREA_FIXED_OVERFLOW_PANEL, which
was manually spliced out of the area array when initting the toolbars after
DOMContentLoaded.

A later patch in this series is adding a new area of TYPE_MENU_PANEL, and
instead of also splicing that out of the area array in DOMContentLoaded,
we now make sure to only call registerToolbarNode on areas that are
actually toolbars.

Differential Revision: https://phabricator.services.mozilla.com/D161077
2022-11-08 14:51:39 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D161013
2022-11-07 17:56:10 +00:00
Bernard Igiri
4b27d1890a Bug 1785272 - Fix Fx View Button VO Announcement r=Gijs
Changed the aria role from tab to button to fix the VO announcement so that it correctly reports when the Fx View tab is actually selected.

Differential Revision: https://phabricator.services.mozilla.com/D159887
2022-11-07 07:07:20 +00:00
Neil Deakin
6cc6947dde Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,settings-reviewers
w

Differential Revision: https://phabricator.services.mozilla.com/D155003
2022-11-01 20:43:02 +00:00
Neil Deakin
b1a9cbd869 Bug 1676492, create a special blank tab page that will show the bookmarks toolbar when 'Only Show on New Tab' is used' even when the new tab page is disabled, r=Gijs,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D154319
2022-11-01 20:43:01 +00:00
Kelly Cochrane
68b7ec47c7 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao
Differential Revision: https://phabricator.services.mozilla.com/D159766
2022-11-01 15:45:45 +00:00
steven100695
bf405ca708 Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D158655
2022-10-27 23:52:49 +00:00
Noemi Erli
fa30a0f2a7 Backed out 2 changesets (bug 1788919) for causing failures in browser_noLoginsView.js CLOSED TREE
Backed out changeset 2f03490ec72e (bug 1788919)
Backed out changeset 449aea6fc974 (bug 1788919)
2022-10-27 23:45:56 +03:00
steven100695
a150df2a6a Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D158655
2022-10-27 18:15:55 +00:00
Emilio Cobos Álvarez
72480b4a85 Bug 1796972 - Fix popup container for webextension popups. r=Gijs
Depends on D160224

Differential Revision: https://phabricator.services.mozilla.com/D160225
2022-10-25 22:28:44 +00:00
Simon Friedberger
6b0a251a63 Bug 1549057 - Rename (Gg)etCSP to (Gg)etCsp - r=freddyb
Differential Revision: https://phabricator.services.mozilla.com/D159268
2022-10-24 20:38:11 +00:00
Marian-Vasile Laza
22a37b6925 Backed out changeset caddc49839d3 (bug 1793088) for causing bc failures on browser_firefoxview_tab.js. CLOSED TREE 2022-10-24 17:49:47 +03:00
Kelly Cochrane
3305772c50 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao
Differential Revision: https://phabricator.services.mozilla.com/D159766
2022-10-24 12:32:44 +00:00
Henrik Skupin
d25a13e56d Bug 1533058 - [browser] Extend BrowserOpenTab to open a custom URL. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D159424
2022-10-24 07:46:15 +00:00
Tomislav Jovanovic
586bffe470 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-22 17:21:58 +00:00
Noemi Erli
55e26cd909 Backed out changeset 0a1431ca8979 (bug 1793088) for causing failures browser_firefoxview_tab.js CLOSED TREE 2022-10-20 18:53:41 +03:00
Kelly Cochrane
1c701caf06 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao
Differential Revision: https://phabricator.services.mozilla.com/D159766
2022-10-20 14:43:31 +00:00
Cosmin Sabou
ba255c1975 Backed out changeset 27a859f55fdd (bug 1793629) for causing bc failures on browser_preferences_usage.js. 2022-10-19 02:34:23 +03:00
Tomislav Jovanovic
fc9a32fdd5 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-18 21:44:48 +00:00
Dana Keeler
a3addf941f Bug 1793841 - don't serialize securityInfo in browser_aboutCertError_exception.js r=pbz
This test only needs the bytes of the server certificate, not the entire
nsITransportSecurityInfo of the connection.

Differential Revision: https://phabricator.services.mozilla.com/D157994
2022-10-18 21:25:03 +00:00
Bernard Igiri
a45b1f8121 Bug 1710092 - Back out workaround from bug 1708809 r=mconley
Backed out workaround from bug 1708809.

Differential Revision: https://phabricator.services.mozilla.com/D159331
2022-10-18 18:39:32 +00:00
Mark Banner
c22552a3de Bug 1795370 - Add nsICrashReporter as an interface on nsAppRunner. r=gsvelto
This fixes ESLint issues raised by mozilla/valid-services-properties.
This also changes follow-on issues to use Services.appinfo rather than getService.

Differential Revision: https://phabricator.services.mozilla.com/D159461
2022-10-18 18:22:24 +00:00
James Teow
8448fad066 Bug 1788953 - Part 2: Use cached originalURI in setURI - r=adw
Depends on D157485

Differential Revision: https://phabricator.services.mozilla.com/D157486
2022-10-18 13:38:49 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Noemi Erli
ac856abc50 Backed out 2 changesets (bug 1793841) for causing Gtest failures CLOSED TREE
Backed out changeset 4d39c423b92e (bug 1793841)
Backed out changeset 5cfb5f595add (bug 1793841)
2022-10-18 04:29:44 +03:00
Dana Keeler
5a52df916d Bug 1793841 - don't serialize securityInfo in browser_aboutCertError_exception.js r=pbz
This test only needs the bytes of the server certificate, not the entire
nsITransportSecurityInfo of the connection.

Differential Revision: https://phabricator.services.mozilla.com/D157994
2022-10-18 00:18:08 +00:00
Cristian Tuns
d3ff37595e Backed out changeset f8554e4080f2 (bug 1793629) for causing mochitest failures on browser_preferences_usage.js CLOSED TREE 2022-10-15 16:14:29 -04:00
Tomislav Jovanovic
1afb6235b3 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-15 19:05:26 +00:00
Norisz Fay
4c718323c1 Backed out changeset c5a9bca461ce (bug 1793629) for causing multiple mochitest failures CLOSED TREE 2022-10-15 01:56:26 +03:00
Tomislav Jovanovic
8958e06b79 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-14 21:03:23 +00:00
Narcis Beleuzu
c8bd80aae4 Backed out changeset 8140f297aa36 (bug 1710092) as req by Bernard. CLOSED TREE 2022-10-14 17:45:53 +03:00
Bernard Igiri
8244a63285 Bug 1710092 - Back out workaround from bug 1708809 r=mconley
Backed out workaround from bug 1708809.

Differential Revision: https://phabricator.services.mozilla.com/D159331
2022-10-14 14:13:47 +00:00