corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
694,018 Commits 1 Branch 0 Tags
9369fcebed6b47417f0b7cacb948e44e5ab3e3e9
Commit Graph

63 Commits

Author SHA1 Message Date
Tom Ritter
9369fcebed Bug 1645419: Add new static analysis documentation r=andi 
Differential Revision: https://phabricator.services.mozilla.com/D101956
 2021-03-22 17:28:37 +00:00
Tom Ritter
bf3229c37c Bug 1645419: Edit the old static analysis page in the context of what's to come r=andi 
Depends on D108053

Differential Revision: https://phabricator.services.mozilla.com/D108054
 2021-03-22 17:28:37 +00:00
Tom Ritter
50b873e6c0 Bug 1645419: Move the existing static analysis page to a new one explicitly about existing stuff r=andi 
Differential Revision: https://phabricator.services.mozilla.com/D108053
 2021-03-22 17:28:37 +00:00
Simon Giesecke
a6e3b52371 Bug 1692835 - Remove nsJSThingHashtable. r=xpcom-reviewers,nika 
The only use of nsJSThingHashtable is replaced by a direct use of
nsBaseHashtable.

Differential Revision: https://phabricator.services.mozilla.com/D105971
 2021-03-02 09:02:19 +00:00
Akshat
7c84a12c84 Bug 1692974 - doc(mozlint): Add documentation for counting fixed issues r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D105271
 2021-02-17 08:49:12 +00:00
Mark Banner
8f47e34c9f Bug 1608272 - Extend an ESLint rule to disallow 'this' as the second argument to ChromeUtils.import. r=Gijs 
Depends on D104684

Differential Revision: https://phabricator.services.mozilla.com/D104685
 2021-02-11 22:02:16 +00:00
Dan Minor
e0cef26343 Bug 1416149 - Add linter for checking fluent files r=zbraniecki,gregtatum,flod,Gijs,fluent-reviewers,linter-reviewers,sylvestre 
This adds a linter for Fluent files based upon the existing test for bad
strings in browser_misused_characters_in_strings.js. It also adds a check
for identifiers that only permits lowercase letters, numbers and the
hyphen character (in ascii). Since a large number of existing identifiers
use uppercase letters, an exclusions file is used to disable the identifier
check on a file by file basis.

Differential Revision: https://phabricator.services.mozilla.com/D104414
 2021-02-11 17:35:29 +00:00
Sylvestre Ledru
96ca2cb1c5 Bug 1690959 - docs: Mozlint/rust - Fix the link to the source r=linter-reviewers,andi DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D104160
 2021-02-05 09:48:03 +00:00
Mark Banner
fd6460f596 Bug 1687650 - Rework Lint and ESLint document pages to provide a better layout and more information for ESLint itself. r=firefox-source-docs-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D103168
 2021-01-29 09:09:12 +00:00
Mark Banner
34db9cc17a Bug 1686226 - Add references to the Matrix Lint & Formatting room in the coding style docs. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D101463
 2021-01-12 15:04:35 +00:00
Kartik Gautam
301c68f371 Bug 1682817 - Make whitespace/newline linter also fail for absent newline character at the end of files and also implement fix for it r=sylvestre 
Depends on D100484

Differential Revision: https://phabricator.services.mozilla.com/D100443
 2021-01-07 08:53:16 +00:00
Kartik Gautam
ee0e92e46f Bug 1675131 - Make whitespace / newline linter also fail for missing empty lines at the end of files. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D98000
 2020-12-15 21:49:43 +00:00
Butkovits Atila
84f1d7afa2 Backed out changeset eb6cdd43ce2e (bug 1677549) as requested by Simon. CLOSED TREE 2020-12-14 17:32:44 +02:00
Simon Giesecke
0db014fa9a Bug 1677549 - Add some guidelines on include directives and header files to the coding style. r=andi,sylvestre,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D97916
 2020-12-11 10:35:54 +00:00
Sylvestre Ledru
05ff410247 Bug 1676514 - Add --fix to mozlint/clippy 
I will add a test once this feature is considered as stable upstream

Differential Revision: https://phabricator.services.mozilla.com/D96634
 2020-11-17 12:03:33 +00:00
Sylvestre Ledru
af5e653325 Bug 1667831 - doc: fix more pygments r=firefox-source-docs-reviewers,championshuttler DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D91868
 2020-09-30 07:03:41 +00:00
Sylvestre Ledru
e256974131 Bug 1667831 - doc: fix more warnings r=firefox-source-docs-reviewers,ahal DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D91642
 2020-09-29 18:48:17 +00:00
Sylvestre Ledru
527e1fbebf Bug 1667831 - doc: refresh links as many pages moved in-tree r=firefox-source-docs-reviewers,ahal DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D91619
 2020-09-29 17:53:54 +00:00
ruchikabgosain
e543682c6c Bug 1587022 - Improve documentation for Mozilla specific ESLint rules. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D52626
 2020-09-29 15:18:56 +00:00
Markus Stange
ee173b67a1 Bug 1667463 - Fix two typos in using_cxx_in_firefox_code.rst. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D91472
 2020-09-25 20:25:23 +00:00
Simon Giesecke
29f4eb535b Bug 1648010 - Update coding style with respect to string literals. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D81503
 2020-07-21 11:24:06 +00:00
Sylvestre Ledru
29ba23e5b6 no bug - Update the pylint doc r=andi DONTBUILD 
Also do that to verify reviewbot

Differential Revision: https://phabricator.services.mozilla.com/D90075
 2020-09-14 10:34:37 +00:00
Bryce Seager van Dyk
ffd3ef948e Bug 1659726 - Fix mode line docs to use 2 space indents rather than 8. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D87448
 2020-08-19 07:51:42 +00:00
Sylvestre Ledru
fb390e82f9 Bug 1657926 - firefox doc: fix some warnings r=championshuttler 
Differential Revision: https://phabricator.services.mozilla.com/D86732
 2020-08-11 23:20:25 +00:00
Simon Giesecke
c9d094b6d9 Bug 1653532 - Improve reference of Google Coding Style for C++ Code. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D83923
 2020-08-04 08:31:17 +00:00
Sylvestre Ledru
3e3d29db56 no bug - python CS doc - point to our linters r=marco 
Differential Revision: https://phabricator.services.mozilla.com/D82897
 2020-07-10 12:50:25 +00:00
Tom Prince
b74d7826bf Bug 1651731: [lint] Only allow files that are typically executable to have shebang lines override permission check; r=linter-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D82949
 2020-07-09 21:16:32 +00:00
Chris AtLee
e6f287cb81 Bug 1555560: Add support for black formatting with mozlint; r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D33125
 2020-07-08 22:08:08 +00:00
Mihai Alexandru Michis
1dcfa78743 Backed out 2 changesets (bug 1555560) for causing multiple lint failures. 
CLOSED TREE

Backed out changeset bd9460ac6e48 (bug 1555560)
Backed out changeset f2896032ced6 (bug 1555560)
 2020-07-09 01:04:18 +03:00
Chris AtLee
920e30c5d9 Bug 1555560: Add support for black formatting with mozlint; r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D33125
 2020-07-08 19:35:49 +00:00
Sylvestre Ledru
43d6e932ae Bug 1647265 - mozlint: when type is 'regex', add the capability to ignore the case r=ahal 
Differential Revision: https://phabricator.services.mozilla.com/D80477
 2020-06-23 21:45:16 +00:00
Sylvestre Ledru
6c553b3c2e Bug 1623024 - mozlint/pylint - follow up: fix a syntax issue in the rst file 
Differential Revision: https://phabricator.services.mozilla.com/D80375
 2020-06-20 12:28:48 +00:00
Sylvestre Ledru
c354babd59 Bug 1623024 - mozlint: Add pylint as new linter r=linter-reviewers,ahal 
Differential Revision: https://phabricator.services.mozilla.com/D79076
 2020-06-18 20:04:50 +00:00
Sylvestre Ledru
3ff637327c Bug 1642825 - mozlint: Add a linter to prevent further use of black/whitelist r=Gijs,linter-reviewers,mossop,ahal 
Note that I cannot do unit test because of it doesn't support regex payload
''Failed: could not resolve a lint function from''

Differential Revision: https://phabricator.services.mozilla.com/D78158
 2020-06-16 17:02:59 +00:00
Sylvestre Ledru
9e24410e89 Bug 1642898 - Remove most of the references of black/whitelist within the doc r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D78000
 2020-06-03 09:34:12 +00:00
Sylvestre Ledru
3c97cfe41d Bug 1641848 - Import https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code in-tree r=nalexander 
I replaced the color by bold on "No".
It seems we can't have color in cells with rst :/

Differential Revision: https://phabricator.services.mozilla.com/D77444
 2020-05-29 19:28:52 +00:00
Tilden Windsor
1e2eb80cb3 Bug 1614477 - Replaced deprecated dxr links with searchfox links. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D76621
 2020-05-24 13:46:30 +00:00
Sylvestre Ledru
4ee57e063f Bug 1636494 - doc: update the doc about some of the lint job moved to tier-2 r=linter-reviewers,ahal 
Depends on D74435

Differential Revision: https://phabricator.services.mozilla.com/D74436
 2020-05-13 09:32:57 +00:00
Ian Moody
3875762810 Bug 1536556 - Extend no-throw-cr-literal ESLint rule to forbid and fix throw new Error(Cr.ERROR);. r=Standard8 
Code should be using `throw Components.Exception("", Cr.ERROR);` instead,
since `new Error()` just converts the int value of the Cr.ERROR into a string,
whereas `Exception` constructs an Exception object with the result property set
to the Cr.ERROR value, so other code can identify it.

Differential Revision: https://phabricator.services.mozilla.com/D28074
 2020-05-05 17:43:39 +00:00
Ian Moody
43422d262d Bug 1536556 - Add custom no-throw-cr-literal ESLint rule, and enable it by default. r=Standard8 
This rule is based on the ESLint built-in no-throw-literal. Cr.ERRORs are also
literals since they are just integers and so have all the same disadvantages of
no stack info.

TestInterfaceJS.js is explicitly testing handling of throwing raw Cr.ERRORs and
thus needs to stay.

Differential Revision: https://phabricator.services.mozilla.com/D28072
 2020-05-05 15:00:50 +00:00
Sylvestre Ledru
fa3ea0481a no bug - static analysis doc: Fix a trivial rst typo in the doc 
Differential Revision: https://phabricator.services.mozilla.com/D71449
 2020-04-18 10:55:15 +00:00
Sylvestre Ledru
67f14e6168 Bug 1466070 - Integrate clang-format into mozlint r=linter-reviewers,ahal 
For now, the local detection sucks. I will fix that once bug 1625884
is fixed

Differential Revision: https://phabricator.services.mozilla.com/D69683
 2020-04-15 20:39:32 +00:00
Chris Peterson
5bc9d3f177 Bug 1625855 - Replace MOZ_MUST_USE with [[nodiscard]] in some Servo Rust code. r=emilio 
Are there any Rust crates outside mozilla-central that include or emit Mozilla C++ code that should be updated to use [[nodiscard]] instead of MOZ_MUST_USE?

Depends on D68751

Differential Revision: https://phabricator.services.mozilla.com/D69319
 2020-04-02 08:27:59 +00:00
Sylvestre Ledru
d2c4c26557 Bug 1623320 - Add support to run mozlint on dotfile r=linter-reviewers,ahal 
Differential Revision: https://phabricator.services.mozilla.com/D67316
 2020-03-20 21:51:03 +00:00
Andrew Halberstadt
b7556ed1a0 Bug 1623656 - [mozlint] Make output of ./mach lint --list readable, r=linter-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D67501
 2020-03-19 18:06:41 +00:00
Andrew Halberstadt
d61c55b71b Bug 1623339 - [lint.flake8] Fix path filtering bug when specifying subdirectory of excluded path, r=linter-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D67335
 2020-03-18 17:02:34 +00:00
Andi-Bogdan Postelnicu
5f558eb3a4 Bug 1619921 - enable clang-plugin with support for alpha checkers module. r=froydnj,sg 
Differential Revision: https://phabricator.services.mozilla.com/D65314
 2020-03-17 07:01:09 +00:00
Andreea Pavel
1d86d8f66b Backed out changeset 780399392e20 (bug 1619921) for breaking toolchains on a CLOSED TREE 2020-03-16 18:27:17 +02:00
Andi-Bogdan Postelnicu
2aea02458f Bug 1619921 - enable clang-plugin with support for alpha checkers module. r=froydnj,sg 
Differential Revision: https://phabricator.services.mozilla.com/D65314
 2020-03-16 16:04:00 +00:00
Sylvestre Ledru
a06a60ece6 Bug 1620635 - doc follow up - fix a typo DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D65864
 2020-03-07 12:13:02 +00:00