Commit Graph

188 Commits

Author SHA1 Message Date
23596c1d8b Bug 421303 Crash [@ jsds_ScriptHookProc] r=caillon a=dsicore If we reach ~jsdService, that means our client doesn't care about us, so we can (and should) drop all references to any callbacks (if they cared, they'd have kept us alive!*). I think jsdService::Off should clear all the hooks, the strange magic of not clearing it isn't really a great idea. So for Off, we'll now clear the ScriptHook too (consumers who use off should really drop any references they have to our objects...). I'm still on the fence on this point, I suspect we can actually move it from ::Off to ~jsdService (it must be cleared at some point, otherwise if jsd_xpc's library manages to get unloaded, the function pointer would be invalid, which would be *BAD*). jsds_NotifyPendingDeadScripts needs to clear gDeadScripts whether or not there's a service or hooks, so it does. Because it's a static callback and because of the scary way GC works, I'd rather ensure (deathgrip) that jsds is available (and consistent!) for the duration of the function call. The code already handles the lack of a hook, so there's no reason to do magical returns.... The real problem which mayhemer found was that jsdService::Off was returning early (failure) because gGCStatus wasn't JSGC_END when called from ~jsdService from JS_GC from the cyclecollector, so we make sure that ~jsdService forces ::Off to act as if it is JSGC_END (after ensuring that there are no callbacks available). * a pure javascript (xpcom component, not DOM hosted!) version of a jsdService consumer means that jsdService will need to talk to the CycleCollector eventually (this is another bug for the future). 2008-03-10 17:13:48 -07:00
8306c0c5ac Bug 282660 Crash [@ jsds_NotifyPendingDeadScripts] ds->script is null r=jst a=beltzner 2008-03-05 13:10:01 -08:00
6151f9ab37 Bug 394114 Interfaces missing from various QI implementations. jsdContext r=caillon sr=jag a=dsicore 2008-02-26 07:10:19 -08:00
1e6651be67 Bug 411249 Top crash [@ jsds_ScriptHookProc][@jsds_ScriptHookProc(JSDContext*, JSDScript*, int, void*)] on shutdown with Firebug 1.1.0b10 installed r=gijs a=beltzner 2008-01-31 11:12:47 -08:00
fd502496c5 Bug 411327 - nsIXPCNativeCallContext should not inherit from nsISupports, r=mrbkap, a=schrep 2008-01-15 07:50:57 -08:00
98de634631 Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
dbc27bc6e1 Bug 385765 [@ jsdASObserver::Observe] You can't dereference a NULL nsCOMPtr with operator->()
r=dveditz sr=dveditz
2007-07-01 12:25:10 -07:00
ef4773ff71 Bug 365363 Return value for GetJSDValue ignored leading to death
r=silver sr=biesi
2007-06-19 22:56:13 -07:00
703c12a83c Bug 379165: Simplifing JS_DimpHeap while fixing BeOS build problems. r=brendan 2007-04-29 14:49:00 -07:00
f35dc5025a Bug 378261: Replacing GC_MARK_DEBUG by DumpHeap. r=brendan 2007-04-25 06:43:18 -07:00
silver@warwickcompsoc.co.uk
7591966a7d Bug 341919 - Remove widget dependency from JSD. r=rginda sr=jst 2006-06-26 10:36:28 +00:00
gijskruitbosch@gmail.com
150dc19eef Bug 342074 - JSD crashes on exit when there's two clients
r+a=timeless
2006-06-20 15:54:44 +00:00
mrbkap@gmail.com
76c64de9cd Checking in Ben Turner <bent.mozilla@gmail.com> and timeless's patch to make Gecko use the JS engine's request model to help multithreaded embedders avoid GC races and crashes. bug 176182, r=mrbkap assumed-rs=brendan 2006-06-12 22:39:55 +00:00
darin@meer.net
0700b87ece landing patch for bug 326273 "Implement nsIThreadManager" (Mac portions by Mark Mentovai) with reviews from bienvenu, bsmedberg, bzbarsky, josh, roc, and ssieb 2006-05-10 17:30:15 +00:00
neil@parkwaycc.co.uk
ee09c42893 Followup patch to bug 207327 to move the "service" string from the name to the value of the category entry where it is interpreted to belong r=timeless sr=bz 2006-02-28 17:36:58 +00:00
timeless@mozdev.org
b61d9d9307 Bug 327605 [@ JSD_GetContextFlags - jsdService::GetFlags]
r=rginda
2006-02-27 04:17:08 +00:00
timeless@mozdev.org
f07795d670 Bug 281137 Add profiling column for functions excluding other functions running
jsd part
patch by silver@warwickcompsoc.co.uk r=shaver sr=dmose a=bsmedberg
2005-08-02 15:53:59 +00:00
timeless@mozdev.org
6a055c7220 Bug 283532 OOM crash [@ jsdValue::GetProperties]
patch by b.jacques@planet.nl r=rginda sr=brendan a=brendan
2005-07-01 05:12:47 +00:00
timeless@mozdev.org
756c1fa290 Bug 207309 nsMemoryImpl::Alloc of 0: 'size' in jsdValue::GetProperties
r=shaver sr=shaver
2004-11-10 21:58:00 +00:00
timeless@mozdev.org
ec52e849db Fixing code for CAUTIOUS_SCRIPTHOOK (not part of the build), broken by changes for
Bug 208030 JS errors report incorrect line numbers in the source code
2004-05-13 06:04:09 +00:00
gerv@gerv.net
4ba0518141 Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-18 22:01:16 +00:00
timeless@mozdev.org
90242f5acb Bug 238393 DRefTool analysis for jsd files
r=rginda a=asa
2004-03-26 07:27:05 +00:00
timeless@mozdev.org
21472eb92b Bug 238393 DRefTool analysis for jsd files
r=rginda
GC_MARK_DEBUG is not part of the build...
2004-03-24 23:25:30 +00:00
timeless@mozdev.org
e671c90660 Bug 238305 jsd doesn't build on windows if JS_MARK_DEBUG is set
r=rginda
not part of the build...
2004-03-23 05:33:09 +00:00
timeless@mozdev.org
c3f39c77aa Bug 238058 Crash [@js_GetStringBytes] from venkman
r=rginda a=brendan
2004-03-23 05:13:09 +00:00
darin@meer.net
14e471acbc landing string defragmentation patch for bug 231995, r/sr=dbaron,jst,dougt 2004-02-19 02:44:03 +00:00
jst@mozilla.jstenback.com
0c5e542fe7 Fixing bug 233307. deCOMtaminating nsIScript* and related interfaces. r+sr=bryner@brianryner.com. 2004-02-09 22:48:53 +00:00
dwitte@stanford.edu
6104eabbf7 spelling fixes... s/debuging/debugging/. thanks to WeirdAl for the patch.
b=106386, p=ajvincent@juno.com, r=timeless, sr=bz.
2003-10-10 04:31:15 +00:00
bryner@brianryner.com
4475fee458 Fix build on gcc 3.4 by removing extra semicolons (bug 218551). r/sr=dbaron, a=brendan. 2003-09-07 22:37:27 +00:00
rginda@netscape.com
da3f7b26e4 bug 216112, "add ability to disable object tracking in jsd"
r=caillon, sr=brendan, a=asa

adds the ability to turn off the object tracking without having to disable the debugger.  should make a dormant venkman less of a performance impact.
2003-08-14 22:49:09 +00:00
brendan@mozilla.org
4da5959a33 Big dynamic footprint win via script filename caching, plus line number fix for strict/const diags (see http://bugzilla.mozilla.org/attachment.cgi?id=127130&action=view for detailed checkin comments; 208030, r/rs=shaver, r=rginda on the jsd change, r=jst on the dom change). 2003-07-26 22:37:11 +00:00
timeless@mozdev.org
64b1a0a5ad Bug 207327 @mozilla.org/js/jsd/app-start-observer;2 isn't registering itself correctly as an app-startup observer service
r=rginda
2003-05-28 22:34:20 +00:00
rginda@netscape.com
11e0edbb4a Bug 204028, "debugger service crashes when asked to eval an empty string"
a=sspitzer@netscape.com

return NS_ERROR_INVALID_ARG if asked to eval an empty string
2003-05-01 18:50:58 +00:00
rginda@netscape.com
4a67b57039 bug 200591, "File Options > Don't Debug Eval/Timeouts isn't working", r=brendan
prevent any stack with a disabled frame from being debugged during single-stepping, or break-on-throw.  Also adds versioning support to the jsdIDebuggerService interface.
2003-04-18 20:12:11 +00:00
dbaron@dbaron.org
cb8b9c7c57 Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag 2003-01-08 21:07:51 +00:00
rginda@netscape.com
ae0150ab28 bug 185719, r=peterv@netscape.com, sr=brendan@mozilla.org
"add ability to get at function object for a jsdIScript"

add a |functionObject| attribute to the jsdIScript interface, which returns the function's JSObject as a jsdIValue
2002-12-17 22:22:30 +00:00
dbaron@fas.harvard.edu
746424466d Fix leaks of references to jsdService. r=rginda sr=alecf b=170194 2002-11-06 12:59:21 +00:00
rginda@netscape.com
f63b170e23 bug 155838, "Infinite loop caused by strange code", r=peterv, sr=brendan, a=roc+moz@cs.cmu.edu
don't leave gDeadScripts pointing at garbage.  May or may not fix the problem at hand, but is an improvement in either case.
2002-07-12 21:28:29 +00:00
rginda@netscape.com
227db4d1a0 fix build bustage, NS_IF_RELEASE the raw pointer, not the COM pointer. 2002-06-19 22:40:19 +00:00
rginda@netscape.com
70163d1d1f Bug 151803, "Debugger is leaking JSDValues", r=peterv, sr=jst
Stop caching jsdIValues, it doesn't seem to be worth the lookup cost.  This has the side effect of plugging the leak, as described in the bug.
also...
* Convert a few raw pointers to nsCOMPtrs
* Fix a bug where removing the last filter did not null out the list head,
causing a crash the next time filters were used.
* Track live jsdStackFrames, so we can invalidate them all when execution
continues.  Without this, only the top frame is properly invalidated, and any
other frame accessed after a continue will do Bad Things.
* Add some debugging prints to GetInitAtService, which seems to be failing at
random times.
2002-06-19 21:56:23 +00:00
dougt@netscape.com
00d8c29c64 Fixes mozilla/strings requiring unfrozen nsCRT class. patch by scc, r=dougt, sr=jag, b=136756 2002-05-15 18:55:21 +00:00
rginda@netscape.com
176c1e8165 - venkman only -
bug 139883, "ErrorHookProc can be tricked into thinking it never finished running", r=peterv
fixes bad early return in jsds_ErrorHookProc
test for correct max params (12, not 8) in CreatePPLineMap
use nsnull instead of 0 for null pointer return value
2002-04-26 20:57:35 +00:00
dbaron@fas.harvard.edu
e990a4631d Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa 2002-03-24 00:16:18 +00:00
rginda@netscape.com
c11da0b0d9 part of bug 109652, "Venkman needs to profile" r=peterv,r=a=shaver
add profiling support.
2002-02-27 09:24:14 +00:00
rginda@netscape.com
2e233f2bb9 bug 126365, "add options and private support to jsdIContext", sr=jst, r=jband
add jsdIContext::options and ::privateData attributes
2002-02-20 05:45:57 +00:00
rginda@netscape.com
bf0e0c1e2a bug 124717, need to wrap JSVAL_NULL for eval result, instead of just returning it unwrapped. 2002-02-16 10:53:52 +00:00
rginda@netscape.com
7bf866284b bug 124474, "add native frame support to jsd"
sr=shaver, r=jband
add JSD_IsStackFrameNative, IsStackFrameDebugger, and IsStackFrameConstructing
add similar attributes to jsdIStackFrame
tweak return values in jsds_FilterHook
don't include dummy stack frames in threadstates

bug 110387, "Crash on exiting venkman"
check to see if the debugger was turned off before going through with an unPause.
2002-02-14 07:57:30 +00:00
rginda@netscape.com
9b9dd4173c bug 121039, "Need a way to unwrap jsdIValues", r=jband, sr=jst
adds jsdIValue::getWrappedValue() and jsdIService::wrapValue() methods to provid
e js scripts a way to convert between jsdIValues and "real" js values.
Also includes fix to not call breakpoint hook while paused, and changes jsdIFilt
er::glob attribute to jsdIFilter::globalObject, to match jsdIContext::globalObject
2002-02-07 00:59:55 +00:00
jst@netscape.com
7f80575c14 Fixing bug 116834. Making element.innerHTML='...<script>...</script>...' not execute the script, this makes mozilla compatible with IE wrt innerHTML and execution of scripts. r=bzbarsky@mit.edu, sr=rpotts@netscape.com 2002-02-05 05:53:56 +00:00
rginda@netscape.com
40b9214286 changing a string constant, comenting out a DEBUG_rginda
use more descriptive url when compiling prettyprint changes
2002-01-31 00:37:28 +00:00