Commit Graph

6 Commits

Author SHA1 Message Date
Ting-Yu Lin
b58a8bdeec Bug 1211365 - Add test case for scrolling in selection mode. r=mtseng 2015-10-05 16:52:29 +08:00
Ting-Yu Lin
742821878e Bug 1196176 - Do not fire extra CaretStateChanged event when typing. r=mtseng
After HideCaret() is called via keyboard event,
OnScrollPositionChanged() still fire another CaretStateChanged event
even if the caret is hidden. We follow OnReflow() to update carets only
when carets are logically visible.

A test case:
1. Type a string on the rocketbar until the text is long enough to scroll.
2. Copy arbitrary string.
3. Tap on rocketbar to show caret, and move it to the end (within 15
   seconds timeout)
4. Type a character.

The text selection dialog should not show.
2015-09-22 17:39:36 +08:00
Ting-Yu Lin
e1d004b150 Bug 1196176 - Fix CaretStateChanged not dispatch on empty content. r=mtseng
We should dispatch CaretStateChanged event in OnReflow() in cursor mode
when the first caret's appearance is NormalNotShown. Otherwise the text
selection dialog won't update its position.
2015-09-22 17:39:36 +08:00
Ting-Yu Lin
587446f058 Bug 1196176 - Hide carets for mouse down reason. r=mtseng
SelectionCaret had been hiding carets upon receiving mouse down reason.
In this way, text selection dialog won't show, hide, and show again.
2015-09-22 17:39:36 +08:00
Ting-Yu Lin
a30c83e84b Bug 1196176 - No need to test mLastUpdateCaretMode. r=mtseng
I now think that mLastUpdateCaretMode is an implementation detail. Test
it will make test and implementation coupled.

It's better to call EXPECT_EQ directly in test functions so that the
line number in test result will be accurate when things go wrong.
2015-09-22 17:39:35 +08:00
Ting-Yu Lin
0a5588a884 Bug 1204872 - Add gtest for AccessibleCaretManager. r=roc
Add basic gtest to ensure AccessibleCaret and AccessibleCaretManager are
both testable. More tests to come.

Allow -Winconsistent-missing-override warning in gtest since MOCK_METHOD
does not have 'override' keyword. See bug 1169974.
2015-09-19 01:05:19 +08:00