corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
388,014 Commits 1 Branch 0 Tags
901b911c7d36325a277abe7bca2bc4e76ee62bad
Commit Graph

125 Commits

Author SHA1 Message Date
Ehsan Akhgari
d4c6d2cd2e Backed out 2 changesets (bug 989012) because of test failure on Linux32 opt mochitest-a11y on a CLOSED TREE 
Backed out changeset 9698f6f3f72e (bug 989012)
Backed out changeset 22fb05349a10 (bug 989012)
 2015-01-27 16:40:30 -05:00
Ehsan Akhgari
59c2df2758 Bug 989012 - Part 1: Stop after passing over a non-selectable frame if one is found during the frame traversal; r=roc 
The caret movement code already handles unselectable text frames if we
happen to land in the middle of one in nsTextFrame::PeekOffsetCharacter/Word.
However, when performing frame traversal to find the next frame to jump
to, we don't remember if we skipped over an unselectable frame, which causes
us to jump one offset too much when the caret is on the boundary of
selectable and unselectable content.  The test cases demonstrate the
scenario.  Note that an <img alt=foo> is implemented by adding a
generated content to the inline frame representing it, so as far as
the caret movement code is concerned, both test cases are treated similarly.

Note that we need to do this only when moving the selection, and not
when extending it.  We are adding an aExtend argument to
nsPeekOffsetStruct's constructor in order to be able to special case
that.
 2015-01-27 15:35:32 -05:00
Peter Chang
fdec704305 Bug 1121335 - Choose the right selection range for drag mode, r=roc 2015-01-23 06:09:00 +01:00
Jeremy Chen
aa1f716a14 Bug 1110917 - v3 Part 2: Fix focus not changing while selecting word. r=roc 2015-01-15 22:46:00 +01:00
Gregor Wagner
7bbbe93bf8 Backout bug 1110917 for Gij red. 2015-01-14 11:25:38 -08:00
Jeremy Chen
b2eb1b9655 Bug 1110917 - Part 2: Fix focus not changing while selecting text by long press v2. r=roc 2015-01-12 18:10:03 +08:00
pchang
222fed5fa0 Bug 1111433 - Dispatch the SelectionStateChanged event for blur. r=ehsan 2015-01-07 01:01:00 -05:00
Morris Tseng
98806e2664 Bug 1117643 - Always send blur event to selection carets but cancel long tap detector when leaving document. r=roc 2015-01-05 01:15:00 +01:00
pchang
56259cb050 Bug 1098161 - Notify shortcut mode to system app when long tap on content with empty text. r=roc 2014-12-19 14:04:45 +08:00
Ting-Yu Lin
84f589a772 Bug 1090682 - Do not consume NS_MOUSE_MOZLONGTAP if SelectWord failed. f=mtseng, r=roc 2014-12-24 19:14:00 +01:00
Morris Tseng
b3956cdd31 Bug 1114853 - Part 5: Don't dispatch event when we're at drag mode. r=roc 2014-12-24 00:02:00 +01:00
Morris Tseng
2f9785c560 Bug 1114853 - Part 4: Bail out if selections are mismatch. r=roc 2014-12-29 20:02:00 +01:00
Morris Tseng
595f013ec0 Bug 1114853 - Part 3: Reset mSelectionVisibleInScrollFrames when visibility set to false. r=roc 2014-12-24 01:07:00 +01:00
Morris Tseng
74aba96f79 Bug 1114853 - Part 2: Remove useless SetVisibility calls. r=roc 2014-12-24 00:01:00 +01:00
pchang
e05b155890 Bug 1068474 - Limit the selection range based on the boundary of startcaret and endcaret. r=roc 2014-12-19 13:25:17 +08:00
Carsten "Tomcat" Book
94c934b09b Backed out changeset 4aad6ecf4b7d (bug 1098161) for marionette test failures 2014-12-22 09:34:14 +01:00
Morris Tseng
5cb3628585 Bug 1109800 - Call CancelLongTapDetector when Selection carets are blurred. r=roc 2014-12-18 22:50:00 +01:00
pchang
7463f266b8 Bug 1098161 - Notify shortcut mode to system app when long tap on content with empty text. r=roc 2014-12-19 14:04:45 +08:00
Phil Ringnalda
dccf3eedb4 Back out 155b9d4cb8cb (bug 1068474) for Marionette failures 2014-12-21 18:54:23 -08:00
pchang
faa50bbc8b Bug 1068474 Limit the selection range based on the boundary of startcaret and endcaret, r=roc 
---
 layout/base/SelectionCarets.cpp | 13 +++++++++++++
 layout/base/SelectionCarets.h   |  8 ++++++++
 2 files changed, 21 insertions(+)
 2014-12-19 13:25:17 +08:00
Morris Tseng
e49c473a84 Bug 1092888 - Part 2: Check pointer of FrameSelection and Selection is valid. r=roc 2014-11-10 02:04:00 -05:00
Morris Tseng
7ea16aaeee Bug 1092888 - Part 1: Remove preference for selection carets with non-editable fields support. r=roc 2014-12-07 18:52:00 -05:00
Ting-Yu Lin
f47661ef92 Bug 1067728 - Part 5 - Dispatch updateposition after scroll end and reflow. r=roc, sr=smaug 
Add a selection state "updateposition" and a field "visible" to indicate
that the current selection's boundingClientRect or visible is changed.
We dispatch this state after scrolling or reflowing is done.
 2014-12-10 01:50:00 +01:00
Ting-Yu Lin
57ecef1608 Bug 1067728 - Part 4 - Refactor two functions in SeletionCarets. r=roc 
Make DispatchSelectionStateChangedEvent() and GetSelectionBoundingRect()
become member functions of SeletionCarets so that they are easier to use
in later patches.
 2014-12-08 01:55:00 +01:00
Ting-Yu Lin
4cc0337d66 Bug 1067728 - Part 2 - Hide start or end selection caret if it's out of scroll frame. f=mtseng, r=roc 
nsLayoutUtils::IsRectVisibleInScrollFrames() had been used by
TouchCaret. We do the similar check for SelectionCarets.
 2014-12-08 01:54:00 +01:00
Ryan VanderMeulen
a64e68352d Backed out 5 changesets (bug 1092888) because something in the push made Gij(2) permafail. 
Backed out changeset 0ad25135a27f (bug 1092888)
Backed out changeset 7cd8260bfc16 (bug 1092888)
Backed out changeset 86385291d8c8 (bug 1092888)
Backed out changeset be16d194d5df (bug 1092888)
Backed out changeset daee46827258 (bug 1092888)
 2014-12-09 12:08:59 -05:00
Morris Tseng
7ebccb0c29 Bug 1092888 - Part 2: Check pointer of FrameSelection and Selection is valid. r=roc 2014-11-10 02:04:00 +01:00
Morris Tseng
6613282fff Bug 1092888 - Part 1: Remove preference for selection carets with non-editable fields support. r=roc 2014-12-07 18:52:00 +01:00
Morris Tseng
15bc3a4aa2 Bug 1102135 - When select word, bailed out if frame is not selectable. r=roc 2014-11-27 23:57:00 +01:00
peter chang
78fa7f29d4 Bug 1090008 Dispatch SelectionStateChanged event for blur, r=roc r=smaug 2014-11-27 18:56:00 +01:00
peter chang
bb65c6b933 Bug 1090008 - Part 4 - Rename SelectionChange to SelectionStateChanged, r=smaug 2014-11-27 18:55:00 +01:00
pchang
caa30f7d54 Bug 1090008 -Part 1 - Refactor the logic to dispatch selectionchange to TextDialog, r=roc 2014-11-28 05:35:00 +01:00
Morris Tseng
d69d3866f9 Backed out 5 changesets (bug 1092888) for breaking QA smoketest on b2g. 
Backout changeset 8c513f282a9e (bug 1092888)
Backout changeset db37104f6fbd (bug 1092888)
Backout changeset b1a0a7ea1a32 (bug 1092888)
Backout changeset c53a6181a4b2 (bug 1092888)
Backout changeset 54e551c1f2cd (bug 1092888)
 2014-11-26 10:11:38 +08:00
Jonathan Kew
6a5c361e8b Bug 1077515 - part 3 - Change desiredX (nscoord) to desiredPos (nsPoint) in nsPeekOffsetStruct, to support maintaining either vertical or horizontal position on inter-line moves. r=roc 2014-11-22 14:39:03 +00:00
Ting-Yu Lin
34d7f80254 Bug 1100243 - Fix wrong log in SelectionCarets::SetEndFrameVisibility(). r=mtseng 2014-11-17 00:05:00 +01:00
Morris Tseng
89a80a347d Bug 1092888 - Part 2: Check pointer of FrameSelection and Selection is valid. r=roc 2014-11-10 02:04:00 +01:00
Morris Tseng
5e6cfa9ba4 Bug 1092888 - Part 1: Remove preference for selection carets with non-editable fields support. r=roc 2014-11-10 02:03:00 +01:00
Ting-Yu Lin
484e868db0 Bug 1097094 - Keep a WeakPtr to nsDocShell in SectionCarets. r=roc 
When SelectionCarets::Terminate() is called, it's not guaranteed that we
can get nsDocShell from PresContext. It causes that SelectionCarets
cannot remove itself as an observer.

To fix this, we keep a member WeakPtr<nsDocShell> so that we can always
have nsDocShell in SelectionCarets::Terminate().
 2014-11-13 08:32:00 -05:00
Morris Tseng
fbfa29f0c0 Bug 1096169 - Handle selection carets overlapping case. r=roc 2014-11-12 23:03:00 -05:00
Morris Tseng
5998dde150 Bug 1094056 - Use nsCaret::GetGeometryForFrame to determine position of selection carets. r=roc 2014-11-11 22:54:00 +01:00
Ting-Yu Lin
b40f143209 Bug 1073457 - Launch long tap detector when APZ isn't enabled. f=mtseng, r=roc 
LaunchLongTapDetector() is used to fire long tap to select word when
async pan zoom is not enabled. We should check if async pan zoom is
enabled rather than check whether it's on main process.

This can also fix selection carets not working on e10s.
 2014-11-10 00:29:00 +01:00
Ting-Yu Lin
f7be8d5ee9 Bug 1094607 - Move scroll observer logic to SelectionCarets. r=roc 2014-11-05 22:00:00 +01:00
Ting-Yu Lin
38f76ce3a3 Bug 1094072 - Update selection carets after reflow. r=roc 
Let SelectionCarets inherits from nsIReflowObserver so it could refresh
its position after reflow. This fixes the incorrect position of
selection carets after we rotate the device to change the screen from
portrait mode to landscape mode and vice versa.
 2014-11-05 21:18:00 +01:00
Morris Tseng
4942d31de9 Bug 1088559 - Also dispatch NotifyAsyncPanZoomStarted/NotifyAsyncPanZoomStopped to nsDocShell's child. r=roc 2014-10-29 02:03:00 -04:00
Morris Tseng
c3fb41b95c Bug 1088552 - Change downPoint and movePoint from canvasframe's coordinate to rootframe's coordinate. r=roc 2014-10-28 18:25:00 -04:00
Ting-Yu Lin
b704123245 Bug 1087190 - Add debug log to SelectionCarets. f=mtseng, f=pchang, r=roc 2014-10-29 01:16:00 +01:00
Morris Tseng
bb8bf1f072 Bug 1074736 - Consider multiple range selection in selection caret. r=roc 2014-10-23 19:49:00 +02:00
Ryan VanderMeulen
956e0a87db Backed out changesets 94c5f5317e4b, f43962d6b41e, and 6e0a13090cd8 (bug 1074736) for various carat-related Marionette failures. 2014-10-27 15:39:44 -04:00
Morris Tseng
9a523f32b7 Bug 1074736 - Consider multiple range selection in selection caret. r=roc 2014-10-23 19:49:00 +02:00
Carsten "Tomcat" Book
73e873dc28 Backed out changeset b1ab04e807c3 (bug 1074736) 2014-10-24 14:45:59 +02:00