Commit Graph

620 Commits

Author SHA1 Message Date
Dorel Luca
8cc61e1d4b Backed out changeset bbb39655cf71 (bug 1605934) for build bustage in widget/gtk/mozwayland/mozwayland.c 2020-01-18 15:39:55 +02:00
Sylvestre Ledru
8cc3e9bf3f Bug 1605934 - Use nested namespaces r=sg
Done with:
./mach static-analysis check --checks="-*, modernize-concat-nested-namespaces" --fix .
and then clang-format on the files

Differential Revision: https://phabricator.services.mozilla.com/D58217
2020-01-18 13:16:39 +00:00
Simon Giesecke
4efcf9d790 Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55673
2020-01-17 12:47:17 +00:00
Jan Varga
bf171d3df0 Bug 1608025 - Clean up the test for the upgrade from storage version 2.1; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D59710
2020-01-14 06:16:52 +00:00
Csoregi Natalia
683448754f Backed out 3 changesets (bug 1497007) for assertion failures on IDBTransaction.cpp. CLOSED TREE
Backed out changeset 72bc4f39b659 (bug 1497007)
Backed out changeset 99fc4eedacc7 (bug 1497007)
Backed out changeset 787c340dd3d0 (bug 1497007)
2020-01-14 15:22:26 +02:00
Simon Giesecke
22e13211f2 Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55673
2020-01-14 11:14:29 +00:00
Eric Rahm
daeb56f35b Bug 1606187 - Part 2b: Update users of nsClassHashtable to handle UniquePtr differences r=KrisWright,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D59042
2020-01-13 19:18:56 +00:00
Simon Giesecke
73725debbb Bug 1600906 - Harmonize types for index and object store ids. r=dom-workers-and-storage-reviewers,ytausky
Formerly, a mixture of uint64_t, int64_t and even int32_t was used. Now,
int64_t is used via an IndexOrObjectStoreId type alias. int64_t is the
type used in PBackgroundIDBSharedTypes.ipdlh

Differential Revision: https://phabricator.services.mozilla.com/D59483
2020-01-10 15:23:47 +00:00
Simon Giesecke
e6e9c2dda2 Bug 1600906 - Transform Cursor into a template depending on the cursor type. r=dom-workers-and-storage-reviewers,ytausky
This change reduces the number of data members and state in individual classes
and ensures that for each cursor type only the data members actually used
exist at compile time rather than requiring various assertions and case
distinctions at run-time. The mapping from the type known at run-time to the
compile-time types is done at a single code location in
TransactionBase::AllocCursor.

The ObjectStore vs. Index and Key vs. Value cursor type aspects are now properly
separated in different classes.

This patch also renames the misnamed CursorTypeTraits in ActorsParent.cpp to
PopulateResponseHelper, which is necessary as part of this patch to resolve
the ambiguity with the CursorTypeTraits defined in IDBCursorType.h

It also eliminates the CursorPosition type, which is redundant with the
CursorData template defined in IDBCursorType.h, which is now reused on both
the parent and child sides to avoid unnecessary heterogeneity.

Differential Revision: https://phabricator.services.mozilla.com/D59478
2020-01-13 10:31:06 +00:00
Simon Giesecke
556830c732 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993
2020-01-10 15:23:52 +00:00
Csoregi Natalia
8a5ddbf4ee Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke
9b9b1a19e1 Bug 1600906 - Harmonize types for index and object store ids. r=dom-workers-and-storage-reviewers,ytausky
Formerly, a mixture of uint64_t, int64_t and even int32_t was used. Now,
int64_t is used via an IndexOrObjectStoreId type alias. int64_t is the
type used in PBackgroundIDBSharedTypes.ipdlh

Differential Revision: https://phabricator.services.mozilla.com/D59483
2020-01-10 14:22:11 +00:00
Simon Giesecke
6eb359be68 Bug 1600906 - Transform Cursor into a template depending on the cursor type. r=dom-workers-and-storage-reviewers,ytausky
This change reduces the number of data members and state in individual classes
and ensures that for each cursor type only the data members actually used
exist at compile time rather than requiring various assertions and case
distinctions at run-time. The mapping from the type known at run-time to the
compile-time types is done at a single code location in
TransactionBase::AllocCursor.

The ObjectStore vs. Index and Key vs. Value cursor type aspects are now properly
separated in different classes.

This patch also renames the misnamed CursorTypeTraits in ActorsParent.cpp to
PopulateResponseHelper, which is necessary as part of this patch to resolve
the ambiguity with the CursorTypeTraits defined in IDBCursorType.h

It also eliminates the CursorPosition type, which is redundant with the
CursorData template defined in IDBCursorType.h, which is now reused on both
the parent and child sides to avoid unnecessary heterogeneity.

Differential Revision: https://phabricator.services.mozilla.com/D59478
2020-01-10 14:21:43 +00:00
Simon Giesecke
6ab7211daa Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993
2020-01-10 14:21:18 +00:00
Simon Giesecke
0f2ed92cf9 Bug 1600906 - Avoid copying key buffers. r=dom-workers-and-storage-reviewers,ytausky
Depends on D57991

Differential Revision: https://phabricator.services.mozilla.com/D57992
2020-01-06 14:16:33 +00:00
Simon Giesecke
c0d76c854a Bug 1600906 - Use scoped enums in IDBCursor. r=dom-workers-and-storage-reviewers,ytausky
Depends on D57990

Differential Revision: https://phabricator.services.mozilla.com/D57991
2020-01-06 14:19:39 +00:00
Simon Giesecke
95498b30b5 Bug 1600906 - Use InitializedOnce in DirectoryInfo to allow moving instances without additional state. r=dom-workers-and-storage-reviewers,ytausky
Depends on D57989

Differential Revision: https://phabricator.services.mozilla.com/D57990
2020-01-09 14:58:17 +00:00
Simon Giesecke
dc3e941e24 Bug 1600906 - Encapsulate ThreadInfo; use std::move instead of swap, use const where then possible. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D57988
2020-01-07 15:11:39 +00:00
Simon Giesecke
d4d82dcbd0 Bug 1600906 - Merge identical switch cases. r=dom-workers-and-storage-reviewers,ttung
Depends on D57986

Differential Revision: https://phabricator.services.mozilla.com/D57987
2019-12-20 15:33:40 +00:00
Simon Giesecke
08b8c3488c Bug 1600906 - Avoid unnecessary copy. r=dom-workers-and-storage-reviewers,ttung
Differential Revision: https://phabricator.services.mozilla.com/D57986
2019-12-20 15:32:36 +00:00
Simon Giesecke
e722e33ba9 Bug 1601707 - Workaround for compilers that do not extend the lifetime of temporaries resulting from ?: expressions. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D56873
2019-12-17 14:23:28 +00:00
Simon Giesecke
d32226e5b0 Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55514
2019-12-19 09:56:38 +00:00
Simon Giesecke
7a1563ecfa Bug 1600283 - Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung
Differential Revision: https://phabricator.services.mozilla.com/D55511
2019-12-19 09:56:05 +00:00
Simon Giesecke
c84c17908b Bug 1600283 - Use std::move instead of forget/swap. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55510
2019-12-19 09:55:52 +00:00
Simon Giesecke
72dc959f9e Bug 1600283 - Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung
Differential Revision: https://phabricator.services.mozilla.com/D55509
2019-12-19 09:55:44 +00:00
Simon Giesecke
8054ac390b Bug 1600283 - Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55508
2019-12-19 09:55:31 +00:00
Simon Giesecke
fb2457211b Bug 1600283 - Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55507
2019-12-19 09:25:48 +00:00
Simon Giesecke
4be94f12ed Bug 1600283 - Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55506
2019-12-19 09:25:40 +00:00
Simon Giesecke
9459dbe282 Bug 1600283 - Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55505
2019-12-19 09:25:28 +00:00
Simon Giesecke
e5672ccaa6 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55504
2019-12-19 09:25:20 +00:00
Simon Giesecke
eba895263e Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55502
2019-12-19 09:25:08 +00:00
Simon Giesecke
65c740ec1f Bug 1600283 - Remove uses of plain pointers and already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55501
2019-12-19 09:24:58 +00:00
Simon Giesecke
9a430d6839 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55500
2019-12-19 09:24:47 +00:00
Simon Giesecke
fe8e1ec7c9 Bug 1600283 - Removed uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55499
2019-12-19 09:24:35 +00:00
Simon Giesecke
01fc281703 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55497
2019-12-19 09:24:15 +00:00
Simon Giesecke
7b764405f4 Bug 1603767 - Ensure that NoteActorDestroyed is not called multiple times. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D57301
2019-12-19 09:55:05 +00:00
Simon Giesecke
4981e5ea1d Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55490
2019-12-16 13:19:24 +00:00
Simon Giesecke
675deb26e3 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55489
2019-12-16 13:19:08 +00:00
Simon Giesecke
0af55bc258 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55488
2019-12-16 13:19:01 +00:00
Simon Giesecke
32ab286c9d Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55487
2019-12-16 13:18:46 +00:00
Simon Giesecke
91fc97a9a2 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55486
2019-12-16 13:18:39 +00:00
Simon Giesecke
99fa370f3b Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55480
2019-12-16 13:17:46 +00:00
Simon Giesecke
2176821c11 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55478
2019-12-13 12:31:10 +00:00
Simon Giesecke
66bd4949a5 Bug 1600283 - Reduce uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55477
2019-12-13 12:18:21 +00:00
Simon Giesecke
23c396b19b Bug 1577202 - Defer closing of a database while CreateFileOp's are pending. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D44683
2019-12-13 13:32:02 +00:00
Simon Giesecke
a13ea4dd47 Bug 1600906 - Reduce statefulness of TransactionDatabaseOperationBase using InitializedOnce. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56015
2019-12-13 11:31:56 +00:00
Simon Giesecke
70c2d14fb4 Bug 1600906 - Encapsulate DatabaseOperationBase::mResultCode. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56014
2019-12-13 11:28:24 +00:00
Simon Giesecke
b03b8a322d Bug 1600906 - Use move semantics with IdleDatabaseInfo. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56012
2019-12-13 12:21:18 +00:00
Simon Giesecke
87c344b031 Bug 1600906 - Use move semantics with ThreadInfo. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56011
2019-12-13 12:20:23 +00:00
Simon Giesecke
9b11a9200a Bug 1600906 - Reduce statefulness of DatabaseConnection using InitializedOnce. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56008
2019-12-13 10:55:10 +00:00