corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
898,585 Commits 1 Branch 0 Tags
8c703a7db2b9672e7328d912f45fe3791f4044db
Commit Graph

589 Commits

Author SHA1 Message Date
Mark Banner
935c704913 Bug 1951365 - Add names to the unnamed configurations sections in eslint-plugin-mozilla. r=frontend-codestyle-reviewers,mossop 
These make debugging configuration issues easier to handle.
The top-level .eslintrc.js change is so that we use the configuration handling system in index.js to be able to filter out the name for the legacy configuration set-ups.

Differential Revision: https://phabricator.services.mozilla.com/D240138
 2025-03-04 08:29:40 +00:00
Dave Townsend
1f501407fe Bug 1945566 - Add eslint and vscode module resolvers for moz-src, r=firefox-desktop-core-reviewers ,frontend-codestyle-reviewers,mconley,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D236570
 2025-03-03 12:47:47 +00:00
Sandor Molnar
13d09c1f65 Backed out 4 changesets (bug 1945566) for causing build bustages/py3 unit test failures/bugzilla lint failures CLOSED TREE 
Backed out changeset 6d69925d57ac (bug 1945566)
Backed out changeset 1b2bd35ca71f (bug 1945566)
Backed out changeset 9eba66d33006 (bug 1945566)
Backed out changeset c19c6833ebdc (bug 1945566)
 2025-02-26 14:24:49 +02:00
Dave Townsend
99a274b0af Bug 1945566 - Add eslint and vscode module resolvers for moz-src, r=firefox-desktop-core-reviewers ,frontend-codestyle-reviewers,mconley,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D236570
 2025-02-26 11:30:59 +00:00
mark
c2958a4a93 Bug 1936120 - Enforce no quotes around Lit expressions r=reusable-components-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,backup-reviewers,sidebar-reviewers,frontend-codestyle-reviewers,profiles-reviewers,mtigley,mconley,hjones,jsudiaman,niklas,Standard8,pdahiya 
* Enables lit/quoted-expressions rule to enforce that no surrounding
  quotes when expressions are bound to attributes and properties in Lit templates.
  See f71ea1741e/docs/rules/quoted-expressions.md

* Updates all violations to adhere to lit/quoted-expressions rule

Differential Revision: https://phabricator.services.mozilla.com/D237657
 2025-02-19 16:19:42 +00:00
mark
ac3f87d8dd Bug 1936120 - Install eslint-plugin-lit and configuration r=Standard8,frontend-codestyle-reviewers 
* Installs eslint-plugin-lit

* Adds configuration

Differential Revision: https://phabricator.services.mozilla.com/D237656
 2025-02-19 16:19:41 +00:00
Mike Conley
6db006549f Bug 1938452 - Update a bunch of non-permalink references to browser/extensions/newtab. r=sylvestre,search-reviewers,tabbrowser-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mcheang,pdahiya,thecount,dao,pollymce 
Differential Revision: https://phabricator.services.mozilla.com/D233874
 2025-02-03 16:45:33 +00:00
Alexandru Marc
88e7c19d5c Backed out 10 changesets (bug 1938452) for causing node failures CLOSED TREE 
Backed out changeset f6a771e83261 (bug 1938452)
Backed out changeset 69f385bc90ce (bug 1938452)
Backed out changeset 9c8837fc4805 (bug 1938452)
Backed out changeset c9737e213e42 (bug 1938452)
Backed out changeset ac0a50aaf347 (bug 1938452)
Backed out changeset f1f41e902e36 (bug 1938452)
Backed out changeset aef74a3d077d (bug 1938452)
Backed out changeset 8ca1a633192a (bug 1938452)
Backed out changeset 88df910fa038 (bug 1938452)
Backed out changeset cd4fdafb2594 (bug 1938452)
 2025-02-03 18:28:59 +02:00
Mike Conley
661a090489 Bug 1938452 - Update a bunch of non-permalink references to browser/extensions/newtab. r=sylvestre,search-reviewers,tabbrowser-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mcheang,pdahiya,thecount,dao,pollymce 
Differential Revision: https://phabricator.services.mozilla.com/D233874
 2025-02-03 15:07:11 +00:00
Tooru Fujisawa
94bba12a39 Bug 1936051 - Part 15: Remove JSM handling from eslint config. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D233741
 2025-01-23 12:09:37 +00:00
Tooru Fujisawa
2b05a3b05e Bug 1936051 - Part 5: Remove the reject-global-this rule. r=Standard8,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233731
 2025-01-23 12:09:33 +00:00
Tooru Fujisawa
142c49a4d5 Bug 1936051 - Part 1: Remove the mark-exported-symbols-as-used rule. r=Standard8,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233727
 2025-01-23 12:09:30 +00:00
Gijs Kruitbosch
e18f3f1840 Bug 1845725 - add eslint rule for using then/catch without arguments, r=frontend-codestyle-reviewers,Standard8,home-newtab-reviewers,geckoview-reviewers,mossop,ohall,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D232957
 2025-01-16 15:02:12 +00:00
Mark Banner
3832e2355f Bug 1927798 - Re-enable the curly rule for ESLint. r=frontend-codestyle-reviewers,mossop 
This was accidentally disabled in bug 1920531 with the re-organisation of how eslint-plugin-mozilla worked.
The rule needs to be (re)enabled after eslint-config-prettier is applied, as eslint-config-prettier turns it off by default.

Differential Revision: https://phabricator.services.mozilla.com/D227621
 2024-11-01 14:15:01 +00:00
Mark Banner
c68ca31462 Bug 1881696 - Rework the ESLint environment so that eslint-plugin-mozilla is not enforcing the environment everywhere. r=frontend-codestyle-reviewers,Gijs 
This makes it easier for subscribers of eslint-plugin-mozilla to use it more generally as a set of recommended
rules. The only environment definitions are for mozilla-specific file types, where we should be safe to specify
them.

Differential Revision: https://phabricator.services.mozilla.com/D225704
 2024-10-18 09:21:27 +00:00
Mark Banner
e0e5df61a5 Bug 1920802 - Update node_modules related to ESLint as far as possible. r=frontend-codestyle-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D222622
 2024-09-25 06:37:10 +00:00
Mark Banner
59c6aa8339 Bug 1920531 - Remove html, json and prettier plugin dependencies from eslint-plugin-mozilla. r=frontend-codestyle-reviewers,Gijs 
Requiring these in eslint-plugin-mozilla seems a bit unnecessary:

* The html plugin is used as a parser and is only required if a project is parsing html.
* Similary, we use the recommended config for the JSON parser, and it only applies for JSON files.
* The prettier option is only required if a project wants to use prettier. Whilst I think we should have prettier for all Mozilla projects, I don't think we need to enforce/require it here.

Differential Revision: https://phabricator.services.mozilla.com/D222628
 2024-09-23 17:46:18 +00:00
Mark Banner
cf294b2b28 Bug 1917532 - Remove overrides sections from *-test configurations in eslint-plugin-mozilla. r=frontend-codestyle-reviewers,mossop 
ESLint v9 doesn't support overrides/file specification in the configurations, so we don't want these
now.

The top-level configuration already strips out the overrides for these and handles them separately, so
there's nothing to add - simply remove the 'removeOverrides' function.

Differential Revision: https://phabricator.services.mozilla.com/D221447
 2024-09-12 21:08:45 +00:00
Mark Banner
26216a2205 Bug 1575506 - Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221446
 2024-09-12 21:08:45 +00:00
Mark Banner
fe5b823483 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 21:08:44 +00:00
Sandor Molnar
b59809ee6a Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE 
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
 2024-09-12 20:45:28 +03:00
Mark Banner
c02efe7faa Bug 1917532 - Remove overrides sections from *-test configurations in eslint-plugin-mozilla. r=frontend-codestyle-reviewers,mossop 
ESLint v9 doesn't support overrides/file specification in the configurations, so we don't want these
now.

The top-level configuration already strips out the overrides for these and handles them separately, so
there's nothing to add - simply remove the 'removeOverrides' function.

Differential Revision: https://phabricator.services.mozilla.com/D221447
 2024-09-12 16:42:00 +00:00
Mark Banner
a1f8e140ba Bug 1575506 - Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221446
 2024-09-12 16:41:59 +00:00
Mark Banner
4b68d25082 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 16:41:59 +00:00
Mark Banner
66e8ca14df Bug 1907841 - Change ESLint's .eslintignore to be an imported module. r=frontend-codestyle-reviewers,zeid,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D216540
 2024-07-16 12:53:09 +00:00
Mark Banner
19edc747a2 Bug 1905959 - Move jsm rule handling out of eslint-plugin-mozilla to the top-level config. r=frontend-codestyle-reviewers,Gijs 
This helps to simplify the combinations in eslint-plugin-mozilla ahead of supporting the ESLint flat config.

Differential Revision: https://phabricator.services.mozilla.com/D215541
 2024-07-03 11:41:30 +00:00
Mark Banner
94a2472342 Bug 1897898 - Separate out ESLint rule rollouts configurations to a separate module. r=frontend-codestyle-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D210992
 2024-05-21 13:38:01 +00:00
Mark Banner
0bd2cccf87 Bug 1897770 - Improve .sjs file environment definitions in ESLint. r=frontend-codestyle-reviewers,extension-reviewers,Gijs 
This stops sjs files from picking up the test environments/configurations which means they get just the sjs environment
which is what we want.

Differential Revision: https://phabricator.services.mozilla.com/D210928
 2024-05-20 13:49:44 +00:00
Mark Banner
2bd3784e7f Bug 1897770 - Move ESLint no-insecure-url definitions to general-test.js. r=frontend-codestyle-reviewers,Gijs 
This moves the general test definition to be first, so that the other test types can build on it.
It also re-arranges the no-insecure-url rule definitions to be defined in a single place in general-test.

This also exposes a few more places where we're not currently meeting the no-insecure-url rule, so we allowlist
those as well for now.

Differential Revision: https://phabricator.services.mozilla.com/D210927
 2024-05-20 13:49:44 +00:00
Dão Gottwald
04686bbe63 Bug 1837575 - Move Tabbed Browser related files to browser/components/tabbrowser/. r=mconley,desktop-theme-reviewers,zeid,tabbrowser-reviewers,frontend-codestyle-reviewers,Itiel 
This is a start, there are more modules and scripts we can/should move, as well as tests.

Differential Revision: https://phabricator.services.mozilla.com/D210676
 2024-05-17 13:25:23 +00:00
Mike Hommey
68e5cec3f6 Bug 1885449 - Move GV code shared between Android and iOS to a shared directory. r=geckoview-reviewers,frontend-codestyle-reviewers,nalexander,owlish 
And hook them up to the iOS build.

Differential Revision: https://phabricator.services.mozilla.com/D204711
 2024-05-16 22:08:51 +00:00
Gijs Kruitbosch
d4ea70da14 Bug 1895692 - turn off import/no-unassigned-import for storybook files, r=reusable-components-reviewers,frontend-codestyle-reviewers,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D210475
 2024-05-15 16:08:57 +00:00
James Teow
dd5f2cae2c Bug 1891982 - Part 1: Copy Top Sites Feed into the Top Sites component - r=dao,frontend-codestyle-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D207827
 2024-04-23 18:32:30 +00:00
Mark Banner
6699dcb7f8 Bug 1799465 - Enable require-jsdoc rules by default, disabling on code where there are existing failures. r=frontend-codestyle-reviewers,migration-reviewers,backup-reviewers,mossop,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D206878
 2024-04-08 13:34:13 +00:00
Mark Banner
d79c6960e4 Bug 1889087 - Enable ESLint rule mozilla/reject-chromeutils-import on devtools as well. r=arai,devtools-reviewers,profiler-reviewers,julienw,frontend-codestyle-reviewers,perftest-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D206349
 2024-04-06 09:08:47 +00:00
Sandor Molnar
890280e412 Backed out changeset 50f86f169ee8 (bug 1889087) for causing talos performance test failures CLOSED TREE 2024-04-03 09:18:07 +03:00
Mark Banner
8b11d372f2 Bug 1889087 - Enable ESLint rule mozilla/reject-chromeutils-import on devtools as well. r=arai,devtools-reviewers,profiler-reviewers,julienw 
Differential Revision: https://phabricator.services.mozilla.com/D206349
 2024-04-02 19:05:48 +00:00
Irene Ni
ea6c87d4f9 Bug 1876432 - Added support for custom themes as its own menu in Reader View. r=reader-mode-reviewers,fluent-reviewers,desktop-theme-reviewers,hjones,accessibility-frontend-reviewers,bolsson,devtools-reviewers,sfoster,cmkm,jules,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D204519
 2024-04-02 00:08:46 +00:00
Luca Greco
1977c9cd4f Bug 1883452 - Obliterate Corroborator remaining bits. r=rhelmer,Gijs,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D205735
 2024-03-27 16:29:42 +00:00
Dave Townsend
188a75ae0a Bug 1864896: Enable unused argument lint rule. r=Standard8,perftest-reviewers,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,nchevobbe,robwu,sparky,issammani,sgalich,owlish,migration-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D195632
 2024-03-21 08:50:00 +00:00
Gijs Kruitbosch
94e799935c Bug 1880899 - add lint rule that prevents adding more browser.js globals, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D202804
 2024-03-16 15:14:07 +00:00
Greg Tatum
6ff74ae304 Bug 1814289 - Enable the jsdoc lint rule for translations and run auto-fix; r=translations-reviewers,nordzilla 
There will be lint errors reported, as the following patch will manually
fix the remaining errors.

Differential Revision: https://phabricator.services.mozilla.com/D204516
 2024-03-13 19:23:41 +00:00
Mark Banner
d534b7b6ee Bug 1885041 - Expand disallowing JSM based imports via ESLint to everything except for devtools. r=arai,omc-reviewers,aminomancer,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D204441
 2024-03-13 17:38:28 +00:00
Mark Banner
0a0c3c6972 Bug 1884623 - Cleanup jsm references in ESLint files. r=mossop,devtools-reviewers,omc-reviewers,ochameau,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204180
 2024-03-11 15:26:27 +00:00
Mark Banner
383e208b95 Bug 1883371 - Enable ESLint rule no-console on production code. r=mossop,webcompat-reviewers,devtools-reviewers,omc-reviewers,twisniewski,nchevobbe,aminomancer 
Allow for console.error, console.warn and console.createInstance, but fail for everything else.

Differential Revision: https://phabricator.services.mozilla.com/D203456
 2024-03-05 16:56:57 +00:00
Mark Banner
5990e673ae Bug 1883371 - Add a general configuration for rules specific for all tests. r=mossop 
This gives us the option to specify rule variations for all tests without having to copy across the configurations.

More importantly, we can also apply this to anything under `/test/` or `/tests/` and so we can catch utils and other files that the specific test configurations don't already catch.

Differential Revision: https://phabricator.services.mozilla.com/D203455
 2024-03-05 16:56:57 +00:00
Mark Banner
1cced537f0 Bug 1881266 - Enable ESLint recommended rule no-case-declarations globally, warning for existing cases. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D202320
 2024-02-26 11:35:41 +00:00
Mark Banner
871b6aeefb Bug 1881266 - Enable ESLint recommended rule no-constant-condition globally, warning for existing cases. r=mossop,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D202319
 2024-02-26 11:35:41 +00:00
Gijs Kruitbosch
2901dd36aa Bug 1780071 - turn on no-comparison-or-assignment-inside-ok for xpcshell and browser tests, r=mossop,devtools-reviewers,fxview-reviewers,sclements,ochameau 
I'll split up the autofix commits separately assuming we're all happy to go ahead with this.

Differential Revision: https://phabricator.services.mozilla.com/D198594
 2024-02-20 12:40:07 +00:00
Marco Bonardo
41a226217e Bug 1880510 - Use console.createInstance instead of Log.sys.mjs in Urlbar. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D201985
 2024-02-20 08:58:33 +00:00