Commit Graph

19 Commits

Author SHA1 Message Date
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Marco Zehe
563e9a7ced Bug 968111 - Fix various accessibility markup issues in Toolkit XUL files, r=da0 2014-02-05 17:33:43 +01:00
Gregory Szorc
6e1333520a Bug 774572 - Part 2: Define JAR_MANIFESTS in moz.build files; r=glandium
Every directory with a jar.mn now has JAR_MANIFESTS defined in its
moz.build file.

We also removed the may_skip special consideration of jar.mn files
because this information is now available during tier traversal by the
reader courtesy of the variables being present in moz.build files.
2013-12-10 16:18:11 +09:00
Kyle Machulis
331f36baa9 Bug 855465 - Add emacs python mode comments to moz.build files; r=gps 2013-04-01 11:36:59 -07:00
Kyle Machulis
ec9b53db93 Backout for changeset 03452b187c14 (Bug 855465) due to bustage on a CLOSED TREE; r=qdot 2013-03-29 15:12:58 -07:00
Kyle Machulis
0419a0b889 Bug 855465 - Add emacs python mode comments to moz.build files; r=gps 2013-03-29 13:56:18 -07:00
Gregory Szorc
9b83c3d1f4 Bug 844635 - Part 3: Remove empty Makefile.in files; r=glandium 2013-03-17 18:01:25 -07:00
Gregory Szorc
f96c000ea2 Bug 784841 - Part 18θ: Convert /toolkit f=Mossop, Ms2ger; rs=ted 2013-02-25 13:19:09 -08:00
Mike Hommey
0f9f294ea0 Bug 774032 bonus - Use @DEPTH@ and @relativesrcdir@ in Makefile.in. r=ted 2012-08-04 20:26:44 +02:00
Neil Rashbrook
3f194429dd Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-26 00:11:16 +01:00
Ed Morley
4bd90ea948 Backout ec9451e9e830 (bug 758354) for PGO linux permaorange in browser_bug422590.js and friends 2012-06-25 19:14:43 +01:00
Neil Rashbrook
d9a10be7eb Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-25 09:24:49 +01:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Gavin Sharp
6bd9f119a1 Bug 569542: fix appPicker.js's getFileDisplayName function, and make all copies of this method identical, r=Neil 2010-06-07 10:29:25 -04:00
Neil Rashbrook
959d6df5e6 Bug 501095 Clean up appPicker.xul r=Mano 2009-09-09 23:18:35 +01:00
395c945adf Bug 410461 - "List of "Other" applications has no accessible names" [p=jmathies@mozilla.com (Jim Mathies) r=MarcoZ a1.9b3=beltzner] 2008-01-31 18:13:59 -08:00
f44b956f60 Bug 400460 - "appPicker.css should be moved to /mozapps/skin/ for themers" [p=jmathies@mozilla.com (Jim Mathies) r=gavin a=blocking-firefox3+] 2007-11-20 21:28:47 -08:00
a7bff26bc3 bug 400466: application selector dialog isn't wide enough if there is long file type description; patch by Jim Mathies; r=myk, a=schrep 2007-11-19 23:50:00 -08:00
5828746939 Bug 348808 - "use application selector instead of file selector dialog when picking helper apps" [p=jimm r=dolske r=rob_strong r=myk r=biesi a=blocking-firefox3+ for M9] 2007-10-18 21:15:41 -07:00