Commit Graph

5 Commits

Author SHA1 Message Date
Brendan Dahl
532fe1f6b0 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265
2018-08-25 00:16:27 +00:00
Paolo Amadini
323238e7d1 Bug 1484275 - Fix opening the main menu while another popup is open on Windows. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3979
2018-08-23 14:04:43 +01:00
Paolo Amadini
bc4ac85924 Bug 1428839 - Part 4 - Avoid re-entrancy in PanelMultiView navigation functions. r=Gijs
We now use the "active" property of views to track whether navigation is possible. This has the advantage of being already handled correctly when views are moved to a different panel, and is in line with the purpose of the "active" state. The note about using the "popupshown" event for navigation has been updated accordingly.

Keyboard navigation is also linked to the "active" property now, so there is no need to track the state of the "_transitioning" property anymore.

Since the goBack and showSubView methods can only be called when the view is active, we don't need to check for attempts to start a transition while the panel is closed anymore.

MozReview-Commit-ID: 3KT3A5EwGFy
2018-02-27 15:33:33 +00:00
Paolo Amadini
8c8dfa43a5 Bug 1440358 - Part 2 - Add tests for cancellation while opening a view. r=Gijs
This includes both canceling the ViewShowing event and calling the hidePopup method of PanelMultiView.

MozReview-Commit-ID: Goo45SEBC3z
2018-02-25 19:49:00 +00:00
Paolo Amadini
485e61158e Bug 1440358 - Part 1 - Add unit tests for PanelMultiView. r=Gijs
MozReview-Commit-ID: 3WM2Skrg3QV
2018-02-26 13:45:09 +00:00