corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
871,156 Commits 1 Branch 0 Tags
8ab6d14094fa13c56ccc75ed69fc3db6de6f249d
Commit Graph

211 Commits

Author SHA1 Message Date
Nipun Shukla
8ab6d14094 Bug 1794159 - Part 2: Add LAF unlocking and check for pinning status using new APIs r=nalexander,nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D213331
 2024-08-08 02:48:50 +00:00
Sandor Molnar
f5c1f4fe7c Backed out changeset 82cd657ce425 (bug 1906260) for causing mochitest failures @ test_interactive_widget.html & pup wd test failures CLOSED TREE 2024-08-06 18:06:20 +03:00
Dave Townsend
b3f84cff12 Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D217569
 2024-08-06 11:46:07 +00:00
Joel Maher
bd1a0e2de3 Bug 1909759 - s/preferences/settings/ for >= macosx 13.x. r=gbrown 
Differential Revision: https://phabricator.services.mozilla.com/D217835
 2024-07-26 16:22:15 +00:00
Joel Maher
d70349f2c5 Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D214969
 2024-07-09 13:01:55 +00:00
Meg
8f07351683 Bug 1905379 - Clean up set default guidance notification check and update tests r=nrishel,negin 
- Remove redundant check for `regRename` pref when deciding whether to show set default guidance notification
- Update guidance notification test helper to set `setDefaultBrowserUserChoice` to the same value as `...regRename` to make tests that include one-click being enabled more accurate.

These updates should not change the user experience.

Differential Revision: https://phabricator.services.mozilla.com/D215218
 2024-07-03 14:41:46 +00:00
Tamas Szentpeteri
93f27874e0 Backed out changeset 50043205a8aa (bug 1905379) for causing mochitest failures on browser_download_preferred_action.js. CLOSED TREE 2024-07-02 19:20:10 +03:00
Meg
4c468ff89d Bug 1905379 - Clean up set default guidance notification check and update tests r=nrishel 
- Remove redundant check for `regRename` pref when deciding whether to show set default guidance notification
- Update guidance notification test helper to set `setDefaultBrowserUserChoice` to the same value as `...regRename` to make tests that include one-click being enabled more accurate.

These updates should not change the user experience.

Differential Revision: https://phabricator.services.mozilla.com/D215218
 2024-07-02 12:57:53 +00:00
Meg Viar
212619a587 Bug 1903416 - Add a pref to control the display of set default guidance notification r=nrishel,negin 
Add a pref and nimbus variable to control whether users see set to default guidance notifications when one-click set to default is disabled. Windows only.

This patch supports the [[ https://experimenter.services.mozilla.com/nimbus/one-click-set-to-default-new-users/summary | one-click set to default guidance experiment ]].

Differential Revision: https://phabricator.services.mozilla.com/D214700
 2024-06-24 20:50:38 +00:00
Barret Rennie
871e74ca58 Bug 1829412 - Simplify NimbusTestUtils.enrollmentHelper r=chumphreys,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,omc-reviewers,home-newtab-reviewers,thecount,issammani,aminomancer,mconley 
The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.

The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.

Differential Revision: https://phabricator.services.mozilla.com/D212318
 2024-06-06 14:42:00 +00:00
Joel Maher
3318408dfe Bug 1898801 - Fix tests on mac which use python2 to use python3 on macosx 14.x+. r=gbrown 
Differential Revision: https://phabricator.services.mozilla.com/D211604
 2024-05-24 19:45:19 +00:00
Nicholas Rishel
c38ebcec1e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D210247
 2024-05-21 02:37:10 +00:00
Sandor Molnar
0f4b2c2a80 Backed out changeset 6c952a8ea651 (bug 1894865) for causing build bustages @ browser/components/shell/nsWindowsShellServiceInternal.h CLOSED TREE 2024-05-20 22:06:06 +03:00
Nicholas Rishel
2e90f2e33e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D210247
 2024-05-20 18:49:11 +00:00
Barret Rennie
6dbf58c7e9 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys 
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
 2024-05-16 17:15:58 +00:00
Sandor Molnar
0881a06ac2 Backed out changeset c9a936171ae4 (bug 1790428) for causing bc failures @ browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_nimbus_impressions.js CLOSED TREE 2024-05-16 01:29:10 +03:00
Barret Rennie
eeaac588c8 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys 
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
 2024-05-15 19:19:29 +00:00
Cristian Tuns
fc78328f7f Backed out changeset 9db188aa6dac (bug 1790428) for causing bc failures in browser_remotesettingsexperimentloader_remote_defaults.js CLOSED TREE 2024-05-14 18:00:11 -04:00
Barret Rennie
58a50459f7 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys 
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
 2024-05-14 16:18:01 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Michael Hughes
0708cf0525 Bug 1863636 - mochi tests for filename validation to prevent callers of new functions from creating bad file paths r=nshukla,gstoll 
Added in mochi tests to validate that the C++ filename validation for taskbar tab shortcut paths works.

Differential Revision: https://phabricator.services.mozilla.com/D199689
 2024-01-29 22:26:21 +00:00
Joel Maher
3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D198974
 2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-24 16:35:54 +00:00
Michael Hughes
5ea9a03802 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers 
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
 2023-12-01 20:07:08 +00:00
Joel Maher
33fa84a382 Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D193996
 2023-11-21 17:35:23 +00:00
Masatoshi Kimura
8262afb8c6 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D189696
 2023-10-02 19:00:07 +00:00
Noemi Erli
8561f7ec9a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures 
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
 2023-10-02 21:16:25 +03:00
Masatoshi Kimura
89e9a36583 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D189696
 2023-10-02 17:36:27 +00:00
Masatoshi Kimura
c2dc436126 Bug 1845057 - Remove aClaimAllTypes from setDefaultBrowser. r=nrishel,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189678
 2023-10-02 16:56:42 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Masatoshi Kimura
11c3a07046 Bug 1852881 - Stop using MockRegistrar in browser_setDefaultPDFHandler.js. r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D188075
 2023-09-13 18:22:24 +00:00
Masatoshi Kimura
d8eea9e97a Bug 1850631 - Call nsIDefaultAgent directly to set default. r=nrishel,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D187853
 2023-09-13 03:18:46 +00:00
Masatoshi Kimura
25336440d8 Bug 1851596 - await _handleWDBAResult. r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D187845
 2023-09-10 06:44:06 +00:00
Norisz Fay
5d9b700de0 Backed out changeset df18c9cb1487 (bug 1851596) for causing mochitest failure on browser_setDefaultBrowser.js CLOSED TREE 2023-09-10 03:04:19 +03:00
Masatoshi Kimura
625a5be1dc Bug 1851596 - await _handleWDBAResult. r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D187845
 2023-09-09 23:15:51 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
anwar
1d2e079021 Bug 1829673 - Put all mochitest test manifest files under browser/components into alphabetical order. r=mconley,extension-reviewers,credential-management-reviewers,dimi,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D176459
 2023-05-02 16:13:24 +00:00
Barret Rennie
f7a4fadf48 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D172850
 2023-03-30 20:51:58 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
Barret Rennie
32bcefe11c Bug 1820642 - Fix intermittent in browser_setDefaultPDFHandler.js r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D171794
 2023-03-08 18:38:46 +00:00
Barret Rennie
e03ee80902 Bug 1805509 - Add ShellService.setAsDefaultPDFHandler r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D169817
 2023-03-06 20:10:56 +00:00
Sandor Molnar
ffa80a3221 Backed out 4 changesets (bug 1805511, bug 1805509) for causing bc and xpc failures. CLOSED TREE 
Backed out changeset 31a8dcad0d88 (bug 1805509)
Backed out changeset 3dd1735b85fa (bug 1805509)
Backed out changeset 87641a6eee2b (bug 1805509)
Backed out changeset e5bd4ad558f2 (bug 1805511)
 2023-03-02 23:26:06 +02:00
Barret Rennie
e9f8cf042a Bug 1805509 - Add ShellService.setAsDefaultPDFHandler r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D169817
 2023-03-02 20:33:22 +00:00
Sandor Molnar
5ace18f79f Backed out 4 changesets (bug 1805509, bug 1805511) for causing node newtab failures. CLOSED TREE 
Backed out changeset 1c1d335d4ef5 (bug 1805509)
Backed out changeset 0bf2579bccd7 (bug 1805509)
Backed out changeset a87f459f2caa (bug 1805509)
Backed out changeset ae16a9890f22 (bug 1805511)
 2023-03-02 21:03:45 +02:00
Barret Rennie
2da8c2d8dd Bug 1805509 - Add ShellService.setAsDefaultPDFHandler r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D169817
 2023-03-02 18:27:14 +00:00
Gijs Kruitbosch
b965c4660a Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D166179
 2023-01-31 11:48:41 +00:00
Marco Castelluccio
ba39d286d5 Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D165395
 2022-12-23 22:45:46 +00:00
Emilio Cobos Álvarez
0f61b77b68 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers 
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
 2022-12-15 03:11:55 +00:00