Commit Graph

5988 Commits

Author SHA1 Message Date
Perry McManis
ae12db4b36 Bug 1853218 - remove visibility state change log message r=jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D188286
2023-09-15 12:21:31 +00:00
Perry McManis
7fa9e8a074 Bug 1849236 - Send a shopping component displayed Event r=jhirsch,TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D186500
2023-09-12 20:00:05 +00:00
Yifan Zhu
780cd203f2 Bug 1852191 - Only show tooltip when document has focus. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D187749
2023-09-10 12:21:47 +00:00
Gijs Kruitbosch
75a3e19a54 Bug 1847600 - ensure shopping sidebar activeness updates when switching tabs or hiding/showing it, r=emilio,fchasen
Differential Revision: https://phabricator.services.mozilla.com/D187552
2023-09-08 23:05:53 +00:00
Gijs Kruitbosch
97007df73d Bug 1846787 - let shopping code ride the train (disabled by default), r=jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D187779
2023-09-08 17:04:40 +00:00
Perry McManis
70723bc8b9 Bug 1851036 - Add events for displaying the shopping component's address bar icon r=Gijs,TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D187230
2023-09-08 13:43:17 +00:00
Niklas Baumgardner
7f0d05b4aa Bug 1849159 - Toolbar button should hide when opted out. r=shopping-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D187052
2023-09-07 20:55:48 +00:00
Mike Kaply
068962bb83 Bug 1851525 - Allow Firefox View icon to be set via Nimbus. r=sclements,desktop-theme-reviewers,fxview-reviewers,dao,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D187458
2023-09-07 18:01:32 +00:00
Niklas Baumgardner
c5fbb6799f Bug 1849685 - Shopping button should only show if current browser is a product page. r=shopping-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D187326
2023-09-07 01:55:15 +00:00
Fred Chasen
ffc98e6ccc Bug 1846768 - Re-request analysis on reloads. r=shopping-reviewers,Gijs
When a reload flag is passed, bypass the same URI check and request an analysis for the reloaded product again.

Differential Revision: https://phabricator.services.mozilla.com/D187251
2023-09-06 19:13:38 +00:00
Sandor Molnar
be8235207e Backed out changeset 91e76d818152 (bug 1849159) causing bc failures in browser/components/shopping/tests/browser/browser_shopping_urlbar.js CLOSED TREE 2023-09-06 17:47:09 +03:00
Sandor Molnar
3898c4b253 Backed out changeset f5f15b313e48 (bug 1851525) for causing bc failures in browser/base/content/test/performance/browser_startup_images.js 2023-09-06 17:46:35 +03:00
Niklas Baumgardner
a15ddd6a40 Bug 1849159 - Toolbar button should hide when opted out. r=shopping-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D187052
2023-09-06 13:41:37 +00:00
Mike Kaply
399f06dfdf Bug 1851525 - Allow Firefox View icon to be set via Nimbus. r=sclements,desktop-theme-reviewers,fxview-reviewers,dao,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D187458
2023-09-06 13:41:27 +00:00
Stanca Serban
873b7d7a4a Backed out changeset 4ced56d93af6 (bug 1849159) for causing mochitests failures in browser_stale_product.js. CLOSED TREE 2023-09-05 19:54:32 +03:00
Niklas Baumgardner
acdc4fbb1b Bug 1849159 - Toolbar button should hide when opted out. r=shopping-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D187052
2023-09-05 14:38:14 +00:00
Sarah Clements
6bde708b88 Bug 1851453 - Disable notification dot in firefox view r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D187372
2023-09-04 14:17:18 +00:00
Paul Zuehlcke
01d5b71c28 Bug 1851163 - Remove obsolete felt privacy (2022) prefs. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D187275
2023-09-04 08:36:02 +00:00
Shane Hughes
f947fd1418 Bug 1846044 - Implement Shopping Sidebar auto-activation behavior. r=shopping-reviewers,omc-reviewers,jhirsch,Mardak
If the user has not opted in, automatically set the sidebar to `active` if:
1. The sidebar has not already been automatically set to `active` twice.
2. It's been at least 24 hours since the user last saw the sidebar because
   of this auto-activation behavior.
3. The sidebar was not already auto-activated in this session. This is
   unlikely to come into play for most users, since this only executes on
   startup and when the `enabled` Nimbus variable changes.

Also, if the user has still not opted in at the end of the session, and
we auto-activated the sidebar for them, auto-close the sidebar on
shutdown. This means we show the onboarding to the user automatically in
each PDP for up to 2 sessions. After that, if the user still has not
opted in, we will stop trying.

Differential Revision: https://phabricator.services.mozilla.com/D184994
2023-08-31 19:50:58 +00:00
John Schanck
703bd4d439 Bug 1823720 - prevent some fullscreen states while WebAuthn prompts are shown. r=edgar,keeler
This prevents fullscreen states that hide chrome while WebAuthn prompts are shown. Specifically, it
  1) ensures that the navigation toolbox is shown in fullscreen windows, and
  2) disallows fullscreen DOM elements.

Differential Revision: https://phabricator.services.mozilla.com/D187001
2023-08-29 22:39:45 +00:00
DJ
cff3198b49 Bug 1846583 - remove pocket button and bookmarks bar from PBM. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D186145
2023-08-17 20:21:20 +00:00
Erik Nordin
fe6e7847b3 Bug 1842369 - Ensure Translations button is hidden in reader mode r=gregtatum
Previously the translations button would stay visible in reader
mode but no interact with the page when clicked. This patch
ensures that the translations button is no longer visible
once a user enters reader mode.

Differential Revision: https://phabricator.services.mozilla.com/D185607
2023-08-15 18:40:37 +00:00
Sean Feng
28b60a5bda Bug 1846714 - Make the newtab button to not handle click event if the menu is open r=Gijs
If the menu is opened, the corresponding `mouseup` event that generates
this `click` event will be handled by the menuitem, so we don't
need to handle this `click` event.

Differential Revision: https://phabricator.services.mozilla.com/D185465
2023-08-11 15:29:47 +00:00
Eemeli Aro
9bef605113 Bug 1834305 - Remove intl/locale/PluralForm.sys.mjs as unused. r=nordzilla,devtools-reviewers
This library is now completely unused in m-c.

Differential Revision: https://phabricator.services.mozilla.com/D185699
2023-08-10 20:39:20 +00:00
Gijs Kruitbosch
4aef5fd2de Bug 1842252 - use correct destruction callback and improve handling of hiding the sidebar, r=jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D185310
2023-08-05 16:12:02 +00:00
Stanca Serban
b8c2426c52 Backed out 3 changesets (bug 1842252) for causing mochitests failures in browser_shopping_urlbar.js.
Backed out changeset a39a276eba75 (bug 1842252)
Backed out changeset a9ddfdc1aeb0 (bug 1842252)
Backed out changeset 0974a625881c (bug 1842252)
2023-08-05 14:43:35 +03:00
Gijs Kruitbosch
cce2ce2fc9 Bug 1842252 - use correct destruction callback and improve handling of hiding the sidebar, r=jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D185310
2023-08-05 10:30:26 +00:00
Noemi Erli
4073f5cb3e Backed out 3 changesets (bug 1842252) for causing failures in browser_shopping_integration.js CLOSED TREE
Backed out changeset bf3153aac104 (bug 1842252)
Backed out changeset 2fbeb8b11917 (bug 1842252)
Backed out changeset 5b3d1da13031 (bug 1842252)
2023-08-04 17:16:39 +03:00
Fred Chasen
6b34194f99 Bug 1846750 - Only enable ShoppingSidebarManager on Nighly builds r=shopping-reviewers,Gijs
Updates ShoppingSidebarManager init, uninit and onLocationChange to only be called when AppConstants.NIGHTLY_BUILD is true.

Differential Revision: https://phabricator.services.mozilla.com/D185369
2023-08-04 13:01:09 +00:00
Gijs Kruitbosch
0590f4e7fb Bug 1842252 - use correct destruction callback and improve handling of hiding the sidebar, r=jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D185310
2023-08-04 10:18:44 +00:00
Gregory Pappas
37dc90e72c Bug 1846845 - Remove some unneeded isPlatformAndVersionAtLeast checks r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D185221
2023-08-02 22:30:37 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Fred Chasen
a51c5cc0a6 Bug 1840156 - Shopping urlbar button r=shopping-reviewers,fluent-reviewers,desktop-theme-reviewers,Gijs,flod,jhirsch
- Adds a urlbar button to toggle shopping sidebars and show sidebar state
- ShoppingSidebarParent.toggleAllSidebars() method to open and close sidebars
- Adds `browser.shopping.experience2023.active` pref to store the state of all sidebars
- Sidebars open and close based on state of the active pref

Differential Revision: https://phabricator.services.mozilla.com/D183394
2023-08-01 22:11:15 +00:00
Jared Hirsch
7bfd0c2540 Bug 1840518 - Disable shopping experience if users opt out via settings r=shopping-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D184252
2023-07-26 15:33:40 +00:00
Jared Hirsch
16d2d53d34 Bug 1842913 - Update parent window code to check optedIn pref r=shopping-reviewers,Gijs
Also fixes bug 1844106, "Update shopping container to display onboarding
based on optedIn pref".

Differential Revision: https://phabricator.services.mozilla.com/D184129
2023-07-26 15:01:07 +00:00
Stanca Serban
99c6dd0599 Backed out changeset c2a7f1a6f481 (bug 1842913) as requested by dev for eventually failing the linter. CLOSED TREE 2023-07-26 17:11:08 +03:00
Jared Hirsch
267e129e2f Bug 1842913 - Update parent window code to check optedIn pref r=shopping-reviewers,Gijs
Also fixes bug 1844106, "Update shopping container to display onboarding
based on optedIn pref".

Differential Revision: https://phabricator.services.mozilla.com/D184129
2023-07-26 13:41:55 +00:00
Mathew Hodson
28aa899942 Bug 1564391 - Rename internal uses of mozInputSource. r=emilio,pip-reviewers,tabbrowser-reviewers,dao,kpatenio
This allows us to deprecate `mozInputSource` for the Web while
avoiding console warnings for internal uses, which now use the
ChromeOnly `inputSource` attribute.

Differential Revision: https://phabricator.services.mozilla.com/D183643
2023-07-26 09:27:45 +00:00
Jared Hirsch
7ebd1ba5ee Bug 1840847 - Switch shopping sidebar to use Actors for product URL messaging. r=Gijs
Also closes bug 1844101 and bug 1844097.

Differential Revision: https://phabricator.services.mozilla.com/D184048
2023-07-25 13:29:58 +00:00
Calixte
a618a7cc5d Bug 1844530 - Add an option to filter pdf files in the file chooser r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D184092
2023-07-21 06:59:05 +00:00
Emilio Cobos Álvarez
3b3b822f77 Bug 1844242 - Clean-up windows titlebar set-up now that buttons are always non-native. r=dao,handyman
Differential Revision: https://phabricator.services.mozilla.com/D183986
2023-07-20 13:33:19 +00:00
Gijs Kruitbosch
6ff71185f9 Bug 1842215 - handle pushState navigations between shopping pages, r=shopping-reviewers,jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D184006
2023-07-20 12:20:45 +00:00
Sarah Clements
a64e5d3f38 Bug 1820660 - Persist recently closed tabs between sessions r=dao,sfoster,extension-reviewers,sessionstore-reviewers,robwu
* For cases where a user does not have automatic session restore enabled, recently closed
tabs will persist between sessions and previously open tabs will be added to the recently closed tabs
list; upon manual session restore, the previously open tabs will reopen and be removed from the closed tabs list

* Add marionette test and fix test bustages due to these changes.

Differential Revision: https://phabricator.services.mozilla.com/D178521
2023-07-18 10:40:00 +00:00
Dão Gottwald
bbec0cb63b Bug 1705215 - Stop resizing all background browsers when showing the bookmarks toolbar only on the new tab page. r=Gijs,tabbrowser-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D183493
2023-07-17 15:59:59 +00:00
Jared Hirsch
23a69be0e9 Bug 1838635 - Disable shopping experience in private browsing mode. r=shopping-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D183043
2023-07-12 14:25:00 +00:00
Sam Foster
b23b17ffa1 Bug 1819675 - Include tabs from all windows in all views of recently-closed tabs and re-open them into the current window. r=dao,sclements,fxview-reviewers,fluent-reviewers,flod,robwu,sessionstore-reviewers,tabbrowser-reviewers
* Menu Bar History menu recently-closed tab items includes closed tabs from all currently-open windows
* Toolbar/Appmenu history menu recently-closed tabs list includes closed tabs from all currently-open windows
* Firefox view recently-closed tab list includes closed tabs from all currently-open windows
* All recently-closed tab menu/items re-open in the current window
* Re-open all tabs menu item re-opens all tabs into the current window

* Ensure we filter out tabs without any useful state in firefox-view
* Add a target window argument to undoCloseTab and undoCloseById
* undoCloseTab will remove the tab data from the source window collection and re-open the tab into the target window
* Add an options argument to SessionStore.getWindows to get all private or non-private windows
* Add a getWindowForTabClosedId method on SessionStore, allowing look-up of the window associated with a closed tab
* Ensure recently-closed tab lists only include tabs from non-private windows when attached (i.e. opened from) a non-private window. And vice-versa.
* Update the sessionstore closed tab tests to assert on the new behavior

* Update the browser.sessions.restore implementation to always find and pass the source window when restoring a closed tab
* sessions.restore should always restore closed tabs to the source window as there's no implicit top or current window in the API context

Differential Revision: https://phabricator.services.mozilla.com/D174501
2023-07-06 22:49:52 +00:00
Cosmin Sabou
a41e837bdf Backed out 2 changesets (bug 1819675) for causing a spike in wpt and browser-chrome failures.
Backed out changeset aa4368bfb81a (bug 1819675)
Backed out changeset e5be8edfd9cf (bug 1819675)
2023-07-08 13:44:40 +03:00
Jared Hirsch
338186d62d Bug 1840852 - Use shopping toolkit isProductURL check to decide whether to open the shopping sidebar. r=shopping-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D183014
2023-07-07 18:24:46 +00:00
Dão Gottwald
d5c2d8dccd Bug 713713 - Expand BrowserWindowTracker.openWindow to cover the use cases of OpenBrowserWindow, and remove BrowserUIUtils.openNewBrowserWindow. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D182557
2023-07-07 12:15:35 +00:00
Sam Foster
5ddefef54e Bug 1819675 - Include tabs from all windows in all views of recently-closed tabs and re-open them into the current window. r=dao,sclements,fxview-reviewers,fluent-reviewers,flod,robwu,sessionstore-reviewers,tabbrowser-reviewers
* Menu Bar History menu recently-closed tab items includes closed tabs from all currently-open windows
* Toolbar/Appmenu history menu recently-closed tabs list includes closed tabs from all currently-open windows
* Firefox view recently-closed tab list includes closed tabs from all currently-open windows
* All recently-closed tab menu/items re-open in the current window
* Re-open all tabs menu item re-opens all tabs into the current window

* Ensure we filter out tabs without any useful state in firefox-view
* Add a target window argument to undoCloseTab and undoCloseById
* undoCloseTab will remove the tab data from the source window collection and re-open the tab into the target window
* Add an options argument to SessionStore.getWindows to get all private or non-private windows
* Add a getWindowForTabClosedId method on SessionStore, allowing look-up of the window associated with a closed tab
* Ensure recently-closed tab lists only include tabs from non-private windows when attached (i.e. opened from) a non-private window. And vice-versa.
* Update the sessionstore closed tab tests to assert on the new behavior

* Update the browser.sessions.restore implementation to always find and pass the source window when restoring a closed tab
* sessions.restore should always restore closed tabs to the source window as there's no implicit top or current window in the API context

Differential Revision: https://phabricator.services.mozilla.com/D174501
2023-07-06 22:49:52 +00:00