Commit Graph

4541 Commits

Author SHA1 Message Date
Christoph Kerschbaumer
72e1ad4898 Bug 1490874: Log Principal based Security Errors to the Security pane in the console. r=smaug 2018-09-24 09:34:04 +02:00
Rob Wu
7b1069666e Bug 1393570 - Set allowInheritPrincipal=false by default r=Gijs,glandium
This change prevents javascript:-URLs from being passed at the command
line. This restriction was already applied to every URL but the first.
Even the first URL did not result in any visible effect when Firefox is
started. Yet somehow the PGO profiler script managed to rely on it.

This commit ensures that "javascript:" URLs are not activated regardless of
position in the command line, and switches to a data:-URL for the PGO script to
achieve the (previously) desired effect of quitting the browser on startup.

Depends on D4929

Differential Revision: https://phabricator.services.mozilla.com/D5958
2018-09-18 11:54:44 +00:00
Rob Wu
d3b588550f Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl
Other (internal API) changes besides extension API changes:

- This also introduces support for opening a window with multiple tabs
  in a non-default container tab.

- This also adds LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL to the
  gBrowser.loadTabs call, unless allowInheritPrincipal is set.
  For backwards-compatibility, this flag defaults to true.

Depends on D4928

Differential Revision: https://phabricator.services.mozilla.com/D4929
2018-09-19 10:57:48 +00:00
Dragana Damjanovic
fe9c8db4c3 Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus 2018-09-22 23:54:11 +03:00
Preeti Mukherjee
02080b373a Bug 1492419 - Remove BrowserGoHome in favor of BrowserHome; r=dao
Differential Revision: https://phabricator.services.mozilla.com/D6484
2018-09-21 12:31:45 +00:00
Gurzau Raul
b5bc7bfc3d Backed out changeset dc225279994a (bug 1473736) for web platform leaks 2018-09-21 04:30:10 +03:00
Dragana Damjanovic
49db0c9629 Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
Implement necko part of ESNI

Differential Revision: https://phabricator.services.mozilla.com/D2716
2018-09-20 20:53:28 +00:00
Mark Banner
c9b1edf1ef Bug 1491253 - Link the UrlbarController with the input and the view. r=dao
This links together the controller with the input and view. It moves the fake results generation to the controller. As a result, there is now an input -> controller -> view round-trip in place.

Also hooks up the input with determining if we're in private browsing mode or not.

Differential Revision: https://phabricator.services.mozilla.com/D6261
2018-09-20 13:07:18 +00:00
Coroiu Cristina
3a644e295c Backed out changeset 261d22d6d396 (bug 1491253) for browser-chrome failures at browser/base/content/test/static/browser_all_files_referenced.js on a CLOSED TREE 2018-09-20 14:22:58 +03:00
Mark Banner
16df3be46d Bug 1491253 - Link the UrlbarController with the input and the view. r=dao
This links together the controller with the input and view. It moves the fake results generation to the controller. As a result, there is now an input -> controller -> view round-trip in place.

Also hooks up the input with determining if we're in private browsing mode or not.

Differential Revision: https://phabricator.services.mozilla.com/D6261
2018-09-20 10:11:47 +00:00
Jonathan Kingston
adaa868721 Bug 1485305 - browser/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4551
2018-08-29 15:43:27 +01:00
Brindusan Cristian
6c0094d53f Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston
52a379b132 Bug 1485305 - browser/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4551
2018-08-29 15:43:27 +01:00
arthur.iakab
f36e6bf3d0 Backed out 10 changesets (bug 1485305)for failing browser chrome tests on browser_loadDisallowInherit.js
Backed out changeset 138b8596a9cd (bug 1485305)
Backed out changeset d9f04aeeeef7 (bug 1485305)
Backed out changeset cd063d8afe4e (bug 1485305)
Backed out changeset 2f8a5a03ccb5 (bug 1485305)
Backed out changeset 8085d1eefd7c (bug 1485305)
Backed out changeset 3aaccb374a59 (bug 1485305)
Backed out changeset 3a111e9e5c9c (bug 1485305)
Backed out changeset 61aa1cfb0b01 (bug 1485305)
Backed out changeset bca973d90acc (bug 1485305)
Backed out changeset 4eb33bf25d6f (bug 1485305)
2018-09-18 20:30:07 +03:00
Jonathan Kingston
b7aabac2a5 Bug 1485305 - browser/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4551
2018-08-29 15:43:27 +01:00
Gijs Kruitbosch
5cf14463b7 Bug 1491243 - remove subscribe button, menu items and subscription section out of feed previews, r=florian
This removes subscribe UI and functionality from the main browser window,
the page info window, and from feed previews. It may leave some stray strings
in subscribe.properties/dtd, which will be removed in bug 1477669 when the
preview code goes away completely.

Differential Revision: https://phabricator.services.mozilla.com/D5982
2018-09-18 06:06:27 +00:00
Coroiu Cristina
7711c0dc3c Backed out changeset d61965849528 (bug 1491243) for en-US failures at testing\firefox-ui\tests\puppeteer\test_page_info_window.py 2018-09-17 22:23:58 +03:00
Gijs Kruitbosch
8b64dcadcd Bug 1491243 - remove subscribe button, menu items and subscription section out of feed previews, r=florian
This removes subscribe UI and functionality from the main browser window,
the page info window, and from feed previews. It may leave some stray strings
in subscribe.properties/dtd, which will be removed in bug 1477669 when the
preview code goes away completely.

Differential Revision: https://phabricator.services.mozilla.com/D5982
2018-09-17 18:06:05 +00:00
Gijs Kruitbosch
9c681e0239 Bug 1488822 - propagate allowScriptsToClose via the frameloader instead of relying on frame scripts, r=mconley,kmag,nika
Differential Revision: https://phabricator.services.mozilla.com/D5775
2018-09-15 08:26:33 +00:00
Noemi Erli
b3cd3ce8e4 Merge inbound to mozilla-central. a=merge 2018-09-14 01:01:37 +03:00
Dão Gottwald
d569ccf386 Bug 1477985 - Implement basic UrlbarInput and UrlbarView classes and a hidden pref for using them. r=standard8 2018-09-13 18:38:07 +02:00
Marco Bonardo
9186784257 Bug 1488296 - Race condition when setting favicons for a browser with a changed currentURI. r=mossop
There is a race condition between the time we decide to fetch an icon and the time we actually store that icon, where the original browser currentURI may have changed.

Differential Revision: https://phabricator.services.mozilla.com/D5685
2018-09-13 13:24:41 +00:00
Daniel Varga
ea804b7559 Merge mozilla-inbound to mozilla-central. a=merge 2018-09-13 05:30:59 +03:00
Dorel Luca
adcc065da0 Backed out changeset fddb4d2af447 (bug 1488296) for browser-chrome failures on browser/components/originattributes/test/browser/browser_favicon_userContextId.js 2018-09-13 01:51:59 +03:00
Marco Bonardo
7cd74b4ce6 Bug 1488296 - Race condition when setting favicons for a browser with a changed currentURI. r=mossop
There is a race condition between the time we decide to fetch an icon and the time we actually store that icon, where the original browser currentURI may have changed.

Differential Revision: https://phabricator.services.mozilla.com/D5685
2018-09-12 17:07:15 +00:00
Shane Caraveo
d6623e6be7 Bug 1488055 fix loading ext-browser-content script in sidebar when browser_style=false, r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D5196
2018-09-12 18:52:52 +00:00
Coroiu Cristina
520dc59463 Backed out 2 changesets (bug 1393570) for build bustage on linux on a CLOSED TREE
Backed out changeset 23f496cd8a42 (bug 1393570)
Backed out changeset e41e69aa9eb5 (bug 1393570)
2018-09-12 20:40:27 +03:00
Rob Wu
b5d13cea2a Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl
Other (internal API) changes besides extension API changes:

- This also introduces support for opening a window with multiple tabs
  in a non-default container tab.

- This also adds LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL to the
  gBrowser.loadTabs call, unless allowInheritPrincipal is set. Currently
  there are no callers that set this flag, but in case it's desired,
  I added an opt-in via window.arguments[10] in browser.xul/js.

  For single-argument URLs, the flag is an opt-out, since there are
  multiple callers that rely on principal inheritance (bug 1475201).

Depends on D4928

Differential Revision: https://phabricator.services.mozilla.com/D4929
2018-09-12 15:15:22 +00:00
Preeti Mukherjee
0a8688b209 Bug 1489765 - Remove getBoolPref function from utilityOverlay.js. r=dao 2018-09-12 01:18:18 +02:00
Cosmin Sabou
3d2444653d Merge mozilla-inbound to mozilla-central. a=merge 2018-09-11 13:06:37 +03:00
Dipen Patel
fbf2d8d5d9 Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=Gijs,snorp,jcj,mcmanus,sfraser,keeler,baku,ato
Move all fields of nsISSLStatus to nsITransportSecurityProvider
Remove nsISSLStatus interface and definition
Update all code and test references to nsISSLStatus
Maintain ability to read in older version of serialized nsISSLStatus.  This
is verified with psm_DeserializeCert gtest.

Differential Revision: https://phabricator.services.mozilla.com/D3704
2018-09-11 00:07:30 +00:00
Csoregi Natalia
4c04e1f45b Backed out changeset bd8baf88f373 (bug 1468222) for test_security-info-parser.js failures. CLOSED TREE 2018-09-08 03:16:25 +03:00
Dipen Patel
8e9fd08fb5 Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=snorp,ato,sfraser,keeler,baku,mcmanus,Gijs
Move all fields of nsISSLStatus to nsITransportSecurityProvider
Remove nsISSLStatus interface and definition
Update all code and test references to nsISSLStatus
Maintain ability to read in older version of serialized nsISSLStatus.  This
is verified with psm_DeserializeCert gtest.

Differential Revision: https://phabricator.services.mozilla.com/D3704
2018-09-07 22:50:17 +00:00
Luca Greco
0967b35e40 Bug 1433334 - Store the install source of the extensions for telemetry. r=aswan
- Implemented stored "install source of the extensions" for telemetry events.
- Added test assertions related to the expected install and addon installTelemetryInfo.
- Added installTelemetryInfo to addon installed from "drag-and-drop" file urls on Firefox Desktop.

Differential Revision: https://phabricator.services.mozilla.com/D4445
2018-09-07 19:08:14 +00:00
Dorel Luca
def124f1cd Backed out changeset f105be1abab0 (bug 1477985) for browser-chrome failures on browser/base/content/test/performance/browser_urlbar_search.js. CLOSED TREE 2018-09-12 22:59:14 +03:00
Dão Gottwald
7e4b71897d Bug 1477985 - Implement basic UrlbarInput and UrlbarView classes and a hidden pref for using them. r=standard8 2018-09-12 20:47:03 +02:00
Coroiu Cristina
7eaf5bd4a0 Backed out 2 changesets (bug 1393570) for build bustage on linux on a CLOSED TREE
Backed out changeset 23f496cd8a42 (bug 1393570)
Backed out changeset e41e69aa9eb5 (bug 1393570)
2018-09-12 20:40:27 +03:00
Rob Wu
886b08d264 Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl
Other (internal API) changes besides extension API changes:

- This also introduces support for opening a window with multiple tabs
  in a non-default container tab.

- This also adds LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL to the
  gBrowser.loadTabs call, unless allowInheritPrincipal is set. Currently
  there are no callers that set this flag, but in case it's desired,
  I added an opt-in via window.arguments[10] in browser.xul/js.

  For single-argument URLs, the flag is an opt-out, since there are
  multiple callers that rely on principal inheritance (bug 1475201).

Depends on D4928

Differential Revision: https://phabricator.services.mozilla.com/D4929
2018-09-12 15:15:22 +00:00
Dale Harvey
02db992aaa Bug 1478348 - Dont show doorhanger on about:newtab. r=johannh
MozReview-Commit-ID: EmHV3OS6Kra
2018-09-12 16:15:03 +01:00
Dão Gottwald
d7912f3fa1 Bug 1489552 - Let BrowserWindowTracker.getTopWindow use the module's internal window list instead of nsIWindowMediator::getZOrderDOMWindowEnumerator / getMostRecentWindow. r=nhnt11 2018-09-10 22:27:38 +02:00
Oriol Brufau
62eb4954f7 Bug 1401610 - Add "Remove Extension" context menu item to browserAction. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D3565
2018-09-05 10:02:52 +00:00
Rob Wu
1018b8cd58 Bug 1415333 - Set correct userContextId at window creation r=Gijs
The container tab indicator should also be set on the tab, not just on
the browser. Otherwise it is possible for the indicator to be missing
when a new window is opened.

And previously, if the URL was an "about:blank" URL, the tab in the new
window would use the default container because of the early return in
_handleURIToLoad. This is fixed by accounting for window.arguments[6]
when initializing the default (about:blank) tab in the tabbrowser.

Unit tests for these code path will be added in bug 1393570.

Differential Revision: https://phabricator.services.mozilla.com/D4920
2018-09-05 09:39:56 +00:00
Gijs Kruitbosch
78e12eb7a8 Bug 1337794 - remove obsolete pagehide handling hacks from browser.js r=mconley
The pagehide handler has been as dead as a doornail for a while now,
but the side-effect of forcing the creation of an about:blank document
in non-remote windows was implicitly relied upon by some tests.

This removes the dead code and fixes up some tests.

Differential Revision: https://phabricator.services.mozilla.com/D4962
2018-09-04 17:55:05 +00:00
Gijs Kruitbosch
fb25f8415a Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466
2018-09-03 14:43:38 +01:00
Margareta Eliza Balazs
c9b513d70b Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-08-31 12:27:44 +03:00
Margareta Eliza Balazs
e835f67a30 Backed out changeset 96b5a88ac004 (bug 1486824) for causing frequent failures e.g: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js a=backout 2018-08-31 12:17:27 +03:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Gijs Kruitbosch
fa5a2cb49a Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466
2018-08-30 15:07:36 +00:00
Gurzau Raul
25380ab82e Merge inbound to mozilla-central. a=merge 2018-08-31 00:49:36 +03:00
Dave Townsend
6f808d6f9a Bug 1487437: Only show a space for a pending icon if it started loading while the throbber was showing. r=dao.
This stops us from showing a pending space when an icon is added after loading is
complete causing us to shift the title when both pending and previous icon are
shown.

Differential Revision: https://phabricator.services.mozilla.com/D4694
2018-08-30 16:58:44 +00:00