Commit Graph

4489 Commits

Author SHA1 Message Date
Makoto Kato
69e594563d Bug 1769907 - Don't register desktop's SelectChild and SelectParent in GeckoView. r=geckoview-reviewers,agi
Actually, GeckoView registers both desktop and mobile actor for `<select>`
element. It is unnecessary to use desktop's `<select>` actor.

But, if GeckoView doesn't register desktop's `<select>` actor,
`layout/forms/test/test_select_reframe.html` will be failure since GV doesn't
handle `mozhidedropdown` that is a event when the control is unbinded from
layout tree.

So we need to handle this for this situation that is one of dismissed cases.

Differential Revision: https://phabricator.services.mozilla.com/D149526
2022-06-22 05:27:28 +00:00
Mark Banner
e731bc0930 Bug 1771173 - Fix/ignore some duplicate imports caught by the new valid-lazy rule. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D149715
2022-06-21 20:42:14 +00:00
Sammy Khamis
1b33077f58 Bug 1773154 - Reduce number of scheduled sync calls in sync-after-tab-change r=markh,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D148871
2022-06-21 20:17:22 +00:00
Mirko Brodesser
b37aba2072 Bug 1744524: part 1) Add JS code for the "Paste" menupopup to handle ClipboardReadTextPaste events created from the C++ side. r=edgar,Gijs
Implements showing a "Paste" popup at the last mouse position (which
overlapped the browser window) when a certain custom event is received.
Creating and dispatchting that event is implemented in one of the
following parts.

Differential Revision: https://phabricator.services.mozilla.com/D135333
2022-06-16 14:43:40 +00:00
Tooru Fujisawa
62aa93946a Bug 1608282 - Part 4: Remove Cu.defineLazyGlobalGetters from JSM. r=webdriver-reviewers,extension-reviewers,jdescottes,kmag
Depends on D149196

Differential Revision: https://phabricator.services.mozilla.com/D149197
2022-06-16 00:19:54 +00:00
Tooru Fujisawa
8f9bf2f553 Bug 1608282 - Part 3: Remove Cu.importGlobalProperties from JSM. r=extension-reviewers,kmag
Depends on D149195

Differential Revision: https://phabricator.services.mozilla.com/D149196
2022-06-16 00:19:54 +00:00
Butkovits Atila
0642580e74 Backed out 4 changesets (bug 1608282) for causing hazard failures. CLOSED TREE
Backed out changeset 32aebc8be201 (bug 1608282)
Backed out changeset 37c970364269 (bug 1608282)
Backed out changeset ced8d82cc2d2 (bug 1608282)
Backed out changeset e26e480c7dd6 (bug 1608282)
2022-06-16 03:10:02 +03:00
Tooru Fujisawa
b3d40a272f Bug 1608282 - Part 4: Remove Cu.defineLazyGlobalGetters from JSM. r=webdriver-reviewers,extension-reviewers,jdescottes,kmag
Depends on D149196

Differential Revision: https://phabricator.services.mozilla.com/D149197
2022-06-15 20:34:35 +00:00
Tooru Fujisawa
a4b321722f Bug 1608282 - Part 3: Remove Cu.importGlobalProperties from JSM. r=extension-reviewers,kmag
Depends on D149195

Differential Revision: https://phabricator.services.mozilla.com/D149196
2022-06-15 20:34:35 +00:00
Sean Burke
9471bef671 Bug 1343826 - Return updated timezone on system timezone change. r=smaug,mstange,stransky,handyman
Differential Revision: https://phabricator.services.mozilla.com/D146725
2022-06-14 19:41:30 +00:00
Haik Aftandilian
80186ba9cb Bug 1773207 - "libgmpopenh264.dylib" can't be opened because Apple cannot check it for malicious software r=media-playback-reviewers,kinetik
Use the correct function name (delMacXAttr vs removeMacXAttr) to remove the com.apple.quarantine extended attribute from downloaded plugin files.

Add test code to ensure extracted plugin files do not have the quarantine attribute.

Differential Revision: https://phabricator.services.mozilla.com/D148739
2022-06-09 05:06:54 +00:00
Tooru Fujisawa
ed8615e2b9 Bug 1772099 - Part 12: Use plain object for lazy getter in toolkit/modules/AppConstants.jsm. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D147938
2022-06-08 13:01:35 +00:00
Tooru Fujisawa
b482d0cb73 Bug 1772099 - Part 5: Use plain object for lazy getter in toolkit/modules/. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D147931
2022-06-07 04:29:50 +00:00
Tooru Fujisawa
a169e1bd48 Bug 1772099 - Part 4: Use plain object for lazy getter in toolkit/modules/subprocess/. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D147930
2022-06-07 04:29:50 +00:00
Tooru Fujisawa
1009028a48 Bug 1772099 - Part 3: Use plain object for lazy getter in toolkit/modules/sessionstore/. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D147929
2022-06-07 04:29:49 +00:00
Tooru Fujisawa
ebcb6dfd9c Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 04:42:10 +00:00
Tooru Fujisawa
f947410342 Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 04:42:09 +00:00
Tooru Fujisawa
bf94464e91 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D148164
2022-06-06 04:42:08 +00:00
Tooru Fujisawa
3e483c26e8 Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148160
2022-06-06 04:42:06 +00:00
Tooru Fujisawa
c56eb55371 Bug 1772313 - Part 5: Stop calling ChromeUtils.defineModuleGetter for Services. r=kmag,webcompat-reviewers,pip-reviewers,denschub,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D148158
2022-06-06 04:42:06 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
81758ebac5 Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 02:49:14 +00:00
Tooru Fujisawa
b580e51d8f Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 02:49:13 +00:00
Tooru Fujisawa
6ed0357d29 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D148164
2022-06-06 02:49:12 +00:00
Tooru Fujisawa
c98ea942de Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148160
2022-06-06 02:49:10 +00:00
Tooru Fujisawa
dae44f3ce8 Bug 1772313 - Part 5: Stop calling ChromeUtils.defineModuleGetter for Services. r=kmag,webcompat-reviewers,pip-reviewers,denschub,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D148158
2022-06-06 02:49:10 +00:00
Dana Keeler
88d8e888f0 Bug 1769669 - require specifying the trusted root in content signature verifier r=jschanck,leplatrem,robwu,barret
Before this patch, the content signature verifier
(nsIContentSignatureVerifier/ContentSignatureVerifier) would identify the root
it trusted based on the value of a preference. This patch changes the
implementation to require a specified hard-coded root to trust as with add-on
signature verification.

Depends on D146644

Differential Revision: https://phabricator.services.mozilla.com/D146645
2022-06-03 23:26:28 +00:00
Sergey Galich
cd8b1906ac Bug 1771841 - use HTMLInputElement.isInstance(field) instead of ChromeUtils.getClassName(field) === "HTMLInputElement". r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D147712
2022-05-31 12:39:18 +00:00
Tooru Fujisawa
135b53d7f4 Bug 1771464 - Do not export lazy getter "SubprocessImpl" from Subprocess.jsm r=Gijs
SubprocessImpl is a lazy getter, and it cannot be exported once ESM-ified.

Depends on D147596

Differential Revision: https://phabricator.services.mozilla.com/D147597
2022-05-30 20:50:23 +00:00
Gabriel Luong
71f1656cb5 Bug 1738012 - Fetch content meta data only after the page is loaded. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D129733
2022-05-30 17:46:02 +00:00
Tooru Fujisawa
a7eb584232 Bug 1610653 - Part 11: Do not use global this property assignment to define global variable in toolkit/. r=Standard8,extension-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D144118
2022-05-30 15:19:39 +00:00
Gijs Kruitbosch
1d925a3a2d Bug 1738574 - add an option to put downloads in tmp to start with, r=mak,mkaply,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D146719
2022-05-24 12:54:42 +00:00
Mathieu Leplatre
57f5978d20 Bug 1702759 - Remove load_dump preference r=robwu
This is a breaking change. It is not possible to control the loading of dumps from a preference anymore.

Dumps are only loaded if server is pointed at PROD. The recommended way to prevent dumps loading in tests is to store a high timestamp in the local DB.

Differential Revision: https://phabricator.services.mozilla.com/D146049
2022-05-23 16:24:58 +00:00
Mathieu Leplatre
d4a89f2c4b Bug 1702759 - Remove bucket name preference r=robwu
This introduces a breaking change: the buckets cannot be changed via preferences anymore.

Before landing this patch, we should have a released a new version of the Remote Settings DevTools that is compatible with this new API.

Differential Revision: https://phabricator.services.mozilla.com/D145455
2022-05-23 16:24:57 +00:00
ui.sayuree
e67bae715c Bug 1007656 - Have Log.jsm handle nsIStackFrame instances. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D146375
2022-05-19 05:43:45 +00:00
Andreas Farre
16fb77fbb8 Bug 1766232 - Remove tests using Services.mainThreadEventTarget. r=smaug
These test were intended to use the planned, but dropped, one thread
per TabGroup feature. They used to dispatch timer callbacks to the
system group to test the labelling needed, but since TabGroups were
removed and the event target was changed to the main thread event
target, these tests actually test the same thing as the regular
non-target tests. This because nsITimer is created with a target which
just happens to be the mainThreadEventTarget.

Differential Revision: https://phabricator.services.mozilla.com/D146532
2022-05-18 11:16:57 +00:00
Jeff Muizelaar
23ae0b6a8e Bug 1769839 - Record the GMP download failure reason in telemetry. r=chutten
We're seeing a number of download failures in the field. It would be
nice to understand why they're happening.

Differential Revision: https://phabricator.services.mozilla.com/D146623
2022-05-17 20:56:43 +00:00
Bryce Seager van Dyk
47946c9f14 Bug 1769156 - Use content sig checks for GMP updates if controlling pref is missing. r=Gijs
Currently if the pref for using content sig checks with GMP updates is missing
we will use cert pinning. I.e. the default behaviour in the absence of a pref
value is cert pinning. This changes that so that we use content sig by default.

This is done as we're moving to content signatures as default behaviour, so it
makes sense to have it be the default if the pref is missing.

Differential Revision: https://phabricator.services.mozilla.com/D146260
2022-05-16 20:21:27 +00:00
Jeff Muizelaar
fca657ca7d Bug 1769614 - Add some more prefs/telemetry around GMP installation failure. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D146479
2022-05-16 20:18:45 +00:00
Magnus Melin
1dc8ce9384 Bug 1768529 - use default param value for hideTopSitesWithSearchParam. r=adw
Thunderbird doesn't have the pref => test failures:
https://treeherder.mozilla.org/logviewer?job_id=377954876&repo=comm-central&lineNumber=5509

Differential Revision: https://phabricator.services.mozilla.com/D146337
2022-05-13 23:44:50 +00:00
Jeff Muizelaar
c8fbe0e40d Bug 1769091 - Add some more prefs/telemetry around GMP installation. r=chutten
We have a number of users that check for updates but don't seem to
actually update. This should help narrow down what's going wrong.

Differential Revision: https://phabricator.services.mozilla.com/D146216
2022-05-12 20:52:42 +00:00
Butkovits Atila
3aba42338e Backed out changeset 150184b55bae (bug 1769091) for causing xpcshell failrues. CLOSED TREE 2022-05-12 23:03:02 +03:00
Jeff Muizelaar
e863d33522 Bug 1769091 - Add some more prefs/telemetry around GMP installation. r=chutten
We have a number of users that check for updates but don't seem to
actually update. This should help narrow down what's going wrong.

Differential Revision: https://phabricator.services.mozilla.com/D146216
2022-05-12 19:26:31 +00:00
Drew Willcoxon
d057d84a78 Bug 1768529 - Exclude URLs with a particular search param from appearing as tiles on the new-tab page. r=nanj
This modifies `ActivityStreamProvider.getTopFrecentSites()` so it excludes URLs
with a given search param. There are two questions I considered when writing
this patch:

* The top-sites code is a little complex and there are multiple places where
  this logic could be implemented. I chose the bottommost layer, where the top
  sites are fetched from Places and some other exclusion logic already exists,
  because we don't want these URLs to appear in any list of top sites in Firefox
  AFAIK -- not on the new-tab page and not in the urlbar.
* How should we encode this new exclusion logic? We don't want to hardcode a
  specific search param. We may not even want to base it on search params at all
  but instead make it more general somehow. For now, I did the simple thing and
  went ahead and based it on a search param, and I added a new option to
  `getTopFrecentSites()` that specifies the param and that falls back to a new
  pref. Callers can override the pref fallback by passing in an option.

The pref value and option to `getTopFrecentSites()` supports the following
forms:

* `""` (empty) - Disable this feature
* `"key"` - Search param named "key" with any or no value
* `"key="` - Search param named "key" with no value
* `"key=value"` - Search param named "key" with value "value"

Differential Revision: https://phabricator.services.mozilla.com/D146139
2022-05-12 18:38:48 +00:00
Mathieu Leplatre
9c4746ef13 Bug 1767890 - Prevent packaged dump from being loaded r=robwu
Change tests and snippets in documentation to use `Date.now()` instead of an arbitrary number like `42`.
This way, we make sure the packaged dump isn't loaded on top of the tests data. Indeed, since Bug 1718083 we load the packaged dump if it's newer than local data.

Differential Revision: https://phabricator.services.mozilla.com/D145579
2022-05-10 09:51:50 +00:00
Jeff Muizelaar
43188d509b Bug 1767984 - Remove code for 32 bit macOS. r=bryce
We don't support this 32 bit macOS anymore.

Differential Revision: https://phabricator.services.mozilla.com/D145614
2022-05-06 00:37:41 +00:00
Meg Viar
083c4b4030 Bug 1766592 - [Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D145015
2022-05-04 13:35:28 +00:00
Doug Thayer
3b737ed548 Bug 1756823 - Replace ConsoleAPIStorage observer calls with js array r=nchevobbe,webdriver-reviewers,geckoview-reviewers,agi,jdescottes
See the comment in the file explaining it. For a case of logging 100k numbers,
this dropped the time per number from 15 microseconds to 9 with the console
closed, and 55 microseconds to 38 with the console open. I think we could shave
off more with a native approach, but I don't know that it's worth it and it's
much more likely for that to introduce bugs.

Differential Revision: https://phabricator.services.mozilla.com/D143782
2022-05-03 17:21:59 +00:00
Tooru Fujisawa
45ac4b3dfa Bug 1765167 - Part 10: Stop using Cu.import in toolkit/. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D144103
2022-05-03 06:32:32 +00:00
Henrik Skupin
9760ffb2c8 Bug 1719505 - [remote] Unify Remote Agent's running state with Marionette. r=webdriver-reviewers,mossop,smaug,keeler,jdescottes
Both components are related to WebDriver and should expose the
same flag for their running state.

Differential Revision: https://phabricator.services.mozilla.com/D144982
2022-04-29 17:38:14 +00:00