Commit Graph

161 Commits

Author SHA1 Message Date
Kagami Sascha Rosylight
b5a4737383 Bug 1767989 - Apply readability-make-member-function-const on dom/indexedDB r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D145624
2022-05-05 18:11:55 +00:00
Jari Jalkanen
1c5a7a733f Bug 1708705 - Check new requests are rejected during structured cloning. r=dom-storage-reviewers,janv
The check is restored from the previous implementation.

Differential Revision: https://phabricator.services.mozilla.com/D137031
2022-02-02 12:42:10 +00:00
Jari Jalkanen
c66861192b Bug 1708705 - Handle transaction abort during value clone. r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D125509
2022-01-26 09:18:24 +00:00
Simon Giesecke
6c6f47b599 Bug 1682536 - Use references/NotNull with IDBCursor. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D99785
2021-01-21 11:58:29 +00:00
Simon Giesecke
b3e540427f Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D88143
2020-08-28 15:50:23 +00:00
Razvan Maries
639bed10fd Backed out 2 changesets (bug 1660800, bug 1660816) as per Simon's request. CLOSED TREE
Backed out changeset 55d2e05d2e0b (bug 1660800)
Backed out changeset 7b9687fb7d41 (bug 1660816)
2020-08-28 18:45:54 +03:00
Simon Giesecke
ab38435cfa Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D88143
2020-08-28 14:43:51 +00:00
Simon Giesecke
5b492099f3 Bug 1648454 - Use NotNull with IDBRequest where applicable. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D81078
2020-07-01 20:14:23 +00:00
Chris Peterson
6a1ecad80a Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-23 01:49:16 +00:00
Dorel Luca
323f221095 acked out changeset 6bbecc3020b7 (bug 1631684) for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE 2020-04-22 08:41:47 +03:00
Chris Peterson
03ad9a920b Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-22 05:22:44 +00:00
Simon Giesecke
cb31f1e722 Bug 1623278 - Use SafeRefPtr for IDBTransaction. r=dom-workers-and-storage-reviewers,ttung,janv
Differential Revision: https://phabricator.services.mozilla.com/D67287
2020-04-21 14:32:51 +00:00
Simon Giesecke
b9883a12fd Bug 1623278 - Use SafeRefPtr for IDBFactory. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D66972
2020-04-01 09:54:43 +00:00
Simon Giesecke
54bae4eea4 Bug 1613340 - Remove const_cast relating to DatabaseSpec. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D61668
2020-03-03 13:44:25 +00:00
Simon Giesecke
3341745640 Bug 1497007 - Replace CanAcceptRequests by the now equivalent IsActive. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D59834
2020-01-17 12:47:09 +00:00
Simon Giesecke
4efcf9d790 Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55673
2020-01-17 12:47:17 +00:00
Simon Giesecke
ec35ff5810 Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.

Differential Revision: https://phabricator.services.mozilla.com/D59713
2020-01-17 10:11:58 +00:00
Csoregi Natalia
683448754f Backed out 3 changesets (bug 1497007) for assertion failures on IDBTransaction.cpp. CLOSED TREE
Backed out changeset 72bc4f39b659 (bug 1497007)
Backed out changeset 99fc4eedacc7 (bug 1497007)
Backed out changeset 787c340dd3d0 (bug 1497007)
2020-01-14 15:22:26 +02:00
Simon Giesecke
22e13211f2 Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55673
2020-01-14 11:14:29 +00:00
Simon Giesecke
5af9959598 Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.

Differential Revision: https://phabricator.services.mozilla.com/D59713
2020-01-14 11:14:52 +00:00
Simon Giesecke
556830c732 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993
2020-01-10 15:23:52 +00:00
Csoregi Natalia
8a5ddbf4ee Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke
6ab7211daa Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993
2020-01-10 14:21:18 +00:00
Simon Giesecke
e352fe42d4 Bug 1608115 - Use CheckedUnsafePtr for IDBCursor::mTransaction to improve safety r=ttung
Differential Revision: https://phabricator.services.mozilla.com/D51411
2020-01-10 14:10:00 +00:00
Simon Giesecke
5e9a05dc70 Bug 1600283 - Removed unused include directives. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55516
2019-12-19 09:57:40 +00:00
Simon Giesecke
d1144f7008 Bug 1497007 - Added IDBTransaction.commit method, with a minimal implementation. r=ttung,hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D46277
2019-12-10 10:24:18 +00:00
Simon Giesecke
3d8add6c11 Bug 1598164 - Implement transaction inactive state according to spec. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55142
2019-12-04 12:59:09 +00:00
Simon Giesecke
425710b496 Bug 1598164 - Made some boolean flags in IDBTransaction FlippedOnce to reduce statefulness. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55081
2019-12-03 15:32:18 +00:00
Simon Giesecke
eb288ab51f Bug 1598164 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Depends on D54322

Differential Revision: https://phabricator.services.mozilla.com/D55079
2019-11-28 15:05:28 +00:00
Simon Giesecke
b5c4af6154 Bug 1598164 - Align ReadyState with states defined in the spec. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54322
2019-11-28 16:00:29 +00:00
Simon Giesecke
200d77aeef Bug 1598164 - Use scoped enums in IDBTransaction. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54321
2019-11-27 10:54:57 +00:00
Simon Giesecke
99c43cd395 Bug 1598164 - Fix structured-clone-transaction-state.any.js test case. r=dom-workers-and-storage-reviewers,janv
Also removed obsolete dom/indexedDB/test/test_clone_before_key_evaluation.html test case,
which tested for the opposite behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D54267
2019-11-26 13:18:09 +00:00
Simon Giesecke
c4c3ab9d96 Bug 1497007 - Mark group of methods exposed via webidl. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47232
2019-11-11 08:25:33 +00:00
Simon Giesecke
26c3fdfee9 Bug 1497007 - Added explaining comments. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47231
2019-11-11 08:25:20 +00:00
Simon Giesecke
774807f060 Bug 1497007 - Extracted HasTransactionChild and DoWithTransactionChild functions. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46946
2019-11-11 08:24:32 +00:00
Simon Giesecke
af443693d2 Bug 1497007 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46945
2019-11-11 08:24:25 +00:00
Simon Giesecke
d568eb0b6c Bug 1168606 - Resolved clang-tidy warnings. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D49274
2019-11-08 13:22:28 +00:00
shindli
5e4962d1f7 Backed out 8 changesets (bug 1497007) for causing build bustages in /builds/worker/workspace/build/src/dom/indexedDB/IDBTransaction.cpp CLOSED TREE
Backed out changeset 15de0d72f1c4 (bug 1497007)
Backed out changeset 7056932f6422 (bug 1497007)
Backed out changeset 7304fae8c436 (bug 1497007)
Backed out changeset be22a95de04b (bug 1497007)
Backed out changeset 98ac48b5f1ef (bug 1497007)
Backed out changeset 562d3cda9fa3 (bug 1497007)
Backed out changeset 3f96e71be2e3 (bug 1497007)
Backed out changeset 3d9e86698c9f (bug 1497007)
2019-11-08 16:28:53 +02:00
Simon Giesecke
b1f4313e94 Bug 1497007 - Mark group of methods exposed via webidl. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47232
2019-11-08 13:33:56 +00:00
Simon Giesecke
50bcd0cd62 Bug 1497007 - Added explaining comments. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47231
2019-11-08 13:33:45 +00:00
Simon Giesecke
a98ebfe130 Bug 1497007 - Extracted HasTransactionChild and DoWithTransactionChild functions. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46946
2019-11-08 13:29:46 +00:00
Simon Giesecke
be2c9e84c0 Bug 1497007 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46945
2019-11-08 13:29:39 +00:00
Simon Giesecke
2991eaae9a Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252
2019-11-05 14:40:37 +00:00
Cosmin Sabou
1078f19412 Backed out 12 changesets (bug 1168606) for causing build bustages on ActorsParent.cpp and Assertions.h. CLOSED TREE
Backed out changeset 307bd8d24407 (bug 1168606)
Backed out changeset a2ae085f929f (bug 1168606)
Backed out changeset 8fdc4a3d3ecb (bug 1168606)
Backed out changeset 918dc7cce5e9 (bug 1168606)
Backed out changeset 8c776a5cb5db (bug 1168606)
Backed out changeset dffe1e6c58bd (bug 1168606)
Backed out changeset 41f1bef0f019 (bug 1168606)
Backed out changeset 96cb7140a4f6 (bug 1168606)
Backed out changeset 6818224b9b11 (bug 1168606)
Backed out changeset f1be81af7d6b (bug 1168606)
Backed out changeset 8dc185488801 (bug 1168606)
Backed out changeset 9d8b02674d45 (bug 1168606)
2019-11-05 16:34:22 +02:00
Simon Giesecke
edc9fa805c Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252
2019-11-05 12:48:36 +00:00
Oana Pop Rus
d9e48c0b03 Backed out 5 changesets (bug 1168606) for xpcshell failures in dom/indexedDB/test/unit/test_temporary_storage.js on a CLOSED TREE
Backed out changeset fc5e1bee1332 (bug 1168606)
Backed out changeset 63cf0966cb41 (bug 1168606)
Backed out changeset f844afbebc6a (bug 1168606)
Backed out changeset 9e7a90dcc429 (bug 1168606)
Backed out changeset e493a6b5f125 (bug 1168606)
2019-10-02 02:28:15 +03:00
Simon Giesecke
1e227ada3d Bug 1168606 - Send two records with every ObjectStoreCursorResponse. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252
2019-10-01 09:15:49 +00:00
Andrea Marchesini
94d383a51c Bug 1559919 - Finish the WorkerHolder cleanup - part 1 - IndexedDB doesn't use WorkerHolder, r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D35220
2019-07-12 11:15:33 +00:00
Andrea Marchesini
18a24375f9 Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041
2019-03-29 18:05:11 +00:00
Daniel Varga
11153391d9 Backed out changeset 98452610cfcc (bug 1539407) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE 2019-03-29 18:01:58 +02:00