Commit Graph

219 Commits

Author SHA1 Message Date
Simon Giesecke
6c6f47b599 Bug 1682536 - Use references/NotNull with IDBCursor. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D99785
2021-01-21 11:58:29 +00:00
Simon Giesecke
46908cfb51 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Sylvestre Ledru
68b806d604 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila
a6e7dcc53f Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE 2020-11-04 10:54:36 +02:00
Sylvestre Ledru
8f709b39e8 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Simon Giesecke
e262d1f0b8 Bug 1665347 - Do not indicate SpecialValues::Invalid could be returned on functions that never return it. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90962
2020-10-06 08:39:04 +00:00
Simon Giesecke
54a4e17a0b Bug 1665347 - Make IDBResult based on mozilla::Result. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90562
2020-10-06 08:37:59 +00:00
Sebastian Hengst
07e61ece2b Backed out 5 changesets (bug 1666219, bug 1665347) for crashing hazard task. CLOSED TREE.
Backed out changeset c261ec06a826 (bug 1665347)
Backed out changeset 212c9df41410 (bug 1665347)
Backed out changeset 435f02d9f1d7 (bug 1665347)
Backed out changeset 7b36a79247b7 (bug 1666219)
Backed out changeset af8025162523 (bug 1665347)
2020-10-01 23:17:19 +02:00
Simon Giesecke
dd4cf5dedd Bug 1665347 - Do not indicate SpecialValues::Invalid could be returned on functions that never return it. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90962
2020-10-01 15:30:36 +00:00
Simon Giesecke
9fb9c90cc0 Bug 1665347 - Make IDBResult based on mozilla::Result. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90562
2020-10-01 15:30:36 +00:00
Bogdan Tara
7bbd692ffa Backed out 5 changesets (bug 1666219, bug 1665347) for indexedDB related bustage CLOSED TREE
Backed out changeset 5cd7e2d67f91 (bug 1665347)
Backed out changeset 9159fdd05097 (bug 1665347)
Backed out changeset 64a086636738 (bug 1665347)
Backed out changeset 5ef18af381ec (bug 1666219)
Backed out changeset 3b81349a5f39 (bug 1665347)
2020-10-01 17:41:23 +03:00
Simon Giesecke
e41aa38d86 Bug 1665347 - Do not indicate SpecialValues::Invalid could be returned on functions that never return it. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90962
2020-10-01 12:04:27 +00:00
Simon Giesecke
c51f0dc8d8 Bug 1665347 - Make IDBResult based on mozilla::Result. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90562
2020-10-01 12:00:51 +00:00
Simon Giesecke
9fbdc8d323 Bug 1650076 - Fix bad printf format strings/argument lists. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D82016
2020-07-03 09:39:24 +00:00
Cosmin Sabou
ac68fa95fe Backed out 4 changesets (bug 1650076) for build bustages on indexedDB/ProfilerHelpers.h. CLOSED TREE
Backed out changeset 42951b61e9dc (bug 1650076)
Backed out changeset 18b34fb0ddbd (bug 1650076)
Backed out changeset 1d378f2af866 (bug 1650076)
Backed out changeset 42df520d1cff (bug 1650076)
2020-07-03 11:49:58 +03:00
Simon Giesecke
1d44b0cddf Bug 1650076 - Fix bad printf format strings/argument lists. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D82016
2020-07-03 08:08:05 +00:00
Simon Giesecke
182f61faf1 Bug 1644379 - Change ToLocaleAwareKey to return new Key by value. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78879
2020-06-30 14:18:15 +00:00
Simon Giesecke
46562b92b4 Bug 1644379 - Extract extraction of ErrorResult from IDBResult into a function. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78708
2020-06-30 11:17:29 +00:00
Simon Giesecke
97b2b32895 Bug 1644379 - Change IDBResult(Base) to contain the ErrorResult. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78707
2020-06-30 11:17:40 +00:00
Narcis Beleuzu
dfce2aabe3 Backed out 6 changesets (bug 1644379) for bustages on IDBResult.h . CLOSED TREE
Backed out changeset df76fe2ab8bf (bug 1644379)
Backed out changeset a22f8c2a1fe7 (bug 1644379)
Backed out changeset 1244dc147bb7 (bug 1644379)
Backed out changeset 88afa250d734 (bug 1644379)
Backed out changeset e90b2d69b818 (bug 1644379)
Backed out changeset c9690f97b893 (bug 1644379)
2020-06-30 13:54:22 +03:00
Simon Giesecke
1f6537f44c Bug 1644379 - Extract extraction of ErrorResult from IDBResult into a function. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78708
2020-06-30 10:01:20 +00:00
Simon Giesecke
ce0e47d951 Bug 1644379 - Change IDBResult(Base) to contain the ErrorResult. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78707
2020-06-30 10:01:03 +00:00
Simon Giesecke
337ce45d84 Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 09:14:04 +00:00
Bogdan Tara
32cb177a3b Backed out 2 changesets (bug 1623278, bug 1633719) for assertion failure on NotNull.h CLOSED TREE
Backed out changeset 8a21ea441fc7 (bug 1623278)
Backed out changeset ab6a041c0d57 (bug 1633719)
2020-05-14 11:34:50 +03:00
Simon Giesecke
08e6a873ee Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 07:47:46 +00:00
Simon Giesecke
ff81fc9bd2 Bug 1536540 - Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku
Differential Revision: https://phabricator.services.mozilla.com/D71786
2020-04-23 08:38:57 +00:00
Andreea Pavel
41b6201260 Backed out changeset 7dccafbf3437 (bug 1536540) for failing wpt at idlharness.any.worker.html on a CLOSED TREE 2020-04-22 21:54:11 +03:00
Simon Giesecke
18e981fb8a Bug 1536540 - Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku
Differential Revision: https://phabricator.services.mozilla.com/D71786
2020-04-22 14:53:17 +00:00
Simon Giesecke
cb31f1e722 Bug 1623278 - Use SafeRefPtr for IDBTransaction. r=dom-workers-and-storage-reviewers,ttung,janv
Differential Revision: https://phabricator.services.mozilla.com/D67287
2020-04-21 14:32:51 +00:00
Jon Coppeard
129887dbbb Bug 1627282 - Mark all IndexDB cursor subclasses as potentially containing pointers into more than one JS zone r=sg
At this point it's probably worth marking all these subclasses in the same way as I expect they can all contain pointers into multiple zones.

Differential Revision: https://phabricator.services.mozilla.com/D69809
2020-04-06 13:02:52 +00:00
Simon Giesecke
4130e192c2 Bug 1625444 - Make IDBObjectStoreCursor a multi-zone JSHolder class. r=jonco,dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D68766
2020-03-30 18:31:04 +00:00
Jon Coppeard
3ff4e1a268 Bug 1624810 - Set the multi-zone JS holder flag on appropriate cycle collected classes r=mccr8
Set the flag on the affected classes, which are:
 - CallbackTimeoutHandler
 - nsJSArgArray
 - CallbackObject
 - Console
 - MessageEvent
 - IDBIndexCursor
 - ExtendableMessageEvent
 - JSPurpleBuffer

Differential Revision: https://phabricator.services.mozilla.com/D68196
2020-03-26 10:49:06 +00:00
Simon Giesecke
9754419e89 Bug 1617170 - Fix non-unified build. r=janv,dom-workers-and-storage-reviewers
Based on a patch supplied by janv@mozilla.com

Differential Revision: https://phabricator.services.mozilla.com/D67129
2020-03-17 11:28:49 +00:00
Simon Giesecke
29c1d74824 Bug 1617170 - Split StructuredCloneReadInfo into parent- and child-specific classes. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D64131
2020-03-11 17:30:33 +00:00
Boris Zbarsky
e62a6fc4d1 Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D65538
2020-03-06 21:04:58 +00:00
Simon Giesecke
2011d7d8d3 Bug 1613340 - Remove const_cast relating to StructuredCloneReadInfo. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D61670
2020-03-03 13:45:26 +00:00
Simon Giesecke
3341745640 Bug 1497007 - Replace CanAcceptRequests by the now equivalent IsActive. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D59834
2020-01-17 12:47:09 +00:00
Simon Giesecke
556830c732 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993
2020-01-10 15:23:52 +00:00
Csoregi Natalia
8a5ddbf4ee Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke
6ab7211daa Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993
2020-01-10 14:21:18 +00:00
Simon Giesecke
c0d76c854a Bug 1600906 - Use scoped enums in IDBCursor. r=dom-workers-and-storage-reviewers,ytausky
Depends on D57990

Differential Revision: https://phabricator.services.mozilla.com/D57991
2020-01-06 14:19:39 +00:00
Simon Giesecke
d0bbf6e70a Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55492
2019-12-16 14:42:54 +00:00
Simon Giesecke
b5c4af6154 Bug 1598164 - Align ReadyState with states defined in the spec. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54322
2019-11-28 16:00:29 +00:00
Simon Giesecke
f27c619213 Bug 1598164 - Fixed log message printf string. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55076
2019-11-28 10:19:45 +00:00
Simon Giesecke
200d77aeef Bug 1598164 - Use scoped enums in IDBTransaction. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54321
2019-11-27 10:54:57 +00:00
Simon Giesecke
25c41f9d4c Bug 1168606 - Support preloading also for index cursors. r=ttung,asuth
Depends on D43252

Differential Revision: https://phabricator.services.mozilla.com/D43461
2019-11-05 14:40:35 +00:00
Simon Giesecke
2991eaae9a Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252
2019-11-05 14:40:37 +00:00
Cosmin Sabou
1078f19412 Backed out 12 changesets (bug 1168606) for causing build bustages on ActorsParent.cpp and Assertions.h. CLOSED TREE
Backed out changeset 307bd8d24407 (bug 1168606)
Backed out changeset a2ae085f929f (bug 1168606)
Backed out changeset 8fdc4a3d3ecb (bug 1168606)
Backed out changeset 918dc7cce5e9 (bug 1168606)
Backed out changeset 8c776a5cb5db (bug 1168606)
Backed out changeset dffe1e6c58bd (bug 1168606)
Backed out changeset 41f1bef0f019 (bug 1168606)
Backed out changeset 96cb7140a4f6 (bug 1168606)
Backed out changeset 6818224b9b11 (bug 1168606)
Backed out changeset f1be81af7d6b (bug 1168606)
Backed out changeset 8dc185488801 (bug 1168606)
Backed out changeset 9d8b02674d45 (bug 1168606)
2019-11-05 16:34:22 +02:00
Simon Giesecke
c82b7bbae7 Bug 1168606 - Support preloading also for index cursors. r=ttung,asuth
Depends on D43252

Differential Revision: https://phabricator.services.mozilla.com/D43461
2019-11-05 12:45:48 +00:00
Simon Giesecke
edc9fa805c Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252
2019-11-05 12:48:36 +00:00