Commit Graph

1200 Commits

Author SHA1 Message Date
Jari Jalkanen
0416d333d7 Bug 1736844 - Add interrupt flag to storage service methods opening database; r=dom-storage-reviewers,mak,janv
Differential Revision: https://phabricator.services.mozilla.com/D129023
2022-02-17 06:22:27 +00:00
Marian-Vasile Laza
2521ad393d Backed out changeset 0ef0b43b28f1 (bug 1736844) for causing gtest failures. CLOSED TREE 2022-02-16 09:27:30 +02:00
Haiyang Xu
5199250fc0 Bug 1736844 - Add interrupt flag to storage service methods opening database; r=dom-storage-reviewers,mak,janv
* The same flags can be used to enable other features such as extented error codes

Differential Revision: https://phabricator.services.mozilla.com/D129023
2022-02-16 06:08:11 +00:00
Randell Jesup
471f453378 Bug 1625161: Move ASSERT_UNLESS_FUZZING() to mfbt and hook into FUZZING r=glandium,decoder
Differential Revision: https://phabricator.services.mozilla.com/D133166
2021-12-16 04:13:48 +00:00
Jari Jalkanen
ba59f98e02 Bug 1741201 - Increase intermediate byte storage maximum capacity. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D131235
2021-12-09 10:42:55 +00:00
Jan Varga
f3b6f859bd Bug 1731969 - Rename ToResultInvoke member function overloads to ToResultInvokeMember; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D126328
2021-11-30 05:05:53 +00:00
Jan Varga
3e73e7ce93 Bug 1731960 - Move all Result extensions from QMResult.h to a dedicated file; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D126324
2021-11-30 05:05:51 +00:00
Haiyang Xu
2609a9be23 Bug 1726809 - Simplify QuotaManager::GetOrCreate and intermediate state of opening QuotaManager; r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D131592
2021-11-28 00:09:56 +00:00
Butkovits Atila
2dd947aa8c Backed out changeset b4b0ae95055b (bug 1726809) for causing build bustages at ActorsParent.cpp. CLOSED TREE 2021-11-26 12:02:18 +02:00
Haiyang Xu
b52b5893f5 Bug 1726809 - Simplify QuotaManager::GetOrCreate and intermediate state of opening QuotaManager; r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D131592
2021-11-26 09:20:57 +00:00
Jan Varga
dec6d4fb9c Bug 1731546 - Replace existing ToResultGet uses with MOZ_TO_RESULT_GET_TYPED; r=dom-storage-reviewers,jstutte,jari
Differential Revision: https://phabricator.services.mozilla.com/D125325
2021-10-11 06:00:15 +00:00
Jan Varga
7fbbc22b76 Bug 1731544 - Replace existing ToResult uses with MOZ_TO_RESULT; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D125324
2021-10-10 19:06:36 +00:00
Jens Stutte
850558a4e4 Bug 1731564: Use motivated SpinEventLoopUntil inside dom/*. r=smaug
Depends on D126714

Differential Revision: https://phabricator.services.mozilla.com/D126957
2021-10-07 08:06:11 +00:00
Marian-Vasile Laza
7de6967c5a Backed out 18 changesets (bug 1731564) for causing build bustages on SpinEventLoopUntil. CLOSED TREE
Backed out changeset 0464dbdc8584 (bug 1731564)
Backed out changeset 0d996df13545 (bug 1731564)
Backed out changeset 5630a0e7a109 (bug 1731564)
Backed out changeset 37b41d187cdb (bug 1731564)
Backed out changeset d37700fa60b6 (bug 1731564)
Backed out changeset b0ce7db44b99 (bug 1731564)
Backed out changeset aa5ec3aa1535 (bug 1731564)
Backed out changeset 73b648f1fa70 (bug 1731564)
Backed out changeset bb8fb0f9833e (bug 1731564)
Backed out changeset 0d8905144f5d (bug 1731564)
Backed out changeset 2cfb094a1ec3 (bug 1731564)
Backed out changeset 78d3b0257a6a (bug 1731564)
Backed out changeset e9d32926e93c (bug 1731564)
Backed out changeset 874cab520ce5 (bug 1731564)
Backed out changeset d8071cc32bd9 (bug 1731564)
Backed out changeset 283c5393cbbc (bug 1731564)
Backed out changeset 317bc38e3de5 (bug 1731564)
Backed out changeset 53e3f4862439 (bug 1731564)
2021-10-07 00:09:19 +03:00
Jens Stutte
433c18b98c Bug 1731564: Use motivated SpinEventLoopUntil inside dom/*. r=smaug
Depends on D126714

Differential Revision: https://phabricator.services.mozilla.com/D126957
2021-10-06 19:45:12 +00:00
Jan Varga
711f6a0798 Bug 1728267 - Remove implicit ToResult from QM_TRY when no extra argument is passed in dom/indexedDB; r=dom-storage-reviewers,jstutte,jari
Differential Revision: https://phabricator.services.mozilla.com/D125318
2021-09-24 13:08:30 +00:00
Jan Varga
7345ed5f93 Bug 1728267 - Remove implicit ToResult from QM_TRY when one extra argument is passed; r=dom-storage-reviewers,jstutte,jari
Differential Revision: https://phabricator.services.mozilla.com/D125316
2021-09-23 10:16:09 +00:00
Jan Varga
e0c0c469a0 Bug 1728267 - Remove implicit ToResult from QM_TRY when two extra arguments are passed; r=dom-storage-reviewers,jstutte,jari
Differential Revision: https://phabricator.services.mozilla.com/D125315
2021-09-23 10:16:09 +00:00
Jan Varga
2c53929de2 Bug 1728267 - Remove implicit ToResult from QM_WARNONLY_TRY macros; r=dom-storage-reviewers,jstutte,jari
We can use QM_TO_RESULT (instead of MOZ_TO_RESULT) because QM_WARNONLY_TRY
doesn't propagate errors, so no other adjustment is needed.

Differential Revision: https://phabricator.services.mozilla.com/D125314
2021-09-23 10:16:08 +00:00
Jan Varga
c1ef8cb786 Bug 1728267 - Remove implicit ToResult from QM_TRY_RETURN; r=dom-storage-reviewers,jstutte,jari
Differential Revision: https://phabricator.services.mozilla.com/D125312
2021-09-23 04:06:11 +00:00
Kagami Sascha Rosylight
3a60d21b9f Bug 1723050 - Part 15: Replace typedef by using in dom/indexedDB/ r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D121313
2021-08-16 17:05:41 +00:00
Gabriele Svelto
6c84191650 Bug 1723934 - Remove useless nsExceptionHandler.h inclusions and crash reporter service definitions r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D121708
2021-08-09 20:08:17 +00:00
Jan Varga
076e26f9a5 Bug 1661413 - Improve deleting files in DeleteFileManagerDirectory; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119588
2021-08-03 11:43:50 +00:00
Jan Varga
b12805661f Bug 1661413 - Introduce a generic function for non-recursive traversing of directory entries in file manager directory; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119587
2021-08-03 11:43:50 +00:00
Jan Varga
12b2d84659 Bug 1621920 - Convert IDB client to use the new macro for warning about unknown stuff in .files directory and add handling of unknown directories in .files directory; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D119586
2021-08-03 10:46:28 +00:00
Jan Varga
a0895ea9fc Bug 1711848 - Add argument separation comments for QM_OR_ELSE(WARN|NOTE|LOG_VERBOSE)(_IF) uses; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115465
2021-06-01 13:58:27 +00:00
Jan Varga
ea18231e8b Bug 1711656 - Rename QM_OR_ELSE_LOG to QM_OR_ELSE_LOG_VERBOSE; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115363
2021-06-01 12:12:27 +00:00
Jan Varga
c4b6867520 Bug 1711663 - Clean up includes related to FileInfo/FileInfoManager/DatabaseFileInfo/DatabaseFileManager; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115360
2021-06-01 08:50:32 +00:00
Jan Varga
e677eb6f81 Bug 1711663 - Rename FileManagerBase to FileInfoManager; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115359
2021-06-01 08:50:31 +00:00
Jan Varga
ea28dcb98a Bug 1711663 - Rename FileInfoT to FileInfo; r=dom-storage-reviewers,jstutte
This patch also renames FileManagerBase::FileInfo alias to
FileManagerBase::FileInfoType to fix a base toolchains compilation error.
FileManagerBase::AutoLock has been renamed to FileManagerBae::AutoLockType for
consistency.

Differential Revision: https://phabricator.services.mozilla.com/D115358
2021-06-01 07:04:28 +00:00
Jan Varga
c73cd55676 Bug 1711663 - Rename FileManager to DatabaseFileManager and TestFileManager to SimpleFileManager; r=dom-storage-reviewers,jstutte
Method arguments, member variables and method names related to FileManager were
not renamed since there are no other classes based on FileManager (except the
one defined in TestSimpleFileInfo.cpp).

Differential Revision: https://phabricator.services.mozilla.com/D115357
2021-06-01 03:42:47 +00:00
Iulian Moraru
e5735ce9ee Backed out 5 changesets (bug 1711663) for causing build bustages on FileManager. CLOSED TREE
Backed out changeset 9f3260aaab11 (bug 1711663)
Backed out changeset adb6539a1e6f (bug 1711663)
Backed out changeset 2b58a824285d (bug 1711663)
Backed out changeset 28e04756a73d (bug 1711663)
Backed out changeset 8a36c84e9269 (bug 1711663)
2021-06-01 02:21:02 +03:00
Jan Varga
c7ebadb9bb Bug 1711663 - Clean up includes related to FileInfo/FileInfoManager/DatabaseFileInfo/DatabaseFileManager; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115360
2021-05-31 19:50:24 +00:00
Jan Varga
b6cbfbcb71 Bug 1711663 - Rename FileManagerBase to FileInfoManager; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115359
2021-05-31 19:50:24 +00:00
Jan Varga
011a4feb2e Bug 1711663 - Rename FileInfoT to FileInfo; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115358
2021-05-31 19:50:23 +00:00
Jan Varga
190717205b Bug 1711663 - Rename FileManager to DatabaseFileManager and TestFileManager to SimpleFileManager; r=dom-storage-reviewers,jstutte
Method arguments, member variables and method names related to FileManager were
not renamed since there are no other classes based on FileManager (except the
one defined in TestSimpleFileInfo.cpp).

Differential Revision: https://phabricator.services.mozilla.com/D115357
2021-05-31 19:50:23 +00:00
Jan Varga
944f33c41b Bug 1711663 - Rename FileInfo to DatabaseFileInfo and TestFileInfo to SimpleFileInfo; r=dom-storage-reviewers,jstutte
Method arguments, member variables and method names related to FileInfo were
not renamed since there are no other classes based on FileInfo (except the one
defined in TestSimpleFileInfo.cpp).

Differential Revision: https://phabricator.services.mozilla.com/D115356
2021-05-31 17:44:19 +00:00
Jan Varga
2aff6d5ef6 Bug 1708643 - IDB: Replace QM_OR_ELSE_(WARN|LOG) with QM_OR_ELSE_(WARN|LOG)_IF in places where the fallback needs to be called conditionally; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D115131
2021-05-30 11:08:02 +00:00
Jan Varga
3a5b6ab6e3 Bug 1708643 - Rename orElseFunc argument to fallback in QM_OR_ELSE_REPORT definition; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114843
2021-05-29 05:05:39 +00:00
Jens Stutte
870791d9a9 Bug 1706998: Replace QuotaManager::GetRef().MaybeRecordShutdownStep by static QuotaManager::(Safe)MaybeRecordQuotaClientShutdownStep; r=dom-storage-reviewers,janv
There are some few unsafe uses of MaybeRecordShutdownStep where the QuotaManager singleton may be  not (yet or anymore) alive.
In order to not add many unnecessary null checks, we drop GetRef and MaybeRecordShutdownStep in favor of
QuotaManager::MaybeRecordQuotaClientShutdownStep
QuotaManager::SafeMaybeRecordQuotaClientShutdownStep
with the sole difference that the Safe variant runtime checks the singleton, while the normal one only asserts.

Differential Revision: https://phabricator.services.mozilla.com/D115988
2021-05-28 06:46:04 +00:00
Jan Varga
c56aaf3187 Bug 1711181 - Add explanatory comments for some special uses of QM_OR_ELSE_WARN; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115160
2021-05-21 09:30:30 +00:00
Jan Varga
3c117bf290 Bug 1711181 - Use QM_OR_ELSE_LOG in remaining places where QM_OR_ELSE_WARN would spam the reports; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D115159
2021-05-21 09:30:30 +00:00
Jan Varga
7e88bb0001 Bug 1711181 - Change uses of ordinary orElse to QM_OR_ELSE_LOG; r=dom-storage-reviewers,jstutte
This is more consistent with other cases where we either use QM_OR_ELSE_WARN or
QM_OR_ELSE_NOTE. We will later change some uses of QM_OR_ELSE_LOG to
QM_OR_ELSE_LOG_IF. The switch from custom OrElseIf to Result::orElseIf will be
easier when we don't use OrElseIf directly.

This patch only changes uses of ordinary orElse introduced in bug 1701346.

Remaining uses will be handled in bug 1711180 (the ones that were missed in bug
1686191).

Differential Revision: https://phabricator.services.mozilla.com/D115055
2021-05-21 09:30:30 +00:00
Andi-Bogdan Postelnicu
f4dd222589 Bug 1519636 - Initial reformat of C/C++ code with clang-format version 12.0.0. r=sylvestre
clang-format version 12.0.0 (taskcluster-KEgO7qdgQ8uaewA6NkRnRA)

Differential Revision: https://phabricator.services.mozilla.com/D114211
2021-05-10 07:15:07 +00:00
Andi-Bogdan Postelnicu
fc12bef7c8 Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,valentin,sylvestre
Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)

Differential Revision: https://phabricator.services.mozilla.com/D114618
2021-05-10 07:15:06 +00:00
Jan Varga
4dd5e829fb Bug 1709067 - IDB: Remove module specific QM_TRY macros; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114080
2021-05-03 19:44:38 +00:00
Jan Varga
1c41d8d6ca Bug 1690025 - Move and rename DirectoryLock::Specialize to UniversalDirectoryLock::SpecializeForClient; r=dom-storage-reviewers,asuth
This patch also changes the only consumer to not depend on the lock passed to
OpenDirectoryListener::DirectoryLockAcquired because it uses the base type (
unsafe static_cast would have to be used).

Differential Revision: https://phabricator.services.mozilla.com/D104804
2021-05-02 09:57:15 +00:00
Jan Varga
5d600890d9 Bug 1702599 - Report missing database in UpgradeStorageFrom1_0To2_0 as a warning (instead of an error); r=dom-storage-reviewers,jstutte,asuth
At the time we didn't have the warning QM_TRY macros, so the only option was to
replace NS_WARN_IF with IDB_TRY. We now have QM_WARNONLY_TRY which is exatly
what we need here.

Differential Revision: https://phabricator.services.mozilla.com/D113505
2021-04-28 07:33:54 +00:00
Snehaa2296
63138ba2f7 Bug 1334986 - changed the parameters in declarations and definitions of Transaction Base::VerifyRequestParams. r=sg
Depends on D106257

Differential Revision: https://phabricator.services.mozilla.com/D106584
2021-04-14 11:44:24 +00:00
Jan Varga
3a3ae3442d Bug 1701346 - IDB: Revert QM_OR_ELSE_WARN to ordinary orElse in QuotaClient::GetUsageForOriginInternal; r=asuth,dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D109991
2021-03-27 13:08:07 +00:00