Commit Graph

455 Commits

Author SHA1 Message Date
Marco Bonardo
888d71022d Bug 1477996 - Move getURIsForTag to the bookmarking API. r=Standard8,lina
The tagging API is being merged into the bookmarking API. This is part of it.

Differential Revision: https://phabricator.services.mozilla.com/D2450
2018-07-27 15:16:57 +00:00
Brian Grinstead
b0a65148db Bug 1445764 - Move Places imports from XUL to JS for the Places documents;r=standard8
MozReview-Commit-ID: 1LKRgTlaupu
2018-07-03 14:26:49 -07:00
Mark Banner
b24bddc9dc Bug 1452645 - Remove load in sidebar functionality. r=lina,mak
Based on patch by mixedpuppy.

MozReview-Commit-ID: BZwOtr4VbCH
2018-06-06 21:00:45 +01:00
Mark Banner
8853e86675 Bug 1463738 - Remove the Bookmark description UI. r=dao
This removes the bookmark description UI, but leaves the backend in-place for a release or two, so that users have time to save anything they want (e.g. via backup).
The backend will be removed in bug 1402890.

MozReview-Commit-ID: La4AYFar7eK
2018-05-23 17:15:09 +01:00
Mark Banner
9e457b164d Bug 1209518 - Fix highlighting of cut bookmarks. r=mak
Fix the ownership check to correctly check if we're cutting or copying.

MozReview-Commit-ID: 1eLt4Fyy2nE
2018-05-21 16:55:26 +01:00
jakehm
6494c8336e Bug 1089691 - Convert consumers of removePagesByTimeframe and removePagesFromHost to PlacesUtils.history.removeByFilter. r=mak
MozReview-Commit-ID: HevUcwPhYhd
2018-02-25 14:27:03 -05:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Marco Bonardo
2e80ffbe53 Bug 1453545 - Properties option disabled when right-clicking a bookmarks folder. r=standard8
MozReview-Commit-ID: 30JmVhO7sh9
2018-04-19 00:16:48 +02:00
Marco Bonardo
0e37435fdd Bug 1452621 - Cleanup some tag queries related code. r=standard8
MozReview-Commit-ID: L8L3i5W1CHe
2018-04-09 15:38:45 +02:00
Marco Bonardo
3382b7442d Bug 1293445 - 5 - Rename RESULTS_AS_TAG_QUERY. r=standard8
MozReview-Commit-ID: 7HwPKkGvAvv
2018-04-04 16:14:20 +02:00
Marco Bonardo
b2e8b679a0 Bug 1293445 - 4 - Remove RESULTS_AS_TAG_CONTENTS. r=standard8
MozReview-Commit-ID: rybSCGrfnf
2018-04-03 18:32:00 +02:00
Mark Banner
9055c0fac7 Bug 1450223 - Remove unnecessary synchronous annotation lookups from the places context menu. r=mak
MozReview-Commit-ID: Ck2eaeVAjXs
2018-03-29 15:49:39 +01:00
Marco Bonardo
36ec58e083 Bug 1421664 - 3 - Fix the UI and tests. r=standard8
test_419731.js can be removed since it is already covered by browser_bookmarkProperties_editTagContainer.js

MozReview-Commit-ID: K0LFuTptWyW
2018-03-22 14:13:07 +01:00
Marco Bonardo
39cfa2a663 Bug 1446951 - 2 - Change nsINavHistoryQueryResultNode::GetQueries to a query attribute. r=standard8
MozReview-Commit-ID: 77xEeAE13xW
2018-03-16 16:20:22 +01:00
Mark Banner
a8659a2b7c Bug 1425555 - Avoid a database fetch after showing the new bookmark dialog. r=mak
MozReview-Commit-ID: 1pjynkFFSOd
2018-03-20 23:52:58 +00:00
Brendan Dahl
8a8bb26748 Bug 1442302 - Remove placesOverlay.xul. r=Gijs,mak,standard8
The overlay was responsible for script loading and defining three elements
(bhTooltip, placesCommands, placesContext). In the majority of places where
the overlay was included only part of it was used. To remove the overlay, the
elements were each split into include files and moved into where they
were used. For the scripts, a JS file was added that defines all the lazy
modules and then this script, globalOverlay.js and utilityOverlay.js were
inlined to everywhere that would have included them from the overlay.

MozReview-Commit-ID: 8T5D46oYWLn
2018-03-12 10:43:35 -07:00
manikishan
02874947cf Bug 1431050 - Replace NS_ASSERT with conditional exceptions/console.assert and remove the debug.js module. r=mak
console.assert keeps the same semantics as NS_ASSERT in that it doesn't throw an exception,
but a lot of the places code was using it in a way that would be better served by throwing
an exception when the condition is false.

MozReview-Commit-ID: DEF5HSfYO36
2018-02-03 11:32:25 +05:30
Michael Kaply
97e2f5fdd4 Bug 1432355 - Add a policy to disable private browsing. r=Gijs
MozReview-Commit-ID: AprbL6usEv5
2018-03-01 10:20:38 -06:00
Marco Bonardo
c03dbb59bd Bug 1439315 - 6 - Move some utils into PlacesController or PlacesUIUtils. r=standard8
MozReview-Commit-ID: D7J6hY7Akro
2018-02-28 13:51:28 +01:00
Marco Bonardo
3e6ba6ed6d Bug 1439315 - 5 - defineLazyScriptGetter controller.js. r=standard8
MozReview-Commit-ID: 4Kq3XvJNNGB
2018-02-28 12:31:37 +01:00
Marco Bonardo
9755291ead Bug 1439315 - 3 - Don't use NetUtil.newURI. r=standard8
MozReview-Commit-ID: 58jYURt7EWF
2018-02-28 12:28:54 +01:00
Marco Bonardo
e0791e9a76 Bug 1439315 - 2 - Move command utils to PlacesUIUtils. r=standard8
MozReview-Commit-ID: 6hN9LxVQunX
2018-02-28 12:27:21 +01:00
Marco Bonardo
47da5f79b5 Bug 1439315 - 1 - rename InsertionPoint to PlacesInsertionPoint. r=standard8
MozReview-Commit-ID: 1NfkueEUPXC
2018-02-28 12:10:12 +01:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mark Banner
8b297fe619 Bug 1434261 - Disable user actions on the places trees not in the library window to avoid accidential/unintentional actions. r=mak
MozReview-Commit-ID: ILo09hwWRsZ
2018-02-21 17:51:23 +00:00
Mark Banner
1135f98089 Bug 1437310 - Fix moving bookmarks across special folders. r=mak
MozReview-Commit-ID: dj6dOwDxOT
2018-02-12 21:51:08 +00:00
Francesco Lodolo (:flod)
a26d7198c4 Bug 1437583 - Split plural forms for Delete/Add bookmarks in separate strings r=standard8
Since the number of tabs is not actually displayed, having two separate strings from 1 vs many is preferable.

MozReview-Commit-ID: y1dgvsCxmC
2018-02-12 19:04:59 +01:00
Jared Wein
db0a992247 Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8
MozReview-Commit-ID: 66sXxnOWDgw
2018-02-08 12:57:31 -05:00
Mark Banner
5e632ca5e3 Bug 1437651 - Remove unused simulated-places-node references. r=mak
MozReview-Commit-ID: 6JzFXRykF2W
2018-02-12 20:33:07 +00:00
Mark Banner
00472aedd4 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Coroiu Cristina
8fb5593ad1 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner
2339900150 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Mark Banner
b62dfadc2c Bug 1432407 - Merge loops in PlacesController.onDrop now that sync transactions have been removed. r=mak
MozReview-Commit-ID: JXaxRv10HQs
2018-01-25 21:00:34 +00:00
Mark Banner
dbe8b88641 Bug 1131491 - Remove browser.places.useAsyncTransactions preference - async transactions are now the only version. r=mak
MozReview-Commit-ID: 9EKNvA8Q9jo
2018-01-22 13:36:41 +00:00
Mark Banner
23fcf17af7 Bug 1432112 - Remove the Move Bookmarks dialog as it doesn't work properly and has alternatives. r=mak
MozReview-Commit-ID: LRqyjJeuoVt
2018-01-22 13:48:14 +00:00
Mark Banner
8d1d3df1ae Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids. r=mak
MozReview-Commit-ID: LmZ7AYXBsJ4
2017-12-14 13:56:26 -06:00
Mark Banner
4416ebb91e Bug 1425437 - Improve view batching when dropping/pasting to tags, use the actual bookmarks count, not the count of transactions. r=mak
MozReview-Commit-ID: B6Bt8bHhh3e
2017-11-08 15:32:51 +00:00
Mark Banner
4fc8cc8128 Bug 1422724 - Remove unused constants in Places' controller.js. r=mak
MozReview-Commit-ID: AWTTksnPUp8
2017-12-04 12:09:03 +00:00
Mark Banner
aebd86c238 Bug 1415877 - Merge transaction handling into one function for onDrop/paste. r=mak
MozReview-Commit-ID: AMhuLyc98WO
2017-11-08 14:48:45 +00:00
Mark Banner
60b83c5096 Bug 1415877 - Rework PlacesControllerDragHelper#onDrop and PlacesController#paste to make the transaction handling parts similar. r=mak
MozReview-Commit-ID: BInw5oT0Ja5
2017-11-08 12:02:30 +00:00
Mark Banner
6f15fd42c1 Bug 1415877 - Remove unused type parameter to PlacesUIUtils#getTransactionForData. r=mak
MozReview-Commit-ID: 3kZQ4vnCk3b
2017-11-08 11:25:26 +00:00
Mark Banner
ad0aef3c26 Bug 1413843 - Improve speed of operations when pasting to the left-hand library pane by getting the right-hand pane to use for batching. r=mak
MozReview-Commit-ID: 2Q1rIpIhmmM
2017-11-02 10:37:14 +00:00
Mark Banner
64f3f531c3 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm
2017-10-23 18:18:00 +01:00
Mark Banner
3003416b05 Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak
MozReview-Commit-ID: EEFizNPmKpr
2017-10-23 15:50:52 +01:00
Sebastian Hengst
bba67d8083 Backed out 2 changesets (bug 1410940) for failing browser-chrome's browser/components/places/tests/browser/browser_controller_onDrop_tagFolder.js. r=backout
Backed out changeset 1c78029ded02 (bug 1410940)
Backed out changeset 37ceb314b2b3 (bug 1410940)
2017-11-03 11:52:54 +01:00