- Adds new illustrations and copy
- Shows a variant using emptyStateB for supported sites and PDPs
- Shows a variant using emptyStateC for unsupported sites
- To test the feature, set browser.shopping.experience2023.integratedSidebar=true, browser.shopping.experience2023.shoppingSidebar=true. Also set browser.shopping.experience2023.optedIn=0.
- To see the variant with emptyStateB, go to any page within amazon.com, bestbuy.com or walmart.com.
- To see the variant with emptyStateC, go to any page that's not amazon, bestbuy or walmart.
- Added tests to distinguish between empty state variants for the opt-in screen
Differential Revision: https://phabricator.services.mozilla.com/D226075
To support an upcoming experiment (details linked in Jira ticket referenced in bug), we want to add the ability to disable closing Spotlight with an ESC keypress via a message JSON configuration.
Differential Revision: https://phabricator.services.mozilla.com/D230170
In addition to upgrding our Stylelint packages, this patch also introduces the @stylistic/stylelint-plugin to preserve a number of rules that were completely removed in v16. It also migrates the code for the custom plugin introduced in bug 1838298 to ES Modules.
Differential Revision: https://phabricator.services.mozilla.com/D224250
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions
Differential Revision: https://phabricator.services.mozilla.com/D221396
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions
Differential Revision: https://phabricator.services.mozilla.com/D221396
- Give all bordered tables 100% width.
- Show which view is active in the sidebar by highlighting the active
tab in blue. Adjust the sidebar styles to match about:preferences.
- Increase the space between filter columns.
Differential Revision: https://phabricator.services.mozilla.com/D214353
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.
Differential Revision: https://phabricator.services.mozilla.com/D213865
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.
Differential Revision: https://phabricator.services.mozilla.com/D213880
The newtab page is styled according to a `lwt-newtab-brighttext`
attribute, which until now is only present in the newtab page, and not
exposed to the chrome. This is a problem for elements like feature
callouts, which we want to fit in with the newtab content, even though
they exist in the chrome. That's okay in many cases, because the
callouts also use theme properties, and there's usually a concordance
between `lwt-newtab-brighttext` and the content color scheme. But in a
few older (but very popular) themes, there are missing theme properties,
and it's possible for the newtab page to be very dark even though
prefers-color-scheme is not dark.
This patch resolves the issue by exposing `lwt-newtab-brighttext` to the
chrome, and using that attribute to theme newtab callouts.
Differential Revision: https://phabricator.services.mozilla.com/D208256
