Commit Graph

2950 Commits

Author SHA1 Message Date
Gregory Pappas
8c7823746a Bug 1918681 - part 2: Ensure the list-all-tabs button is visible the first time an extension hides a tab r=extension-reviewers,mconley,dao,willdurand
Depends on D224623

Differential Revision: https://phabricator.services.mozilla.com/D224624
2024-10-09 15:17:13 +00:00
Gregory Pappas
ab4cbe853e Bug 1918681 - part 1: Allow moving the list-all-tabs button again r=dao
In bug 878551, the ability to move the list-all-tabs button was	removed
for a few reasons:

> Moving this widget to the navbar gives it a tiny scaled version of Toolbar.png (like a horizontal line).

> Moving it back to the tab strip make it misbehave. It disappears, but sometimes flickers into view when opening/closing a tab.

These issues are no longer present, so we should be able to allow moving
the list-all-tabs button once again.

Differential Revision: https://phabricator.services.mozilla.com/D224623
2024-10-09 02:35:42 +00:00
Tamas Szentpeteri
0f6c394a5e Backed out changeset 04e9738d508b (bug 1918681) for causing mn failures related to test_initialize_vertical_tabs.py. CLOSED TREE 2024-10-09 03:28:27 +03:00
Gregory Pappas
c07e0ea87e Bug 1918681 - part 1: Allow moving the list-all-tabs button again r=dao
In bug 878551, the ability to move the list-all-tabs button was	removed
for a few reasons:

> Moving this widget to the navbar gives it a tiny scaled version of Toolbar.png (like a horizontal line).

> Moving it back to the tab strip make it misbehave. It disappears, but sometimes flickers into view when opening/closing a tab.

These issues are no longer present, so we should be able to allow moving
the list-all-tabs button once again.

Differential Revision: https://phabricator.services.mozilla.com/D224623
2024-10-08 20:02:20 +00:00
Tamas Szentpeteri
f344fc775f Backed out changeset 9ae14bfd6300 (bug 1918681) for causing mochitest failures on browser_UsageTelemetry_toolbars.js. CLOSED TREE 2024-10-08 21:21:38 +03:00
Gregory Pappas
49e18c5cd9 Bug 1918681 - part 1: Allow moving the list-all-tabs button again r=dao
In bug 878551, the ability to move the list-all-tabs button was	removed
for a few reasons:

> Moving this widget to the navbar gives it a tiny scaled version of Toolbar.png (like a horizontal line).

> Moving it back to the tab strip make it misbehave. It disappears, but sometimes flickers into view when opening/closing a tab.

These issues are no longer present, so we should be able to allow moving
the list-all-tabs button once again.

Differential Revision: https://phabricator.services.mozilla.com/D224623
2024-10-08 14:51:22 +00:00
Nikki Sharpley
b9c3ba706c Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,dao,sfoster,jsudiaman
- different sidebar button icons for expanded, collapsed sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning
- add hover animation to button

Differential Revision: https://phabricator.services.mozilla.com/D223406
2024-10-03 14:20:55 +00:00
Sam Foster
58c1f20705 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-10-02 22:14:13 +00:00
Sandor Molnar
fbc2bb1bd2 Backed out changeset 6ad99c7c787d (bug 1914452) for causing bc sider bar related failures. CLOSED TREE 2024-10-02 21:25:44 +03:00
Nikki Sharpley
20a153c56b Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,dao,sfoster,jsudiaman
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning

Differential Revision: https://phabricator.services.mozilla.com/D223406
2024-10-02 16:52:46 +00:00
Iulian Moraru
4a9432209c Backed out changeset 98b6ddc6deed (bug 1899598) for causing marionette failures on test_initialize_vertical_tabs.py. CLOSED TREE 2024-10-02 07:49:47 +03:00
Sam Foster
d888c32cc4 Bug 1919721 - Check size before building an empty placements list from gFuturePlacements in CustomizableUI. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D224268
2024-10-02 00:57:15 +00:00
Sam Foster
15a36fe751 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-10-01 23:37:37 +00:00
Jonathan Sudiaman
40b2800c49 Bug 1921539 - Sidebar button has no label when moved to the overflow menu r=sidebar-reviewers,fluent-reviewers,Gijs,sclements
Fluent messages were missing `label` attribute. Use the existing one from customizableWidgets.properties.

Differential Revision: https://phabricator.services.mozilla.com/D224167
2024-10-01 14:30:04 +00:00
Stanca Serban
24647acde4 Backed out changeset 0b970f2cd8fd (bug 1899598) for causing devtools failures in browser_aboutdebugging_devtoolstoolbox_tooltip_markupview.js. CLOSED TREE 2024-10-01 01:54:25 +03:00
Sebastian Hengst
f906185391 Bug 1921617 - disabled browser_876926_customize_mode_wrapping.js on Linux for Beta and Release. r=jmaher
The failure has been observed frequently since the test got reenabled in
bug 1917222 but only for central-as-beta simulations.

Differential Revision: https://phabricator.services.mozilla.com/D224125
2024-09-30 20:32:02 +00:00
Sam Foster
ef30ebaf5c Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-09-30 18:10:42 +00:00
Iulian Moraru
7f4f522517 Backed out changeset 5808b8ac42ad (bug 1914452) for causing multiple bc failures. CLOSED TREE 2024-09-28 02:36:30 +03:00
Nikki Sharpley
8536a92e8d Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,sfoster,jsudiaman
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button

Differential Revision: https://phabricator.services.mozilla.com/D223406
2024-09-27 20:33:59 +00:00
Florian Quèze
165920b94c Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi.
Differential Revision: https://phabricator.services.mozilla.com/D222608
2024-09-25 10:00:41 +00:00
Sandor Molnar
5095328e2d Backed out 5 changesets (bug 1918702) for causing bc failures @ browser_aaa_eventTelemetry_run_first.js CLOSED TREE
Backed out changeset f55480885aeb (bug 1918702)
Backed out changeset db1eaf09430d (bug 1918702)
Backed out changeset a9179f6e684d (bug 1918702)
Backed out changeset f9d3349e6fe3 (bug 1918702)
Backed out changeset 10d2957bbfe8 (bug 1918702)
2024-09-25 12:38:05 +03:00
Florian Quèze
3cf2dde6da Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi.
Differential Revision: https://phabricator.services.mozilla.com/D222608
2024-09-25 07:19:05 +00:00
Florian Quèze
cd093f0a88 Bug 1918702 - Migrate telemetry events to use Glean APIs for screenshots, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D222607
2024-09-20 13:58:19 +00:00
Joel Maher
beccd9e33d Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D221307
2024-09-19 02:52:04 +00:00
Joel Maher
02bf7c92f9 Bug 1917073 - adjust skip-if -> run-if for browser/components/.../browser.toml. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,places-reviewers,mtigley,robwu
Differential Revision: https://phabricator.services.mozilla.com/D221247
2024-09-16 06:12:31 +00:00
Sam Foster
adb5a03beb Bug 1899346 - Move CUI widgets out of the horizontal tabstrip when in vertical tabs mode. r=sidebar-reviewers,mconley,sclements,webdriver-reviewers,whimboo,tabbrowser-reviewers
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode

Differential Revision: https://phabricator.services.mozilla.com/D217161
2024-09-11 16:27:08 +00:00
Dave Townsend
c88e214a59 Bug 1916961: Right clicking in the vertical tabs sidebar should show the tabs context menu. r=sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D221129
2024-09-05 16:32:59 +00:00
Tamas Szentpeteri
6c877ec7e8 Backed out changeset 3423c859c8be (bug 1916961) for causing mochitest failures on browser_UsageTelemetry_toolbars.js. CLOSED TREE 2024-09-05 18:30:38 +03:00
Dave Townsend
59044cc9ba Bug 1916961: Right clicking in the vertical tabs sidebar should show the tabs context menu. r=sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D221129
2024-09-05 14:16:37 +00:00
Cristina Horotan
211657609a Backed out changeset 0c7c121f1fa3 (bug 1899346) for causing Mn failures at test_quit_restart.py CLOSED TREE 2024-09-04 05:34:33 +03:00
Sam Foster
5ebd63c578 Bug 1899346 - Move CUI widgets out of the horizontal tabstrip when in vertical tabs mode. r=sidebar-reviewers,mconley,sclements,webdriver-reviewers,whimboo
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode

Differential Revision: https://phabricator.services.mozilla.com/D217161
2024-09-04 00:12:07 +00:00
Kelly Cochrane
04a3166151 Bug 1913157 - Ensure new sidebar pref is enabled when enabling vertical tabs in Firefox Labs r=sidebar-reviewers,nsharpley,mconley
Differential Revision: https://phabricator.services.mozilla.com/D219887
2024-08-27 17:02:04 +00:00
Norisz Fay
a1d50a6697 Backed out changeset c540259f992c (bug 1913157) for causing bc failure on browser_sidebar_prefs.js CLOSED TREE 2024-08-27 17:31:26 +03:00
Kelly Cochrane
448c1dcaf6 Bug 1913157 - Ensure new sidebar pref is enabled when enabling vertical tabs in Firefox Labs r=sidebar-reviewers,nsharpley,mconley
Differential Revision: https://phabricator.services.mozilla.com/D219887
2024-08-27 13:08:12 +00:00
timw-dev
84076b9d83 Bug 1896764 - onViewToolbarsPopupShowing and ToolbarContextMenu should move out of browser.js.r=scunnane,rpl
Differential Revision: https://phabricator.services.mozilla.com/D217795
2024-08-22 11:11:50 +00:00
Sam Foster
5211719945 Bug 1912312 - Insert the sidebar-button into the navbar when the sidebar.revamp pref is enabled. r=sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D218871
2024-08-09 16:55:40 +00:00
Masayuki Nakano
528d09c312 Bug 1904279 - Get rid of dom.w3c_pointer_events.dispatch_click_as_pointer_event pref r=smaug,pip-reviewers,search-reviewers,devtools-reviewers,urlbar-reviewers,nchevobbe,dao,jteow,mconley
Keep supporting the pref makes a lot of `click`, `auxclick` and `contextmenu`
event creators complicated (and look messy).  So, let's delete it as soon as
possible.

Differential Revision: https://phabricator.services.mozilla.com/D217225
2024-07-30 06:49:42 +00:00
Moritz Beier
650113020b Bug 1863530 - Remove browser.search.widget.inNavBar pref. r=dao,settings-reviewers,search-reviewers,omc-reviewers,urlbar-reviewers,Gijs,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D215607
2024-07-23 17:29:00 +00:00
William Wen
060019310e Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney,firefox-desktop-core-reviewers ,Gijs,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D209857
2024-07-18 15:56:17 +00:00
Meg Viar
76dd97ec96 Bug 1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215429
2024-07-15 13:49:33 +00:00
Kelly Cochrane
b40657ff11 Bug 1897976 - Update existing tests involving sidebar-button in the nav bar for when sidebar.revamp pref is flipped on r=places-reviewers,sidebar-reviewers,urlbar-reviewers,mak,sfoster,Gijs,sclements
Differential Revision: https://phabricator.services.mozilla.com/D215253
2024-07-12 15:58:29 +00:00
Sandor Molnar
0aa78a67c5 Backed out changeset bccc4faa349a (bug 1904630) for causing bc perma failures @ browser/components/extensions/test/browser/browser_ext_menus.js CLOSED TREE 2024-07-12 18:55:26 +03:00
Meg Viar
ca1ff96b3d Bug 1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215429
2024-07-12 13:53:00 +00:00
Cristian Tuns
1606b37864 Backed out changeset b44ee81f22b7 (bug 1880230) for causing bc failures in browser_privatebrowsing_resetPBM.js CLOSED TREE 2024-07-11 11:34:19 -04:00
William Wen
7ddfef8c45 Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney,firefox-desktop-core-reviewers ,Gijs,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D209857
2024-07-11 14:30:52 +00:00
Tamas Szentpeteri
79cd189012 Backed out changeset ab233ce47da1 (bug 1904630) for causing mochitest failures on browser_ext_contextMenus.js. CLOSED TREE 2024-07-09 18:23:08 +03:00
Meg Viar
b81abef302 Bug 1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215429
2024-07-09 13:16:13 +00:00
David P
5c77b63f65 Bug 1893119: Part 20 - Move EndDragSession from nsIDragService to nsIDragSession r=gstoll,rkraesig,win-reviewers,geckoview-reviewers,m_kato
This is a straightforward move.  It does take the liberty of breaking out an
EndDragSessionImpl method, which will be needed later.

Differential Revision: https://phabricator.services.mozilla.com/D211083
2024-07-04 07:48:11 +00:00
David P
808c72fba0 Bug 1893119: Part 15 - Give StartDragSessionForTests a window to start the drag session on r=gstoll,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D211079
2024-07-04 07:48:09 +00:00
Cristian Tuns
0aedcf9a34 Backed out changeset 7f2beff76748 (bug 1880230) for causing bc failures in browser_913972_currentset_overflow.js CLOSED TREE 2024-06-29 00:00:06 -04:00