Commit Graph

920 Commits

Author SHA1 Message Date
Sylvestre Ledru
8ae54ea4f9 Bug 1519636 - Reformat recent changes to the Google coding style r=geckoview-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,nalexander,gstoll,tcampbell,janv,julienw
Updated with clang-format version 19.1.7 (taskcluster-DYvBxDZJRVqTi8E7pTSJAQ)

Differential Revision: https://phabricator.services.mozilla.com/D249880
2025-05-17 19:11:13 +00:00
Nishu Sheth
7622586f14 Bug 1909845 - Updated ConstructCommandLine to return a UniquePtr r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D249476
2025-05-15 20:09:26 +00:00
Daniel Thorn
127d08ec0b Bug 1959483 - Port tests from ExperimentFakes and ExperimentTestUtils to NimbusTestUtils in browser/components/shell r=nimbus-reviewers,beth
Differential Revision: https://phabricator.services.mozilla.com/D247016
2025-05-01 22:42:15 +00:00
Gijs Kruitbosch
6e00b6ddab Bug 1958070 - move misc taskbar and other shell integration bits out of BrowserGlue, r=application-update-reviewers,firefox-desktop-core-reviewers ,bytesized,frontend-codestyle-reviewers,mossop
Doing this helps with code organization and keeping related things together,
further shrinking the list of custom component-specific code in
BrowserGlue.sys.mjs .

Differential Revision: https://phabricator.services.mozilla.com/D244427
2025-04-23 08:28:41 +00:00
Daisuke Akatsuka
c5cba09269 Bug 1915762: Apply getFaviconForPage() in nsGNOMEShellSearchProvider r=mak
Depends on D239487

Differential Revision: https://phabricator.services.mozilla.com/D240120
2025-04-23 04:40:34 +00:00
Cristian Tuns
a9d8f21da6 Backed out 11 changesets (bug 1915762) for causing node failures in gecko.d.ts CLOSED TREE
Backed out changeset 5c7edcb3b105 (bug 1915762)
Backed out changeset 05691232a461 (bug 1915762)
Backed out changeset 964a29c9a07a (bug 1915762)
Backed out changeset 5d74e419e249 (bug 1915762)
Backed out changeset 677c35e884d3 (bug 1915762)
Backed out changeset 8a7b0b87a0ef (bug 1915762)
Backed out changeset 5e38449cd4d9 (bug 1915762)
Backed out changeset ec8a0553d97a (bug 1915762)
Backed out changeset fb2232e5f3b5 (bug 1915762)
Backed out changeset b290501f5832 (bug 1915762)
Backed out changeset 9955e42e749b (bug 1915762)
2025-04-22 22:15:19 -04:00
Daisuke Akatsuka
2e7e944793 Bug 1915762: Apply getFaviconForPage() in nsGNOMEShellSearchProvider r=mak
Depends on D239487

Differential Revision: https://phabricator.services.mozilla.com/D240120
2025-04-23 01:49:38 +00:00
Joel Maher
986c1b9cc2 Bug 1959265 - clean and sanitize browser/**/xpcshell.toml files. r=aryx,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,backup-reviewers,home-newtab-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,willdurand,tarek,dimi,jteow,sthompson,mconley,pdahiya,mossop
Differential Revision: https://phabricator.services.mozilla.com/D244829
2025-04-17 18:30:44 +00:00
Simon Friedberger
ba25883f84 Bug 1956801. Add CSP to win.xhtml r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D243580
2025-04-03 10:04:57 +00:00
Francesco Lodolo (:flod)
88fdda4cc7 Bug 1955747 - Migrate strings in shellservice.properties to Fluent, r=nrishel,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D242977
2025-04-02 05:42:44 +00:00
Eric Chen
67bb7296ec Bug 1955385 - revise MSIX code path for CheckCurrentProcessAUMIDForTesting r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D242588
2025-03-23 19:07:20 +00:00
Eric Chen
192c0c6787 Bug 1950734 - Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D239827
2025-03-19 20:41:18 +00:00
Beth Rennie
549fd892f5 Bug 1943119 - Remove ExperimentAPI._store r=nalexander,nimbus-reviewers,emcminn
ExperimentAPI._store used to create a new, separate ExperimentStore in
the child process until bug 1941948 (which was unnecessary) and now only
exists for vestigial reasons. Use ExperimentAPI._manager.store
everywhere.

Differential Revision: https://phabricator.services.mozilla.com/D240414
2025-03-17 17:05:56 +00:00
Butkovits Atila
7f46417564 Backed out 2 changesets (bug 1947908, bug 1943119) for causing failures at browser_setDefaultPDFHandler.js. CLOSED TREE
Backed out changeset f605bd14b753 (bug 1947908)
Backed out changeset 6498ad43bb47 (bug 1943119)
2025-03-13 23:42:12 +02:00
Beth Rennie
eca22ee4e9 Bug 1943119 - Remove ExperimentAPI._store r=nalexander,nimbus-reviewers,emcminn
ExperimentAPI._store used to create a new, separate ExperimentStore in
the child process until bug 1941948 (which was unnecessary) and now only
exists for vestigial reasons. Use ExperimentAPI._manager.store
everywhere.

Differential Revision: https://phabricator.services.mozilla.com/D240414
2025-03-13 15:52:44 +00:00
Cristina Horotan
bb136e0d12 Backed out changeset c7a895ce1e23 (bug 1950734) for causing bc failures at browser_processAUMID.js. CLOSED TREE 2025-03-13 07:31:36 +02:00
Eric Chen
3fa85c5c7a Bug 1950734 - Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D239827
2025-03-12 23:45:49 +00:00
Eric Chen
d4bc2bcaee Bug 1949263 - prevent MSIX Firefox from calling PollAppsFolderForShortcut r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D239824
2025-03-03 15:34:20 +00:00
Tom Schuster
f81d16e706 Bug 1941365 - Use a <?csp ?> processing instructions instead of a csp attribute. r=Gijs,settings-reviewers,devtools-reviewers,places-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D238474
2025-02-26 16:13:13 +00:00
Sandor Molnar
bc9b3e4b97 Backed out 2 changesets (bug 1941365) for causing CSP related dt failures. CLOSED TREE
Backed out changeset b022efa3b9e7 (bug 1941365)
Backed out changeset 90c5b60c6163 (bug 1941365)
2025-02-26 17:28:48 +02:00
Tom Schuster
07c8930ba5 Bug 1941365 - Use a <?csp ?> processing instructions instead of a csp attribute. r=Gijs,settings-reviewers,devtools-reviewers,places-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D238474
2025-02-26 14:36:42 +00:00
Florian Quèze
b412ac1d8d Bug 1944631 - Migrate histograms to use Glean APIs for BROWSER_*, r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D238788
2025-02-20 19:34:10 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Tom Schuster
0e404dc903 Bug 1945153 - Remove inline event handlers from SetDesktopBackgroundDialog r=firefox-desktop-core-reviewers ,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D236348
2025-02-03 16:02:02 +00:00
Florian Quèze
1ee252004d Bug 1935420 - rewrite JS code storing histograms in local variables to make automatic glean migration easier, r=chutten,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,places-reviewers,markh,nsharpley.
Differential Revision: https://phabricator.services.mozilla.com/D234008
2025-01-24 16:18:32 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Nicholas Rishel
7034f58767 Bug 1932795 - Fix debug build assert by moving SourceSurface::GetFrame call to main thread during nsWindowsShellService::CreateWindowsIcon. r=nalexander,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D229849
2024-11-27 21:56:01 +00:00
Sebastian Hengst
8424c52dc1 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228118
2024-11-19 17:19:24 +00:00
Nicholas Rishel
57ab7f1ebd Bug 1930048 - Fix MinGW compile errors. r=mpohle,win-reviewers,gstoll
Tagalong: Clean up include order and remove unnecessary includes.

Differential Revision: https://phabricator.services.mozilla.com/D229033
2024-11-14 20:45:22 +00:00
Max Christian Pohle
846bcd126a Bug 1923448 - Generalized Windows Pinning, r=nrishel,gfx-reviewers,nical
Differential Revision: https://phabricator.services.mozilla.com/D224975
2024-11-12 22:48:55 +00:00
Nicholas Rishel
2a8da6a369 Bug 1893458 - Verify Start Menu shortcuts created at runtime have propagated to shell:appsfolder before attempting to pin them. r=win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D227131
2024-11-07 21:51:23 +00:00
Stanca Serban
1cefb44ccb Backed out changeset 2fe294eb4a06 (bug 1923448) for causing nsWindowsShellService.cpp. CLOSED TREE 2024-11-07 12:37:21 +02:00
Max Christian Pohle
423ab686ff Bug 1923448 - Generalized Windows Pinning, r=nrishel,gfx-reviewers,nical
Differential Revision: https://phabricator.services.mozilla.com/D224975
2024-11-07 09:54:52 +00:00
Nicholas Rishel
085457c06f Bug 1926151 - Remove Desktop and Public Desktop from folders a pinnable shortcut can exist in. r=bhearsum
We prioritize using `ITaskbarManager` now, which requires a shortcut exist in a location visible from `shell:appsfolder`. `IPinnedList3` can use shortcuts from Desktop and Public Desktop (and potentially other locations) but there's no reason to check for these cases since we have already created the shortcut for `ITaskbarManager`. The rare case of failing to create as shortcut for `ITaskbarManager` is not worth accounting for given `IPinnedList3` is not supported in newer versions of Windows.

Differential Revision: https://phabricator.services.mozilla.com/D227134
2024-10-31 19:53:56 +00:00
Nicholas Rishel
51fef936bb Bug 1926151 - Pre: Rename Matching to Pinnable to better convey usage of hasPinnableShortcut. r=bhearsum,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D227133
2024-10-31 19:53:55 +00:00
serge-sans-paille
262f78c07f Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-28 08:21:19 +00:00
Alexandru Marc
a5eb905bf4 Backed out changeset d92f391b3b0c (bug 1922838) for backing out bug 1915351 2024-10-25 16:42:33 +03:00
serge-sans-paille
07101ac24d Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 09:06:01 +00:00
Alexandru Marc
004e704b22 Backed out changeset 448597bce69d (bug 1922838) for causing build bustages. CLOSED TREE 2024-10-24 11:37:49 +03:00
serge-sans-paille
2c916d4973 Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 07:38:30 +00:00
Emilio Cobos Álvarez
4c840d573b Bug 1925866 - NS_NewLocalFile's aFollowSymlinks arg is unused. r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,win-reviewers,karlt,nika,rkraesig
Remove it and related functions, and update the callers.

Differential Revision: https://phabricator.services.mozilla.com/D226261
2024-10-22 09:38:16 +00:00
stransky
c8940b8f54 Bug 1921719 [Linux] Gnome shell search - quit early if we don't have any search results r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D224089
2024-10-01 09:02:43 +00:00
Martin Sirringhaus
74d886e471 Bug 1634961 - Add option to list/switch to open tabs in gnome shell search provider. r=emilio,stransky
Differential Revision: https://phabricator.services.mozilla.com/D220671
2024-09-25 11:17:43 +00:00
Nicholas Rishel
fa92b82d1a Bug 1917674 - Part 2: Ensure shell service native interface members are present on ShellService. r=nalexander
A quirk of the JavaScript implementation of XPCOM's QueryInterface is that it loads the interface's functions onto the queried object. For Services like `ShellService` this creates situations where the interface can be initialized at a distance, causing races depending on how Firefox is run - e.g. Desktop vs Background Task. To ensure consistent behavior this patch forces `ShellService` initialization of the native interface so that the native functions are always present.

To accomplish this, `nsIWindowsShellService` has been modified to inherit from `nsIShellService` to match other platforms and ensure that querying it also loads the `nsIShellService` members into `shellService`.

Differential Revision: https://phabricator.services.mozilla.com/D222154
2024-09-13 17:38:50 +00:00
Nicholas Rishel
303dbaa6f5 Bug 1917674 - Part 1: Fix set to default throwing exception from ShellService in Firefox Background Tasks. r=nalexander,mossop
This succeeds in normal Firefox due to `QueryInterface(Ci.nsIWindowsShellService)` having likely been called on the `nsIShellService` prior to this call, which populates the root `nsIShellService` JavaScript object with the queried interface methods. In Firefox Background Tasks the relevant `QueryInterface` is unlikely to be called ahead of time, resulting in an exception.

Differential Revision: https://phabricator.services.mozilla.com/D221540
2024-09-13 17:38:49 +00:00
stransky
d8ddeccbaa Bug 1917515 [Linux] Check remote command line params before use r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D221624
2024-09-12 12:17:06 +00:00
Nicholas Rishel
08191d01a4 Bug 1917373 - Check that method is present for shellService to prevent exception and dead logging code. r=mpohle
Differential Revision: https://phabricator.services.mozilla.com/D221537
2024-09-10 18:57:00 +00:00
Butkovits Atila
491ec7019a Backed out changeset b469fb3f8d08 (bug 1917373) for causing failures at browser_setDefaultBrowser.js. CLOSED TREE 2024-09-10 03:52:37 +03:00