Commit Graph

2644 Commits

Author SHA1 Message Date
Kyle Machulis
8416fded30 Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState r=bzbarsky,nika
Creates the nsDocShellLoadState object, which is basically
nsDocShellLoadInfo plus a few extra fields to make it usable as a
single argument to nsDocShell::LoadURI (and eventually
nsDocShell::InternalLoad).

Subframe history handling is a huge logic block in
nsDocShell::LoadURI, which is only used on history loads. This patch
also extracts the logic out into its own function to make the body of
LoadURI clearer.

Differential Revision: https://phabricator.services.mozilla.com/D6944
2018-10-26 03:50:37 +00:00
Nicholas Hurley
ae88624519 Bug 1050329 - part 2 - Add error page for h2 goaway. r=dragana,bzbarsky
This is kind of like the previous patch (where we had a not-very-friendly user experience shutting down misbehaving h2 sessions), but in this case the server has proven to us that it can speak a minimum of h2, so we don't want to just fallback. Instead, when we send a GOAWAY frame because we have detected some error on the part of the server, if it's a top-level page load, we'll show an error page explaining that the server spoke bad http/2, and the site admin(s) need to be contacted. We already did this for INADEQUATE_SECURITY (which is its own special case still), but that didn't cover all the cases.

Differential Revision: https://phabricator.services.mozilla.com/D8436
2018-10-25 20:46:46 +00:00
Narcis Beleuzu
28f99c035d Backed out changeset 8dd09fad1f35 (bug 1492648) for bc failures on browser_auto_close_window.js 2018-10-19 10:11:33 +03:00
Kyle Machulis
dc2a795ff8 Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState r=bzbarsky,nika
Creates the nsDocShellLoadState object, which is basically
nsDocShellLoadInfo plus a few extra fields to make it usable as a
single argument to nsDocShell::LoadURI (and eventually
nsDocShell::InternalLoad).

Subframe history handling is a huge logic block in
nsDocShell::LoadURI, which is only used on history loads. This patch
also extracts the logic out into its own function to make the body of
LoadURI clearer.

Differential Revision: https://phabricator.services.mozilla.com/D6944
2018-10-18 22:14:54 +00:00
Johann Hofmann
bd1813f9f4 Bug 1484255 - Add Telemetry Events for the certificate error pages. r=nhnt11,keeler
Differential Revision: https://phabricator.services.mozilla.com/D8281
2018-10-17 13:10:26 +00:00
Ciure Andrei
aa65696252 Backed out changeset 1119f9458b5d (bug 1484255) for browser_aboutCertError_telemetry.js failures CLOSED TREE 2018-10-16 03:33:42 +03:00
Johann Hofmann
89d3e9b226 Bug 1484255 - Add Telemetry Events for the certificate error pages. r=nhnt11,keeler
Differential Revision: https://phabricator.services.mozilla.com/D8281
2018-10-15 23:00:08 +00:00
Ehsan Akhgari
a00e095d4d Bug 1498720 - Ensure that we revoke a subframe's storage access when it is removed from the DOM r=baku
Differential Revision: https://phabricator.services.mozilla.com/D8615
2018-10-15 10:37:11 +00:00
Dorel Luca
a5b6424b63 Backed out changeset 8d7987ea4fb1 (bug 1490257) for causing android failures. CLOSED TREE 2018-10-15 14:39:00 +03:00
Jonathan Kingston
8ccca3858d Bug 1490257 - Add asserts and remove implied system triggering principal code r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D8368
2018-10-15 06:29:45 +00:00
Mats Palmgren
a0cc868f8f Bug 1494745 part 5 - Don't check the result from ns[Auto]TObserverArray insertions since they're infallible. r=bz 2018-10-14 18:12:23 +02:00
Gijs Kruitbosch
fd849225b3 Bug 1493634 - make docshell responsible for outer window IDs, r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D7702
2018-10-10 10:20:36 +00:00
Boris Zbarsky
cc13eb826b Bug 1497598. Stop using GetCurrentJSContext in loadcontext code. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D8122
2018-10-09 18:28:17 +00:00
Brad Werth
c50fd7151e Bug 1290420 Part 4: Make the PresShell create a MobileViewportManager on demand. r=botond,smaug
Depends on D3376

Differential Revision: https://phabricator.services.mozilla.com/D3377
2018-10-04 03:28:40 +00:00
Botond Ballo
62bc204ac9 Bug 1290420 Part 1: Add a docshell flag for overriding meta viewport handling. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D3373
2018-10-04 00:19:40 +00:00
Andrew McCreight
05b70f0bb6 Bug 1493737 - Fix many trivial calls to do_QueryInterface r=smaug
If class A is derived from class B, then an instance of class A can be
converted to B via a static cast, so a slower QI is not needed.

Differential Revision: https://phabricator.services.mozilla.com/D6861
2018-10-01 21:38:01 +00:00
Mark Banner
38f9a15a1f Bug 1489503 - In docShell, don't set the same title a second time. r=bzbarsky
This avoids setting the title a second time when the title and uri remain the same across setTitle calls. This means we can avoid unnecessary history updates which currently result in extra disk i/o.

Differential Revision: https://phabricator.services.mozilla.com/D5431
2018-09-29 07:55:16 +00:00
Ehsan Akhgari
7bddc35620 Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-28 14:46:02 -04:00
Noemi Erli
7fb8829472 Backed out 12 changesets (bug 1493563) for failures in test_css-logic-getCssPath.html CLOSED TREE
Backed out changeset d2e83655082f (bug 1493563)
Backed out changeset 1ce58f004593 (bug 1493563)
Backed out changeset 344298c73ee7 (bug 1493563)
Backed out changeset 02b8b073f7d7 (bug 1493563)
Backed out changeset 3ef707008502 (bug 1493563)
Backed out changeset bb2720a401fe (bug 1493563)
Backed out changeset ce0211be57a1 (bug 1493563)
Backed out changeset 83d6c2bf8dc6 (bug 1493563)
Backed out changeset 1844af4cc25b (bug 1493563)
Backed out changeset c8ab17addb7a (bug 1493563)
Backed out changeset a1ff0cd62563 (bug 1493563)
Backed out changeset 932b41e211e0 (bug 1493563)
2018-09-28 21:31:18 +03:00
Ehsan Akhgari
6c662bd61e Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-28 13:24:41 -04:00
Gijs Kruitbosch
ae4c0d1d3d Bug 1493655 - make nsISecureBrowserUI initialize from a docshell instead of a window, r=keeler,nika
This also removes the (afaict, unused) stub implementation from TabParent. The netwerk header
inclusions were necessary because those files included TabParent.h and through it,
nsISecureBrowserUI, but now TabParent.h no longer does that.

Differential Revision: https://phabricator.services.mozilla.com/D6829
2018-09-26 17:48:38 +00:00
Margareta Eliza Balazs
1290c58f68 Merge inbound to mozilla-central. a=merge 2018-09-25 12:42:09 +03:00
Christoph Kerschbaumer
619aeb7fa1 Bug 1490874: Log Principal based Security Errors to the Security pane in the console. r=smaug 2018-09-25 07:25:05 +02:00
Tim Huang
dd9540847a Bug 680300 - Part 1: Stopping reporting errors when loading an unknown external protocol. r=smaug
This patch makes the docshell not to report an error if it is a unknown
protocol error. However, we will still display the error page in this
case.

Differential Revision: https://phabricator.services.mozilla.com/D3492
2018-09-25 07:50:28 +00:00
shindli
23c0be1304 Backed out changeset 510e95767aeb (bug 1490874) for security failures in browser/components/payments/test/mochitest/test_basic_card_form.html CLOSED TREE 2018-09-24 11:43:30 +03:00
Christoph Kerschbaumer
72e1ad4898 Bug 1490874: Log Principal based Security Errors to the Security pane in the console. r=smaug 2018-09-24 09:34:04 +02:00
Ehsan Akhgari
075e40f8f6 Bug 1492039 - Remove the XPCOM component registration for SessionStorageManager; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6118
2018-09-18 09:42:43 -04:00
Ehsan Akhgari
5b2864e8bb Bug 1491735 - Remove the XPCOM registration for nsWebBrowserFind; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D5993
2018-09-17 19:48:13 -04:00
Andreas Farre
f45379434e Bug 1480113 - Split parent process specific parts out of BrowsingContext r=peterv
Create ChromeBrowsingContext and move parent process specific parts
from BrowsingContext there. After that make sure that all
BrowsingContexts created in the parent process is actually
ChromeBrowsingContexts and all BrowsingContexts in the child processes
are BrowsingContexts.

Differential Revision: https://phabricator.services.mozilla.com/D5419
2018-09-14 14:57:18 +00:00
Nicholas Nethercote
76fd3d6b38 Bug 1490858 - Make most nsISHEntry attributes infallible. r=nika
The patch also removes some NS_ENSURE_ARG_POINTER checks from these attributes'
getters. Most of these getters already lack such checks, and as long as the
infallible getters are used a non-null pointer is guaranteed. In the worst case
we'll safely null-crash anyway.
2018-09-07 11:56:23 +10:00
Dylan Roeh
af0804d29d Bug 1489257 - Backed out 3 changesets (bug 1441059, bug 1478171) for causing bug 1489257. r=me
Backed out changeset f7bd4f224f9a (bug 1441059)
Backed out changeset e66e6bd82e3f (bug 1441059)
Backed out changeset 94cfd6113ca7 (bug 1478171)
2018-09-13 12:27:23 -05:00
Nicholas Nethercote
e7b4ef7cd5 Bug 1490524 - Streamline nsISHistory a little more. r=nika
- Move VIEWER_WINDOW from nsISHistory to nsSHistory.

- Mark some C++-only nsISHistory methods as [noscript, notxpcom].

- Add gotoIndex() to nsISHistory so that LegacySHistoryImpl() can be removed.
2018-09-11 16:08:39 +10:00
Nicholas Nethercote
ab66aa04ba Bug 1490524 - Make some nsISHistory attributes infallible. r=nika
This also requires making nsISHistory `builtinclass`.
2018-09-11 16:08:37 +10:00
arthur.iakab
6079672082 Backed out changeset 16d2d6dc3cdf (bug 1489257)on request by droeh for causing geckowiev failures 2018-09-11 18:47:58 +03:00
Dylan Roeh
c6b369eb4c Bug 1489257 - Backed out 3 changesets (bug 1441059, bug 1478171) for causing bug 1489257. r=me
Backed out changeset f7bd4f224f9a (bug 1441059)
Backed out changeset e66e6bd82e3f (bug 1441059)
Backed out changeset 94cfd6113ca7 (bug 1478171)
2018-09-10 16:15:31 -05:00
Sylvestre Ledru
0c1c733b0d Bug 1489454 - Remove all trailing whitespaces (again) r=Ehsan
This also includes moving some files to the regular format.

Differential Revision: https://phabricator.services.mozilla.com/D5249
2018-09-07 14:47:51 +00:00
Nicholas Nethercote
e0b1835fc5 Bug 1488628 - Change some nsIWebNavigation method arguments from wstring to AString. r=nika 2018-09-05 13:42:16 +10:00
Nicholas Nethercote
3d067dad0c Bug 1488628 - Change nsISHEntry.title to an AString. r=nika
This patch also removes the setTitle() method and makes `title` non-readonly.
2018-09-05 11:29:36 +10:00
Nicholas Nethercote
aa1ac557fc Bug 1488321 - Remove all traces of the "transaction" terminology in SHistory. r=nika.
This patch:

- removes GetTransactionAtIndex(), because getTransactionAtIndex() can be used
  instead;

- renames a lot of things;

- updates some comments.
2018-09-05 09:03:22 +10:00
Nicholas Nethercote
357e821fd9 Bug 1488321 - Fix up nsISHEntry.{index,getEntryAtIndex()}. r=nika
nsISHEntry.index is readonly, but if you pass `true` as getEntryAtIndex()'s
second argument, nsISHEntry.index will be modified. This is pretty gross.

This patch changes `index` so it's not readonly (because it's not!) and removes
getEntryAtIndex()'s second argument.
2018-09-05 09:02:37 +10:00
Ehsan Akhgari
0054eabedd Bug 1488111 - Remove the XPCOM component registration for nsCommandManager; r=qdot
Differential Revision: https://phabricator.services.mozilla.com/D4834
2018-09-04 15:03:22 -04:00
Ehsan Akhgari
364dd5924a Bug 1487396 - Part 1: Enable the secure browser UI object to keep track of the newly added content blocking states for each document; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D4809
2018-09-04 14:20:22 -04:00
Nicholas Nethercote
789c176560 Bug 1487328 - Make nsSHistory *not* implement nsIWebNavigation. r=nika
nsSHistory currently implements nsIWebNavigation, but only three of the methods
are actually used, and the rest call MOZ_CRASH. This patch removes the
inheritance and changes the implementations of those three methods (Reload(),
GetCurrentURI(), and GotoIndex()) to pure C++.

There is one test, bug662200_window.xul, that calls Reload() from JS, which is
no longer possible. Fortunately, nsSHistory::ReloadCurrentEntry() -- which *is*
available from JS -- is similar enough to Reload(0) that it can be used
instead.

(The only difference between Reload(0) and ReloadCurrentEntry() is that the
former triggers the `OnHistoryReload` notification and the latter triggers
`OnHistoryGotoIndex`, which doesn't matter for this test.)
2018-09-03 09:27:37 +10:00
Nicholas Nethercote
61fa13d890 Bug 1487296 - Merge nsISHistoryInternal into nsISHistory. r=nika
With legacy add-ons gone, there is no benefit to keeping them separate.
2018-08-30 11:37:40 +10:00
Boris Zbarsky
0a587b88a6 Bug 1486932 part 2. Remove nsIDOMStorage. r=mccr8 2018-08-31 13:56:55 -04:00
Gabriele Svelto
b3b1ef307d Bug 1486772 - Refactor the screen-orientation types and headers r=smaug
This patch removes the 'ScreenOrientationInternal' type from
dom/base/ScreenOrientation.h and moves it into the
HalScreenConfiguration.h header, renaming it simply to 'ScreenOrientation'
in the process. This has several knock-off effects:

- It allows files that needed ScreenOrientationInternal to include a much
  smaller header than before

- It greatly reduces the number of headers pulled in when including Hal.h

- It clarifies the role of the type. The 'Internal' part in the name had
  nothing to do with it being part of the implementation. The type was public
  and called that way only to avoid clashing with the 'ScreenOrientation'
  class. Since we moved it into a different namespace it can be renamed
  safely.

- It allows a file that was manually re-declaring 'ScreenConfigurationInternal'
  type to use the original one

- Finally this fixes a few files which were missing headers they actually
  required but that would still build because unified compilation put them into
  units that already had those headers thanks to ScreenConfiguration.h

Differential Revision: https://phabricator.services.mozilla.com/D4458
2018-08-29 20:54:56 +00:00
Andreas Farre
383c4c2fb1 Bug 1481238 - Create WebIDL interface for BrowsingContext. r=peterv
Expose Chrome only WebIDL to interface with BrowsingContext from
script. The API consists of parent, firstChild and nextSibling
attributes for BrowsingContext, and the browsingContext attribute for
Window.
2018-08-29 05:00:00 +03:00
Nicholas Nethercote
cd127441a0 Bug 1486690 - Remove unnecessary checks after moz_xmalloc() calls. r=glandium
There are surprisingly many of them.

(Plus a couple of unnecessary checks after `new` calls that were nearby.)
2018-08-28 15:56:01 +10:00
Ehsan Akhgari
10f79b9857 Bug 1486092 - Part 1: Move the browser.contentblocking.enabled pref to StaticPrefs; r=baku 2018-08-27 09:22:01 -04:00
Nicholas Nethercote
4683d6b86a Bug 1485279 - Merge nsISHContainer into nsISHEntry. r=qdot
nsSHEntry is the only class that instantiates those two interfaces, so the
separation is not useful. This lets us remove numerous pointless QIs.
2018-08-22 19:20:56 +10:00