Commit Graph

1882 Commits

Author SHA1 Message Date
Stephen Thompson
504eddfac8 Bug 1933114 - add tests for restoring tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers
Adds/updates test cases for restoring saved tab groups, closed tab groups, and open tab groups from session state

Differential Revision: https://phabricator.services.mozilla.com/D230322
2024-12-12 15:22:41 +00:00
Jeremy Swinarton
cf23be9260 Bug 1933485: Ensure tab groups always appear in history menus r=dao,sthompson,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D230985
2024-12-12 14:36:08 +00:00
Joel Maher
64f299c4bd Bug 1936417 - extend windows11 skip-if conditions for marionette tests to win11 24H2 update. r=whimboo
Differential Revision: https://phabricator.services.mozilla.com/D231798
2024-12-12 13:09:19 +00:00
Sam Foster
a15eb85904 Bug 1934182 - Disable the restore session infobar by default in all tests r=sessionstore-reviewers,Gijs,dao,perftest-reviewers,sparky
- But reset the default value in the browser-mochitest-chrome session store suite.

Differential Revision: https://phabricator.services.mozilla.com/D230861
2024-12-11 18:02:53 +00:00
Stephen Thompson
4b0b5070a8 Bug 1933574 - saved tab groups session schema change r=dao,sessionstore-reviewers,tabbrowser-reviewers
This patch makes saved tab groups use the "closed tabs" schema for storing tab data. This makes saved tab groups consistent with closed tabs and closed tab groups. The tab/tab group restoration code is built to work with the "closed tabs" schema, so this schema change allows saved tab groups to be restored correctly.

Bug 1933114 will add and improve the tests for restoring tab groups.

Differential Revision: https://phabricator.services.mozilla.com/D231818
2024-12-11 16:47:41 +00:00
Sandor Molnar
b34a0a7264 Backed out changeset e5ecd3645987 (bug 1933114) for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js CLOSED TREE 2024-12-11 03:45:56 +02:00
Stephen Thompson
0630d8f7bc Bug 1933114 - tests and fixes for tab group restoration r=dao,sessionstore-reviewers,tabbrowser-reviewers
Also addresses bug 1933574 by changing the schema of saved tab groups so that they look the same as closed tab groups (that is, the saved tab groups' tabs list now has the same schema as the _closedTabs list).

Differential Revision: https://phabricator.services.mozilla.com/D230322
2024-12-10 16:37:36 +00:00
Alexandru Marc
820db0e701 Backed out changeset 4436a8f5e82d (bug 1933114) for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js CLOSED TREE 2024-12-06 08:56:12 +02:00
Stephen Thompson
4c2d2eea70 Bug 1933114 - tests and fixes for tab group restoration r=dao,sessionstore-reviewers,tabbrowser-reviewers
Also addresses bug 1933574 by changing the schema of saved tab groups so that they look the same as closed tab groups (that is, the saved tab groups' tabs list now has the same schema as the _closedTabs list).

Differential Revision: https://phabricator.services.mozilla.com/D230322
2024-12-06 05:25:26 +00:00
Sandor Molnar
594e700d37 Backed out changeset ceeaeae381df (bug 1933114) for causing bc failures @ browser_tab_groups_restore_closed_in_closed_window.js CLOSED TREE 2024-12-05 20:22:04 +02:00
Stephen Thompson
e70b247934 Bug 1933114 - tests and fixes for tab group restoration r=dao,sessionstore-reviewers,tabbrowser-reviewers
Also addresses bug 1933574 by changing the schema of saved tab groups so that they look the same as closed tab groups (that is, the saved tab groups' tabs list now has the same schema as the _closedTabs list).

Differential Revision: https://phabricator.services.mozilla.com/D230322
2024-12-05 15:55:10 +00:00
Adam Vandolder
2ba689d99e Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-05 01:20:07 +00:00
Goloman Adrian
05b7d33317 Backed out changeset 4d19e4620e63 (bug 1924861) for causing bc failures @browser_stop_pending.js. CLOSED TREE 2024-12-04 09:11:45 +02:00
Adam Vandolder
87c9038ba7 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-04 04:17:36 +00:00
Henrik Skupin
b3b89d930f Bug 1932916 - [remote] Don't retry to run a command when the browsing context was discarded. r=webdriver-reviewers,sessionstore-reviewers,jdescottes,sclements
Differential Revision: https://phabricator.services.mozilla.com/D230662
2024-12-02 14:59:51 +00:00
Cosmin Sabou
82fbc8fbe4 Backed out changeset a8d030efc4ea (bug 1924861) for causing bc failures on browser_stop_pending. 2024-12-02 01:21:14 +02:00
Adam Vandolder
f6e7455adc Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-01 04:13:01 +00:00
Sandor Molnar
7e190c9386 Backed out changeset b94afd94ed9c (bug 1924861) for causing multiple bc failures. CLOSED TREE 2024-11-30 20:40:15 +02:00
Adam Vandolder
5f7b028386 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-11-29 23:38:09 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Butkovits Atila
6a4f64d393 Backed out changeset 8c5bff1fa41a (bug 1924861) for causing failures at forward.py. 2024-11-26 12:51:09 +02:00
Adam Vandolder
fad0c07fe5 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-11-26 04:48:49 +00:00
Sandor Molnar
7058c42e18 Backed out changeset c64aebba09d9 (bug 1924861) for causing mochitest failures. CLOSED TREE 2024-11-26 03:17:30 +02:00
Adam Vandolder
2d308415a4 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-11-25 23:18:32 +00:00
Stephen Thompson
19712400f0 Bug 1932670: Add restore tab group API to session r=dao,sessionstore-reviewers,tabbrowser-reviewers
Adds `restoreTabGroup` to SessionStore, enabling a closed tab group or saved tab group to come back into the tab strip.

Includes more robust functionality for forgetting a saved tab group or closed tab group.

Differential Revision: https://phabricator.services.mozilla.com/D230011
2024-11-25 02:44:50 +00:00
Sebastian Hengst
8424c52dc1 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228118
2024-11-19 17:19:24 +00:00
Tim Huang
1399f0a3ad Bug 1922193 - Enforce isPartitioned flag for partitioned session cookie when restoring session cookies. r=sfoster,sessionstore-reviewers
The session cookies in the session store file didn't have the
isPartitioned flag. The patch enforces the isPartitioned flag for the
partitioned session cookies in order to properly set the flag when
restoring.

Differential Revision: https://phabricator.services.mozilla.com/D228815
2024-11-15 11:05:27 +00:00
Norisz Fay
c379b8f9cb Backed out 6 changesets (bug 1923663, bug 1922193) for causing bc failures on browser_cookies_legacy.js CLOSED TREE
Backed out changeset e2c5151ea497 (bug 1922193)
Backed out changeset eb53ce8d9fd7 (bug 1923663)
Backed out changeset 8a47156d3dfa (bug 1923663)
Backed out changeset 817a9db0594b (bug 1922193)
Backed out changeset 7a03590458f2 (bug 1922193)
Backed out changeset abfae75af05f (bug 1922193)
2024-11-15 12:11:13 +02:00
Tim Huang
ca9f8d6308 Bug 1922193 - Enforce isPartitioned flag for partitioned session cookie when restoring session cookies. r=sfoster,sessionstore-reviewers
The session cookies in the session store file didn't have the
isPartitioned flag. The patch enforces the isPartitioned flag for the
partitioned session cookies in order to properly set the flag when
restoring.

Differential Revision: https://phabricator.services.mozilla.com/D228815
2024-11-15 08:41:28 +00:00
Jeremy Swinarton
8a3c3e1e4c Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-12 16:34:19 +00:00
Butkovits Atila
85eb562171 Backed out changeset 307c830b0d2b (bug 1908422) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-11-08 21:50:37 +02:00
Jeremy Swinarton
f5892027d4 Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 17:29:38 +00:00
Alexandru Marc
f7c8138cf9 Backed out changeset 9e5edf53c876 (bug 1908422) for causing bc failures @ browser_tab_groups_a11y.js 2024-11-08 16:57:36 +02:00
Jeremy Swinarton
62d713d116 Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 13:53:19 +00:00
Norisz Fay
7c7d41d846 Backed out changeset 5b4cea7ea948 (bug 1924861) for causing mochitest failures on test_ext_tabs_goBack_goForward.html, test_bug1300461.html CLOSED TREE 2024-10-29 04:57:43 +02:00
Adam Vandolder
b0355ca479 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-10-29 00:27:19 +00:00
Sebastian Hengst
41d38bb30f Bug 1775605 - disable browser/components/sessionstore/test/browser_label_and_icon.js on both Linux and Windows opt for frequent failures. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D227029
2024-10-28 14:14:20 +00:00
Joel Maher
3dc8be4954 Bug 1925104 - Adjust mac/linux skip-if conditions to include os_version/architecture on remaining browser-chrome manifests. r=aryx,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,omc-reviewers,urlbar-reviewers,alwu,hanna_a,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D225870
2024-10-24 22:40:25 +00:00
Brian Grinstead
f6bb34aa25 Bug 1925724 - Use page wireframe for tab hover preview as a fallback when a normal thumnail is not available;r=mconley,sessionstore-reviewers,tabbrowser-reviewers,farre
This will only work when the pref is enabled (browser.history.collectWireframes), and is being landed primarily
to allow some expanded testing to see if it's worth cleaning this up further and turning it on.

Differential Revision: https://phabricator.services.mozilla.com/D226080
2024-10-24 03:34:40 +00:00
Zach Hoffman
14134ce9b2 Bug 1544428 - Do not dispatch popstate or hashchange when hasRef changes. r=jjaschke,dom-core,sessionstore-reviewers,dao,farre
This behavior was already agreed upon in
<https://github.com/whatwg/html/issues/7386>, but bug 1544428 was an
implementation edge case needing to be fixed.

An exception is when the fragment contains a directive, in which case a
difference in `hasRef` is sufficient, to retain existing behavior WRT
directives.

Although bug 1544428 is about popstate, hashchange was erroneously being
dispatched, as well, which this patch fixes.

Some tests that depended on the old behavior are updated.

Differential Revision: https://phabricator.services.mozilla.com/D225567
2024-10-23 14:59:04 +00:00
Jonathan Sudiaman
b15a6918fd Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
2024-10-21 14:52:00 +00:00
Dão Gottwald
f049ccd8d8 Bug 1925842 - Rename _numPinnedTabs to pinnedTabCount. r=tabbrowser-reviewers,jswinarton,dwalker
Also move getDuplicateTabsToClose and getAllDuplicateTabsToClose away from essentials at the top, closer to related methods.

Differential Revision: https://phabricator.services.mozilla.com/D226279
2024-10-21 14:35:06 +00:00
Dale Harvey
41a278d88a Bug 1923212 - Skip tests that fail with ScotchBonnet enabled. r=mak,settings-reviewers,sessionstore-reviewers,urlbar-reviewers,dao,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D224633
2024-10-20 08:35:05 +00:00
Norisz Fay
3e0a85be12 Backed out changeset 214c931a0501 (bug 1908019) for causing bc failure on browser_keyboard_tests.js 2024-10-19 02:25:01 +03:00
Jonathan Sudiaman
59eeb5c1d8 Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
2024-10-18 19:45:30 +00:00
Norisz Fay
1917d598d3 Backed out changeset 4ef6f0f9300d (bug 1923212) for causing bc failures on browser_searchModeSwitcher_basic.js CLOSED TREE 2024-10-18 20:41:04 +03:00
Dale Harvey
9ce57913c3 Bug 1923212 - Skip tests that fail with ScotchBonnet enabled. r=mak,settings-reviewers,sessionstore-reviewers,urlbar-reviewers,dao,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D224633
2024-10-18 13:25:17 +00:00
Sandor Molnar
e3731da318 Backed out changeset 47f93788c763 (bug 1908019) for causing perma bc failures @ browser_sidebar_keys.js CLOSED TREE 2024-10-17 21:46:35 +03:00
Jonathan Sudiaman
80c7c66253 Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
2024-10-17 17:45:07 +00:00
Paul Zuehlcke
dbbdb0518d Bug 1914585 - Remove legacy method ForgetAboutThisSite.removeDataFromDomain. r=hsohaney,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D225544
2024-10-16 15:52:28 +00:00