Commit Graph

1639 Commits

Author SHA1 Message Date
Jason Prickett
2e0ac10a90 Bug 1870805 - Allow shopping onboarding container to scroll when extra-long words extend it r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D198343
2024-01-16 16:47:23 +00:00
Emily McMinn
b508852984 Bug 1871067 - Remove Protections Panel info message from Messaging System docs and update schemas r=barret
Differential Revision: https://phabricator.services.mozilla.com/D198207
2024-01-15 21:28:01 +00:00
Cosmin Sabou
2757782dc8 Backed out changeset 9bcde04da83b (bug 1871067) for causing build bustages. CLOSED TREE 2024-01-12 00:04:42 +02:00
Emily McMinn
b03ab39c44 Bug 1871067 - Remove Protections Panel info message from Messaging System docs and update schemas r=barret
Differential Revision: https://phabricator.services.mozilla.com/D198207
2024-01-11 21:50:53 +00:00
Shane Hughes
f5f65e48f9 Bug 1857995 - Add Feature Callout page to firefox source docs. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D191221
2024-01-10 01:38:51 +00:00
Mark Banner
b350124d0a Bug 1873158 - Update ESLint related modules to their latest versions. r=mossop,aminomancer,devtools-reviewers,reusable-components-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D197765
2024-01-05 19:52:08 +00:00
Shane Hughes
7e94e1a73b Bug 1868494 - Feature Callouts to support button submenus. r=omc-reviewers,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D195619
2024-01-05 01:13:25 +00:00
scottdowne
4e942e88d8 Bug 1868232 - Fixing newtab customize menu initial transition state. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D197700
2024-01-04 20:51:44 +00:00
Shane Hughes
fcb1a8fc9b Bug 1872688 - Fix react/no-unknown-property violations in newtab. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D197622
2024-01-04 18:44:48 +00:00
Perry McManis
4c783d9036 Bug 1868441 - Update docs to reflect pingcentre being removed from messaging system r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D196493
2023-12-29 22:57:15 +00:00
Chris H-C
747c89c5bc Bug 1868988 - Remove PingCentre. Its watch has ended. r=nanj,thecount,perry.mcmanis
Differential Revision: https://phabricator.services.mozilla.com/D196227
2023-12-18 16:56:22 +00:00
Mike Conley
10a029d952 Bug 1866802 - Update documentation for the ASRouter and Discovery Stream devtools. r=pdahiya,thecount
Differential Revision: https://phabricator.services.mozilla.com/D195812
2023-12-14 18:46:57 +00:00
Mike Conley
86f73ac4f2 Bug 1866802 - Rename newtab's ASRouterAdmin to DiscoveryStreamAdmin and strip down to just Discovery Stream things. r=thecount,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D194813
2023-12-14 18:46:56 +00:00
Butkovits Atila
e9b8149367 Backed out 5 changesets (bug 1866802) for causing failures at test_TopSitesFeed.js. CLOSED TREE
Backed out changeset af9fbbc9ae50 (bug 1866802)
Backed out changeset 81d5b7de7178 (bug 1866802)
Backed out changeset e4d0863ed222 (bug 1866802)
Backed out changeset c0deb681b193 (bug 1866802)
Backed out changeset dda3e5e39f8c (bug 1866802)
2023-12-14 03:22:48 +02:00
Mike Conley
09b11f1d24 Bug 1866802 - Update documentation for the ASRouter and Discovery Stream devtools. r=pdahiya,thecount
Differential Revision: https://phabricator.services.mozilla.com/D195812
2023-12-13 23:29:49 +00:00
Mike Conley
b57029eeb7 Bug 1866802 - Rename newtab's ASRouterAdmin to DiscoveryStreamAdmin and strip down to just Discovery Stream things. r=thecount,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D194813
2023-12-13 23:29:49 +00:00
Mark Banner
a1c6d4d388 Bug 1867620 - Avoid updating the in-content search bar placeholders / text from multiple locations when in handoff mode. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D195167
2023-12-12 21:15:25 +00:00
Paul Bone
0bfa3b8f2a Bug 1863867 - Add support for targeting experiments based on memory r=barret
Differential Revision: https://phabricator.services.mozilla.com/D193160
2023-12-12 11:18:23 +00:00
Paul Bone
81eb21ce78 Bug 1863867 - Add expriment targeting based on archiecture bits r=barret
Differential Revision: https://phabricator.services.mozilla.com/D193159
2023-12-12 11:18:23 +00:00
Nipun Shukla
dd8b73c28c Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191763
2023-12-12 00:22:08 +00:00
Mike Conley
b7799b3290 Bug 1869327 - Fix typo / broken link in ASRouter targeting attributes source documentation. r=negin
Differential Revision: https://phabricator.services.mozilla.com/D196055
2023-12-11 15:25:51 +00:00
Jason Prickett
da24bddf95 Bug 1866501 - Add style to shopping survey and onboarding card to support variable width r=pdahiya,omc-reviewers,negin
Simple fix to address the survey container's overflow issue in the sidebar. This allows the survey to stretch to fit the outer container, which allows the rest of the container's content to flow responsively.

Differential Revision: https://phabricator.services.mozilla.com/D195063
2023-12-06 22:26:23 +00:00
Mike Conley
811a60b0f5 Bug 1715158 - Remove traces of snippets from source documentation. r=pdahiya,perftest-reviewers,sparky
Depends on D193855

Differential Revision: https://phabricator.services.mozilla.com/D193856
2023-12-06 16:15:16 +00:00
Mike Conley
a3b3f76e18 Bug 1715158 - Remove snippet-related SCSS/CSS. r=thecount
Depends on D193854

Differential Revision: https://phabricator.services.mozilla.com/D193855
2023-12-06 16:15:15 +00:00
Mike Conley
b6711f55d6 Bug 1715158 - Remove ASRouterUISurface, snippet templates, and associated tests. r=pdahiya
Depends on D193853

Differential Revision: https://phabricator.services.mozilla.com/D193854
2023-12-06 16:15:15 +00:00
Mike Conley
3ba090a3e4 Bug 1715158 - Remove snippets ASRouter infrastructure and stop using ASRouterUISurface in Base.jsx. r=pdahiya,thecount
Depends on D193852

Differential Revision: https://phabricator.services.mozilla.com/D193853
2023-12-06 16:15:14 +00:00
Jason Prickett
b028fc133b Bug 1865745 - Fix feature callout arrow hiding behavior r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D195191
2023-12-01 23:26:58 +00:00
Mike Conley
f7379dcdcf Bug 1865536 - Queue and flush early messages from about:newtab after the parent-process is ready. r=Mardak
Before this patch, the about:home/about:newtab Redux store code had some
middleware that queued any messages sent from the page before the parent
had sent any messages. Presumably this was so that those messages wouldn't
be dropped if they were sent while the parent process was still setting
up its Feeds.

Unfortunately, there's a race here - if the parent process _is_ ready and
just chooses not to send any messages right away, the loaded about:home/about:newtab
document will just hold on to any actions until the parent process has
sent something down to it.

The Talos test that was failing here was waiting for the initial about:home
page to send a message which would record a Telemetry probe. That message
wasn't arriving in time. Presumably, _eventually_ the parent process would
have sent a message down to the about:home page which would flush the actions,
but the Talos test would time out before that would occur.

This patch changes things by having the _parent_ process queue any messages
sent from the content in the event that the ActivityStreamMessageChannel
is not yet set up. Once it is set up, those messages are dispatched after
the simulated NEW_TAB_INIT and NEW_TAB_LOAD for those early tabs are
sent to the parent process Redux store.

Differential Revision: https://phabricator.services.mozilla.com/D195179
2023-12-01 18:29:06 +00:00
Chris H-C
444d051000 Bug 1862670 - Submit "spoc" ping with shim for pocket impressions|saves|clicks r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D192702
2023-11-30 16:13:51 +00:00
Chris H-C
fd81503995 Bug 1862670 - Add tile_id to pocket impressions|saves|clicks r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D192606
2023-11-30 16:13:51 +00:00
Mike Conley
ed1ac7a99f Bug 1863400 - Part 6: Perform bundling within browser/components/aboutwelcome folder. r=pdahiya
Depends on D193120

Differential Revision: https://phabricator.services.mozilla.com/D193121
2023-11-28 01:37:37 +00:00
Mike Conley
9bf8e2e138 Bug 1863400 - Part 5: Move bundled about:welcome components into browser/components/aboutwelcome folder. r=pdahiya,aminomancer
Depends on D193119

Differential Revision: https://phabricator.services.mozilla.com/D193120
2023-11-28 01:37:37 +00:00
Amy Churchwell
2229a1c8d9 Bug 1827969 - Remove about:welcome Colorways code. r=omc-reviewers,hanna_a,fluent-reviewers,bolsson,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D180887
2023-11-22 00:14:26 +00:00
Cristian Tuns
d43e3c5645 Backed out changeset d4424163a8bf (bug 1827969) for causing bc failures in browser_all_files_referenced.js 2023-11-21 14:06:46 -05:00
Amy Churchwell
ccc7cd0e29 Bug 1827969 - Remove about:welcome Colorways code. r=omc-reviewers,hanna_a,fluent-reviewers,bolsson,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D180887
2023-11-21 17:55:45 +00:00
Iulian Moraru
ba19f5931c Backed out changeset 51a922bf4c7e (bug 1827969) for causing bc failures on browser_all_files_referenced.js. CLOSED TREE 2023-11-14 21:49:20 +02:00
Amy Churchwell
79723b7dfd Bug 1827969 - Remove about:welcome Colorways code. r=omc-reviewers,hanna_a,fluent-reviewers,bolsson,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D180887
2023-11-14 16:42:39 +00:00
hanna alemu
358d2dcf81 Bug 1860892 - Remove Firefox View CFR message r=fxview-reviewers,omc-reviewers,aminomancer,sclements
Differential Revision: https://phabricator.services.mozilla.com/D192374
2023-11-07 18:09:39 +00:00
Chris H-C
7284cf9ac7 Bug 1854245 - Add pocket recommendation id to pocket newtab events r=thecount,mmiermans
Depends on D190858

Differential Revision: https://phabricator.services.mozilla.com/D190980
2023-10-26 07:20:43 +00:00
Chris H-C
4fa2bba2e4 Bug 1857324 - Instrument 'dismiss' actions for newtab topsites r=nanj
See Also DENG-1363

Depends on D190855

Differential Revision: https://phabricator.services.mozilla.com/D190856
2023-10-26 07:20:41 +00:00
Chris H-C
ed4d986946 Bug 1857324 - Instrument the 'about our sponsors' link r=nanj
See also: DENG-1364

Differential Revision: https://phabricator.services.mozilla.com/D190855
2023-10-26 07:20:41 +00:00
Shane Hughes
c0e0c0561e Bug 1830715 - ASRouter devtools for editing and resetting impressions. r=omc-reviewers,emcminn
Adds some new ASRouter methods for resetting impressions of all 3 types,
message impressions, group impressions, and screen impressions, and
exposes them through some new buttons and textboxes in a new Impressions
tab in the ASRouter devtools.

Differential Revision: https://phabricator.services.mozilla.com/D178261
2023-10-25 20:52:29 +00:00
Sylvestre Ledru
3608dc8457 Bug 1860157 - Fix typos found by codespell 2.2.6 r=webdriver-reviewers,zeid,search-reviewers,perftest-reviewers,devtools-reviewers,releng-reviewers,gbrown,sparky,jteow
Differential Revision: https://phabricator.services.mozilla.com/D191480
2023-10-19 20:52:10 +00:00
negin
03bfa843f0 Bug 1858259 - [Easy Setup Feature] Fixes easy setup checkbox misalignment and spacing on responsive mode <800px r=omc-reviewers,aminomancer,emcminn
Removes secondary section image on <800px/responsive mode for 3 checkbox easy setup.
Aligns checkboxes to the left on responsive mode.

Differential Revision: https://phabricator.services.mozilla.com/D191340
2023-10-19 18:23:04 +00:00
Jason Prickett
f10f683d0e Bug 1857036 - create asrouter targeting for primary monitor resolution r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D190615
2023-10-12 05:36:26 +00:00
scottdowne
9680ca1364 Bug 1858038 - Pocket newtab decouple Pocket sponsored content system pref from Discovery Stream JSON config. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D190521
2023-10-10 14:54:10 +00:00
Emilio Cobos Álvarez
edbe0ff9a0 Bug 1857522 - Don't ignore pseudo-classes in max-nesting-depth limit. r=Gijs
As that allows you to get around the lint with :is() trivially.

Differential Revision: https://phabricator.services.mozilla.com/D190311
2023-10-08 23:07:36 +00:00
Emilio Cobos Álvarez
ede2cef8c9 Bug 1857522 - Reduce max nesting depth to 3. r=Gijs
That still doesn't trigger on the code in comment 2, so that is a bit
confusing and needs investigation.

Differential Revision: https://phabricator.services.mozilla.com/D190310
2023-10-08 22:33:39 +00:00
scottdowne
a55282b555 Bug 1847786 - Pocket newtab remove old remote layout switching code. r=gvn,mconley
Differential Revision: https://phabricator.services.mozilla.com/D185688
2023-10-03 18:53:02 +00:00
Emily McMinn
1d086f0280 Bug 1855041 - Adjust spacing and padding of survey elements r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D189291
2023-09-27 17:51:07 +00:00