Commit Graph

361 Commits

Author SHA1 Message Date
Neil Deakin
24f16bd35c Bug 1869153, remove file import preference signon.management.page.fileImport.enabled and supporting code since it is enabled by default, r=mconley,fluent-reviewers,credential-management-reviewers,migration-reviewers,issammani
Differential Revision: https://phabricator.services.mozilla.com/D223852
2024-10-02 16:13:52 +00:00
Joel Maher
d70349f2c5 Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley
Differential Revision: https://phabricator.services.mozilla.com/D214969
2024-07-09 13:01:55 +00:00
Daisuke Akatsuka
3a8e1f71cd Bug 1552815: Use setFaviconForPage() instead of replaceFaviconData() r=mak,migration-reviewers,mconley
Depends on D192536

Differential Revision: https://phabricator.services.mozilla.com/D192537
2024-05-01 20:40:50 +00:00
Stanca Serban
375a8970d3 Backed out 5 changesets (bug 1552815) for causing bp-nu bustages in nsFaviconService.cpp. CLOSED TREE
Backed out changeset 4be83e948d32 (bug 1552815)
Backed out changeset 0b2d40719586 (bug 1552815)
Backed out changeset c17e4da85514 (bug 1552815)
Backed out changeset c66812747d09 (bug 1552815)
Backed out changeset 62b3d85f4ca3 (bug 1552815)
2024-05-01 09:58:57 +03:00
Daisuke Akatsuka
4a1f83472b Bug 1552815: Use setFaviconForPage() instead of replaceFaviconData() r=mak,migration-reviewers,mconley
Depends on D192536

Differential Revision: https://phabricator.services.mozilla.com/D192537
2024-05-01 05:47:09 +00:00
Stanca Serban
b0b915869e Backed out 5 changesets (bug 1552815) for causing bp-nu bustages in nsFaviconService.cpp.
Backed out changeset 08a2ac7a9834 (bug 1552815)
Backed out changeset bb9854e6ffe7 (bug 1552815)
Backed out changeset 4e06ccb2599e (bug 1552815)
Backed out changeset d28dd2aec9f4 (bug 1552815)
Backed out changeset 392389a8d495 (bug 1552815)
2024-04-24 03:03:10 +03:00
Daisuke Akatsuka
8084fddcc3 Bug 1552815: Use setFaviconForPage() instead of replaceFaviconData() r=mak,migration-reviewers,mconley
Depends on D192536

Differential Revision: https://phabricator.services.mozilla.com/D192537
2024-04-23 23:21:39 +00:00
Nikki Sharpley
0edb981bd2 Bug 1885664 - PlacesQuery#getHistory() should have the option to fetch infinite history r=fxview-reviewers,places-reviewers,sclements
`PlacesQuery#getHistory()` now has the option to fetch all history by passing in Infinity daysOld

Differential Revision: https://phabricator.services.mozilla.com/D207446
2024-04-22 12:53:41 +00:00
Gregory Pappas
9bd4fc9c87 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 21:29:39 +00:00
Sandor Molnar
c853f2f3e9 Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Gregory Pappas
55e30a8b92 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 15:07:46 +00:00
Joel Maher
3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Mark Banner
e2e80f646d Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in system modules. r=Gijs,perftest-reviewers,necko-reviewers,extension-reviewers,application-update-reviewers,fxview-reviewers,sync-reviewers,sessionstore-reviewers,reusable-components-reviewers,rpl,jesup,hjones,kshampur,skhamis,nalexander,sclements
Differential Revision: https://phabricator.services.mozilla.com/D197489
2024-01-05 09:22:34 +00:00
Mike Conley
e42785a693 Bug 1866772 - Be more resilient against malformed URLs when importing from Safari. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D196100
2023-12-12 19:13:26 +00:00
Sylvestre Ledru
5bd4bc54a3 Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot
clang-format version 17.0.6 (taskcluster-QueHFUviQeyM8Y7r_d7MQQ)

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D195397
2023-12-04 10:09:36 +00:00
Joel Maher
33fa84a382 Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Mike Conley
1201221bf2 Bug 1860606 - Get rid of migration.ftl in favour of migrationWizard.ftl. r=kpatenio,fluent-reviewers,bolsson
migration.ftl was used by the old, legacy XUL migration dialog that was removed
in bug 1824851.

There were still a few strings being used by migration.ftl, but I've moved those
over to migrationWizard.ftl, and gone ahead and just removed the old file.

Differential Revision: https://phabricator.services.mozilla.com/D192509
2023-11-02 22:03:26 +00:00
Mike Conley
1ba58e779d Bug 1818237 - Add automated tests for requesting migrator permissions. r=mstriemer
Depends on D188874

Differential Revision: https://phabricator.services.mozilla.com/D189842
2023-10-11 20:09:22 +00:00
Mike Conley
5085c317ab Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 20:09:21 +00:00
Sandor Molnar
d8a0e28ce0 Backed out 2 changesets (bug 1818237) for causing xpc failures on browser/components/migration/tests/unit/test_Chrome_permissions.js CLOSED TREE
Backed out changeset e5d78a9ddcb4 (bug 1818237)
Backed out changeset 87f67f05c8a8 (bug 1818237)
2023-10-11 19:53:35 +03:00
Mike Conley
3c1fdf043c Bug 1818237 - Add automated tests for requesting migrator permissions. r=mstriemer
Depends on D188874

Differential Revision: https://phabricator.services.mozilla.com/D189842
2023-10-11 14:53:56 +00:00
Mike Conley
1452dbdc7b Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 14:53:55 +00:00
Sandor Molnar
3a1563107d Backed out 2 changesets (bug 1818237) for causing mochitest/xpc failures on browser/components/migration/<...>.js CLOSED TREE
Backed out changeset a8584f57dc7c (bug 1818237)
Backed out changeset 477292e081b3 (bug 1818237)
2023-10-11 09:32:23 +03:00
Mike Conley
bb96d52ce8 Bug 1818237 - Add automated tests for requesting migrator permissions. r=mstriemer
Depends on D188874

Differential Revision: https://phabricator.services.mozilla.com/D189842
2023-10-11 04:16:49 +00:00
Mike Conley
bcdf5f918d Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 04:16:49 +00:00
Gregory Pappas
e6625835b6 Bug 1846934 - Remove IE7FormPasswords migrator r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D185267
2023-08-03 19:07:06 +00:00
Mike Conley
e0e8f038f1 Bug 1807023 - Record successfully matched and failed-to-match extension ids during import. data-review=chutten. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D184512
2023-08-03 13:13:43 +00:00
Neil Deakin
8b3a54ba0f Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-07-16 20:15:31 +00:00
Stanca Serban
edc8457447 Backed out 2 changesets (bug 1807618) for autocomplete related failures. CLOSED TREE
Backed out changeset 548365f1d102 (bug 1807618)
Backed out changeset 149b536f4fed (bug 1807618)
2023-07-06 01:27:55 +03:00
Neil Deakin
0688cd6017 Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-07-05 19:24:40 +00:00
Mike Conley
2ca930cc08 Bug 1840792 - Be more resilient and timely when dealing with database corruption during Chrome browser import. r=kpatenio
This patch does two things:

1. It makes it so that a corrupt database doesn't result in several retries to
   requery the database, as it's extremely unlikely that a corrupt database is
   going to somehow get repaired in the interim.
2. It makes it so that if any Chrome-based browser resource fails to be acquired
   properly, it still allows other resources from the same (and other!) profiles
   to be imported.

Differential Revision: https://phabricator.services.mozilla.com/D182737
2023-07-04 20:43:09 +00:00
William Durand
daf67c6f7a Bug 1840843 - Handle Chrome extensions without a description in their manifest. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D182353
2023-06-28 19:18:01 +00:00
Mike Conley
a984381bf2 Bug 1840393 - Test that only Chrome (for now) offers extension importing. r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182277
2023-06-28 14:15:46 +00:00
Mike Conley
22d6bfe4bf Bug 1838926 - Record interaction preference when CSV passwords are imported from the migration wizard. data-review=jhirssch,r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D181286
2023-06-23 14:14:26 +00:00
William Durand
409e3fa522 Bug 1839830 - Integrate AMBrowserExtensionsImport with the migration wizard UI. r=mconley,mixedpuppy
Depends on D181465

Differential Revision: https://phabricator.services.mozilla.com/D181747
2023-06-23 12:25:55 +00:00
Mike Conley
a049470152 Bug 1839827 - Display a generic error message for password and bookmark file migrations despite the exception. r=kpatenio,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D181801
2023-06-23 00:00:52 +00:00
Cosmin Sabou
3a0d2da9d4 Backed out changeset 5be10443a2ea (bug 1807618) for mochitest failures on test_autocomplete_password_generation.html. 2023-06-16 00:48:28 +03:00
Neil Deakin
410283a615 Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-06-15 20:39:05 +00:00
Marco Castelluccio
e242e5b9dd Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-15 08:10:45 +00:00
Noemi Erli
7ca9d6cc02 Backed out changeset 63ccd00a399a (bug 898315) for causing failures in test_no_window_update_restart.py CLOSED TREE 2023-06-15 03:21:27 +03:00
Marco Castelluccio
747c4ff841 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-14 20:55:52 +00:00
Mike Conley
a998b6f44b Bug 1837367 - Throw an error if the bookmarks file migrator doesn't import anything. r=tgiles,fluent-reviewers,flod
An earlier patch in the series makes the error message appear in the
migration wizard on the selection page.

Depends on D180490

Differential Revision: https://phabricator.services.mozilla.com/D180491
2023-06-13 14:53:00 +00:00
Mark Banner
40de601f11 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-06-07 08:42:36 +00:00
Mike Conley
eee3689314 Bug 1833460 - Don't run test_Chrome_credit_cards.js on official builds. r=NeilDeakin
This appears to be a limitation of what we can do on official builds, and so
we just simply don't run these kinds of tests on official builds.

Differential Revision: https://phabricator.services.mozilla.com/D179493
2023-06-01 13:58:54 +00:00
Sandor Molnar
178e788bb5 Backed out changeset fbac3e184322 (bug 1833460) for causing xpc failures in browser/components/migration/tests/unit/test_Chrome_credit_cards.js CLOSED TREE 2023-06-01 01:45:36 +03:00
Mike Conley
73aff02250 Bug 1833460 - Don't run test_Chrome_credit_cards.js on official builds. r=NeilDeakin
This appears to be a limitation of what we can do on official builds, and so
we just simply don't run these kinds of tests on official builds.

Differential Revision: https://phabricator.services.mozilla.com/D179493
2023-05-31 20:59:57 +00:00
Mark Striemer
44dc08eca6 Bug 1236916 - Part 2: Test Safari history migration r=mconley
Depends on D179104

Differential Revision: https://phabricator.services.mozilla.com/D179170
2023-05-30 17:06:53 +00:00