Gregory Pappas
9bd4fc9c87
Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
...
Depends on D200551
Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 21:29:39 +00:00
Sandor Molnar
c853f2f3e9
Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
...
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Gregory Pappas
55e30a8b92
Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
...
Depends on D200551
Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 15:07:46 +00:00
Gregory Pappas
b8a57ea6f0
Bug 1708289 - Implement AllowFileSelectionDialogs policy r=fluent-reviewers,mkaply,emilio,Gijs,bolsson,win-reviewers,rkraesig
...
Differential Revision: https://phabricator.services.mozilla.com/D199328
2024-02-01 00:48:24 +00:00
Mike Kaply
4c6c297a4d
Bug 1868669 - Add Fallback to DOH policy. r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D197666
2024-01-29 13:27:43 +00:00
Joel Maher
3662d84cd4
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96
Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures.
2024-01-24 21:08:19 +02:00
Joel Maher
04ec786571
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Karandeep
f11961815d
Bug 1852048 - Move address bar to search preferences. r=dao,fluent-reviewers,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D194895
2024-01-04 09:11:22 +00:00
Mike Kaply
64a15745de
Bug 1872267 - Allow setting an explicit preference type in policy. r=kcochrane
...
Differential Revision: https://phabricator.services.mozilla.com/D197534
2024-01-03 16:28:38 +00:00
Anna Yeddi
4a5db92d9e
Bug 1871491 - Add a check for combobox container of moz-input-box and options within the URL bar autocomplete list in AccessibilityUtils. r=Jamie,search-reviewers,credential-management-reviewers,sgalich,Standard8
...
Adding an additional check similar to [the isKeyboardFocusableBrowserToolbarButton check](https://searchfox.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/AccessibilityUtils.js#228-238 ) that could pass the `assertLabelled` rule for following URL Bar-specific controls, since these controls are either left unlabeled or are being labeled after the Fluent l10n is completed deliberately:
1. [Combobox container of the Search Input](https://searchfox.org/mozilla-central/rev/b580e3f77470b2337bc8ae032b58a85c11e66aba/browser/base/content/navigator-toolbox.inc.xhtml#314-318 ) with id `moz-input-box` - we intentionally leave this element unlabeled, because its child is a search input (properly labeled) that is the target and main control of this component and we want to avoid duplication in the label announcement when a user focuses the input. This causes an a11y failure `Interactive elements must be labeled: id: , tagName: moz-input-box, className: urlbar-input-box`
1. [Options within an autocomplete listbox](https://searchfox.org/mozilla-central/rev/b580e3f77470b2337bc8ae032b58a85c11e66aba/browser/components/urlbar/UrlbarSearchOneOffs.sys.mjs#141-151 ) with class `urlbarView-row-inner` - we know each of these option is accessible, but it disappears as soon as it is clicked and the a11y-checks do not have time to test the label, because the Fluent localization is not yet completed by then. This causes an a11y warning `Unlabeled element removed before l10n finished`
1. [Additional Searchbar](https://searchfox.org/mozilla-central/rev/b580e3f77470b2337bc8ae032b58a85c11e66aba/browser/base/content/navigator-toolbox.inc.xhtml#699 ) with id `searchbar` that triggers `Interactive elements must be labeled` failure. To activate this Search bar next to the URL Bar: `about:preferences` > `Search` > `Search Bar` > select `Add search bar in toolbar`.
Since the `browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js` and six other tests will be passing the a11y_checks without warnings now and two tests will pass this specific check, we are updating appropriate test manifests to remove or update `fail-if` conditions as well.
Differential Revision: https://phabricator.services.mozilla.com/D197113
2024-01-02 21:10:57 +00:00
Mark Banner
0d18781645
Bug 1870644 - Remove nsISearchEngine.iconURI and replace by the new getIconURL function. r=search-reviewers,extension-reviewers,settings-reviewers,mconley,mcheang,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D196734
2023-12-20 13:28:24 +00:00
Mike Conley
4936b01244
Bug 1715158 - Remove Snippets enterprise policy support. r=mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D195448
2023-12-06 16:15:17 +00:00
Joel Maher
33fa84a382
Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Karandeep
499e1c4a7e
Bug 1852046 - Convert "Suggestions from the web" and "Suggestions from sponsors" toggles to checkboxes on privacy prefs page r=dao,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D191641
2023-11-16 07:19:42 +00:00
Natalia Csoregi
ab3b33ee93
Backed out changeset 555c786396f8 (bug 1852046) as requested. CLOSED TREE
2023-11-09 20:53:42 +02:00
Mark Banner
5e07c3f484
Bug 1861865 - Fix ESLint valid-jsdoc issues in enterprise policy code. r=mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D192156
2023-11-01 17:20:39 +00:00
Karandeep
9ec67c7d3d
Bug 1852046 - Convert all toggles to checkboxes on privacy prefs page r=dao,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D191641
2023-10-25 15:30:14 +00:00
Anna Yeddi
3b6a876d14
Bug 1854533 - Temporarily fail-if one Tier 2 a11y_checks for Enterprise Policies. r=mkaply
...
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110 ) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.
This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, component-specific bug 1854534
- Explore capturing click events for a11y_checks: bug 1692110
Depends on D188924
Differential Revision: https://phabricator.services.mozilla.com/D188925
2023-10-09 18:20:19 +00:00
Cristian Tuns
896197e59e
Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE
...
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514
2023-10-07 14:43:05 -04:00
Anna Yeddi
0194decb0c
Bug 1854533 - Temporarily disable one Tier 2 a11y_checks for Enterprise Policies. r=mkaply
...
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110 ) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.
This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, component-specific bug 1854534
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D188925
2023-10-06 18:11:37 +00:00
Sylvestre Ledru
2e0e132821
Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Tom Marble
ad50861ef9
Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Marco Bonardo
6874dffc71
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Sandor Molnar
5d8dd001ad
Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
...
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
c5fb3dbb49
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Harshit Sohaney
3898675cdd
Bug 1835913 - Deprecating RejectForeignAllowList. r=bvandersloot,anti-tracking-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D187286
2023-09-14 15:41:40 +00:00
Molly Howell
ac135e9358
Bug 1852151 - Add a policy equivalent to DisableFirefoxAccounts but without being called Firefox. r=mkaply,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D187726
2023-09-12 18:14:08 +00:00
Mike Kaply
bd6e5e6c66
Bug 1749535 - Add policy for Firefox Suggest. r=adw
...
Differential Revision: https://phabricator.services.mozilla.com/D186241
2023-08-16 21:08:06 +00:00
Mike Kaply
c6f296a985
Bug 1838447 - Exclude EOL distribution IDs from enterprise telemetry. r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D180947
2023-06-22 14:55:24 +00:00
Mike Kaply
0b16097473
Bug 1772503 - Keep policy locked preferences locked. r=mhowell,necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D181100
2023-06-20 12:17:49 +00:00
Katherine Patenio
ce9d8a5dad
Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621
Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
...
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22
Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Sandor Molnar
5cd6d50a7b
Backed out changeset 208ba0efbefb (bug 1772503) for causing xpc failures in netwerk/test/unit/test_trr_enterprise_policy.js CLOSED TREE
2023-06-15 21:06:56 +03:00
Mike Kaply
0350e1278c
Bug 1772503 - Keep policy locked preferences locked. r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D181100
2023-06-15 16:01:20 +00:00
Rob Wu
bad812f243
Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
...
This patch was generated as follows:
Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.
The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.
1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.
Commands:
```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^ # and verify that the removed lines are ok.
git commit -va # one last review to verify correctness of whole patch.
git rebase -i HEAD~3 # drop the WIP + reverted commit, pick only the last.
```
`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.
Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
Mark Banner
232facd440
Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis
...
Depends on D179819
Differential Revision: https://phabricator.services.mozilla.com/D179820
2023-06-02 20:00:35 +00:00
Saira Abdulla
d8dc989e1b
Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
...
Depends on D175553
Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32
Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
...
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236
Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
...
Depends on D175553
Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Mark Banner
0666077666
Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Katherine Patenio
2e593c5af4
Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D178362
2023-05-18 18:34:51 +00:00
Pushpanjali
e60b51b744
Bug 1822010 - Convert toolkit/components/url-classifier to ES modules. r=perftest-reviewers,webcompat-reviewers,geckoview-reviewers,devtools-reviewers,twisniewski,valentin,m_kato,anti-tracking-reviewers,timhuang,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D173390
2023-05-18 12:21:12 +00:00
Gregory Pappas
15b24de236
Bug 1833185 - Remove FlashPlugin policy r=mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D178080
2023-05-16 13:28:57 +00:00
Mark Banner
0fadbc1ec4
Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D176336
2023-05-09 16:14:51 +00:00
anwar
1d2e079021
Bug 1829673 - Put all mochitest test manifest files under browser/components into alphabetical order. r=mconley,extension-reviewers,credential-management-reviewers,dimi,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D176459
2023-05-02 16:13:24 +00:00
Bilal
19e224dcb3
Bug 1816987 - ESMified browser/components/enterprisepolicies/schemas r=kpatenio
...
Differential Revision: https://phabricator.services.mozilla.com/D174495
2023-04-27 19:23:00 +00:00
Gijs Kruitbosch
5672958fb9
Bug 1828280 - honour enterprise policy for profile import in the prefs import section, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D175902
2023-04-21 10:23:22 +00:00
