Commit Graph

80 Commits

Author SHA1 Message Date
Fred Chasen
12e8ffb3f0 Bug 1964835 - Part 1: Remove shopping actors and globals. r=shopping-reviewers,frontend-codestyle-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D248147
2025-05-22 18:04:15 +00:00
Dão Gottwald
0007fe7bd1 Bug 1966617 - Make adoptTabGroup support both elementIndex and tabIndex, and stop converting tab indices to element indices. r=robwu,sthompson,tabbrowser-reviewers,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D249619
2025-05-16 00:39:26 +00:00
agoloman
4b62de7961 Revert "Bug 1965343 - Adopt whole tab group at once in replaceGroupWithWindow r=tabbrowser-reviewers,sthompson" for causing bc failures @browser_tab_groups.js.
This reverts commit fac3f86e95.
2025-05-15 18:42:30 +00:00
Kagami Sascha Rosylight
71f7630aeb Bug 1966656 - Part 1: Toggle touchmode from nsXULPopupManager r=desktop-theme-reviewers,dao,emilio
Differential Revision: https://phabricator.services.mozilla.com/D198801
2025-05-15 13:36:39 +00:00
Rob Wu
fac3f86e95 Bug 1965343 - Adopt whole tab group at once in replaceGroupWithWindow r=tabbrowser-reviewers,sthompson
The `replaceGroupWithWindow` method currently adopts a tab group in
multiple steps, asynchronously. This can result in externally observable
inconsistencies past initial adoption (see bug).

To fix this, this patch changes the adoption logic by passing the tab
group as the initial item to adopt, and adopts the whole group at once
as needed. Now the logic is similar to drag and drop adoption as
implemented in bug 1908441.

Since tabToAdopt is no longer just a tab, but also a tab group (or even
a tab group label since bug 1908441), the logic in ext-browser.js needs
to be adjusted to make sure that it does not mistake non-tab elements
for tabs. Test coverage is in browser_ext_tabGroups_move_onMoved.js,
as not changing that caused the test to fail with:

> FAIL Tab did indeed move to the new window - {"oldWindowId":3,"oldPosition":"undefined"} deepEqual {"oldWindowId":3,"oldPosition":1} -

Differential Revision: https://phabricator.services.mozilla.com/D248537
2025-05-15 13:35:45 +00:00
Rebecca King
65219be51d Bug 1964091 - Clean up RC migration prefs - r=shopping-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D247651
2025-05-09 18:16:32 +00:00
Jeremy Swinarton
39096a611c Bug 1960360: Tab interaction metrics for dragging tabs out of groups r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D245749
2025-04-17 16:29:29 +00:00
shaneziegler
9e82afc772 Bug 1957495 - Move ToolbarIconColor helper object from browser.js into its own module browser/themes/ToolbarIconColor.sys.mjs r=Gijs,desktop-theme-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D244058
2025-04-14 16:46:02 +00:00
Dão Gottwald
3d9566e2de Bug 1917069 - Make the tab strip handle live language switching between LTR and RTL. r=Gijs,reusable-components-reviewers,hjones,fxview-reviewers,sidebar-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D244573
2025-04-08 15:49:13 +00:00
Emilio Cobos Álvarez
c5bf0c134a Bug 1956758 - Expose whether we use a "native" menubar at runtime. r=stransky,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D243431
2025-04-04 09:16:33 +00:00
Kelly Cochrane
a75d2e147f Bug 1956624 - Ensure sidebar collapses on mouse out when expand on hover is enabled and the window is inactive (macOS only) r=sidebar-reviewers,mstange,sclements
Differential Revision: https://phabricator.services.mozilla.com/D243512
2025-04-02 14:44:08 +00:00
Dão Gottwald
9754a011cf Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241004
2025-03-12 11:29:36 +00:00
Alexandru Marc
e03b90be4c Backed out 4 changesets (bug 1953193, bug 1952495, bug 1953249, bug 1908441) for causing bc failures @ browser_bug495058.js CLOSED TREE
Backed out changeset 0ccf1105aa8c (bug 1953249)
Backed out changeset 2ccc75be9d26 (bug 1953193)
Backed out changeset 02b70f25b783 (bug 1952495)
Backed out changeset 46e2f887cea6 (bug 1908441)
2025-03-12 12:01:31 +02:00
Dão Gottwald
e53c0fb5e2 Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241004
2025-03-12 08:19:40 +00:00
Goloman Adrian
168ed8ab47 Backed out 4 changesets (bug 1953193, bug 1908441, bug 1952495, bug 1953249) for causing bc failures @browser_tab_manager_drag.js. CLOSED TREE
Backed out changeset f8634c4fc742 (bug 1953249)
Backed out changeset 066cede5adcc (bug 1953193)
Backed out changeset 7afc87de4a01 (bug 1952495)
Backed out changeset 2ef344554c4c (bug 1908441)
2025-03-12 02:44:08 +02:00
Dão Gottwald
1642f3dfa4 Bug 1908441 - Implement drag and drop of tab group into a new or other window. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241004
2025-03-11 21:39:05 +00:00
Tim Xia
3554189dec Bug 1943391 - Initial entrypoint to detect preview reqeust - r=Mardak,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,mossop
- alt+hover to trigger LinkPreview
- add LinkPreview.sys.mjs modules
- disable browser.ml.linkPreview.enabled by default
- use setOverLink and LinkPreview.sys to handle keyboard shortcut
- dispatch CustomEvent OverLink from browser.js
- add/remove event listeners in sync with state of "browser.ml.linkPreview.enabled"
- update all_files_referenced to handle moz-src

Differential Revision: https://phabricator.services.mozilla.com/D239535
2025-03-10 17:31:36 +00:00
Eric Chen
5e567fd9ce Bug 1915739 - Part 6: Add an attribute to the top-level browser chrome element when opening a Taskbar Tab. r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D234543
2025-03-03 16:40:09 +00:00
Eric Chen
ae8c95aa31 Bug 1915739 - Part 4: Make URL bar read-only for taskbar tabs r=nrishel,urlbar-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D234539
2025-03-03 16:40:08 +00:00
Eric Chen
0624fff97b Bug 1915739 - Part 2: Set up TaskbarTab UI module to disable appropiate UI components r=sync-reviewers,firefox-desktop-core-reviewers ,Gijs,markh
Differential Revision: https://phabricator.services.mozilla.com/D237620
2025-03-03 16:40:07 +00:00
Gijs Kruitbosch
c7252c05d5 Bug 1948931 - move toolbar window initialization into CustomizableUI, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D238536
2025-02-21 16:07:08 +00:00
Gijs Kruitbosch
0dafc27cb8 Bug 1946400 - bonus: move some other DCL/unload handling in browser-init.js to use the category manager, r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D238534
2025-02-21 16:07:08 +00:00
Gijs Kruitbosch
b42a5412d4 Bug 1946400 - move nsBrowserAccess (nsIBrowserDOMWindow impl) out of browser.js into its own module, r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D238533
2025-02-21 16:07:07 +00:00
Alexandru Marc
31459715b9 Backed out 4 changesets (bug 1916424, bug 1946400) for causing leaks @ Alloc, JSString::OwnedChars
Backed out changeset df8e24e9be67 (bug 1946400)
Backed out changeset 88961496629c (bug 1946400)
Backed out changeset 8e0862096be2 (bug 1916424)
Backed out changeset b4b2ef6e086b (bug 1916424)
2025-02-18 19:57:43 +02:00
Gijs Kruitbosch
0ff0641981 Bug 1946400 - bonus: move some other DCL/unload handling in browser-init.js to use the category manager, r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D238534
2025-02-18 16:17:29 +00:00
Gijs Kruitbosch
998f345683 Bug 1946400 - move nsBrowserAccess (nsIBrowserDOMWindow impl) out of browser.js into its own module, r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D238533
2025-02-18 16:17:28 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
Gijs Kruitbosch
747d34d801 Bug 1916424 - allow idle dispatch from BrowserUtils' category manager-based invocations, r=mossop,search-reviewers,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D220896
2025-02-07 16:54:50 +00:00
Moritz Beier
152f732f88 Bug 1880913 - Part 3: Move open search handling from BrowserSearch to dedicated module. r=Standard8,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235597
2025-02-04 11:07:12 +00:00
Moritz Beier
6c0a5096a8 Bug 1880913 - Part 1: Move urlbar placeholder handling from BrowserSearch to UrlbarInput. r=urlbar-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D235595
2025-02-04 11:07:11 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Tom Schuster
e26598fb5f Bug 1938883 - Remove inline event handlers from managed bookmarks. r=firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232828
2024-12-28 11:14:00 +00:00
Fred Chasen
2a40aed615 Bug 1916547 - Part 1: Render Review Checker in the new sidebar. r=shopping-reviewers,firefox-desktop-core-reviewers ,sidebar-reviewers,sclements,mossop,kpatenio
- Adds a remote content browser to contain `about:shoppingsidebar` in `review-checker.xhtml` and update the Review Checker sidebar to use that wrapper document.
- Adds ReviewChecker actors for the sidebar Review Checker panel.
- ReviewCheckerParent is a simplified version of the ShoppingSidebarParent as it does not need to handle the state of the sidebar opening or closing.
- ReviewCheckerChild is just extends ShoppingSidebarChild for now, though it will need to be separate in the future.
- Adds a browser.shopping.experience2023.shoppingSidebar boolean pref to disable ShoppingSidebar actors when they are not needed.
- Fixes `AbortError` error handling when the outer sidebar browser is removed.

Note that any auto-opening or closing behavior will need to be added afterwards, as these actors are not around to check product urls when the sidebar is closed.

Differential Revision: https://phabricator.services.mozilla.com/D222840
2024-12-12 01:24:20 +00:00
Emilio Cobos Álvarez
768894a512 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 12:12:51 +00:00
Emilio Cobos Álvarez
feebe3d11d Bug 1930292 - Turn chromemargin into a boolean attribute. r=win-reviewers,desktop-theme-reviewers,pip-reviewers,firefox-desktop-core-reviewers ,dao,mconley,rkraesig
There are probably other simplifications that can be done after this on the
windows side of things, but I tried to keep this minimal.

Differential Revision: https://phabricator.services.mozilla.com/D229765
2024-11-28 12:12:50 +00:00
Cristina Horotan
bb08cc9f1d Backed out 5 changesets (bug 1930292, bug 1932600) for causing chrome failures at test_maximized_persist.xhtml on a CLOSED TREE
Backed out changeset 2418bfee53f1 (bug 1932600)
Backed out changeset 3297e990715a (bug 1932600)
Backed out changeset 24a670dea977 (bug 1930292)
Backed out changeset 7dd9f48216dd (bug 1930292)
Backed out changeset 15a85ec739dd (bug 1930292)
2024-11-28 06:57:35 +02:00
Emilio Cobos Álvarez
26de824592 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 03:26:50 +00:00
Emilio Cobos Álvarez
67678746e6 Bug 1930292 - Turn chromemargin into a boolean attribute. r=win-reviewers,desktop-theme-reviewers,pip-reviewers,firefox-desktop-core-reviewers ,dao,mconley,rkraesig
There are probably other simplifications that can be done after this on the
windows side of things, but I tried to keep this minimal.

Differential Revision: https://phabricator.services.mozilla.com/D229765
2024-11-28 03:26:50 +00:00
Ray Kraesig
19038c4983 Bug 1929474 - [1/2] Fix Win10 tablet-mode hiding of close-button r=desktop-theme-reviewers,dao
The simplification of browser.css in bug 1844242 caused the close-button
to be hidden in tablet mode alongside the window-resizing buttons.
Revert that change's effect, and add documentation.

Differential Revision: https://phabricator.services.mozilla.com/D228205
2024-11-14 18:01:42 +00:00
Dão Gottwald
f8d89fd012 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 16:33:19 +00:00
Alexandru Marc
898e7469f6 Backed out changeset 365a4dc7fe2d (bug 1930654) for causing bc failures @ browser_standalone_application_chooser_window_fallback.js . CLOSED TREE 2024-11-14 17:37:47 +02:00
Dão Gottwald
af03c5baa7 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 14:02:57 +00:00
Simon Friedberger
4fcd691190 Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 17:15:57 +00:00
Sandor Molnar
9e0c14a80e Backed out changeset c4dfee1f9194 (bug 1919544) for causing bc failures @ browser_UrlbarInput_formatValue.js CLOSED TREE 2024-11-13 15:20:39 +02:00
Simon Friedberger
8eafd874fe Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 11:44:43 +00:00
Sandor Molnar
882c106d21 Backed out 2 changesets (bug 1926145, bug 1924850) for causing bc failures @ browser_menubar_profiles CLOSED TREE
Backed out changeset ce1ce2a8cacd (bug 1924850)
Backed out changeset 387976dca835 (bug 1926145)
2024-11-06 01:15:56 +02:00
Jared Hirsch
a6726bdfef Bug 1926145 - Add profiles menu to menubar. r=niklas,fluent-reviewers,desktop-theme-reviewers,dao,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226412
2024-11-05 21:02:14 +00:00
Dave Townsend
6928b89ed0 Bug 1893692: Notify concurrent profiles via remoting service. r=jhirsch,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D227026
2024-11-01 10:11:24 +00:00
Kelly Cochrane
fc97d3f90a Bug 1925451 - Fix for vertical tabs not always being visible in new windows r=sidebar-reviewers,Gijs,sclements
Differential Revision: https://phabricator.services.mozilla.com/D227089
2024-10-29 14:34:39 +00:00