corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
787,250 Commits 1 Branch 0 Tags
81c86b200c45e4f33d42602f849d692458eb872a
Commit Graph

3264 Commits

Author SHA1 Message Date
Natalia Csoregi
1b67d0b941 Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE 
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
 2023-05-24 04:29:45 +03:00
Mark Banner
d1fc869252 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-05-23 19:09:29 +00:00
Eemeli Aro
23e76253f4 Bug 1833037 - Do not depend on this in RecentlyClosedTabsAndWindowsMenuUtils. r=Gijs 
Also remove public access to the internal Localization instance
and update the call in CustomizableWidgets to not detach the method.

Differential Revision: https://phabricator.services.mozilla.com/D178049
 2023-05-23 12:01:03 +00:00
Noemi Erli
1f146f097e Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE 
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
 2023-05-23 12:14:37 +03:00
Mark Banner
08ff6c0ad9 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-05-23 08:13:08 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Eemeli Aro
d686450a21 Bug 1832141 - Migrate strings to recentlyClosed.ftl. r=Gijs,flod 
The five strings used by the component are collected into one new file.
The dropped `menuUndoCloseWindowSingleTabLabel` is the same in all locales,
so it was easier to recreate its contents in the custom Fluent migration transform.

Differential Revision: https://phabricator.services.mozilla.com/D177614
 2023-05-11 07:29:34 +00:00
Mark Banner
0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D176336
 2023-05-09 16:14:51 +00:00
Victoria Ajala
4b95f9a4cf Bug 942154 - Use normal console logging instead of debug(). r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176322
 2023-04-25 17:18:38 +00:00
Daisuke Akatsuka
f1441c3114 Bug 1824040: Make the loading URL opened in _blank target to be the target of Session Restore r=mak,smaug,farre,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D173790
 2023-04-14 01:59:44 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
Mark Banner
8551cb9af4 Bug 1823763 - Convert toolkit/components/reader to ES modules. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D173183
 2023-03-23 12:11:43 +00:00
Gijs Kruitbosch
5e7d1aeb25 Bug 1823706 - rename addMultipleTabs and batchInsertingTabs parameter for clarity, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D173271
 2023-03-23 10:00:35 +00:00
Gijs Kruitbosch
209acd760d Bug 1822854 - add marionette test for manual session restore while a pinned tab is present, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D173071
 2023-03-21 16:29:06 +00:00
Gijs Kruitbosch
5a7f5e02ed Bug 1822854 - ensure session store doesn't assume _tPos is set and has good stub info for recently restored tabs so we don't break manual session restore, r=dao 
Either of these changes (ie dropping the setTabState call for batch restored
tabs, or ensuring the restoreTabs code correctly fills its array with dummy
entries) is sufficient here. I chose to do both because I think in both cases
the brokenness is not limited to this scenario or the issues at hand.

Specifically, the setTabState call was added in bug 1521346 to deal with
moved lazy tabs, but is now being invoked for session restore because of
the batchInsertingTabs optimization work. It doesn't actually need to be,
as far as I can tell, and the lacking _tPos in this case (because we don't
insert the tab into the tabstrip a few lines above) is what breaks things
inside _ensureNoNullsInTabDataList. Note that this _already_ was breaking
things in restoreTab(), which would assign into tabs[undefined] on the
window state object, so just dropping the call seemed better than wallpapering
the absence of _tPos.

The restoreTabs code, pre-patch, calls _ensureNoNullsInTabDataList but that
will never do anything, because right before calling it we change the array
length, so maxPos was always smaller than the size of the list. This meant
we still had empty slots in the array, which was also causing confusion down
the line.

I added the explicit exception for the broken _tPos in restoreTab so that we
notice any future issues with this more quickly. Doing so without any of the
other fixes broke the pre-existing browser_586068-apptabs.js test, so
hopefully that will catch any future changes that break the code's assumptions.

Differential Revision: https://phabricator.services.mozilla.com/D173070
 2023-03-21 16:29:06 +00:00
anayo
f7b10909f6 Bug 1814427 - Replace linkMoreTroubleshooting xul anchor with moz-support-link r=tgiles 
Differential Revision: https://phabricator.services.mozilla.com/D172221
 2023-03-15 22:06:28 +00:00
Abhishek Tiwari
44d69b39a6 Bug 1821620 - Convert toolkit/components/forgetaboutsite to ES modules r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D172230
 2023-03-14 21:36:38 +00:00
Siya
809af7350c Bug 1821305 - Convert toolkit/components/crashmonitor/ to ES modules. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D172357
 2023-03-13 14:18:06 +00:00
Brad Werth
babfe209e9 Bug 1631735 Part 4: Make tests that minimize windows wait for size mode change events. r=mstange 
Depends on D170841

Differential Revision: https://phabricator.services.mozilla.com/D171626
 2023-03-06 19:38:12 +00:00
Mike Conley
85339f07c4 Bug 1820207 - await BrowserTestUtils.crashFrame cleaning up crashes in browser_pinned_tabs.js. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D171722
 2023-03-06 16:02:17 +00:00
Mike Conley
86eed67fa6 Bug 1423125 - Restore previous session if undoCloseTab is called with no more tabs to restore. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D171377
 2023-03-03 14:06:43 +00:00
Gijs Kruitbosch
3df1817aaa Bug 1763279 - fix session store tab data sanity checks to not be terrible for performance, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D170755
 2023-02-28 08:01:34 +00:00
Kelly Cochrane
3d928092de Bug 1801204 - Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D169010
 2023-02-24 21:32:25 +00:00
Peter Van der Beken
6df2b51cf5 Bug 1816697 - Change test annotations for tests that fail/only succeed with session-history-in-parent. r=smaug 
Some of the tests that fail (or only succeed) with SHIP are currently marked for
Fission. This makes them fail once we turn on SHIP without Fission.

Differential Revision: https://phabricator.services.mozilla.com/D169824
 2023-02-21 14:58:35 +00:00
Joel Maher
417438b9cf Bug 1816191 - Skip tests in order to keep win7 running @ azure. r=gbrown,necko-reviewers,settings-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,nalexander,sgalich,alwu 
Differential Revision: https://phabricator.services.mozilla.com/D169523
 2023-02-14 23:44:12 +00:00
Gijs Kruitbosch
57f2b058ba Bug 1810141 - fix tests to deal with changes to loadURI, r=mossop,perftest-reviewers,geckoview-reviewers,extension-reviewers,sparky,owlish 
Depends on D168396

Differential Revision: https://phabricator.services.mozilla.com/D168397
 2023-02-13 23:50:41 +00:00
Gijs Kruitbosch
bc748bee0c Bug 1810141 - switch consumers where there isn't an obvious URI object to use to fixupAndLoadURIString, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,owlish 
This also updates layoutdebug.js, which in some ways pretends to be like a browser window but
is its own special snowflake. I kept the method naming conventions similar to the main
browser window.

Depends on D168394

Differential Revision: https://phabricator.services.mozilla.com/D168395
 2023-02-13 23:50:40 +00:00
Gijs Kruitbosch
a396f8a867 Bug 1810141 - fix loadURI callers that already have an nsIURI reference or where creating one is clearly safe, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,m_kato 
There are 3 types of changes in this commit:

- from `loadURI(foo.spec)` to `loadURI(foo)`, as there's already a URI
- from `loadURI("string")` to `loadURI(Services.io.newURI("string"))` as the URL is hardcoded
- one or two where there is perhaps an intermediate variable but the patch
  context should still make it trivial to ascertain the change is correct.

Depends on D168393

Differential Revision: https://phabricator.services.mozilla.com/D168394
 2023-02-13 23:50:40 +00:00
Gijs Kruitbosch
2683112303 Bug 1810141 - update consumers of CanonicalBrowsingContext.loadURI to use fixup or pass a URI object if they have it, r=mak,webdriver-reviewers,whimboo 
Depends on D168389

Differential Revision: https://phabricator.services.mozilla.com/D168390
 2023-02-13 23:50:38 +00:00
Cristina Horotan
f062495d94 Backed out 9 changesets (bug 1810141) for several test failures on a CLOSED TREE 
Backed out changeset 8781a0d1254d (bug 1810141)
Backed out changeset 131037295784 (bug 1810141)
Backed out changeset 3852fbe290f4 (bug 1810141)
Backed out changeset 118f131a524a (bug 1810141)
Backed out changeset ab5d76846e10 (bug 1810141)
Backed out changeset dce3aa683445 (bug 1810141)
Backed out changeset 4dc41d90dbb3 (bug 1810141)
Backed out changeset 50b57ba1a061 (bug 1810141)
Backed out changeset 569de94781e4 (bug 1810141)
 2023-02-13 16:05:30 +02:00
Gijs Kruitbosch
c235e8167f Bug 1810141 - fix tests to deal with changes to loadURI, r=mossop,perftest-reviewers,geckoview-reviewers,extension-reviewers,sparky,owlish 
Depends on D168396

Differential Revision: https://phabricator.services.mozilla.com/D168397
 2023-02-13 12:55:26 +00:00
Gijs Kruitbosch
2e04015e9c Bug 1810141 - switch consumers where there isn't an obvious URI object to use to fixupAndLoadURIString, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,owlish 
This also updates layoutdebug.js, which in some ways pretends to be like a browser window but
is its own special snowflake. I kept the method naming conventions similar to the main
browser window.

Depends on D168394

Differential Revision: https://phabricator.services.mozilla.com/D168395
 2023-02-13 12:55:25 +00:00
Gijs Kruitbosch
6122444136 Bug 1810141 - fix loadURI callers that already have an nsIURI reference or where creating one is clearly safe, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,m_kato 
There are 3 types of changes in this commit:

- from `loadURI(foo.spec)` to `loadURI(foo)`, as there's already a URI
- from `loadURI("string")` to `loadURI(Services.io.newURI("string"))` as the URL is hardcoded
- one or two where there is perhaps an intermediate variable but the patch
  context should still make it trivial to ascertain the change is correct.

Depends on D168393

Differential Revision: https://phabricator.services.mozilla.com/D168394
 2023-02-13 12:55:24 +00:00
Gijs Kruitbosch
608c7cef07 Bug 1810141 - update consumers of CanonicalBrowsingContext.loadURI to use fixup or pass a URI object if they have it, r=mak,webdriver-reviewers,whimboo 
Depends on D168389

Differential Revision: https://phabricator.services.mozilla.com/D168390
 2023-02-13 12:55:22 +00:00
Stanca Serban
9d20ea803f Bug 1775608 - disable browser_sessionHistory.js on linux and mac10.15 debug. r=intermittent-reviewers,MasterWayZ DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D169178
 2023-02-08 14:36:01 +00:00
Cosmin Sabou
8bf07d5fb3 Bug 1775616 - disable browser_async_window_flushing.js due to frequent failures. r=intermittent-reviewers,jmaher 
Differential Revision: https://phabricator.services.mozilla.com/D168489
 2023-02-03 06:09:38 +00:00
Gijs Kruitbosch
b965c4660a Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D166179
 2023-01-31 11:48:41 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D167297
 2023-01-20 17:49:21 +00:00
Gijs Kruitbosch
5a903703c5 Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D167153
 2023-01-19 20:16:42 +00:00
Andreas Farre
027c6ceda3 Bug 1810704 - Collect telemetry for session history collection time. r=peterv 
Differential Revision: https://phabricator.services.mozilla.com/D167033
 2023-01-19 06:45:55 +00:00
Florian Quèze
a73b864d0a Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao. 
Differential Revision: https://phabricator.services.mozilla.com/D166099
 2023-01-16 14:55:22 +00:00
Sarah Clements
8f954f3b82 Bug 1804064 - Firefox View window should not be saved r=Gijs,kcochrane 
* If Firefox view tab is the last selected tab when a window is closed it
should not be saved; the first tab should be used instead. This patch updates a test,
updates the title that is saved and the selected index

Differential Revision: https://phabricator.services.mozilla.com/D166362
 2023-01-11 11:59:19 +00:00
Stanca Serban
87d12b6bcd Backed out changeset c6ec3664e1f5 (bug 1808729) for causing mochitests failures in browser_privatebrowsing_history_shift_click.js. CLOSED TREE 2023-01-10 12:31:26 +02:00
Florian Quèze
0e43dbbe17 Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao. 
Differential Revision: https://phabricator.services.mozilla.com/D166099
 2023-01-10 08:26:07 +00:00
Sandor Molnar
2704668f7b Backed out changeset 1a38da4f6de9 (bug 1808729) for causing bc failures in browser/components/sessionstore/test/browser_not_collect_when_idle.js CLOSED TREE 2023-01-09 16:28:29 +02:00
Florian Quèze
0574310850 Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao. 
Differential Revision: https://phabricator.services.mozilla.com/D166099
 2023-01-09 11:31:28 +00:00
Marco Castelluccio
ba39d286d5 Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D165395
 2022-12-23 22:45:46 +00:00
Mark Banner
df47c60747 Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D165002
 2022-12-23 12:37:07 +00:00
Mark Banner
2b069eb017 Bug 1806306 - Convert AsyncShutdown imports to direct ES imports. r=mak,webdriver-reviewers,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D164981
 2022-12-23 12:37:06 +00:00