corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
787,250 Commits 1 Branch 0 Tags
81c86b200c45e4f33d42602f849d692458eb872a
Commit Graph

492 Commits

Author SHA1 Message Date
scottdowne
272067742c Bug 1832507 - Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D177935
 2023-05-15 13:46:01 +00:00
scottdowne
4b6221125c Bug 1832178 - Pocket newtab international onboarding experience alignment issue r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D177641
 2023-05-10 18:33:07 +00:00
scottdowne
4b486920aa Bug 1812690 - Pocket newtab enabling onboarding experience for new users seeing the Pocket section for the first time. r=gvn,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D174710
 2023-04-25 16:49:25 +00:00
scottdowne
de18d8fccf Bug 1812689 - Pocket newtab new regions implementation r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D173853
 2023-04-21 17:57:28 +00:00
Mike Conley
1a8461cd0b Bug 1826360 - Do not include sponsored tiles for about:home startup cache r=mconley,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D174646
 2023-04-04 18:25:43 +00:00
Mark Banner
45cdad50d5 Bug 1825715 - Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling (other). r=Gijs,necko-reviewers,credential-management-reviewers,devtools-reviewers,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D174217
 2023-04-01 16:40:01 +00:00
Lina Butler
0ea22d21eb Bug 1821556 - Collect the tile position and number of tile rows in newtab pings. r=nanj 
This commit:

* Adds a `position` key to the `topsites.{impression, click}` events.
  This position is zero-based, to align with `pocket_position`.
* Refactors the impression stats actions in `TelemetryFeed` to receive
  the zero-based tile position, and adds one to the structured
  ingestion payloads and scalar values.
* Adds a new Glean metric, `topsites.rows`, to record the number of
  rows shown on the New Tab page.

Differential Revision: https://phabricator.services.mozilla.com/D172292
 2023-03-31 05:21:20 +00:00
Shane Hughes
6595d7a3b6 Bug 1786582 - Update fluent and fluent-react in newtab. r=barret 
Differential Revision: https://phabricator.services.mozilla.com/D172720
 2023-03-22 04:15:39 +00:00
Russell Chan
082fa6cd97 Bug 1821820 - Add support to open CFR using about:messagepreview r=omc-reviewers,barret 
Differential Revision: https://phabricator.services.mozilla.com/D172835
 2023-03-21 16:07:44 +00:00
Shane Hughes
dc7748825b Bug 1821497 - Add a message Share button to ASRouterAdmin. r=pdahiya,barret 
Differential Revision: https://phabricator.services.mozilla.com/D172199
 2023-03-20 20:31:29 +00:00
Gavin Suntop
96854f5647 Bug 1814724 - Use BFF For Recent Saves r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D170686
 2023-03-15 00:10:05 +00:00
Lina Butler
d78454e018 Bug 1820707 - Record impressions and clicks for organic tiles. r=nanj 
Currently, the Glean `newtab` ping and legacy scalars collect
impressions and clicks for sponsored (Pocket and Contile) tiles, but
not organic tiles from Places.

This commit adds:

* Support for recording organic impressions to the
  `TopSiteImpressionWrapper` component.
* Support for recording organic clicks to the `TopSiteLink`
  component.
* Instrumentation for recording organic impressions and clicks,
  separate from sponsored ones, to `TelemetryFeed`.

Differential Revision: https://phabricator.services.mozilla.com/D171830
 2023-03-11 05:24:03 +00:00
scottdowne
bcc875f7a0 Bug 1820926 - Pocket newtab fixing Discovery Stream topsite images. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D171945
 2023-03-08 18:29:59 +00:00
scott
173e73bfcf Bug 1805589 - Pocket newtab add Discovery Stream topsites to topsites list earlier. 
Differential Revision: https://phabricator.services.mozilla.com/D164625
 2023-03-03 21:54:36 +00:00
Stanca Serban
ba2c013d86 Backed out changeset 51080108cc0d (bug 1805589) for causing mochitests failures in browser/components/newtab/test/browser/abouthomecache/browser_no_startup_actions.js. CLOSED TREE 2023-03-03 21:29:55 +02:00
scott
89b0078202 Bug 1805589 - Pocket newtab add Discovery Stream topsites to topsites list earlier. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D164625
 2023-03-03 18:22:34 +00:00
Mark Banner
bffb763c63 Bug 1815224 - Migrate newtab's Reducers.jsm to ES modules. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D168955
 2023-02-06 19:11:48 +00:00
prathikshaprasadsuman
f6b948db44 Bug 1749866 - Top site add/edit dialog should get focus when it is opened. r=thecount 
This patch does two things:
1. Brings focus into the add/edit top site dialogs when they are opened.
2. Sets the `aria-haspopup=dialog` attribute on the buttons that open the dialogs. This helps assistive technologies announce that a dialog is being opened before it opens.

Differential Revision: https://phabricator.services.mozilla.com/D168564
 2023-02-01 17:21:00 +00:00
Mark Banner
06e8ca3872 Bug 1808941 - Enable ESLint rules no-restricted-globals and strict for newtab. r=aminomancer 
The 'strict' rule is only enabled for mjs files, as per Mozilla's recommended config.

Differential Revision: https://phabricator.services.mozilla.com/D166197
 2023-01-07 13:21:41 +00:00
Mark Banner
00abf03e4f Bug 1808202 - Convert newtab DeDupe.jsm, ActorConstants.jsm and Actions.jsm to ES modules and update imports. r=Mardak 
Depends on D165820

Differential Revision: https://phabricator.services.mozilla.com/D165821
 2023-01-05 09:58:30 +00:00
scott
9d50f3d711 Bug 1804533 - Save to Pocket and Pocket newtab pass rollout metadata to Pocket links r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D164125
 2022-12-08 17:39:36 +00:00
scott
81b2abcdfd Bug 1803410 - Pocket newtab topsites, fixing replaced pinned edge cases. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D163510
 2022-12-01 17:38:57 +00:00
scott
34d6c900b7 Bug 1803206 - Pocket newtab sponsored topsite fixing image resize. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D163363
 2022-11-30 03:57:12 +00:00
scott
e6e0377789 Bug 1803107 - Pocket newtab topsites fixing pinning issue with sponsored Pocket tile. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D163339
 2022-11-29 19:10:47 +00:00
scott
e7f4d6f040 Bug 1802265 - Pocket newtab topsite spoc use title instead of sponsor. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D162947
 2022-11-24 20:03:53 +00:00
Shane Hughes
8ceb90e910 Bug 1800087 - Fix ASRouter references to RS collections. r=barret 
ASRouter's remote message providers were written to include a property
to specify the desired collection on the Remote Settings Kinto server.
But this property was mistakenly labeled `bucket` in many places. This
could be confusing because Kinto storage is organized by both buckets
and collections, with buckets being a higher level of organization and
collections belonging to buckets. Each individual message provider
specifies a collection like "cfr", while the bucket is set by the router
code ("main"). This carried over to everything that interacted with the
providers, so this patch effectively replaces every reference to a
"message provider bucket" with "message provider collection." But more
importantly, provider definitions are stored as JSON strings in
preference values, so these definitions erroneously contained key-value
pairs like `bucket: "cfr"` which should have been `collection: "cfr"`.
That means the pref values themselves must be migrated to ensure that
modified prefs continue to work. Existing tests are updated and a new
test is added for the migrator, to meet minimum coverage requirements.
Documentation is also updated to reflect the correct property name.

Differential Revision: https://phabricator.services.mozilla.com/D162067
 2022-11-17 18:32:13 +00:00
Mark Banner
9ecec1531f Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D161942
 2022-11-13 21:02:41 +00:00
scott
4f01a04373 Bug 1799649 - Pocket newtab sponsored topsite drag position change fix. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D161625
 2022-11-08 21:24:47 +00:00
scott
b71ec3f1b5 Bug 1799481 - Pocket newtab sponsored topsites pin removed from context menu r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D161496
 2022-11-07 18:57:51 +00:00
scott
6b25631050 Bug 1797612 - Newtab prevent sponsored topsites from being dragged r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D161000
 2022-11-02 22:12:02 +00:00
Nan Jiang
aa7e4ae5e7 Bug 1794022 - Add telemetry for top sites SPOCS r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D160939
 2022-11-01 21:02:26 +00:00
scott
258a894504 Bug 1794020 - topsite promo tiles 
Differential Revision: https://phabricator.services.mozilla.com/D160851
 2022-10-31 22:05:25 +00:00
Punam Dahiya
3187d5e5cb Bug 1753746 - PBM messaging devtool integration r=pdahiya,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D145808
 2022-10-31 15:21:56 +00:00
Marian-Vasile Laza
fe65732048 Backed out changeset f394d8fa64f3 (bug 1794020) for causing marionette & telemetry failures. CLOSED TREE 2022-10-29 12:17:19 +03:00
scott
3adac7d415 Bug 1794020 - topsite promo tiles r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D144438
 2022-10-29 08:42:00 +00:00
Sandor Molnar
17a6bd06dc Backed out changeset 19fcc2a044a8 (bug 1794020) for causing mochitest failures in lib/DiscoveryStreamFeed.jsm CLOSED TREE 2022-10-28 21:37:39 +03:00
scott
dced0ed94d Bug 1794020 - topsite promo tiles r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D144438
 2022-10-28 16:03:49 +00:00
Noemi Erli
111f253947 Backed out changeset 12a565036b3c (bug 1794020) for causing DiscoveryStreamFeed.jsm related failures CLOSED TREE 2022-10-28 01:41:55 +03:00
scott
03cc186a29 Bug 1794020 - topsite promo tiles r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D144438
 2022-10-27 21:54:00 +00:00
Marian-Vasile Laza
bafe5f1f3b Backed out changeset ad5bb5f4a576 (bug 1794020) for causing bc failures on browser_policy_firefoxhome.js. CLOSED TREE 2022-10-26 22:37:25 +03:00
scott
e9cf819459 Bug 1794020 - topsite promo tiles r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D144438
 2022-10-26 18:12:26 +00:00
Chris H-C
4f0806c847 Bug 1795136 - Correct sponsoredness detection for top story impressions, clicks r=nanj,thecount 
I forgot to transmit the information from the content.

Differential Revision: https://phabricator.services.mozilla.com/D159406
 2022-10-14 18:45:45 +00:00
Gavin Suntop
f8b59c716a Bug 1790667 - Design tweaks for STP button r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D157505
 2022-10-07 17:04:27 +00:00
scott
26d7902675 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D158531
 2022-10-05 20:20:02 +00:00
Csoregi Natalia
ca10cb1d71 Backed out changeset 39dd7976006b (bug 1793487) for causing newtab failures. CLOSED TREE 2022-10-05 21:07:56 +03:00
scott
c0bd2e12f8 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D158531
 2022-10-05 17:23:23 +00:00
Norisz Fay
ad1ab8d622 Backed out changeset b65e99ab62ad (bug 1790667) for causing node newtab failure CLOSED TREE 2022-10-04 21:34:07 +03:00
Gavin Suntop
d1027148f6 Bug 1790667 - Design tweaks for STP button r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D157505
 2022-10-04 18:00:17 +00:00
scott
554aaaaf6b Bug 1791614 - Pocket newtab adding reader mode links to recent saves. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D157749
 2022-09-20 20:08:51 +00:00
scott
ca1c4058a5 Bug 1790856 - Fixing Pocket recent saves id for telemetry. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D157353
 2022-09-14 21:35:25 +00:00