corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
787,250 Commits 1 Branch 0 Tags
81c86b200c45e4f33d42602f849d692458eb872a
Commit Graph

76 Commits

Author SHA1 Message Date
Mark Banner
1a15e7c71e Bug 1677562 - Remove eslint-plugin-prettier now that Prettier and ESLint are separated. r=Gijs,devtools-reviewers,ochameau 
Depends on D175769

Differential Revision: https://phabricator.services.mozilla.com/D175770
 2023-04-19 08:52:38 +00:00
Mark Banner
32ebe2b93b Bug 1809497 - Separate running of Prettier from ESLint completely. r=linter-reviewers,devtools-reviewers,andi 
Differential Revision: https://phabricator.services.mozilla.com/D174867
 2023-04-17 13:33:56 +00:00
Mark Banner
781ac41b6a Bug 1825507 - Separate out prettier and ESLint to run as different processes. r=linter-reviewers,devtools-reviewers,ahal 
This is enough to allow ESLint and Prettier to be run as different processes within the same lint command.
It does not fix all the failures with those two separate - that will be handled in follow-up bugs.

Differential Revision: https://phabricator.services.mozilla.com/D174133
 2023-04-04 19:02:13 +00:00
Mark Banner
9b6109ea0f Bug 1808941 - Remove unnecessary/redundant rule specifications from newtab's ESLint configuration. r=aminomancer 
no-catch-shadow has been replaced by no-shadow, which is already enabled.
no-label-var is unnecessary, as no-label is enabled everywhere already.
no-negated-in-lhs has been replaced by no-unsafe-negation which is an ESLint recommended rule and is enabled everywhere.

Depends on D166197

Differential Revision: https://phabricator.services.mozilla.com/D166198
 2023-01-07 13:21:41 +00:00
Mark Banner
06e8ca3872 Bug 1808941 - Enable ESLint rules no-restricted-globals and strict for newtab. r=aminomancer 
The 'strict' rule is only enabled for mjs files, as per Mozilla's recommended config.

Differential Revision: https://phabricator.services.mozilla.com/D166197
 2023-01-07 13:21:41 +00:00
Mark Banner
3f297271e3 Bug 1808941 - Remove ESLint rules from newtab's ESLint setup where the rule is specified as turned off but it has no effects. r=aminomancer 
These rules are not enabled by default in either the ESLint or Mozilla recommended configs. Some of the rules are deprecated.

Depends on D166195

Differential Revision: https://phabricator.services.mozilla.com/D166196
 2023-01-07 13:21:41 +00:00
Mark Banner
f3354f811e Bug 1808941 - In newtab's ESLint setup, only specify node environment where it is actually used. r=aminomancer 
Depends on D166194

Differential Revision: https://phabricator.services.mozilla.com/D166195
 2023-01-07 13:21:40 +00:00
Mark Banner
570a1b2016 Bug 1808941 - In newtab's ESLint configuration, only specify test environments where they are actually used to get the correct globals and rules. r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D166194
 2023-01-07 13:21:40 +00:00
Marian-Vasile Laza
2f82fe003a Backed out 5 changesets (bug 1808941) for causing newtab failures. CLOSED TREE 
Backed out changeset 3df3536eabbb (bug 1808941)
Backed out changeset eee0bb5a4c96 (bug 1808941)
Backed out changeset 9adc7f9ee3c6 (bug 1808941)
Backed out changeset 44c2c13bd7d9 (bug 1808941)
Backed out changeset a20a5cde0fe5 (bug 1808941)
 2023-01-07 13:41:13 +02:00
Mark Banner
d63eb52181 Bug 1808941 - Remove unnecessary/redundant rule specifications from newtab's ESLint configuration. r=aminomancer 
no-catch-shadow has been replaced by no-shadow, which is already enabled.
no-label-var is unnecessary, as no-label is enabled everywhere already.
no-negated-in-lhs has been replaced by no-unsafe-negation which is an ESLint recommended rule and is enabled everywhere.

Depends on D166197

Differential Revision: https://phabricator.services.mozilla.com/D166198
 2023-01-07 10:59:06 +00:00
Mark Banner
4294bb8c4f Bug 1808941 - Enable ESLint rules no-restricted-globals and strict for newtab. r=aminomancer 
The 'strict' rule is only enabled for mjs files, as per Mozilla's recommended config.

Depends on D166196

Differential Revision: https://phabricator.services.mozilla.com/D166197
 2023-01-07 10:59:06 +00:00
Mark Banner
9b485628b4 Bug 1808941 - Remove ESLint rules from newtab's ESLint setup where the rule is specified as turned off but it has no effects. r=aminomancer 
These rules are not enabled by default in either the ESLint or Mozilla recommended configs. Some of the rules are deprecated.

Depends on D166195

Differential Revision: https://phabricator.services.mozilla.com/D166196
 2023-01-07 10:59:05 +00:00
Mark Banner
ed8dd628b8 Bug 1808941 - In newtab's ESLint setup, only specify node environment where it is actually used. r=aminomancer 
Depends on D166194

Differential Revision: https://phabricator.services.mozilla.com/D166195
 2023-01-07 10:59:05 +00:00
Mark Banner
3ab74eaaee Bug 1808941 - In newtab's ESLint configuration, only specify test environments where they are actually used to get the correct globals and rules. r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D166194
 2023-01-07 10:59:04 +00:00
Emily McMinn
7eb37658b5 Bug 1807181 - Make newtab Eslintrc more readable r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D166005
 2023-01-05 18:54:56 +00:00
Mark Banner
5dad366a3e Bug 1803911 - Automatically replace Cu.reportError with console.error (newtab), and manually fix tests. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D163770
 2022-12-08 16:21:28 +00:00
Mark Banner
e4276619d3 Bug 1801092 - Add an ESLint rule to disllow use of Cu.reportError with a single argument. r=Gijs,cmkm 
This enforces the bulk of the cases for Cu.reportError. A follow-up will extend this to the
two argument form.

Differential Revision: https://phabricator.services.mozilla.com/D162285
 2022-11-29 23:07:42 +00:00
Iulian Moraru
e4cb785520 Backed out 3 changesets (bug 1801092) for causing newtab failures. 
Backed out changeset 9153de956154
Backed out changeset 9df9c279c28d (bug 1801092)
Backed out changeset 7323c7444941 (bug 1801092)
 2022-11-30 00:28:42 +02:00
Mark Banner
2f30acd85c Bug 1801092 - Add an ESLint rule to disllow use of Cu.reportError with a single argument. r=Gijs,cmkm 
This enforces the bulk of the cases for Cu.reportError. A follow-up will extend this to the
two argument form.

Differential Revision: https://phabricator.services.mozilla.com/D162285
 2022-11-29 21:21:28 +00:00
Mark Banner
9ecec1531f Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D161942
 2022-11-13 21:02:41 +00:00
Punam Dahiya
eac66c92d8 Bug 1798336 - Add multiselect section to onboarding template r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D161230
 2022-11-10 21:59:44 +00:00
trickypr
69c4be34a0 Bug 1510561 - Part 8: Remove unused jsdoc rules from browser/components/newtab. r=Standard8 
The two rules here (`require-jsdoc` and `valid-jsdoc`) will likely be
removed in the not-to-distant future, so I am cleaning up their usage.

Differential Revision: https://phabricator.services.mozilla.com/D160633
 2022-10-28 13:44:28 +00:00
lyavor
312735b885 Bug 1709150 - Consider linter rule to make https the default for all kind of tests we add. r=Standard8,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D149394
 2022-09-07 08:45:12 +00:00
Mark Banner
19a1cb499e Bug 1784699 - Turn off the ESLint browser environment for xpcshell-tests for better represetation of the globals actually available. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D154606
 2022-08-15 16:50:33 +00:00
Barret Rennie
585dcbcd30 Bug 1761522 - Allow ja-JP-macos locale for RemoteL10n r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D142227
 2022-04-28 17:10:15 +00:00
Mark Banner
29a9a55542 Bug 1702166 - Update ESLint, Babel and associated modules to the latest versions. r=mossop,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D110606
 2021-04-04 08:05:39 +00:00
Punam Dahiya
60c350f877 Bug 1696547 - Refactor MultiStageAboutWelcome to support Proton onboarding r=Mardak,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D107954
 2021-03-25 20:28:39 +00:00
Andrei Oprea
d00578a88e Bug 1693787 - Remove SimpleAboutWelcome r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D105958
 2021-02-26 17:00:16 +00:00
Dorel Luca
a070993bae Backed out changeset a59724449f46 (bug 1693787) for Browser-chrome failures in browser/base/content/test/static/browser_parsable_css.js. CLOSED TREE 2021-02-26 16:41:28 +02:00
Andrei Oprea
667ce874f7 Bug 1693787 - Remove SimpleAboutWelcome r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D105958
 2021-02-26 13:37:16 +00:00
smolnar
95202d59e6 Backed out changeset e3f394d78bab (bug 1693787) for causing mochitest failures in browser_all_files_referenced. CLOSED TREE 2021-02-26 13:32:13 +02:00
Andrei Oprea
cb57ecdbf0 Bug 1693787 - Remove SimpleAboutWelcome r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D105958
 2021-02-26 10:15:29 +00:00
Erica Wright
05d7bbaa0b Bug 1671943 - Create home content section for customize menu. r=prathiksha,thecount,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D98242
 2020-12-09 21:36:54 +00:00
Brindusan Cristian
9159c36c9c Backed out changeset 98e6f69f3c79 (bug 1671943) for bc failures at browser_parsable_css.js. CLOSED TREE 2020-12-09 21:43:01 +02:00
Erica Wright
a889280660 Bug 1671943 - Create home content section for customize menu. r=prathiksha,thecount,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D98242
 2020-12-09 16:21:43 +00:00
smolnar
defe213e24 Backed out changeset bae008440598 (bug 1671943) for causing node test failures in CustomizeMenu.scss CLOSED TREE 2020-12-09 14:56:26 +02:00
Erica Wright
3cbd960f2b Bug 1671943 - Create home content section for customize menu. r=prathiksha,thecount,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D98242
 2020-12-08 20:32:41 +00:00
Punam Dahiya
f385b7bea7 Bug 1659169 - RTAMO custom onboarding r=fluent-reviewers,Mardak,flod 
Differential Revision: https://phabricator.services.mozilla.com/D91667
 2020-10-09 02:57:40 +00:00
Punam Dahiya
d696b17955 Bug 1659150 - Remove about:welcome trailhead, full page and ReturnToAMO templates r=perftest-reviewers,Mardak,mkaply,nanj,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D89077
 2020-09-11 16:35:04 +00:00
Cosmin Sabou
1090e15e9f Backed out changeset 08f94ba4c50c (bug 1659150) for bc failures on browser_all_files_referenced.js. CLOSED TREE 2020-09-11 08:32:46 +03:00
Punam Dahiya
29a57a59ff Bug 1659150 - Remove about:welcome trailhead, full page and ReturnToAMO templates r=perftest-reviewers,Mardak,mkaply,nanj,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D89077
 2020-09-11 00:31:11 +00:00
emcminn
78a857657b Bug 1640027 - Add Zap component that allows zap style to be added to headings r=pdahiya,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D80514
 2020-06-24 21:41:14 +00:00
Punam Dahiya
18411ab120 Bug 1637079 - Initial multi stage about:welcome layout r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D74811
 2020-05-16 00:02:11 +00:00
Sylvestre Ledru
640e18de6a Bug 1622328 - add license info to all eslintrc files r=Standard8,webcompat-reviewers,miketaylr 
Differential Revision: https://phabricator.services.mozilla.com/D67319
 2020-03-19 13:47:51 +00:00
Dave Townsend
6ae7b19881 Bug 1617959: Switch to the babel-eslint parser and turn on support for optional chaining and nullish coalescing operator syntaxes. r=Standard8 
The babel-eslint parser defaults to assuming all scripts are modules. Although
we're moving in that direction it seems reasonable to set the default as regular
scripts for now. All the places that were previously overriding the parser are
already specifying the sourceType in their eslint configs.

I chose to put the babel config in a file that babel itself won't look to avoid
the risk of this config impacting the use of babel elsewhere in the tree.

Differential Revision: https://phabricator.services.mozilla.com/D66127
 2020-03-13 19:15:11 +00:00
Mark Banner
d375cfec54 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703
 2020-03-07 10:09:44 +00:00
Punam Dahiya
782942ae95 Bug 1616370 - Simplified welcome page r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D63406
 2020-02-27 18:52:46 +00:00
Ed Lee
ca726c4d23 Bug 1610923 - Point npm run testmc to use mach to avoid error with linting r=thecount 
Add various linters supported by mach and remove eslint dependency.

Differential Revision: https://phabricator.services.mozilla.com/D60895
 2020-01-31 07:33:54 +00:00
Punam Dahiya
d60330c027 Bug 1588215 - Add modal-less welcome, send-tab recipes and bug fixes to New Tab Page r=Mardak,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D49020
 2019-10-12 07:01:16 +00:00
Ed Lee
970b18304c Bug 1586093 - Add engagement pref, join variant and bug fixes to New Tab Page r=k88hudson,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D48110
 2019-10-04 17:06:01 +00:00