corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
787,250 Commits 1 Branch 0 Tags
81c86b200c45e4f33d42602f849d692458eb872a
Commit Graph

3017 Commits

Author SHA1 Message Date
Mark Banner
81c86b200c Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D178590
 2023-05-26 11:36:33 +00:00
Katherine Patenio
99d830d71b Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D177423
 2023-05-24 15:52:34 +00:00
Perry McManis
5487344d67 Bug 1825863 - Add a Glean version of onboarding and ASRouter telemetry r=dmose,perry.mcmanis,omc-reviewers 
We consolidate all the "messaging-system"-namespace pings into a single Glean
ping to provide a holistic view of all events in that system.

Differential Revision: https://phabricator.services.mozilla.com/D178477
 2023-05-24 02:39:34 +00:00
scottdowne
40b0113078 Bug 1834544 - Pocket newtab sponsored topsites ensure we have a faviconSize for Kevel topsites. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D178796
 2023-05-23 16:47:39 +00:00
Tif Tran
ef8ecfc6a8 Bug 1833691 - Implement the Fallback protocol for Sponsored Tiles. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D178352
 2023-05-22 04:26:30 +00:00
Mark Banner
b61a6a6502 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177938
 2023-05-20 12:26:56 +00:00
Mark Banner
0f2402949a Bug 1826062 - Manual fixes for Prettier 2.8.8 upgrade. r=mossop,webdriver-reviewers,extension-reviewers,devtools-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D177908
 2023-05-20 12:26:55 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
negin
5a8e8520ab Bug 1832855 - Fix up hover styles for text links throughout onboarding & spotlights r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D178237
 2023-05-19 21:22:49 +00:00
Shane Hughes
bac2c296d0 Bug 1833986 - Adjust aboutwelcome multi select transition styles. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D178493
 2023-05-19 16:52:02 +00:00
Nan Jiang
e9b7045c95 Bug 1833898 - Use additional sponsored tiles by default r=ttran 
Differential Revision: https://phabricator.services.mozilla.com/D178486
 2023-05-19 00:15:07 +00:00
Neil Deakin
2cea21c177 Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D177112
 2023-05-18 23:03:34 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178362
 2023-05-18 18:34:51 +00:00
Shane Hughes
d779f112c6 Bug 1818249 - Add a message property to allow CFRs in Private Browsing. r=omc-reviewers,pdahiya 
Also, because the data collection policy now allows Category 1 and 2
data collection in Private Browsing Mode, these CFRs will record
telemetry in PBM according to the existing CFR policy, which allows
Cat1-3 data for pre-release builds and experiments, and Cat1-2 data for
release builds. PBM windows will be treated in the same way that release
builds treat normal windows. When not enrolled in a CFR experiment, the
PBM window will only collect Cat1-2 data. When enrolled in a CFR
experiment, the PBM window may collect Cat3 data. This patch also adds a
new option to PopupNotifications that allows its usual interaction
probes to be recorded in PBM. That means, outside of an experiment,
pings from a PBM window will look just like pings from a release build
non-PBM window. And inside an experiment, pings from a PBM window will
look just like pings from a non-PBM window in any build. This ensures
that the PBM pings do not intrinsically confer any identifying
information, since their privateness cannot be known with certainty.

Differential Revision: https://phabricator.services.mozilla.com/D174200
 2023-05-18 16:26:49 +00:00
Cristian Tuns
a6fcbe72f7 Backed out changeset 8813323684b7 (bug 1830911) for causing bc failures in browser_topsites_contextMenu_options.js CLOSED TREE 2023-05-18 11:36:20 -04:00
Neil Deakin
9bb07d7fd2 Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D177112
 2023-05-18 14:38:27 +00:00
scottdowne
f53be495f8 Bug 1832789 - Pocket newtab card context menu buttons don't show if card is focused. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D178350
 2023-05-17 17:42:23 +00:00
scottdowne
823afcbb67 Bug 1833125 - Pocket newtab onboarding experience dialog small fixes for high contrast modes. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D178094
 2023-05-15 18:36:19 +00:00
scottdowne
272067742c Bug 1832507 - Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D177935
 2023-05-15 13:46:01 +00:00
Barret Rennie
935952aa19 Bug 1832827 - Improve Experimenter error messages for FxMS schemas r=aminomancer 
Previously, when a `TemplatedMessage` was missing a required field, the error
on Experimenter would be that the message's template field was expected to be
`multi`. This happens because the `oneOf` doesn't match `TemplatedMessage` due
to required fields missing, so it infers it must be a `MultiMessage`.

Now instead of using a `oneOf` to match against either a `MultiMessage` or a
`TemplatedMessage`, we use an `if`/`then`/`else`, predicated by the `template`
key so that if `template != "multi"`, the errors will come form the
`TemplatedMessage` definition.

Differential Revision: https://phabricator.services.mozilla.com/D177914
 2023-05-12 15:20:47 +00:00
Mathieu Leplatre
1348d02a4f Bug 1832042 - Update URLs of new Remote Settings servers r=gbeckley,search-reviewers,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D177471
 2023-05-11 13:35:59 +00:00
Karandeep
b4c779e1c3 Bug 1824609 convert consumers of toolkit/components/thumbnails/ to import ES modules directly. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D177197
 2023-05-10 20:00:58 +00:00
scottdowne
4b6221125c Bug 1832178 - Pocket newtab international onboarding experience alignment issue r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D177641
 2023-05-10 18:33:07 +00:00
negin
ba615fe519 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-10 13:08:59 +00:00
Narcis Beleuzu
6d06f48e1a Backed out changeset 86f74f61adc0 (bug 1829039) for newtab failure on aboutwelcome.scss 2023-05-10 00:43:26 +03:00
negin
4ca699875e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 20:22:09 +00:00
Cosmin Sabou
191135a322 Backed out changeset f1e19e0fa144 (bug 1829039) as requested by aminomancer. CLOSED TREE 2023-05-09 20:05:34 +03:00
negin
952dfbc88c Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 16:41:53 +00:00
Mark Banner
0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D176336
 2023-05-09 16:14:51 +00:00
Shane Hughes
da6cbc353b Bug 1619842 - Remove longhand rule from newtab stylelint config. r=CosminS 
CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D177522
 2023-05-09 16:39:07 +00:00
Shane Hughes
268b8b6c64 Bug 1619842 - Migrate from sass-lint to stylelint. r=omc-reviewers,thecount,emcminn 
Fix a bug where VS Code's eslint integration does not work for the
newtab project because of a conflict caused by sass-lint's eslint
dependency. Switching over to stylelint eliminates that dependency and
generally modernizes our SCSS linting. stylelint doesn't have a 1 to 1
replacement for every sass-lint rule, so a few rules have been changed.

Differential Revision: https://phabricator.services.mozilla.com/D173605
 2023-05-09 15:37:15 +00:00
Norisz Fay
32ae2d7897 Backed out changeset 67d785ab3cb3 (bug 1829039) for causing node-newtab failure on aboutwelcome.scss CLOSED TREE 2023-05-09 17:35:44 +03:00
negin
dd6b50d41e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 13:46:13 +00:00
Shane Hughes
2c1e31da7b Bug 1829043 - Add actions for AboutWelcome embedded migration wizard. r=pdahiya,mconley 
Add some properties to the migration wizard screen JSON to specify what
action to perform when CTAs inside the embedded migration wizard are
clicked. This lets us advance screens when the cancel or finish button
is clicked, and send telemetry when the start button is clicked. In
theory we could perform any special message actions too, but for now we
only need telemetry and screen navigation.

Differential Revision: https://phabricator.services.mozilla.com/D176358
 2023-05-08 18:23:47 +00:00
Itiel
1d45b69b81 Bug 1830953 - Fix the toast milestone popup alignment to the shield icon on the urlbar r=anti-tracking-reviewers,timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D176941
 2023-05-08 18:07:50 +00:00
Katherine Patenio
f2226c4d20 Bug 1828433 - restore underlines for links in new tab page. r=amy 
This patch restores link underlines in the new tab page, particularly the settings page and discovery stream (top sites, pocket tiles, and recent activity). Only links that had underlines on hover were updated. `text-decoration: none` is added for cards to maintain original styling.

Differential Revision: https://phabricator.services.mozilla.com/D176819
 2023-05-08 16:28:50 +00:00
Hector Zhao
e110dd136c Bug 1831498 - Stop hardcoding the actor name in ActivityStreamMessageChannel. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D177233
 2023-05-08 01:11:07 +00:00
Cristian Tuns
faf8700d34 Backed out changeset 18480aae2752 (bug 1831498) for causing bc failures in ActivityStreamMessageChannel.jsm CLOSED TREE 2023-05-05 23:06:17 -04:00
Hector Zhao
c7f700d141 Bug 1831498 - Stop hardcoding the actor name in ActivityStreamMessageChannel. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D177233
 2023-05-06 02:10:54 +00:00
Cristian Tuns
05c7ba7f52 Backed out changeset 743c4f059b79 (bug 1829039) for causing bc failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-05-05 19:50:02 -04:00
negin
087c181c62 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-05 19:30:31 +00:00
Shane Hughes
aa7d407c55 Bug 1830422 - Add 5 placeholder FxMS features for 114+, r=aminomancer 
One from the JIRA Roadmap, and 4 more, so the total buffer size is 5.

Differential Revision: https://phabricator.services.mozilla.com/D176725
 2023-05-05 16:44:30 +00:00
Stanca Serban
8fc4f98984 Backed out changeset 72f882230f63 (bug 1829039) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-05 04:28:52 +03:00
negin
c514f3673d Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and lack of transition animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-04 23:32:12 +00:00
Emily McMinn
c65a4decdb Bug 1825144 - Replace istanbul-instrumenter-loader with coverage-istanbul-loader in browser/components/newtab r=mhoye,omc-reviewers,barret 
`Istanbul-instrumenter-loader` has started to block updates to our other npm packages and is no longer being maintained.

`coverage-istanbul-loader` is pretty seamless but is stricter in regards to coverage for functions; I’ve opted to adjust the coverage requirements down for the affected files and file a followup to improve test coverage later.

Differential Revision: https://phabricator.services.mozilla.com/D175284
 2023-05-04 17:36:35 +00:00
Mike Conley
99c30e6674 Bug 1828154 - Ensure new cache entry exists after clearing old one in browser_locale_change.js. r=amy 
This doesn't seem to absolutely fix the intermittent test failure here,
but does seem to reduce the frequency.

Differential Revision: https://phabricator.services.mozilla.com/D177158
 2023-05-04 16:12:10 +00:00
Cosmin Sabou
5eecdbf11c Backed out changeset cdaa6a0312f0 (bug 1829039) for causing increase in failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-03 19:40:03 +03:00
Mike Conley
ce09a57db6 Bug 1830901 - Only check the campaign attribution code when checking isDeviceMigration for ASRouter targeting. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D176937
 2023-05-03 14:03:55 +00:00
Mike Conley
60a2d9d4bf Bug 1830916 - Add UTM parameters for the FxA sign-in flow from AW_WELCOME_BACK. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D176946
 2023-05-03 14:03:55 +00:00