Commit Graph

505 Commits

Author SHA1 Message Date
Kelly Cochrane
5de3b991ac Bug 1818310 - Create reusable category navigation component r=mstriemer,sfoster,Jamie,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D177530
2023-05-25 13:42:47 +00:00
Kelly Cochrane
f5b163db5c Bug 1833218 - Create card container component to be used in Firefox View r=sclements
Creating new revision as a workaround for bug 1834868. The original revision was already R+ed here: https://phabricator.services.mozilla.com/D178473

Differential Revision: https://phabricator.services.mozilla.com/D179073
2023-05-25 13:14:18 +00:00
Stanca Serban
83d3ffb685 Backed out changeset b9da43bde2c9 (bug 1833218) for card_container related failures. CLOSED TREE 2023-05-24 22:13:02 +03:00
Kelly Cochrane
e98e708f30 Bug 1833218 - Create card container component to be used in Firefox View r=ayeddi,fluent-reviewers,fxview-reviewers,flod,sclements
Differential Revision: https://phabricator.services.mozilla.com/D178473
2023-05-24 17:19:46 +00:00
Mark Banner
b61a6a6502 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177938
2023-05-20 12:26:56 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Jonathan Sudiaman
00c66577d9 Bug 1833406 - Firefox view recently closed section items are not visible at hover when using high contrast r=fxview-reviewers,kcochrane
Simple styling adjustment.

Differential Revision: https://phabricator.services.mozilla.com/D178442
2023-05-19 13:54:08 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-05-18 17:19:45 +00:00
Kelly Cochrane
3fcc979ce4 Bug 1833228 - Update naming for new TabList reusable component files to be domain-specific r=mstriemer,fluent-reviewers,fxview-reviewers,flod,sclements
Differential Revision: https://phabricator.services.mozilla.com/D178191
2023-05-17 14:35:53 +00:00
Mike Kaply
3fd3f643e9 Bug 1824438 - Implement a module system for Firefox View. r=kcochrane,jsudiaman,fxview-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D175794
2023-05-12 18:39:12 +00:00
Jonathan Sudiaman
8e2e460f56 Bug 1829847 - Move Synced Tabs error handling into its own component r=fxview-reviewers,sfoster
Add a new component which handles managing the error states for synced tabs. Refactor `tab-pickup-container.js` and `firefox-view-tabs-setup-manager.js` to utilize the new component.

https://treeherder.mozilla.org/jobs?revision=aa98f8425f48a9c90b172dd7249713400989cc26&repo=try

Differential Revision: https://phabricator.services.mozilla.com/D177551
2023-05-12 15:31:22 +00:00
Stanca Serban
0ba1cad0a6 Backed out changeset 41155ff2690b (bug 1824438) for Firefox View related build bustages. CLOSED TREE 2023-05-12 18:26:47 +03:00
Mike Kaply
8273c9ffe3 Bug 1824438 - Implement a module system for Firefox View. r=kcochrane,jsudiaman,fxview-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D175794
2023-05-12 15:06:37 +00:00
Cosmin Sabou
0844d392ee Bug 1824273 - Disable browser_tab_pickup_list.js for frequent failures until a fix in place. r=intermittent-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D177797
2023-05-11 17:18:48 +00:00
Mike Kaply
1e64806384 Bug 1831601 - Switch view chrome URLS to have a firefoxview specific path. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D177283
2023-05-09 18:09:17 +00:00
Gijs Kruitbosch
6641241811 Bug 1508369 - clean up browser CSS to pass basic stylelint rules, r=desktop-theme-reviewers,webcompat-reviewers,extension-reviewers,devtools-reviewers,nchevobbe,denschub,dao
Differential Revision: https://phabricator.services.mozilla.com/D177476
2023-05-09 17:12:50 +00:00
Noemi Erli
ed26d7ff89 Backed out changeset 9e894095a614 (bug 1831601) for causing failures in browser_all_files_referenced.js CLOSED TREE 2023-05-08 18:15:12 +03:00
Mike Kaply
489564949e Bug 1831601 - Switch view chrome URLS to have a firefoxview specific path. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D177283
2023-05-08 14:11:12 +00:00
Kelly Cochrane
55d4ad1d4e Bug 1818322 - Create MozTabList and MozTabRow reusable components r=mstriemer,fluent-reviewers,fxview-reviewers,sfoster,Jamie,flod
Differential Revision: https://phabricator.services.mozilla.com/D171879
2023-05-04 15:26:10 +00:00
Norisz Fay
20f8f4ccab Backed out changeset 08ee4eba4c40 (bug 1818322) for causing bc failures on browser_parsable_css.js CLOSED TREE 2023-05-04 18:10:29 +03:00
Kelly Cochrane
26ce3f8d6b Bug 1818322 - Create MozTabList and MozTabRow reusable components r=mstriemer,fluent-reviewers,fxview-reviewers,sfoster,Jamie,flod
Differential Revision: https://phabricator.services.mozilla.com/D171879
2023-05-04 14:17:11 +00:00
Cristian Tuns
2a26c0ea21 Backed out changeset 437a2458db3c (bug 1818322) for causing bc failures in moz-tab-list.mjs CLOSED TREE 2023-05-04 09:43:58 -04:00
Kelly Cochrane
588f55bfdf Bug 1818322 - Create MozTabList and MozTabRow reusable components r=mstriemer,fluent-reviewers,fxview-reviewers,sfoster,Jamie,flod
Differential Revision: https://phabricator.services.mozilla.com/D171879
2023-05-04 12:44:24 +00:00
Jonathan Sudiaman
e5c848d3db Bug 1828736 - Change recently closed list items into links that support context clicking r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D175823
2023-04-20 12:51:58 +00:00
Mike Kaply
785f0562c8 Bug 1824436 - Add blank page for new view development. r=sfoster,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D174922
2023-04-12 16:03:39 +00:00
Francesco Lodolo (:flod)
1dfecb77f0 Bug 1826755 - Move Firefox account Fluent term to toolkit, r=fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,mconley,sclements,sgalich,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D175097
2023-04-12 15:51:42 +00:00
Ebilite Uchenna
ed5dc481d8 Bug 1824611 - Convert consumers of toolkit/components/passwordmgr to import ES modules directly. r=Standard8,credential-management-reviewers,settings-reviewers,fxview-reviewers,sclements,sgalich,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D174446
2023-04-11 19:06:24 +00:00
Russell Chan
b653cce8ee Bug 1825063 - Add ability to hide the arrow from the feature callout r=fxview-reviewers,omc-reviewers,aminomancer,sclements
Differential Revision: https://phabricator.services.mozilla.com/D174342
2023-04-11 14:01:03 +00:00
Shane Hughes
ca232ede40 Bug 1813716 - Encapsulate aboutwelcome container and make its ID more unique. r=omc-reviewers,fxview-reviewers,sfoster,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D172493
2023-03-29 21:51:09 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
2023-03-29 07:34:10 +00:00
Shane Hughes
7cf9a86c67 Bug 1818829 - Implement Feature Callout theme configuration. r=jprickett,omc-reviewers,fxview-reviewers,sfoster
Add logic to apply theme colors to Feature Callout based on where it's
going to show. We can use in-content CSS properties for Firefox View and
other themed system pages, but not for PDF.js, nor for any callouts we
might show in the browser chrome in the future. For the browser chrome
in general, we can use the lightweight theme properties directly, in the
same way the chrome frontend does. But PDF.js is a special case, since
although it exists in the chrome, it's meant to appear like it's in the
PDF.js viewer. And the PDF.js viewer has its own theme totally
independent of everything else. So this dynamically applies themes from
different sources.

This also fixes the bug where the PDF.js color scheme could mismatch the
PDF.js viewer if the browser theme and system color scheme don't match,
e.g. where system color scheme is light but a dark theme is installed,
or vice versa. For PDF.js specifically, we can use the
-moz-content-prefers-color-scheme media query to follow the color scheme
as it exists in the PDF.js viewer page instead of the color scheme in
the chrome window where the Feature Callout actually exists.

It also adds or modifies some colors that were previously missing or
different from the prototype, fixes the illegibility of buttons in HCM
and forced colors mode, and makes some other minor color changes.

Differential Revision: https://phabricator.services.mozilla.com/D173088
2023-03-28 00:38:42 +00:00
Cosmin Sabou
c31085cb42 Backed out changeset fecef27ba1fa (bug 1818829) for causing newtab failures on _feature-callout-theme.scss. CLOSED TREE 2023-03-28 02:46:44 +03:00
Shane Hughes
43bb7f08b0 Bug 1818829 - Implement Feature Callout theme configuration. r=jprickett,omc-reviewers,fxview-reviewers,sfoster
Add logic to apply theme colors to Feature Callout based on where it's
going to show. We can use in-content CSS properties for Firefox View and
other themed system pages, but not for PDF.js, nor for any callouts we
might show in the browser chrome in the future. For the browser chrome
in general, we can use the lightweight theme properties directly, in the
same way the chrome frontend does. But PDF.js is a special case, since
although it exists in the chrome, it's meant to appear like it's in the
PDF.js viewer. And the PDF.js viewer has its own theme totally
independent of everything else. So this dynamically applies themes from
different sources.

This also fixes the bug where the PDF.js color scheme could mismatch the
PDF.js viewer if the browser theme and system color scheme don't match,
e.g. where system color scheme is light but a dark theme is installed,
or vice versa. For PDF.js specifically, we can use the
-moz-content-prefers-color-scheme media query to follow the color scheme
as it exists in the PDF.js viewer page instead of the color scheme in
the chrome window where the Feature Callout actually exists.

It also adds or modifies some colors that were previously missing or
different from the prototype, fixes the illegibility of buttons in HCM
and forced colors mode, and makes some other minor color changes.

Differential Revision: https://phabricator.services.mozilla.com/D173088
2023-03-27 23:07:45 +00:00
Kelly Cochrane
9f600e8dfc Bug 1824358 - Don't update textContent for elements in Recently Closed tabs in Fx View to prevent Lit errors r=mstriemer,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D173547
2023-03-27 16:04:54 +00:00
Sam Foster
290810a04a Bug 1809661 - Keep track of time spent with 0 tabs after a new device is added, and record a telemetry event with the time elapsed until new tabs are shown. r=kcochrane
* Keep track of the tab-pickup-container views in TabsSetupFlowManager and their visibility
* Fix visibilitychange handling in tab-pickup-container and add some tests
* Capture a timestamp when a device has been added and there are 0 tabs to show, with at least one visible tab-pickup-container view
* Record telemetry when there are > 0 tabs in these conditions
* Small change to rename the `_waitingForTabs` internal tracking property to  `_waitingForNextTabSync` to better clarify its use and meaning
* Use a consistent pattern in some of the existing tests with how we mock SyncedTabs.getRecentTabs

Differential Revision: https://phabricator.services.mozilla.com/D170526
2023-03-23 23:55:49 +00:00
Russell Chan
9b99372418 Bug 1791072 - Add focus to primary button in feature callout r=omc-reviewers,emcminn,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D172725
2023-03-23 16:21:41 +00:00
Sam Foster
ce23bda9d6 Bug 1794435 - Make updateTime a noop when the updateTimeMs pref is 0. r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D173225
2023-03-22 18:36:54 +00:00
Jonathan Sudiaman
e5ab92bd73 Bug 1801734 - Change withFirefoxView helper so it doesn't open a new window by default r=fxview-reviewers,sfoster
Updates `withFirefoxView()` signature to accept a boolean flag indicating whether a new window should be opened, rather than having to pass in a `Window` object or opening a new window by default. The new default behavior is to use the global `window` by default. Update tests to only use this setting if it is needed to pass.

https://treeherder.mozilla.org/jobs?revision=f49e65c14c5eacdaedfb86c81d61450e3274a7c5&repo=try

Differential Revision: https://phabricator.services.mozilla.com/D173014
2023-03-21 19:04:22 +00:00
Abhishek Tiwari
496a43cc06 Bug 1821624 - Convert toolkit/components/messaging-system to ES modules r=Standard8,fxview-reviewers,omc-reviewers,aminomancer,sclements
Differential Revision: https://phabricator.services.mozilla.com/D172406
2023-03-15 18:44:02 +00:00
Francesco Lodolo (:flod)
fa28bcb157 Bug 1822388 - Move brandings.ftl from browser to toolkit, r=eemeli,settings-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sgalich,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D172643
2023-03-15 17:00:48 +00:00
Mark Banner
8aea2c2c67 Bug 1812098 - Fix ESLint raised issues with no-shadow of builtinGlobals in browser .mjs files. r=Gijs,credential-management-reviewers,sgalich,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D169463
2023-03-14 09:13:48 +00:00
Kelly Cochrane
ddc240c8c3 Bug 1822089 - [Fx View] Switch recently closed items back from role='link' to role='button' r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D172436
2023-03-13 18:06:16 +00:00
Butkovits Atila
ef7cdd4868 Backed out changeset 649252a67839 (bug 1809661) for causing failures complaining about _createRecentTabsList . CLOSED TREE 2023-03-08 21:12:35 +02:00
Sam Foster
e99667d462 Bug 1809661 - Keep track of time spent with 0 tabs after a new device is added, and record a telemetry event with the time elapsed until new tabs are shown. r=kcochrane
* Keep track of the tab-pickup-container views in TabsSetupFlowManager and their visibility
* Fix visibilitychange handling in tab-pickup-container and add some tests
* Capture a timestamp when a device has been added and there are 0 tabs to show, with at least one visible tab-pickup-container view
* Record telemetry when there are > 0 tabs in these conditions

Differential Revision: https://phabricator.services.mozilla.com/D170526
2023-03-08 17:21:11 +00:00
Sammy Khamis
90d92c83b3 Bug 1791478 - SyncedTabs should check if pp is locked before syncing r=markh,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D157874
2023-03-08 04:21:56 +00:00
Shane Hughes
4ed597ef90 Bug 1820053 - Alphabetize Firefox View browser test manifest. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D171516
2023-03-07 21:47:44 +00:00
Dão Gottwald
1057069b47 Bug 1820475 - Remove colorways-card.mjs and related code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D171696
2023-03-07 12:35:52 +00:00
Csoregi Natalia
0350da18d5 Backed out changeset d59fe9707337 (bug 1820475) for failures on browser_multistage_spotlight.js. CLOSED TREE 2023-03-07 12:35:33 +02:00