Commit Graph

90 Commits

Author SHA1 Message Date
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Kris Maglione
fab8e5086a Bug 1456677: Make the blocklist service a JSM, with an XPCOM service stub. r=Gijs
Aside from making things easier for JS callers, this also makes it harder to
accidentally trigger an early load of the service, which can be expensive
during startup.

This also makes a slight change to nsPluginHost to initially preserve the
previous blocklist state when a plugin is updated, to avoid the risk of the
possible additioanl asynchrony unblocking a plugin that should stay blocked.

MozReview-Commit-ID: 4EvIGJ1Ke0Z
2018-04-24 17:46:44 -07:00
Kris Maglione
ad06da8d89 Bug 1454202: Part 5b-c - Remove interstitial callback argument from getInstall* APIs. r=aswan
***
Bug 1454202: Part 5b - Remove interstitial callback argument from getInstall* APIs. r=aswan

MozReview-Commit-ID: ATKWozPZF4d
***
Bug 1454202: Part 5c - Update callers for new getInstall* signature. r=aswan

MozReview-Commit-ID: FWzZ2dxZOGs
2018-04-15 14:22:55 -07:00
Kris Maglione
d3bbf87c83 Bug 1454202: Part 1 - Update legacy callers to use Promise-based AddonManager APIs. r=aswan
***
Bug 1454202: Part 1a - Auto-replace uses of callback-based AddonManager APIs with Promise-based versions. r=aswan

This was done using the following script:

4cd5ae9597/processors/aom-api-generators.jsm

MozReview-Commit-ID: 8hobLz15a66
***
Bug 1454202: Part 1b - Manually fix eslint errors after auto-rewrite. r=aswan

This also deletes an obsolete test whose xpcshell variant was already deleted.

MozReview-Commit-ID: DM9W9Q2SVIE
***
Bug 1454202: Part 1c - Manually fix non-eslint issues after auto-rewrite. r=aswan

MozReview-Commit-ID: DtMscWZuExc
2018-04-14 19:38:18 -07:00
Peter Van der Beken
317400d75b Bug 1448850 - Remove nsIMessageListener and nsIMessageListenerManager. r=bz. 2018-02-16 15:28:31 +01:00
Kris Maglione
39c12beb57 Bug 1445551: Part 5 - Remove add-on path service. r=aswan,mccr8
The path service was created to allow us to track resources that were part of
legacy add-ons, and to map URIs ponting to those resources to add-on IDs, so
that we could apply special behavior to them.

We have better ways to track resources belonging to WebExtensions, so this
code does not benefit them in any significant way.

The only remaining legacy extensions are system add-ons, which we control, and
do not need the path service in order to track.

MozReview-Commit-ID: BKXkcaM7jJx
2018-03-13 20:21:22 -07:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Dave Townsend
ed77ba2c67 Bug 1356292: Switch back to triggering principal checks for add-on install permission checking to allow url bar triggered installs to proceed. r=bz, r=aswan
MozReview-Commit-ID: 4HXgGqSGkN0
2017-04-13 14:58:38 -07:00
Andrew Swan
5868ba8df8 Bug 1323129 part 1: Remove support for installing multiple xpis in InstallTrigger r=rhelmer
MozReview-Commit-ID: 567cHYjbjO4
2017-01-04 10:12:53 -08:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Andrew Swan
b724044c44 Bug 1311180 Switch mozAddonManager to frame message managers r=rhelmer
MozReview-Commit-ID: GbX0VRn4HUF
2016-10-11 16:40:24 -07:00
Andrew Swan
c0e148aa18 Bug 1091924 Fix up InstallTrigger for e10s-multi r=kmag
MozReview-Commit-ID: HmGZvanRhxl
2016-10-13 11:21:24 -07:00
Christoph Kerschbaumer
11504c0800 Bug 1297338 - Use principalToInherit instead of TriggeringPrincipal within AddonManager.js. r=bz,mossop 2016-09-20 08:37:17 +02:00
Andrew Swan
102f73697b Bug 1285899 Manager mozAddonManager AddonListeners per child r=krizsa
MozReview-Commit-ID: 6xRhWuHf6rq
2016-08-03 13:36:47 -07:00
Andrew Swan
44a0b44a21 bug 1287125 Lock down mozAddonManager.install() r=rhelmer
MozReview-Commit-ID: 7wLqVme2Yzi
2016-07-15 11:40:45 -07:00
Carsten "Tomcat" Book
11113a7fa4 Backed out changeset fbf164ef9e70 (bug 1287125) for perma failing in browser_webapi_install.js after merged 2016-07-18 09:06:42 +02:00
Andrew Swan
9687680ae7 bug 1287125 Lock down mozAddonManager.install() r=rhelmer
MozReview-Commit-ID: 7wLqVme2Yzi
2016-07-15 11:40:45 -07:00
Andrew Swan
0148598946 Bug 1279046 Expose onOperationCancelled to a.m.o r=rhelmer
MozReview-Commit-ID: 2QTjGi8tnjT
2016-06-24 10:16:50 -07:00
Andrew Swan
93c8915030 Bug 1268077: expose AddonListener through mozAddonManager r=rhelmer,smaug
MozReview-Commit-ID: Klw4o0qIvCE
2016-05-27 15:43:05 -07:00
Andrew Swan
81aafc796a Bug 1255040 - Implement mozAddonManager.createInstall(). r=rhelmer
MozReview-Commit-ID: JLrhGywROzt
2016-04-18 13:48:12 -07:00
Dave Townsend
5467318915 Bug 1245571: Allow AMO to be able to query details about an add-on. r=rhelmer
This adds a bunch of structure supporting a promise-based API on the
AddonManager object that is exposed to webpages and adds the first example,
getAddonByID.

MozReview-Commit-ID: CCEFl4R1o81
2016-03-10 09:50:07 -08:00
Dave Townsend
32f3dc9d6a Bug 1257246: Update toolkit/mozapps/extensions for eslint 2. r=aswan
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: CRpZy873GP6
2016-04-05 11:32:12 -07:00
Dave Townsend
cbf4f5fcdd Bug 1245916: Turn on no-undef in toolkit/mozapps/extensions. r=rhelmer
Mostly just declaring globals that Cu.imports defines but there are some actual
bugs here that have been fixed as well as one test that just never ran because
of a hidden exception.

MozReview-Commit-ID: J6uIpYp8ANx
2016-02-03 22:48:48 -08:00
Dave Townsend
6146fbb7b2 Backed out changeset 3e5b6df276a9 from bug 1245916 for causing test failures.
MozReview-Commit-ID: CbsTB3xqGC6
2016-02-15 11:36:23 -08:00
Dave Townsend
c661daf87a Bug 1245916: Turn on no-undef in toolkit/mozapps/extensions. r=rhelmer
Mostly just declaring globals that Cu.imports defines but there are some actual
bugs here that have been fixed as well as one test that just never ran because
of a hidden exception.

MozReview-Commit-ID: J6uIpYp8ANx
2016-02-03 22:48:48 -08:00
Sebastian Hengst
797e4d5000 Bug 1239868 - remove unused PREF_EM_UPDATE_INTERVAL. r=Mossop 2016-01-15 13:11:31 +01:00
Dave Townsend
315c15417d Bug 1226386: Remove functions names where possible. r=rhelmer
We used to need explicit names for functions to make stack traces display
properly. The JS engine is smarter now so doesn't need them and they just
make the code messy and redundant.
2015-11-19 16:35:41 -08:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Dave Townsend
4a20a1e68c Bug 1200027: Fix installing add-ons from the AMO discovery pane in the add-ons manager. r=dveditz 2015-08-31 11:23:39 -07:00
Dave Townsend
4618999b6b Bug 1042699: Block cross-origin add-on install requests. r=dveditz 2015-08-18 17:21:05 -07:00
Dave Townsend
a05653e0be Bug 1082764: Use the correct referrer when the content handler catches an XPI install in e10s. r=Unfocused 2014-11-04 23:28:55 -08:00
Dave Townsend
f5d707425c Bug 1084558: Switch the web installer interfaces to use browsers instead of DOM windows. r=Unfocused 2014-11-04 19:20:52 -08:00
Irving Reid
647cd1ac80 Bug 995108 - Disable blocklist and update timers during Addon Manager mochitests. r=mossop 2014-09-02 11:47:11 -04:00
Blake Kaplan
d172b97f15 Bug 952201 - Make installing addons from web content work correctly in e10s. r=bmcbride@mozilla.com 2014-07-18 09:27:29 -07:00
Blair McBride
fed2d4072a Bug 926712 - Use WebIDL to expose InstallTrigger, r=Mossop,bholley 2013-12-12 02:08:00 +00:00
Bill McCloskey
ff36ddc3aa Bug 682048 - Change Firefox frame script handling to support anon/global scope (r=felipe) 2013-11-23 21:32:27 -08:00