Commit Graph

70 Commits

Author SHA1 Message Date
Andrea Marchesini
ce10d5d966 Bug 1468592 - use nsIEffectiveTLDService::hasRootDomain instead of custom hasRootDomain implementations, r=valentin 2018-06-14 04:31:14 -07:00
Jared Wein
b0fc9890f1 Bug 1461477 - Create a CreditCard.jsm to consolidate various credit card handling and validation. r=MattN
MozReview-Commit-ID: 3tJdzU3hBvY
2018-05-15 12:41:35 -04:00
Csoregi Natalia
6a9464cac1 Backed out changeset 9b26de736798 (bug 1461477) for multiple CreditCards failures e.g. browser_manageCreditCardsDialog.js . CLOSED TREE 2018-06-01 21:04:39 +03:00
Jared Wein
d7d5af6823 Bug 1461477 - Create a CreditCard.jsm to consolidate various credit card handling and validation. r=MattN
MozReview-Commit-ID: 3tJdzU3hBvY
2018-05-15 12:41:35 -04:00
Jonathan Kingston
3bbca32c9e Bug 1452666 - Simplify SessionHistory serialization code and test expanded principals are serialized and can restore tabs. r=bz,mikedeboer
MozReview-Commit-ID: EV39wz2TFlj
2018-05-19 14:42:52 +01:00
Jan Henning
03f30dc140 Bug 1456391 - Part 7: Move PrivacyFilter to Toolkit. r=mikedeboer
Since we want to start collecting all form data through mapFrameTree on Fennec,
too, we need to change our filtering strategy for form data.
We can no longer bail out directly during the data collection loop and instead
have to filter the data after having collected all of it.

The easiest way to do that is to start using PrivacyFilter.filterFormData() on
Android as well.

MozReview-Commit-ID: GBos4Zn3l2U
2018-04-25 22:33:50 +02:00
Jan Henning
c3f11a7b98 Bug 1456391 - Part 2: Add mapFrameTree to sessionstore's Utils.jsm. r=mikedeboer
GeckoView has already started using a slightly modified version of mapFrameTree,
and since ssu.forEachNonDynamicChildFrame() has vastly simplified the process of
correctly using FormData/ScrollPosition.collect() for *all* (non-dynamic) child
frames, we want to use mapFrameTree for Fennec's session store as well.

Therefore, to avoid further duplication of code, we add a common version to the
session store's Utils.jsm module.
We base the code on the GeckoView implementation of mapFrameTree, which has
gained the ability to use callback *arrays*, however we still use ssu.forEach-
NonDynamicChildFrame() like Desktop currently does, instead of simply iterating
over *all* frames.

MozReview-Commit-ID: 3ilEgNSeCEv
2018-04-25 22:04:56 +02:00
Adrian Wielgosik
65b770c17d Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement. r=bz
MozReview-Commit-ID: 55aIiNHS0xs
2018-04-18 22:29:50 +02:00
Brian Grinstead
7de04ec3b1 Bug 1456703 - Stop using nsIDOMXULTextBoxElement to detect XUL textboxes r=enndeakin+6102
This is used in JS via instanceof checks, and in C++ only to get the `inputField`
attribute (the actual HTML input or textarea). We can swap out instanceof by checking
the tag name, and we can directly query for the input field from C++.


MozReview-Commit-ID: 7xpHQMYzYhD
2018-04-26 15:15:10 -07:00
Nika Layzell
f614b85fbe Bug 1443379 - Stop pretending cacheKey can be anything other than uint32_t, r=smaug 2018-04-10 17:49:46 -04:00
Nika Layzell
3d4a532d9d Bug 1434768 - Part 3: Rewrite JS consumers of .sessionHistory, r=bz 2018-04-10 17:49:45 -04:00
Mark Banner
0f7796144a Bug 1440761 - Enable no-unused-vars for global scope on jsm files in toolkit/. r=mossop
MozReview-Commit-ID: 7Okqmw5dBcL
2018-02-23 19:25:59 +00:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Cameron McCormack
f221bcdd54 Bug 1435666 - Part 3: Remove nsIDOMXPathResult. r=bz
MozReview-Commit-ID: 9j6dUlanNTi
2018-02-05 11:39:18 +08:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Mike de Boer
939d21b28a Bug 1429490 - Since nsISerializationHelper.serializeToString may throw, catch the error to prevent loss of session data. r=ckerschb
MozReview-Commit-ID: GOAFT4CpVrR
2018-01-18 16:54:29 +01:00
Nika Layzell
5a8e4b47d8 Bug 1383876 - Part 6: Fix eslint failures, a=bustage
MozReview-Commit-ID: 90yfcMlr6UU
2018-01-12 18:40:53 -05:00
Nika Layzell
635711a262 Bug 1383876 - Part 2: Remove GroupedSHistory and Prerendering logic from JS code, r=freesamael
MozReview-Commit-ID: KwvOcgQKheK
2018-01-12 17:52:54 -05:00
Matthew Noorenberghe
1cca5b9035 Bug 1415739 - Use type/autocomplete properties, instead of attributes, to decide whether to save FormData. r=mikedeboer
The property values are already normalized according to the spec.

MozReview-Commit-ID: DbKZf9KXCji
2017-11-22 16:37:40 -05:00
Kyle Machulis
7252caefb4 Bug 1412437 - Remove nsIDOMHTMLTextAreaElement; r=bz
MozReview-Commit-ID: JAON7Rd7IAo
2017-11-01 14:28:22 -07:00
Jan Henning
44c7412b37 Bug 1391421 - Part 4 - Switch Session Store to save the "display" URL. r=mikedeboer
The URL can end up being user-visible for "Recently closed tabs" (certainly on Android, and also when hovering over an entry on Desktop, at least in the old menu bar), so we should use pretty URLs instead of Punycode.

MozReview-Commit-ID: Kil2ChToYa8
2017-09-14 21:29:45 +02:00
Masatoshi Kimura
a9e30eaec8 Bug 1322874 - Get rid of nsIURI.originCharset. r=valentin.gosu
nsIURI.originCharset had two use cases:
 1) Dealing with the spec-incompliant feature of escapes in the hash
    (reference) part of the URL.
 2) For UI display of non-UTF-8 URLs.

For hash part handling, we use the document charset instead. For pretty
display of query strings on legacy-encoded pages, we no longer care to them
(see bug 817374 comment 18).

Also, the URL Standard has no concept of "origin charset". This patch
removes nsIURI.originCharset for reducing complexity and spec compliance.

MozReview-Commit-ID: 3tHd0VCWSqF
2017-08-02 20:43:30 +09:00
Tim Taubert
5c1a30b131 Bug 1373672 - Part 1: Filter events from dynamic docShells in Gecko before they reach SessionStore event handlers r=smaug,mystor 2017-08-02 19:08:04 +02:00
Sebastian Hengst
3073215161 Backed out changeset e62c93a8c93b (bug 1373672) for bustage at nsSessionStoreUtils.cpp:21: bad implicit conversion constructor for 'DynamicFrameEventFilter, and e.g. eslint failures. r=backout on a CLOSED TREE 2017-08-01 12:39:21 +02:00
Tim Taubert
12284f3ab0 Bug 1373672 - Part 1: Filter events from dynamic docShells in Gecko before they reach SessionStore event handlers r=smaug,mystor 2017-07-21 14:57:30 +02:00
Beekill95
1903fd53c7 Bug 1379900 - Doing elements filtering in JS to simplify XPath query in FormData::collect. r=mikedeboer
MozReview-Commit-ID: 7VjSkV8dlq1
2017-07-23 14:41:52 +07:00
Tim Taubert
006da10109 Bug 1382635 - FormDataListener shouldn't listen for change events r=mikedeboer 2017-07-21 10:35:25 +02:00
Rajesh Kathiriya
bfb3762076 Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8
MozReview-Commit-ID: RT5QTipaOW
2017-07-04 21:30:18 +05:30
Beekill95
13c6c16fca Bug 1362330 - Part 1: Move XPath generation to Node's interface and move all remaining XPathGenerator.jsm functions to FormData. r=mikedeboer, r=smaug
MozReview-Commit-ID: Ej45wPeddtQ
2017-06-15 08:49:17 +07:00
Carsten "Tomcat" Book
5459c60a72 Backed out changeset 9342f0d949f1 (bug 1362330) for failures like nsFocusManager.cpp:1166:31: error: member access into incomplete type 'mozilla::dom::nsIContentParent' 2017-07-04 09:53:36 +02:00
Beekill95
1e816124ce Bug 1362330 - Part 1: Move XPath generation to Node's interface and move all remaining XPathGenerator.jsm functions to FormData. r=mikedeboer, r=smaug
MozReview-Commit-ID: Ej45wPeddtQ
2017-06-15 08:49:17 +07:00
Frederik Braun
96b2642639 Bug 1351608 - Disable warnings for existing violations to no-unsanitize rule r=Standard8.
MozReview-Commit-ID: 7cTNL5jMtRw
2017-07-03 20:07:02 +01:00
Honza Bambas
d9b2cc5343 Bug 1319111 - Expose 'result principal URI' on LoadInfo as a source for NS_GetFinalChannelURI (removes some use of LOAD_REPLACE flag). r=bz, r=mikedeboer 2017-05-30 18:07:59 +02:00
Sebastian Hengst
08c10ea013 Backed out changeset a4230d2eab5f (bug 1362330) for failing asan-fuzzing (Bof) job, undeclared identifier TaskCategory at nsContentPolicy.cpp:142. r=backout 2017-06-19 17:43:39 +02:00
Beekill95
9ddba5b4ca Bug 1362330 - Move XPath generation to Node's interface and move all remaining XPathGenerator.jsm functions to FormData. r=smaug, r=mikedeboer
MozReview-Commit-ID: Ej45wPeddtQ
2017-06-15 08:49:17 +07:00
Bob Silverberg
a47fa4932e Bug 1344857 - SessionStore does not return titles for tabs which have a url that is identical to the title, r=mikedeboer
MozReview-Commit-ID: H7dHJo6rOuz
2017-04-11 13:50:24 -04:00
Tim Taubert
a40eda9c9e Bug 1351835 - Update PrivacyLevel.canSave() calls in SessionCookies.jsm r=mikedeboer
The first change we can make is to simplify the PrivacyLevel.canSave() method
itself as it only takes a single argument, `isHTTPS`. Callers shouldn't be
required to pass an object, they should simply pass a boolean.

The second change here is to cleanup SessionCookies.jsm that still passes the
old `isPinned` argument that's no longer needed. We can remove some house
keeping and simplify the cookie collection code.

SessionCookies.getHostsForWindow() that previously returned a map from hostnames
to a site's pinned status (tab.pinned) can now simply return a Set containing
all hostnames found in a window.
2017-03-30 13:57:42 +02:00
Jan Henning
e0c811e6eb Bug 1265818 - Part 3 - Store and restore the LayoutHistoryState through SessionHistoy.jsm. r=mikedeboer
Since a LayoutHistoryState is basically just a collection of PresStates, we just save each PresState we can find and then later restore it.

MozReview-Commit-ID: A6WpdelseHn
2017-03-25 15:32:36 +01:00
Andrew McCreight
fd845f486e Bug 1350469 - Lazily load XPathGenerator.jsm in FormData.jsm. r=mikedeboer
MozReview-Commit-ID: 7Cm7tPYc9dW
2017-03-22 14:01:58 -07:00
Jan Henning
923557a9c5 Bug 1341417 - Using aFromIdx should skip SHEntry serialisation, not just throw the data away afterwards.r=mikedeboer
When calling SessionHistory.collect(), we can indicate that we're not interested in the first N (where N = aFromIdx + 1) session history entries, with N potentially being a very big number if we don't want any SHEntries at all and are just interested in updating the value of the current history index.

Currently, we always serialise all available SHEntries and then throw away the first N entries, which is wasteful - instead, we should just skip them right away.

We still need to keep track how many entries we actually skipped and how many we could have collected if we wanted to, so
- we can correctly clamp data.index
- if we end up with no entries, figure out whether we simply skipped all of them or else need to create a fallback entry.

MozReview-Commit-ID: DjHnnhK0M9L
2017-02-21 21:42:08 +01:00
Christoph Kerschbaumer
61b52d6d49 Bug 1301666 - Remove triggeringPrincipal_b64 from SessionHistory.jsm. r=mikedeboer 2017-03-13 16:47:11 +01:00
Jan Henning
f65d19a68e Bug 1340828 - Part 2 - Make life easier for Fennec. r=mikedeboer
Life would easier if the restore function could return a reference to the session history object retrieved from the DocShell, so that Fennec's main session store code can use that to trigger the needed reload afterwards instead of having to retrieve it again independently.

MozReview-Commit-ID: 1J5k4Evbc8Y
2017-02-18 22:50:58 +01:00
Jan Henning
8352e0a6df Bug 1340828 - Part 1 - Move SessionHistory.jsm to toolkit. r=mikedeboer
We want to use this for Android, too. Once again, moving the file necessitates fixing a few ESLint errors that weren't yet checked for under the old directory.

MozReview-Commit-ID: IPxcizKwzAX
2017-02-18 20:54:09 +01:00
Christoph Kerschbaumer
ecd9d4ed04 Bug 1338009 - Utils#deserializePrincipal should return NullPrincipal if deserialization fails. r=mikedeboer 2017-02-12 11:50:25 +01:00
Jan Henning
9755aa98b0 Bug 1335008 - Part 1 - Move PrivacyLevel.jsm to toolkit. r=mikedeboer
... so we can use it on Android, too. Also fix ESLint errors that are appearing at the new file location.

MozReview-Commit-ID: 3A3aoHm00RJ
2017-01-31 23:05:31 +01:00