Commit Graph

52 Commits

Author SHA1 Message Date
Tom Schuster
842fbd09b9 Bug 1418033 - Make it possible to disable fast find. r=mikedeboer 2018-05-14 21:49:43 +02:00
Gijs Kruitbosch
fe0ce76819 Bug 1450247 - avoid warning spew in browser_findbar.js, r=mikedeboer
MozReview-Commit-ID: DLd4oAKruN1
2018-04-27 17:41:24 +01:00
Gijs Kruitbosch
03c94e56b1 Bug 1371523 - remove find bar sync ipc message, r=mikedeboer
MozReview-Commit-ID: C0VO0U3UJ76
2018-03-21 17:10:40 +00:00
Brindusan Cristian
0c919122c7 Backed out changeset cbf007a7027f (bug 1371523) for browser chrome failures on toolkit/content/tests/browser/browser_findbar.js CLOSED TREE 2018-03-31 01:16:09 +03:00
Gijs Kruitbosch
2a9cd6d415 Bug 1371523 - remove find bar sync ipc message, r=mikedeboer
MozReview-Commit-ID: C0VO0U3UJ76
2018-03-21 17:10:40 +00:00
Boris Zbarsky
b4959a209d Bug 1441241. Reget a KeyboardEvent constructor on each findbar keypress, because the findbar lives across navigations. r=felipe 2018-02-26 17:20:24 -05:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Boris Zbarsky
5f1bab8c2d Bug 1439974. Pass actual keypress events to the finder's keypress method, even in the e10s case. r=felipe
We could also, or in addition, pull the KeyboardEvent thing off the given
docshell in Finder.jsm and not rely on having these constants on the event
object we have.

I did look through the other places I changed in
https://hg.mozilla.org/mozilla-central/rev/b01bd36c3899 and the other ones that
get the constants off events look like they're EventListener instances, so
should have actual events coming via normal event dispatch.
2018-02-22 21:40:58 -05:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Mike de Boer
06dc0c6d3b Bug 1290914 - move the matches count and highlight-all request from the findbar binding to the JS module in the content process, so it's closer to the metal. r=jaws
MozReview-Commit-ID: INYobXmrVj5
2016-09-08 22:38:55 +02:00
Mike de Boer
cde795d884 Bug 1298323 - do not destroy the Finder instance when only a single window closes in e10s mode, because that render the findbar useless. r=jaws
MozReview-Commit-ID: 4kxdba41n8k
2016-08-26 10:07:54 +02:00
Mike de Boer
c9a9a89a4c Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws
MozReview-Commit-ID: 1j0C0BUfT8r
2016-08-19 17:18:41 +02:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Mike de Boer
9e4a7c375b Bug 1280876 - don't take screenshots of pages that have the findbar open. r=jaws,mconley
MozReview-Commit-ID: Dmz0MaukNVq
2016-08-10 11:23:47 +02:00
Carsten "Tomcat" Book
186ae7c42a Merge mozilla-central to fx-team 2016-07-28 17:44:58 +02:00
Mike de Boer
0145f8eec4 Bug 1281421 - Merge the find counter and highlighter iterators into a FinderIterator singleton. r=jaws
MozReview-Commit-ID: 9fhOKWIkOXN
2016-07-28 12:34:13 +02:00
Mike de Boer
1269be4829 Bug 1279684 - make sure that toggling 'Highlight All' also hides the found occurrences from the mask. r=jaws
MozReview-Commit-ID: 2AmSwNgE1if
2016-07-27 16:37:26 +02:00
Mike de Boer
40aa390f52 Bug 269442 - whole word matching support for nsFind. r=ehsan,dao. ui-r=shorlander
MozReview-Commit-ID: KIDWHyjOSYL
2016-06-28 15:13:53 +02:00
Mike de Boer
25acabfa98 Bug 1279717 - inverse the mask to use a white background on pages with bright text color. r=jaws
MozReview-Commit-ID: D2UFsOfMJln
2016-06-22 19:22:07 +02:00
Mike de Boer
f9037c003c Bug 384458 - part 4: implement modal highlighting using the AnonymousContent API and SVG masks. r=jaws 2016-06-09 13:30:49 +02:00
Wes Kocher
6a8a703003 Backed out 6 changesets (bug 384458) for frequent browser_FinderHighlighter.js failures
Backed out changeset ded915ec401f (bug 384458)
Backed out changeset 63ec66da50fa (bug 384458)
Backed out changeset ae71396d3be0 (bug 384458)
Backed out changeset 3b025cbfbe3c (bug 384458)
Backed out changeset 091c5465acf7 (bug 384458)
Backed out changeset 5eabde153def (bug 384458)
2016-06-08 14:53:57 -07:00
Mike de Boer
a40c73ccb2 Bug 384458 - part 4: implement modal highlighting using the AnonymousContent API and SVG masks. r=jaws 2016-06-08 19:54:10 +02:00
Jared Wein
aad3a7a7eb Bug 1259531 - [e10s] Fix test_bug451286.xul to run in e10s by converting to a mochitest-browser test. r=mikedeboer
MozReview-Commit-ID: 6Rt0dM6md06
2016-03-31 20:41:00 -04:00
Blake Kaplan
044aeb6502 Bug 1174036 - Handle dynamically-removed textareas gracefully. r=mikedeboer r=ehsan
Also, flush layout when starting a find in order to avoid racing with
textarea-hiding notifications and maintain JS type correctness when objects
are passed over IPC.
2016-03-28 11:12:31 -07:00
Mike de Boer
273d8d8cab Bug 1253233: refactor bug263683_window.xul to run the test on remote browsers as well. r=felipe 2016-03-25 15:26:14 +01:00
Carsten "Tomcat" Book
396196aad3 Backed out changeset f6c028e4f604 (bug 1253233) for test failures in test_bug263683.xul 2016-03-23 09:09:40 +01:00
Mike de Boer
2f2ee5e1af Bug 1253233 - Refactor bug263683_window.xul to run the test on remote browsers as well. r=felipe 2016-03-11 19:27:20 +01:00
Simon Lindholm
38e99d7d6d Bug 1174291 - Fix ctrl-return for e10s findbar. r=evilpie 2015-06-12 13:07:00 -04:00
Simon Lindholm
567174920b Bug 1174289 - Remove fake focus-ring after e10s findbar is closed. r=evilpie 2015-06-12 13:09:00 -04:00
Felipe Gomes
b2e5d38de4 Bug 1079665 - follow up, remove accidental line included from different patch. r=me 2015-03-30 18:38:18 -03:00
Felipe Gomes
93bc8a0cd2 Bug 1079665 - [e10s] Findbar focusContent doesn't work when a link was found. r=enndeakin 2015-03-24 18:58:32 -03:00
Dave Townsend
7fa05a5ed4 Bug 1087966: Fix tab detach in e10s windows. r=mconley
When swapping docshells we also have to swap any properties on remote-browsers
that are cached from the content process. This includes things like the
remoteWebNavigation etc. which in turn cache content information. Some of
these also maintain message listeners that we have to switch to the new browser
and message manager.
2015-02-18 16:47:43 -08:00
Blake Kaplan
72625fcc5b Bug 1055508 - Make the findbar respect the search clipboard as well as prefillwithselection in e10s. r=mikedeboer 2015-01-16 15:11:00 +01:00
Mike Conley
9b4a1b2b0b Bug 927424 - Allow findbar binding to cancel content focusing when using RemoteFinder in an e10s window. r=evilpie. 2014-09-04 15:17:47 -04:00
Alexandru Tifrea
9795bce6b1 Bug 1004515 - Add support for the find counter in RemoteFinder. r=mikedeboer 2014-07-09 16:27:37 -07:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Matt Brubeck
8814bc75e9 Bug 958101 - Pass named params to onFindResult as object properties [r=evilpie] 2014-01-13 17:58:33 -08:00
Matt Brubeck
2ccaad4518 Bug 916481 - Make Finder.jsm send back the selection rect of the find result [r=evilpie,emtwo] 2014-01-09 07:58:26 -08:00
Mike de Boer
5c98564425 Bug 921308: don't scroll when an element is focused on findbar close. r=evilpie 2013-10-16 17:04:49 +02:00