Commit Graph

47 Commits

Author SHA1 Message Date
Jim Chen
128ab3a796 Bug 1452200 - 1b. Add template literal support to Log.jsm; r=markh
Make Log.jsm functions support tagged template literals. For example,
instead of |logger.debug("foo " + bar)| or |logger.debug(`foo ${bar}`)|,
you can now use |logger.debug `foo ${bar}`| (without parentheses).

Using tagged template literals has the benefit of less verbosity
compared to regular string concatenation, with the added benefit of
lazily-stringified parameters -- the parameters are only stringified
when logging is enabled, possibly saving from an expensive stringify
operation.

This patch also fixes a bug in BasicFormatter where consecutive tokens
are not formatted correctly (e.g. "${a}${b}").

MozReview-Commit-ID: 9kjLvpZF5ch
2018-04-15 14:53:28 -04:00
Jim Chen
755d8d7b61 Bug 1452200 - 1a. Add AndroidAppender for Log.jsm; r=markh
Add an AndroidAppender that lets Log.jsm output to the Android logs,
using AndroidLog.jsm. Because the Android logging system keeps track of
the log metadata (time/level/name) separately from the log message, the
patch also adds a separate AndroidFormatter that does not prepend the
metadata to the log message itself.

MozReview-Commit-ID: C9oBbgVQOEc
2018-04-15 14:53:28 -04:00
Gurzau Raul
c14de517e5 Backed out 5 changesets (bug 1452200) for mochitest-chrome failures on Android on a CLOSED TREE
Backed out changeset ed07fb947b5e (bug 1452200)
Backed out changeset b03e9dc6ecd7 (bug 1452200)
Backed out changeset e4cdad2cd3d2 (bug 1452200)
Backed out changeset 8ac249bdc772 (bug 1452200)
Backed out changeset 225bb7ed5f71 (bug 1452200)
2018-04-15 09:19:04 +03:00
Jim Chen
480c2c48b7 Bug 1452200 - 1b. Add template literal support to Log.jsm; r=markh
Make Log.jsm functions support tagged template literals. For example,
instead of |logger.debug("foo " + bar)| or |logger.debug(`foo ${bar}`)|,
you can now use |logger.debug `foo ${bar}`| (without parentheses).

Using tagged template literals has the benefit of less verbosity
compared to regular string concatenation, with the added benefit of
lazily-stringified parameters -- the parameters are only stringified
when logging is enabled, possibly saving from an expensive stringify
operation.

This patch also fixes a bug in BasicFormatter where consecutive tokens
are not formatted correctly (e.g. "${a}${b}").

MozReview-Commit-ID: 9kjLvpZF5ch
2018-04-15 00:15:26 -04:00
Jim Chen
f0b56044a3 Bug 1452200 - 1a. Add AndroidAppender for Log.jsm; r=markh
Add an AndroidAppender that lets Log.jsm output to the Android logs,
using AndroidLog.jsm. Because the Android logging system keeps track of
the log metadata (time/level/name) separately from the log message, the
patch also adds a separate AndroidFormatter that does not prepend the
metadata to the log message itself.

MozReview-Commit-ID: C9oBbgVQOEc
2018-04-15 00:15:26 -04:00
Kris Maglione
d64851a5fe Bug 1439181: Stop mangling stack traces in AOM errors. r=aswan
MozReview-Commit-ID: 6Nh4hwwvrWb
2018-02-17 19:27:01 -08:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Mark Hammond
81ca03c226 Bug 1425987 - part 1: Add support to Log.jsm for managing log levels via prefs. r=Gijs
MozReview-Commit-ID: 6xLSnb0etnl
2017-12-18 17:48:41 +11:00
Mark Banner
62d89b0f75 Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop
MozReview-Commit-ID: 8eEhjFZc4mT
2017-11-09 16:36:57 +00:00
Andreea Pavel
4d905c03dd Backed out 1 changesets (bug 1417940) for failing browser-chrome browser/components/contextualidentity/test/browser/browser_aboutURLs.js r=backout on a CLOSED TREE
Backed out changeset 2c2f807e23b5 (bug 1417940)
2017-11-17 18:08:45 +02:00
Mark Banner
0841e15072 Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop
MozReview-Commit-ID: 8eEhjFZc4mT
2017-11-09 16:36:57 +00:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Florian Quèze
166b62b012 Bug 1374282 - ban Task.jsm during startup, r=Mossop, a=sheriffduty 2017-06-22 12:51:43 +02:00
Masatoshi Kimura
5754eb0ecf Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init(). r=hsivonen
MozReview-Commit-ID: GliLHLsUWjt
2017-06-17 19:30:09 +09:00
Florian Quèze
50b8c6608d Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Mark Banner
d07f540195 Bug 1328338 - Fix more no-undef eslint issues in toolkit/ and browser/. r=mossop
MozReview-Commit-ID: 78dXLYVW1gC
2017-01-03 11:55:24 +00:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Dave Townsend
769fc8f245 Bug 1257246: Update toolkit for eslint 2. r=Gijs
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: KHYdAkRvhVr
2016-04-05 11:33:48 -07:00
Dave Townsend
a215a4a95a Bug 1245649: Turn on no-extra-semi. r=markh 2016-02-03 17:27:36 -08:00
Dave Townsend
7b18d60eed Bug 1229519: Fix toolkit/modules to pass eslint checks. r=mak 2015-12-03 09:58:56 -08:00
Tooru Fujisawa
e1e42ff6d3 Bug 1207497 - Part 1: Remove use of expression closure from toolkit/, exept tests. r=Gijs 2015-09-24 21:20:04 +09:00
Ravi Shankar
ea12dad851 Bug 1109608 - Log.stackTrace should use human-readable task stack traces if available. r=Yoric 2015-03-11 03:21:00 -04:00
Matthew Noorenberghe
c781daf498 Bug 1072014 - Log.jsm: Allow logging of falsy arguments. r=Unfocused 2014-09-23 21:38:43 -07:00
Matthew Noorenberghe
71bb410823 Bug 1071870 - Log.jsm: Fix support for Log.Level.All in some services/ modules. r=markh 2014-09-23 21:38:34 -07:00
Benjamin Smedberg
51e7e224dc Bug 1053836 - Fix subclassing of prefix loggers by only overriding the log() method, not all the other methods. This fixes this resolution in the Experiment log override, r=gps 2014-08-14 16:30:54 -04:00
Chris Manchester
d5b81c43c5 Bug 997364 - Make fileAppender chain promises on file creation.; r=irving 2014-05-16 19:45:04 -04:00
Irving Reid
96d0b944ed Bug 966674: #3 Add parameter substitution in log messages; r=gps,rnewman 2014-04-29 10:09:29 -04:00
Irving Reid
18e0ec4463 Bug 966674: #2 Move exceptionStr() and stackTrace() from utils.js to Log.jsm; r=gps,rnewman 2014-04-29 10:09:27 -04:00
Irving Reid
7f3b4f5e14 Bug 966674: #1 Clean up a couple of ReferenceErrors; r=gps 2014-04-29 10:09:25 -04:00
Gregory Szorc
6910002d9a Bug 989137 - Part 3: Log.jsm API to get a Logger that prefixes messages; r=bsmedberg
A common pattern for logging is to have multiple loggers for multiple
underlying object instances. You often want to have each instance attach
some identifying metdata contained in each logged message. This patch
provides an API to facilitate that.
2014-03-28 11:36:37 -07:00
Mark Hammond
7aa44cb7b6 Bug 975944 - fix log appenders' ._name property. r=unfocused 2014-02-25 09:31:41 +11:00
Blair McBride
04d5b1fd1e Bug 451283 - Move log4moz.js to Toolkit as Log.jsm. r=gps,Mossop 2013-08-26 11:55:58 -07:00