Commit Graph

85 Commits

Author SHA1 Message Date
Adrian Wielgosik
65b770c17d Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement. r=bz
MozReview-Commit-ID: 55aIiNHS0xs
2018-04-18 22:29:50 +02:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Kris Maglione
b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
5298bb7ac5 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
5e845929cf Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
3aa3c6fff8 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Edouard Oger
d341d6e1de Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
MozReview-Commit-ID: Je0rV277d7
2017-09-22 15:19:56 -04:00
Sebastian Hengst
46db05e661 Backed out changeset 553d26ab8ee8 (bug 1395427) 2017-09-27 17:10:26 +02:00
Edouard Oger
aefbf9f5b9 Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
MozReview-Commit-ID: Je0rV277d7
2017-09-22 15:19:56 -04:00
Jonathan Guillotte-Blouin
246e1d8e72 Bug 1372427 - enforce "comma-dangle". r=MattN
auto --fix

MozReview-Commit-ID: KKmDI0Pt43K
2017-06-14 17:46:42 -07:00
Jonathan Guillotte-Blouin
ddb9887bc4 Bug 1372427 - limit lines to a maximum of 100 chars. r=MattN
MozReview-Commit-ID: 3OSKaTMMBot
2017-06-13 16:48:31 -07:00
Jonathan Guillotte-Blouin
29b30a4a82 Bug 1372427 - add js-doc rule. r=MattN
MozReview-Commit-ID: YgDBHM88PW
2017-06-13 10:48:52 -07:00
Jonathan Guillotte-Blouin
4aee0d02d2 Bug 1372427 - add semi-colon rule. r=MattN
auto --fix

MozReview-Commit-ID: F9GvxcghPkt
2017-06-13 09:51:07 -07:00
Jonathan Guillotte-Blouin
10ee9a5b3d Bug 1372427 - Add indentation rules. r=MattN
MozReview-Commit-ID: 62a7RvVlcco
2017-06-12 15:45:00 -07:00
Jonathan Guillotte-Blouin
b956a19bfb Bug 1374427 - remove redundant function names in js-doc. r=MattN
MozReview-Commit-ID: 3EBT7CDl3pC
2017-06-19 14:11:21 -07:00
Jonathan Guillotte-Blouin
22f6792fc0 Bug 1371554 - Change .indexOf(...) == 0 to the more expressive .startsWith(...). r=mattn.
MozReview-Commit-ID: Jr3ALp6v2rM
2017-06-06 13:35:34 -07:00
Jonathan Guillotte-Blouin
15fcc06e43 Bug 1365068 - import with destructuring, switch to shorthand function declarations and use array.includes. r=MattN
MozReview-Commit-ID: IfmePvN8WnA
2017-05-16 18:23:56 -07:00
Jonathan Guillotte-Blouin
735cd256be Bug 1365068 - normalize indentation to 2 spaces. r=MattN
MozReview-Commit-ID: LeooMk6DVMl
2017-05-16 17:15:02 -07:00
Jonathan Guillotte-Blouin
e813613649 Bug 1365068 - Added missing brackets & refactored some conditional statements. r=MattN
MozReview-Commit-ID: 1eOkjI06RCJ
2017-05-16 15:56:28 -07:00
Jonathan Guillotte-Blouin
d39357141f Bug 1363184 - Remove unused Deprecated.jsm import from nsFormAutoComplete.js. r=MattN
MozReview-Commit-ID: 1uCS8gfm5Oi
2017-05-08 15:34:16 -07:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Florian Quèze
c8cf49999e Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Mike Conley
f18abaf5de Bug 1311189 - Put back the separator between form history and datalist entries in the autocomplete popup. r=MattN
MozReview-Commit-ID: 2lRauTr9EQA
2016-10-19 13:55:06 -04:00
Wes Kocher
de96358cdd Backed out changeset 2849f953881f (bug 1311189) for mochitest-5 failures a=backout 2016-10-24 16:49:55 -07:00
Mike Conley
de05381b2f Bug 1311189 - Put back the separator between form history and datalist entries in the autocomplete popup. r=MattN
MozReview-Commit-ID: 2lRauTr9EQA
2016-10-19 13:55:06 -04:00
Mike Conley
515277b6c7 Bug 1294502 - Combine e10s and non-e10s nsFormAutoComplete implementations. r=MattN
MozReview-Commit-ID: 46jM5Q3AfRa
2016-08-11 15:36:22 -04:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Jared Wein
ebf1ccbe46 Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh
2016-08-03 18:54:59 -04:00
Marco Bonardo
adef8ce5ae Bug 1252074 - test_form_autocomplete.html and test_form_autocomplete_with_list.html should pass on e10s. r=paolo
MozReview-Commit-ID: CISKztr4p4N
2016-03-02 14:34:38 +01:00
Blake Kaplan
b1f89ee9a7 Bug 1242208 - Fix cached form history results with a datalist present. r=MattN 2016-02-02 13:44:11 -08:00
Dave Townsend
9743844d60 Bug 1229519: Fix toolkit/components/satchel to pass eslint checks. r=dolske 2015-12-03 10:01:41 -08:00
Marco Bonardo
6c190ee363 Bug 720589 - mMatchCounts may be accessed with a nonexisting index. r=neil 2015-11-10 20:18:24 +01:00
Tooru Fujisawa
2bf22fe47e Bug 1217082 - Remove for-each from toolkit/. r=Gijs 2015-10-19 04:57:14 +09:00
Tooru Fujisawa
afbd2956bc Bug 1207498 - Part 1: Remove use of expression closure from toolkit/components/, except tests. r=Gijs 2015-09-24 20:32:23 +09:00
Tooru Fujisawa
3d13712ac2 Backed out changeset 036615ba3257 (bug 1207498) for Linux pgo M(oth) failure 2015-09-27 23:42:50 +09:00
Tooru Fujisawa
f2efd2a948 Bug 1207498 - Part 1: Remove use of expression closure from toolkit/components/, except tests. r=Gijs 2015-09-24 20:32:23 +09:00
Blake Kaplan
45df5a4846 Bug 1180827 - Fix reuse of previous search results. r=MattN 2015-07-16 13:34:40 -07:00
Blake Kaplan
96716ef1e1 Bug 1162329 - Implement autocompletion entry deletion for e10s. r=felipe 2015-05-28 09:55:47 -07:00