Commit Graph

73 Commits

Author SHA1 Message Date
Boris Zbarsky
9a1a04e3f8 Bug 1453487 part 2. Remove useless implements="nsIDOMEventListener" from XBL bindings. r=smaug
MozReview-Commit-ID: 4OjGuYkpXMM
2018-04-12 00:05:49 -04:00
Mark Banner
6ab28d012c Bug 1436389 - Switch xbl related files to a different method for determining their environment. r=mossop
MozReview-Commit-ID: JLqFrKZykw
2018-02-07 16:02:25 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
5298bb7ac5 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
5e845929cf Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
3aa3c6fff8 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
gorovoja
ef7a044631 Bug 1416875 - Renamed prompt IDs from the form of info.body to InfoBody so they won't need escaping. r=jaws 2017-11-17 13:59:30 -05:00
dluca
d2121b7fb1 Backed out 1 changesets (bug 1413522) for failing a11y on OS X accessible/tests/mochitest/relations/test_ui_modalprompt.html r=backout on a CLOSED TREE.
Backed out changeset a74c645411e7 (bug 1413522)
2017-11-09 19:02:26 +02:00
Jared Wein
cd80086506 Bug 1413522 - Use HiDPI icons on Windows for the toolkit warning and question icons, and lower the size of the icons on OSX so the HiDPI versions are not shown blurry. r=nhnt11
MozReview-Commit-ID: 8u3zxE9HiSx
2017-11-02 12:11:42 -04:00
Kris Maglione
81d6b6f832 Bug 1375490: Part 1 - Correctly support alerts in OOP popups. r=mixedpuppy
MozReview-Commit-ID: KgqAKMLmuTI
2017-08-02 12:49:25 -07:00
Sebastian Hengst
c4ad0ce869 Backed out changeset c0ab60d3c1f8 (bug 1375490) for failing browser_ext_popup_corners.js on OSX and Windows. r=backout on a CLOSED TREE 2017-08-02 13:12:55 +02:00
Kris Maglione
23871a6c13 Bug 1375490: Part 1 - Correctly support alerts in OOP popups. r=mixedpuppy
MozReview-Commit-ID: KgqAKMLmuTI
2017-08-01 15:28:25 -07:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Sebastian Hengst
4cd95d4a02 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Florian Queze
35cd8ba883 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Mark Banner
358fce1e31 Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop
MozReview-Commit-ID: FTDV8BcMGeF
2017-03-01 21:29:52 +00:00
Mark Banner
703aa9e231 Bug 1341029 - Turn on the ESLint no-undef rule for all of toolkit/. r=jaws
MozReview-Commit-ID: Ed9FfkskDos
2017-02-20 11:45:58 +00:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Mark Banner
8ddd9bb511 Bug 1315951 - Fix no-unused-vars issues in toolkit/components (except places). r=mossop
MozReview-Commit-ID: 8svkCKZHxsq
2016-11-08 12:49:32 +00:00
Boris Zbarsky
d01d82f8ef Bug 1167575. Ensure that we don't exit modal state while we're still waiting on a Gecko runnable in the event-loop-spinning code in nsPrompter.js. r=dolske
If we synchronously shut down the prompt, that will exit modal state while we're
still processing our mouse or key event, which happens _before_ Gecko runnable
processing.  Exiting modal state will generally post a runnable to run timeouts,
so we can end up processing that runnable before we return from processNextEvent
and unwind to whatever code did the alert() call on the web page.  The upshot is
that the webpage will see timeouts fire before the alert() call returns.

If we exit modal state off a Gecko runnable instead, that will ensure that we
return to the nsPrompter code immediately after exiting modal state, see that
the prompt is no longer active, and return to the calling web page code _before_
processing any more runnables.
2016-09-01 21:31:22 -04:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Jared Wein
81846147fc Bug 622939 - Clicking anywhere on a tab-modal prompt should focus it. r=Gijs
MozReview-Commit-ID: JziZBlLQZiI
2016-07-14 14:24:24 -04:00
Xidorn Quan
6101508a87 Bug 1141895 part 2 - Use unprefixed unicode-bidi values in internal code. r=jfkthame
MozReview-Commit-ID: 1o2NEe8eiSX
2016-06-30 16:25:31 +10:00
Dragana Damjanovic
6e72a11bb8 Bug 1230462 - Change the authentiation dialog message. r=mayhemer,dolske,margaret,tanvi 2016-06-06 01:06:00 +02:00
Carsten "Tomcat" Book
529f945807 Backed out changeset 490d3460a197 (bug 1230462) for test failures in test_modal_prompts.html 2016-06-05 11:26:57 +02:00
Dragana Damjanovic
570b31b4cc Bug 1230462 - Change the authentiation dialog message. r=mayhemer,dolske,margaret,tanvi 2016-06-03 09:09:00 +02:00
Justin Dolske
b555ebe7b3 Bug 1265194 - use the hidden attribute in commonDialog.xul for consistency with tabPrompts.xml. r=adw 2016-04-24 11:01:01 -07:00
Makoto Kato
b7a5f6178a Bug 1250772 - Remove softkb-change observer listener. r=mossop
MozReview-Commit-ID: 2PkpjTSVSsM
2016-02-24 12:52:38 +09:00
Dave Townsend
2fb8689242 Bug 1231828: Fix JS parsing errors in toolkit and browser XBL files. r=felipe 2015-12-10 16:53:46 -05:00
Gijs Kruitbosch
9118a83203 Bug 332195 - part 2: allow the user to control this behaviour with a checkbox, r=mconley 2015-10-13 11:06:01 +01:00
Carsten "Tomcat" Book
036e6d2fa3 Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
12369728f5 Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)
2015-10-07 12:13:45 +02:00
Shu-yu Guo
474f49adb7 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Alex Bardas
034692ff5a Bug 1068660 - Add confirmation dialog to unblock downloads. r=Paolo r=MattN 2014-10-14 11:19:00 +02:00
Blake Kaplan
71d2278a2e Bug 899648 - Initial patch to make tab-modal prompts work. Original patch from Tom Schuster <evilpies@gmail.com>. r=dolske 2014-04-04 14:50:42 -07:00
Masayuki Nakano
a3ff9acf01 Bug 969247 part.1 Remove or replace DOM_VK_ENTER and NS_VK_ENTER users r=smaug 2014-02-15 09:57:39 +09:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Simon Montagu
ba6078722c Give the text in prompts unicode-bidi: isolate. Bug 652550, r=dolske 2011-12-28 10:33:18 +02:00
Jan Bambach
20f151a4d1 Bug 707677 - Use defaultPrevented instead of the deprecated getPreventDefault() in front-end code. r=dao 2011-12-08 10:21:32 +01:00
Dão Gottwald
bdd5ba2e8e Bug 686469 - Tab-modal alert can overflow the browser window. r=dolske 2011-10-01 21:40:36 +02:00
Mihai Sucan
b05e45b3ba Bug 625187 - Alert origin is no longer shown for third-party iframes.
r+a=dolske
2011-02-22 13:04:56 +01:00
Neil Rashbrook
e4aef85dfc Bug 625814 - commonDialog icon and text are now differently misaligned. ui-r=faaborg, r=dolske, a=dolske 2011-02-11 20:24:08 -08:00