Commit Graph

6 Commits

Author SHA1 Message Date
Bob Owen
11408aa983 Bug 1441598: Don't try and send messages to PrintProgressDialogChild when printing is complete. r=jwatt 2018-03-05 08:22:14 +00:00
Nathan Froyd
d763323722 Bug 1437604 - remove NS_INTERFACE_MAP_END_THREADSAFE; r=mystor
This macro is identical to NS_INTERFACE_MAP_END and encourages the
reader to think that there's something extra-special threadsafe about QI
implementations that use the macro, when in reality there's nothing of
the sort.
2018-02-12 14:36:46 -05:00
Jonathan Watt
b0ae6c3904 Bug 1432203 - Remove nsIPrintStatusFeedback. r=bobowen
MozReview-Commit-ID: 32RoyQ6GPEP
2018-01-15 11:42:15 +00:00
Mantaroh Yoshinaga
f7061507e4 Bug 1409971 - Part 2. Notify cancelling print job when cancel button pushed. r=mconley
This patch will use existing nsIObserver, and distinguish each message by using
parameter character.

MozReview-Commit-ID: GAhPl7n9wmS
2017-11-15 16:29:49 +09:00
Mantaroh Yoshinaga
270a294672 Bug 1409972 - Part 3. Merge windows printingui. r=mconley
This patch will merge windows printingui implementation to common code.
Primary differences are:
 * Use nsCOMPtr on nsPIDOMWindowOuter.
 * Return NS_ERROR_FAILURE if nsPrintingPromptService doesn't have the
   nsPrintProgress member when calling ShowProgress().
   This is the unexpected case.

Original windows implementation has following difference, but this patch will
not copy it:
 * Windows has own NS_IMPL_ADDREF / NS_IMPL_RELEASE implementation, however this
   implementation isn't different from XPCOM implementation. Bug 156318
   doesn't show this reason.
 * Windows implementation lacks some function parameter checks.
   But unixshared code covers these checks.
 * Windows implementation doesn't have the nsIPrintSettings member into
   nsPrintProgress, but this is necessary in order to make printing cancelable.

MozReview-Commit-ID: 8ja40rAaXBo
2017-11-10 10:58:10 +09:00
Mantaroh Yoshinaga
57fb902b8a Bug 1409972 - Part 2. Copy printingui implementation from unixshared. r=mconley
This patch will copy printingui implementation from unixshared in order to merge
other platform implementation.
This unixshared implementation has much common code hence using unixshared code
is reasonable for merging.

MozReview-Commit-ID: 4VManmNcbdc
2017-11-10 10:55:48 +09:00