Commit Graph

133 Commits

Author SHA1 Message Date
Brian Grinstead
a1722b0480 Bug 1450813 - Create print preview toolbar as customized built-in Custom Element;r=mconley,timdream
MozReview-Commit-ID: LYlQ8xxJNA8
2018-07-02 13:33:09 -07:00
Ciure Andrei
df7f0abc2c Backed out 1 changesets (bug 1450813) for failing browser_page_change_print_original.js CLOSED TREE
Backed out changeset ee4e2bfffe18 (bug 1450813)
2018-07-02 22:38:18 +03:00
Brian Grinstead
4ec2ed9eea Bug 1450813 - Create print preview toolbar as customized built-in Custom Element;r=mconley,timdream
MozReview-Commit-ID: Ermed741SRs
2018-07-02 10:28:29 -07:00
Kris Maglione
582a21b473 Bug 1456035: Part 5 - Convert manual QueryInterface to ChromeUtils.generateQI. r=mccr8
Manually-implemented QueryInterface functions don't benefit from the
MozQueryInterface optimizaions, and a lot of them are in hot code, and
implement a large number of interfaces.

MozReview-Commit-ID: 8OzglraowZt
2018-04-23 12:58:34 -07:00
Bob Owen
11408aa983 Bug 1441598: Don't try and send messages to PrintProgressDialogChild when printing is complete. r=jwatt 2018-03-05 08:22:14 +00:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Bob Owen
9763fc476b Bug 1379117 Part 2: Remove some deprecated PrintUtils functions. r=jwatt
I noticed these while looking for other things that were gettting an
nsIWebBrowserPrint for print preview. I think these must have been left for
legacy addons and they don't seem to be used, so I think they can go.
2018-02-08 08:59:20 +00:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
arai
88bf226136 Bug 1265174 - do not restore "onclose" attribute to null value in print preview window, when there was none at the start. r=smaug 2018-01-13 10:16:00 +02:00
Matheus Longaray
f16e229829 Bug 1404176 - Remove aborted print preview browser before bailing out. r=mconley
This patch clears out set of print preview browsers before bailing out when
there is an error while putting the document into print preview mode.

MozReview-Commit-ID: 20cm4DCktQk
2017-11-13 17:17:57 +01:00
Mark Banner
6c1c2e7910 Bug 1412893 - Change instances of using getService to Services.jsm where possible in toolkit/components/printing. r=mossop
MozReview-Commit-ID: 6g26rPnSN1r
2017-10-30 17:08:42 +00:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Bob Owen
150bf4bc53 Bug 1365601 Part 2: Disable parts of the Print Preview toolbar until update has finished. r=mconley 2017-07-11 07:38:36 +01:00
Bob Owen
460591326e Bug 1365601 Part 1: Send number of pages on printPreviewUpdate event instead of requesting from parent. r=mconley
This also makes sure that we don't call nsIWebBrowserPrint::PrintPreview while we're still in a previous call.
2017-07-05 18:12:36 +01:00
Sebastian Hengst
0c4e35a93d Backed out changeset 7fbe19a6f88e (bug 1365601) as requested by bobowen for c3 failures. r=backout 2017-07-05 20:24:26 +02:00
Sebastian Hengst
555805a7f7 Backed out changeset 6035f7b2a12c (bug 1365601) 2017-07-05 20:23:26 +02:00
Bob Owen
500b138887 Bug 1365601 Part 2: Disable parts of the Print Preview toolbar until update has finished. r=mconley 2017-07-05 18:12:36 +01:00
Bob Owen
d6af319194 Bug 1365601 Part 1: Send number of pages on printPreviewUpdate event instead of requesting from parent. r=mconley
This also makes sure that we don't call nsIWebBrowserPrint::PrintPreview while we're still in a previous call.
2017-07-05 18:12:36 +01:00
Mike Conley
ff2c04ca20 Bug 1308820 - Make sure to close the print progress dialog if print preview is exited. r=Gijs
MozReview-Commit-ID: 391bf9J2Qcf
2017-05-01 12:53:31 -04:00
Matheus Longaray
4ec53dad9d Bug 1332386 - Create extra print preview browser when using Simplify Page option. r=mconley
This patch creates a new print preview browser to host the simplified cloned-document
when Simplify Page option is used on preview. Also, this patch keeps track of what browser
should be presented, based on whether the 'Simplify page' checkbox is checked.

MozReview-Commit-ID: FZSRUyC49Wk
2017-05-01 17:30:48 +02:00
Sebastian Hengst
0babf8240b Backed out changeset 99fd6973d18e (bug 1332386) for frequently failing browser_tabSwitchPrintPreview.js on Linux x64 opt-ish builds. r=backout a=backout
MozReview-Commit-ID: 7oyiuBSTGtI
2017-04-29 20:47:54 +02:00
Matheus Longaray
eb9806754f Bug 1332386 - Create extra print preview browser when using Simplify Page option. r=mconley
This patch creates a new print preview browser to host the simplified cloned-document
when Simplify Page option is used on preview. Also, this patch keeps track of what browser
should be presented, based on whether the 'Simplify page' checkbox is checked.

MozReview-Commit-ID: FZSRUyC49Wk
2017-04-20 14:04:03 +02:00
Wes Kocher
ebd9dfc0cc Backed out changeset 6404057679f4 (bug 1332386) for frequent failures in browser_preview_switch_print_selected.js a=backout 2017-04-18 16:21:58 -07:00
Matheus Longaray
880c302111 Bug 1332386 - Create extra print preview browser when using Simplify Page option. r=mconley
This patch creates a new print preview browser to host the simplified cloned-document
when Simplify Page option is used on preview. Also, this patch keeps track of what browser
should be presented, based on whether the 'Simplify page' checkbox is checked.

MozReview-Commit-ID: 77pLXhdbpPp
2017-04-18 22:21:10 +02:00
Frank-Rainer Grahl
18032d54c1 Bug 1353439 - Cc and Ci are not defined in printUtils.js so use Components full names. r=jhector 2017-04-05 03:08:00 -04:00
Mark Banner
358fce1e31 Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop
MozReview-Commit-ID: FTDV8BcMGeF
2017-03-01 21:29:52 +00:00
Bob Owen
c6c9392bfc Bug 1141756 Part 2: Correct removal of Printing:Preview:Entered message listener. r=mconley 2017-03-01 12:12:02 +00:00
Mark Banner
703aa9e231 Bug 1341029 - Turn on the ESLint no-undef rule for all of toolkit/. r=jaws
MozReview-Commit-ID: Ed9FfkskDos
2017-02-20 11:45:58 +00:00
Julian Hector
9ab6d70fef Bug 1329216 - Pass default printer name to child. r=mconley 2017-02-13 13:07:44 +01:00
Gijs Kruitbosch
81df4758f5 Bug 1329220 - fix print preview source browser confusion, r=mconley
Restore overwriting of this._sourceBrowser as it was before bug 1308621
to ensure we continue to use the same DOM to do print previewing (and
eventually printing).

Bug 1308621 already changed the enterPrintPreview code to rely on the
member _sourceBrowser variable, which will be updated to point to the
print preview browser if/when print preview is being reinitialized for
the same page (because one of the print settings changes). We need to
do this to avoid re-initializing off the original browser, which may
now have navigated or be displaying something else entirely.

This also updates the 'simplified' mode code to rely on the extant
_originalURL member to avoid displaying the page URL as about:blank
after a settings change.

MozReview-Commit-ID: DZ1kT7Mb0mS
2017-01-09 22:04:05 +00:00
Florian Quèze
99b1694fdb Bug 1330464 - make the no-useless-parameters eslint rule detect misuses of the Services.prefs APIs, r=jaws. 2017-01-13 20:21:55 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Mark Banner
fb8a196639 Bug 1325623 - Fix most no-undef eslint issues in toolkit/components. r=mossop
MozReview-Commit-ID: DYJa1uNVagw
2016-12-23 16:00:46 +00:00
Gijs Kruitbosch
50ea118ebc Bug 1322414 - part 2,3,4: use a separate 'primary' attribute for primary child browsers, r=bz,mconley
MozReview-Commit-ID: 2yb0WGFYBsH
2016-12-09 09:23:24 -10:00
Boris Zbarsky
e431114f7d Bug 1310796 part 4. Get rid of 'content-targetable' values for the 'type' attribute everywhere except tabbrowser.xml. Just use 'content' instead. r=gijs 2016-12-08 16:41:45 -10:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Wes Kocher
c92af64732 Merge m-c to inbound, a=merge CLOSED TREE 2016-11-04 15:19:49 -07:00
Dave Townsend
dc3810c548 Bug 1314343: Turn on no-unreachable in eslint. r=standard8
Unreachable code can be a sign of a mistake so we should turn this rule on.

MozReview-Commit-ID: LQphsNL7HBX
2016-11-01 10:58:35 -07:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Matheus Longaray
de2c116c77 Bug 1306298 - Close any pre-existing print progress dialogs when on re-entry to print preview. r=mconley 2016-10-27 08:44:00 -04:00
Gijs Kruitbosch
2228c34072 Bug 1308621 - print preview shouldn't re-set the source browser, r=florian
Right now the "already in print preview" case in printPreview() collapses
the print preview browser - but also clobbers its _sourceBrowser property,
which shouldn't point to the print preview browser but to the 'normal'
browser whose print preview is in the print preview browser.

This patch fixes the clobbering, and updates later code to not call
getSourceBrowser() repeatedly, as doing so can in some race conditions end up
print previewing the wrong page.

MozReview-Commit-ID: FlMRrPEkAJQ
2016-10-06 12:58:37 +01:00