Commit Graph

52 Commits

Author SHA1 Message Date
Mark Banner
47dd667387 Bug 1465347 - Remove the ability to sort results by annotation as it is no longer used. r=mak
MozReview-Commit-ID: bl588eAmkD

Differential Revision: https://phabricator.services.mozilla.com/D1662
2018-06-15 07:39:32 +00:00
Mark Banner
cf84e76a1a Bug 824502 - Migrate folder=<id> based queries to parent=<guid> for Places' bookmark queries. r=mak
MozReview-Commit-ID: 9A4SdNpp9wU
2018-05-04 17:03:13 +01:00
Mark Banner
bcb5601b9f Bug 824502 - Change folder=<id> to parent=<guid> in Places' bookmark queries. r=mak
This allows queries to be stable across devices, and requires less work to obtain the ids.

MozReview-Commit-ID: 5KAKKags7o9
2018-04-26 09:05:00 +01:00
Marco Bonardo
3382b7442d Bug 1293445 - 5 - Rename RESULTS_AS_TAG_QUERY. r=standard8
MozReview-Commit-ID: 7HwPKkGvAvv
2018-04-04 16:14:20 +02:00
Marco Bonardo
b2e8b679a0 Bug 1293445 - 4 - Remove RESULTS_AS_TAG_CONTENTS. r=standard8
MozReview-Commit-ID: rybSCGrfnf
2018-04-03 18:32:00 +02:00
Marco Bonardo
fc61b0aea0 Bug 1446951 - 8 - Reduce the number of query node constructors to one. r=standard8
MozReview-Commit-ID: ICDxftFlePN
2018-03-20 11:29:54 +01:00
Marco Bonardo
fdad30e63f Bug 1446951 - 7 - Remove some internal use of GetHas* APIs. r=standard8
MozReview-Commit-ID: E4JudYNzLFT
2018-03-20 01:07:01 +01:00
Marco Bonardo
87ad90c95d Bug 1446951 - 6 - Change internal results code to support a single query. r=standard8
MozReview-Commit-ID: 5ceutaSM6Vk
2018-03-19 11:58:35 +01:00
Marco Bonardo
b18d35da18 Bug 1446951 - 5 - Remove QueryStringToQueryArray. r=standard8
MozReview-Commit-ID: H6nMhiXgDKA
2018-03-16 21:36:02 +01:00
Marco Bonardo
9378cf4109 Bug 1446951 - 4 - Make QueriesToQueryString and QueryStringToQueries singular. r=standard8
MozReview-Commit-ID: K8x2x0kARDn
2018-03-16 18:43:57 +01:00
Mark Banner
8bda7e6d85 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
Dorel Luca
37af71af05 Backed out 2 changesets (bug 1310295) for Mochitest and TV failures on browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
Backed out changeset a277657bfffa (bug 1310295)
Backed out changeset b1af75c617ea (bug 1310295)
2018-03-14 18:23:46 +02:00
Mark Banner
60c4119b69 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
Mark Banner
00472aedd4 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Coroiu Cristina
8fb5593ad1 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner
2339900150 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Marco Bonardo
c3c9c995c4 Bug 1380302 - Fix -Wmaybe-uninitialized warnings in Places. r=adw
MozReview-Commit-ID: 2HxDMhYzaib
2017-07-12 21:29:58 +02:00
Sylvestre Ledru
9d4a84d778 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG
2017-07-06 14:00:35 +02:00
Nicholas Nethercote
4ce1e9c11f Bug 1374580 (part 3) - Remove ns{,C}Substring typedefs. r=froydnj.
All the instances are converted as follows.

- nsSubstring  --> nsAString
- nsCSubstring --> nsACString
2017-06-20 19:19:52 +10:00
Xidorn Quan
6bdcd189bc Bug 1330235 - Remove NS_STDCALL_FUNCPROTO and replace its usage with decltype. r=froydnj
MozReview-Commit-ID: 5jrTqTfDzSk
2017-05-09 23:00:37 +10:00
Kit Cambridge
7a889a2eee Bug 1302901 - Create a Places mobile bookmarks root. r=mak
MozReview-Commit-ID: IESvIHCM2fK
2016-09-29 13:44:08 -07:00
Andrew McCreight
3e587e3a53 Bug 1287624, part 2 - Replace swap with forget in a few places. r=froydnj
The return argument was initialized to null in all of these, so it
should not change the behavior.
2016-07-20 15:19:00 -07:00
Marco Bonardo
00fc9d7055 Bug 1243779 - Remove uriIsPrefix option from nsINavHistoryQuery.r=adw
MozReview-Commit-ID: CM2Jm6iApct
2016-02-10 17:16:23 +01:00
Nathan Froyd
4e6d8f6705 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
2015-10-18 01:24:48 -04:00
Andrew McCreight
222ce9e7f0 Bug 1210517 - Create nsVariant directly rather than via do_CreateInstance(). r=froydnj
The goal here is to leave creation stuff mostly for JS, so we can
convert it entirely over to a non-threadsafe cycle-collected version
without breaking any existing C++ users.

I didn't do this for a remaining use in nsGlobalWindow.h to avoid
including nsVariant.h all over the place.
2015-10-07 08:17:42 -07:00
Michael Layzell
5132f34c32 Bug 1208814 - Part 2: Don't use the default copy constructor in nsNavHistoryQuery::Clone(), r=ehsan 2015-10-03 11:23:54 -04:00
Birunthan Mohanathas
a0f7c73250 Bug 1191100 - Remove XPIDL signature comments in .cpp files. r=ehsan
Comment-only so DONTBUILD.
2015-08-04 16:17:36 -07:00
Birunthan Mohanathas
a29151dc87 Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Mike Hommey
4d93988786 Bug 1134923 - Remove NS_Alloc/NS_Realloc/NS_Free. r=nfroyd
They are kept around for the sake of the standalone glue, which is used
for e.g. webapprt, which doesn't have direct access to jemalloc, and thus
still needs a wrapper to go through the xpcom function list and get to
jemalloc from there.
2015-05-01 09:40:30 +09:00
Nathan Froyd
023e3d5c3f Bug 1153267 - part 1 - use smart-pointer .forget() instead of NS_ADDREF+assign; r=ehsan 2015-03-31 10:03:49 -04:00
Mike Hommey
338d086ead Bug 1134920 - Use moz_xmalloc/moz_xrealloc/free instead of nsMemory::Alloc/Realloc/Free. r=nfroyd 2015-04-01 13:51:45 +09:00
Birunthan Mohanathas
d4ab56898a Bug 869836 - Part 9: Use AssignLiteral instead of Assign(NS_LITERAL_STRING(...)). r=ehsan 2014-05-22 06:48:52 +03:00
Birunthan Mohanathas
1ebdb921a5 Bug 869836 - Part 2: Use AppendLiteral instead of Append(NS_LITERAL_STRING(...)). r=ehsan 2014-05-22 06:48:50 +03:00
Birunthan Mohanathas
eeb9aaaa94 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Ehsan Akhgari
68bfe70f09 Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
This patch was automatically generated by the following script:

#!/bin/bash
# Command to convert PRUnichar to char16_t

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*modules/libmar*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name prtypes.h \
       ! -name Char16.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
Birunthan Mohanathas
b55ff3bd65 Bug 784739 - Switch from NULL to nullptr in toolkit/components/ (1/2); r=ehsan 2013-10-10 16:38:05 -04:00
Marco Bonardo
ead6b8ce9b Bug 791562 - crash in PlacesFolderConversion::AppendFolder.
r=mano
2012-12-17 15:03:49 +01:00
Jeff Walden
8a6657de57 Bug 820570 - Move mozilla::DebugOnly into DebugOnly.h to pare down the grab-baggish Util.h. r=Ms2ger 2012-12-14 18:58:45 -05:00
Randell Jesup
3b4961b603 Bug 773151: Convert nsCAutoString->nsAutoCString CLOSED TREE r=bsmedberg 2012-09-01 22:35:17 -04:00
Landry Breuil
9d3e408eab Bug 785738 Part 6: use PRTime where appropriate, and add reinterpret_casts to int64_t in corresponding GetInt64 calls. r=ehsan
/home/landry/src/mozilla-central/toolkit/components/places/nsNavHistory.cpp:
In member function 'bool nsNavHistory::FindLastVisit(nsIURI*, int64_t*,
PRTime*, int64_t*)':
/home/landry/src/mozilla-central/toolkit/components/places/nsNavHistory.cpp:619:
error: invalid static_cast from type 'PRTime*' to type 'int64_t*'
/home/landry/src/mozilla-central/toolkit/components/places/nsNavHistory.cpp:
In member function 'bool
nsNavHistory::CheckIsRecentEvent(nsDataHashtable<nsCStringHashKey, long
long int>*, const nsACString_internal&)':
/home/landry/src/mozilla-central/toolkit/components/places/nsNavHistory.cpp:4360:
error: invalid static_cast from type 'PRTime*' to type 'int64_t*'
2012-08-30 09:10:49 +02:00
Ehsan Akhgari
243c878d26 Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
This patch was generated by a script.  Here's the source of the script for
future reference:

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t

convert PRIntn int
convert PRUintn unsigned

convert PRSize size_t

convert PROffset32 int32_t
convert PROffset64 int64_t

convert PRPtrdiff ptrdiff_t

convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Aryeh Gregor
6b3ee254ff Bug 777292 - Convert incorrect conversions to nsresult and fix named constants; r=ehsan 2012-07-27 16:59:29 +03:00
Aryeh Gregor
8b4a23fc4c Bug 777292 part 2 - Change all nsnull to nullptr 2012-07-30 17:20:58 +03:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Marco Bonardo
2ea25557ad Bug 737841 - Part 3: remove no more useful redirectsMode query option.
r=dietrich rs=gavin
2012-04-07 01:17:53 +02:00
Makoto Kato
24153c0aed Bug 738209 - Cleanup a usages of NS_Convert*to*() in places. r=mak 2012-03-23 13:18:59 +09:00
Marco Bonardo
8b4c77ff45 Bug 702639 - Kill excludeItemsIfParentHasAnnotation query option.
r=dietrich sr=gavin
2012-02-24 23:43:49 +01:00
Ehsan Akhgari
478ad1a412 Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
Michael Wu
0fe7772ece Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones 2011-09-28 23:19:26 -07:00
Marco Bonardo
c9fd6aa310 Bug 493783 - Fix some Places warnings.
r=sdwilsh
2011-05-10 03:10:25 +02:00